erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions
acdream/tests/AcDream.Core.Net.Tests/Messages
History
Erik ab3934e21d feat(quest): QT1 — parse the contract-tracker events we have been dropping 
Both opcodes have been named in GameEventType since the wire-catalog work with
nothing behind them, so every contract the server has ever sent us arrived and
was discarded.

Three details that a reimplementation from the enum alone would get wrong, and
each has a test:

The two trailing flags on 0x0315 are widened bools, not bytes, and they sit
OUTSIDE the struct writer — ACE's ContractTracker.Write has them commented out
precisely because the event appends them itself. Reading them as bytes decodes
the delete flag from the wrong four bytes and silently drops contracts.

The stage is not a dense enum. Retail encodes N completed steps as
ProgressCounter + N, so a switch over the four named values sees stage 9 as
unknown and shows nothing. Progress/HasProgressCounter do that arithmetic once
here rather than leaving every caller to remember it.

The countdown anchor is not on the wire. FillProgressString @0x00498DE0 counts
down from CContractTracker::_time_of_server_update, which the server never
sends — so arrival has to be stamped at parse time or the repeat timer has
nothing to tick against.

An empty table is a valid answer rather than a decode failure: it is how the
server says "you have no contracts", and confusing the two would leave stale
quests on screen permanently. A truncated one is rejected outright instead of
decoding to its prefix, which would drop quests just as silently.

Campaign QT slice 1 of 6.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-21 14:38:00 +02:00
..
AceWireWriter.cs fix(chat): Campaign CH user-gate round 1 — jump-in-air edge, portal cue cadence, wrap/prefix/color fixes 2026-08-09 23:42:32 +02:00
AllegianceProfileVersionGateTests.cs fix(net): FA1 review round -- zero-id tree rejection, monarch clear, 0x001F builder 2026-08-12 00:46:42 +02:00
AllegianceRequestsTests.cs fix(net): FA1 review round -- zero-id tree rejection, monarch clear, 0x001F builder 2026-08-12 00:46:42 +02:00
AllegianceSmallEventsTests.cs feat(net): FA1 -- S->C parsers for fellowship/allegiance, confirmation triple, allegiance version gates 2026-08-12 00:13:10 +02:00
AppraiseInfoParserTests.cs fix #234: port retail appraisal floaty and inscriptions 2026-07-23 12:12:57 +02:00
AppraiseTests.cs fix(gameplay): reconcile wield ownership and target facing 2026-07-15 08:19:23 +02:00
AutonomousPositionTests.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
CastSpellTests.cs test: remove exact duplicate coverage 2026-08-18 12:36:41 +02:00
CharacterActionsTests.cs fix(net): xpSpent is a dword on the wire, and we were sending eight bytes 2026-07-29 01:59:47 +02:00
CharacterCreateTests.cs feat(net,runtime): Campaign CC CC2 — CharacterCreate wire, 0xF643 correlation, creation status events 2026-08-15 12:49:52 +02:00
CharacterDeleteTests.cs feat(net): Campaign LA LA7a — CharacterDelete/CharacterRestore/CharacterError wire messages 2026-08-14 15:46:48 +02:00
CharacterEnterWorldTests.cs perf(net): frame recurring sends in place 2026-07-25 06:02:52 +02:00
CharacterErrorTests.cs feat(net): Campaign LA LA7a — CharacterDelete/CharacterRestore/CharacterError wire messages 2026-08-14 15:46:48 +02:00
CharacterListTests.cs fix(net): conform character entry and session shutdown 2026-07-21 10:33:03 +02:00
CharacterLogOffTests.cs fix(net): conform character entry and session shutdown 2026-07-21 10:33:03 +02:00
CharacterRestoreTests.cs fix(net): Campaign LA LA7a review fixes — AD-97 register row, corrected restore justification 2026-08-14 16:01:52 +02:00
CharGenVerificationResponseTests.cs feat(net,runtime): Campaign CC CC2 — CharacterCreate wire, 0xF643 correlation, creation status events 2026-08-15 12:49:52 +02:00
ChatTests.cs fix(net): ranged speech carries a range float our parser was eating 2026-07-29 01:51:34 +02:00
ClientCommandRequestsTests.cs feat(chat): port retail's @pklite client command (EnterPkLite 0x028F) 2026-08-03 18:57:17 +02:00
ClientCommandResponsesTests.cs fix(net): FA1 review round -- zero-id tree rejection, monarch clear, 0x001F builder 2026-08-12 00:46:42 +02:00
CombatEventTests.cs fix(net): Phase L.1c conform combat wire events 2026-04-28 10:54:50 +02:00
ConfirmationTripleTests.cs feat(net): FA1 -- S->C parsers for fellowship/allegiance, confirmation triple, allegiance version gates 2026-08-12 00:13:10 +02:00
ContractTrackerMessagesTests.cs feat(quest): QT1 — parse the contract-tracker events we have been dropping 2026-08-21 14:38:00 +02:00
CreateObjectTests.cs fix(physics): AP-129 review fix - port CanMoveInto/IsAllowedIn, stop failing closed 2026-07-30 11:36:11 +02:00
DeleteObjectTests.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
EmoteTextTests.cs feat(net): #18 holtburger inbound chat parity - EmoteText, SoulEmote, ServerMessage, PlayerKilled, WeenieError + Windows-1252 codec 2026-04-25 19:06:01 +02:00
FellowshipEventsTests.cs fix(net): FA1 review round -- zero-id tree rejection, monarch clear, 0x001F builder 2026-08-12 00:46:42 +02:00
GameActionLoginCompleteTests.cs feat(net): Phase 4.8 — send GameAction.LoginComplete after EnterWorld 2026-04-11 23:36:19 +02:00
GameEventDispatcherTests.cs fix(net): stop dropping every transient string on a chat type that isn't sent 2026-07-29 01:58:02 +02:00
GameEventsInventoryTests.cs fix(net): D.2b-B B-Wire — ParseInventoryServerSaveFailed reads weenieError 2026-06-21 18:55:56 +02:00
HearSpeechGoldenTests.cs fix(net): ranged speech carries a range float our parser was eating 2026-07-29 01:51:34 +02:00
HouseEventsTests.cs feat(net): Map/House panel — slice 4a, House wire parsing groundwork 2026-08-17 02:09:34 +02:00
InteractRequestsTests.cs test(B.5): exercise i32 sign-correctness for BuildPickUp.placement 2026-05-14 15:05:07 +02:00
InventoryActionsTests.cs fix #234: port retail appraisal floaty and inscriptions 2026-07-23 12:12:57 +02:00
InventoryRemoveObjectTests.cs feat(net): D.2b-B B-Wire — InventoryRemoveObject (0x0024) parser 2026-06-21 18:52:21 +02:00
JumpActionTests.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
MoveToStateGoldenTests.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
MoveToStateTests.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
ObjDescEventTests.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
ParentEventTests.cs feat(combat): port retail held weapon parenting 2026-07-11 13:02:26 +02:00
PickupEventTests.cs fix(B.5): handle PickupEvent 0xF74A so picked-up items despawn locally 2026-05-14 16:13:16 +02:00
PlayerKilledTests.cs feat(net): #18 holtburger inbound chat parity - EmoteText, SoulEmote, ServerMessage, PlayerKilled, WeenieError + Windows-1252 codec 2026-04-25 19:06:01 +02:00
PlayScriptGoldenTests.cs test(net): generate wire fixtures from ACE's own writer, not hand-typed hex 2026-07-29 01:49:15 +02:00
PositionPackTests.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
PrivateUpdatePropertyInt64Tests.cs fix(ui): port live experience quality updates (#217) 2026-07-13 20:43:48 +02:00
PrivateUpdatePropertyIntTests.cs feat(net): D.2b-B B-Wire — PrivateUpdatePropertyInt (0x02CD) parser 2026-06-21 18:50:56 +02:00
ProjectileVfxPacketFixtures.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
PublicUpdatePropertyIntTests.cs feat(D.5.2): PublicUpdatePropertyInt (0x02CE) parser 2026-06-17 18:29:23 +02:00
RawMotionStatePackTests.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
ServerMessageTests.cs feat(net): #18 holtburger inbound chat parity - EmoteText, SoulEmote, ServerMessage, PlayerKilled, WeenieError + Windows-1252 codec 2026-04-25 19:06:01 +02:00
ServerNameTests.cs fix(ui,net): Campaign LA gate round 2 — char-select exit confirmation, authored row justify, world name 2026-08-15 11:50:45 +02:00
SetStackSizeTests.cs feat(net): D.2b-B B-Wire — SetStackSize (0x0197) parser 2026-06-21 18:51:42 +02:00
SetStateTests.cs feat(phys L.2g slice 1): inbound SetState (0xF74B) parser 2026-05-12 22:15:31 +02:00
SetTurbineChatChannelsTests.cs feat(net+chat): #19 TurbineChat (0xF7DE) codec + ChatChannelInfo + SetTurbineChatChannels parser 2026-04-25 19:44:56 +02:00
SocialActionsTests.cs fix(net): FA1 -- repair fellowship builders, add 0x0290/0x0291, allegiance Kick 2026-08-12 00:12:47 +02:00
SocialStateMessagesTests.cs feat(chat): port retail client command families 2026-07-13 14:50:15 +02:00
SoulEmoteTests.cs feat(net): #18 holtburger inbound chat parity - EmoteText, SoulEmote, ServerMessage, PlayerKilled, WeenieError + Windows-1252 codec 2026-04-25 19:06:01 +02:00
SoundEventTests.cs feat(audio): Campaign A slice A3 — the server sound channel (0xF750) 2026-08-08 22:07:23 +02:00
TradeRequestsTests.cs feat: secure trade with other players - wire, RuntimeTradeState, the 2026-08-14 11:49:13 +02:00
TurbineChatTests.cs feat(net+chat): #19 TurbineChat (0xF7DE) codec + ChatChannelInfo + SetTurbineChatChannels parser 2026-04-25 19:44:56 +02:00
UpdateMotionTests.cs feat(R4-V3): wire completion - mt 8/9 parsing + full params exposure + the mt-0 sticky trailer (closes M7, M13, M14-wire-note) 2026-07-03 11:53:53 +02:00
UpdatePositionTests.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
VectorUpdateGoldenTests.cs test(net): generate wire fixtures from ACE's own writer, not hand-typed hex 2026-07-29 01:49:15 +02:00
VendorApproachTests.cs fix(runtime/core): Slice 5.3 review corrections — retirement/transit close, per-unit pricing, guarded auto-close dispatch 2026-08-07 16:15:57 +02:00
VendorRequestsTests.cs feat(vendor): Slice 6b/6c — move-to-use, buy staging, selling; the vendor arc is functionally complete 2026-08-08 11:43:11 +02:00