Commit graph

1059 commits

Author SHA1 Message Date
Erik
8098875240 docs(overhaul): contract issue 469 lighting ownership 2026-09-05 03:29:21 +02:00
Erik
2f1e625fea docs(overhaul): close issue 470 2026-09-05 03:23:55 +02:00
Erik
56837f547f docs(overhaul): contract issue 470 readback barrier 2026-09-05 03:07:47 +02:00
Erik
011ab1c182 docs(overhaul): isolate issue 470 Vulkan proof
Record retail/behavior review pass 1/10: renderer behavior is correct, but the physical-device witness cannot live in the portable Release lane. Bind fix round 1 to an explicit Vulkan lane owned by the existing lavapipe job and current-machine proof.
2026-09-05 02:50:35 +02:00
Erik
67a8bc21f6 docs(overhaul): contract ordered sidecar index repair
Bind S5 packet section 27 for issue 470. The contract preserves the shared absolute transform index while making every live per-submission sidecar local, requires a nonzero-prefix production recording and offscreen pixel witness, and keeps receiver selection plus issue 469 out of scope.
2026-09-05 02:15:10 +02:00
Erik
d43f6809b4 docs(overhaul): close S5 c4 and narrow ordered sidecars 2026-09-05 02:12:19 +02:00
Erik
13dbb79eeb docs(overhaul): contract S5 c4 detail-off fix 2026-09-05 01:47:17 +02:00
Erik
c47a43eb72 docs(overhaul): contract S5 c4 depth-state fix 2026-09-05 01:12:33 +02:00
Erik
ee8d585651 docs(overhaul): preserve AP-240 in c4 fix 2026-09-05 00:25:45 +02:00
Erik
2281fdb3d6 docs(overhaul): contract S5 c4 material-state fix 2026-09-05 00:08:49 +02:00
Erik
9f410d8b75 docs(overhaul): contract exact S5 c4 detail material 2026-09-04 23:02:33 +02:00
Erik
678bffaa85 docs(overhaul): close S5 c3 and file ordered pack defect 2026-09-04 22:45:47 +02:00
Erik
d0f45f6a99 docs(overhaul): contract S5 c3 fix round 3 2026-09-04 21:56:08 +02:00
Erik
ccd88eabcc docs(overhaul): contract S5 c3 fix round 2 2026-09-04 21:33:29 +02:00
Erik
5cc437bf98 docs(overhaul): refresh S5 c3 packet status 2026-09-04 21:15:59 +02:00
Erik
e18e23a5d3 docs(overhaul): allow ten review passes 2026-09-04 21:15:43 +02:00
Erik
def7fd2119 docs(overhaul): contract S5 c3 fix round 1 2026-09-04 21:13:33 +02:00
Erik
e2f5385037 docs(overhaul): switch remaining agents to OpenAI 2026-09-04 19:57:24 +02:00
Erik
185590e016 docs(overhaul): contract S5 c3 building degrades 2026-09-04 19:08:39 +02:00
Erik
c3ac20b2ad docs(overhaul): close S5 c2 landing gate 2026-09-04 18:44:50 +02:00
Erik
ef819eedf5 docs(overhaul): record S5 c2 clean evidence
Replace the stale pending-evidence result with the exact clean-commit hermetic, broader InstalledDat, and canonical comparison identities, filters, counts, and verified manifests. Preserve the broader artifact as valid noncanonical evidence and record both zero-difference nonpassing comparisons against accepted S5-c1.

Record retail review PASS and production review FAIL solely on the corrected evidence prose, with code, architecture, GPU-flight, lifecycle, allocation, and scope otherwise passing. Mark the documentation-only fix round implemented pending narrow re-review without advancing S5-c2 to landed.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 18:20:31 +02:00
Erik
048027e71a docs(overhaul): contract S5 c2 evidence fix 2026-09-04 18:20:31 +02:00
Erik
a4de2efc4e feat(overhaul): select pack shadows from retail visibility
Borrow the exact prior-completed landscape visibility transaction and S2 CELLARRAY owner for the opt-in IA-24 directional-shadow pack. Select terrain by authored 1..64 cells, ordinary casters by CELLARRAY, and buildings by outdoor EffectCellId with no fallback.

Keep retained caster/material/terrain topology stable across visibility-only frames. Publish exact arbitrary active instance runs and bounded terrain commands through separate selection sequences; preserve transform-journal, fade/retry, deferral, shader/RHI, ordinary world, and pack-off behavior. Amend IA-24 and the S5 ledger.

Pre-commit gates: Release solution build 0 warnings/0 errors; focused visibility/frame/caster/prepared/GPU/terrain/pack lane 137/137; warmed caster/prepared/terrain selectors 0 B; git diff --check clean. Official hermetic and InstalledDat evidence intentionally run post-commit from this exact clean tree.

Mutation evidence (each restored exactly): (1) CELLARRAY->Parent first failed PriorLandscapeSelection expected [201,202,203,205], actual [204,205]. (2) all resident terrain first failed Assert.Single with 3 commands. (3) building EffectCell->anchor first failed expected trailing 205, actual 206. (4) admit missing membership first failed with extra 204. (5) completed->building scratch first failed completed-view Assert.True, expected true/actual false. (6) selection advanced BuildSequence first failed expected 1/actual 2. (7) alternating->prefix first failed active command count expected 3/actual 1.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 18:20:31 +02:00
Erik
5c106bcdff docs(overhaul): contract S5 c2 shadow visibility 2026-09-04 17:24:33 +02:00
Erik
5e418600e5 docs(overhaul): close S5 c1 landing gate 2026-09-04 17:14:31 +02:00
Erik
1718832e2a docs(overhaul): bind S5 c1 clean evidence 2026-09-04 17:09:57 +02:00
Erik
ad115141ab docs(overhaul): bind S5 c1 clean evidence exception
Correct architecture and AD-21 to the existing transaction: normal non-login world frames participate, a walk contributes its exact landscape set, null-root completes an empty set without reconstruction, and login/portal-space retain no completed view.

Record the owner-authorized exception as in progress. Historical dirty-base artifacts remain preserved but clean exact-commit hermetic and InstalledDat evidence plus narrow review are still pending; no counts or hashes are invented.

Scope proof: no src or tests diff relative to b7a7eb9e2; git diff --check clean. No lanes or graphical client run by this commit.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 17:09:57 +02:00
Erik
36569c0b00 docs(overhaul): authorize S5 c1 evidence exception 2026-09-04 17:09:57 +02:00
Erik
6bbb9e117a docs(overhaul): correct S5 c1 null-root truth
State the actual visibility transaction: normal non-login world frames participate, PView contributes the exact walk landscape set, and null-root completes an empty set without reconstruction. Login and portal-space remain without a completed world view.

Prose only. Core particle tests 47/47; combined App visibility/terrain/frame/renderer plus AP-116 41/41; git diff --check clean.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 17:09:57 +02:00
Erik
3f17c9131d docs(overhaul): contract S5 c1 final review fix 2026-09-04 17:09:57 +02:00
Erik
4d1110812c docs(overhaul): correct S5 c1 review comments
Remove the deleted outdoor-fallback claim, describe the visible-cell union as diagnostics rather than a shared admission answer, and distinguish the landscape particle, resident-light, and future shadow consumers.

Correct ParticleSystem complexity prose: only the SortedSet indexes have logarithmic lifecycle edges; the view list uses binary-search insertion with linear shift and linear removal.

Focused verification: Core ParticleSystemTests 47/47; App visibility/terrain/frame/renderer 38/38; AP-116 settings/live-object 3/3; git diff --check clean. No behavior, tests, register, or architecture change.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 17:09:57 +02:00
Erik
282fe87fb3 docs(overhaul): contract S5 c1 review fix 2026-09-04 17:09:57 +02:00
Erik
94a6b5ef39 feat(overhaul): port S5 particle cell visibility
Publish the exact completed walk landscape set as the typed retained particle-view product. Apply retail CLandCell membership versus constant-true non-null CEnvCell eligibility while preserving the x87 distance and AP-116 behavior.

Delete the null-root terrain visibility reconstruction and the dead drawable-cell point-light feedback chain. Retire AP-117, correct AP-85 and AD-21, and keep directional shadows, building degrade, AP-232, probes, RHI, shaders, and DAT outside this chunk.

Automated return: Release 0 warnings/0 errors; Core VFX 111/111; App particle/frame/renderer/terrain 146/146; warmed production allocation 1/1 at 0 B. First official hermetic artifact s5-c1-hermetic-20260904 is preserved at 16759/16760 with only the stale 162-row assertion; after the bounded 161 correction, exact pin 1/1 and fresh s5-c1-hermetic-corrected-20260904 16760/16760. InstalledDat 385 pass, 10 documented failures, 1 documented skip, no new identity.

Mutation 1: making EnvCell eligibility set-dependent first failed ParticleSystemTests.cs:553 Assert.True, expected true actual false. Mutation 2: making outdoor eligibility constant true first failed ParticleSystemTests.cs:559 Assert.False, expected false actual true.

Mutation 3: feeding the diagnostic union first failed WorldSceneRendererTests.cs:279 HashSet equality, expected [16842755], actual [16843008, 16842755]. Mutation 4: restoring CollectVisibleCells first failed TerrainParticleCellVisibilityTests.cs:37 and named TerrainModernRenderer.cs.

Mutation 5: restoring ObserveDrawableCells first failed TerrainParticleCellVisibilityTests.cs:37 and named WorldRenderFrameBuilder.cs. Mutation 6: changing the inclusive boundary from <= to < first failed ParticleSystemTests.cs:519 Assert.True, expected true actual false.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 17:09:51 +02:00
Erik
efb0756190 docs(overhaul): record S5 c1 mandatory stop 2026-09-04 16:55:38 +02:00
Erik
88873ea3dc docs(overhaul): bound S5 c1 gate correction 2026-09-04 16:20:28 +02:00
Erik
00f134f9e4 docs(overhaul): contract S5 typed visibility consumers 2026-09-04 15:52:55 +02:00
Erik
170a807aad docs(overhaul): record provisional G3 self-gate 2026-09-04 15:36:53 +02:00
Erik
9ca82bfc83 docs(overhaul): close S4 c3b landing 2026-09-04 15:17:48 +02:00
Erik
3f2f00c9fa docs(overhaul): correct S4 c3b gate provenance
Disclose that both official c3b artifact sets were captured pre-commit on the restored uncommitted implementation tree at parent a0523e605 with WorktreeDirty=true. Reconcile the transcript status entry as transient mutation-worktree dirtiness rather than an active gate mutation.

Narrow verification: both summary identities match; both 30-entry SHA256SUMS manifests verify with zero mismatches; base, implementation tip, contract HEAD, and worktree transcript blobs are c755c1379f; the hermetic TRX source-truth pin passed; diff-check and packet-only scope passed.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 15:16:03 +02:00
Erik
5110bf6760 docs(overhaul): contract S4 c3b provenance fix 2026-09-04 15:16:03 +02:00
Erik
26e97ba412 refactor(render): delete superseded alpha sidecars
Remove the dead classic-group CachedBatch/InstanceGroup sort-center sidecar and its cache, append, reset, and diagnostic-digest plumbing. Remove the discarded camera parameter chain from grouped alpha deferral and dispatcher submission diagnostics while preserving walk/particle CYpt keys, FIFO submission ordinals, and opaque camera distance.

Add production-facing reflection/source pins for the deleted shapes and camera chain, retained per-cell and opaque owners, the exact three AlphaFlushCounts reasons, and deleted alpha-order symbols. Update directly affected cache/digest/group lifecycle tests and record the complete section 22 result.

Gates: Release 0W/0E; focused App 132/132 plus Core 29/29; new pins 4/4; real allocation pins 2/2 at 0 B; shaders 32/32; hermetic 16755/16755; InstalledDat exactly 385 pass, 10 documented fail, 1 skip; diff-check clean.

Mutations: InstanceGroup and CachedBatch sidecars fail their Assert.Null pins; Defer and digest camera parameters fail method-shape pins; false count prose fails the exact-reason pin; RetailAlphaOrdering resurrection fails the deletion pin. Each was restored independently before the final matrix.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 15:16:03 +02:00
Erik
a0523e6057 docs(overhaul): contract S4 c3b deletions 2026-09-04 14:45:52 +02:00
Erik
b1d33c9b88 docs(overhaul): close S4 c3a landing 2026-09-04 14:41:56 +02:00
Erik
67c76026e6 docs(overhaul): correct c3a mutation evidence
Correct packet section 18.7 mutation 9: renaming AP-241 first fails the earlier AP-table-boundary Assert.True with rowIndex=-1; the later Assert.Single is not reached. Advance only the S4-c3a ledger row to the owner-authorized evidence-exception review.

This commit explicitly supersedes the false mutation-9 sentence recorded in historical candidate commit 44e2bc227b without rewriting or amending that commit. It changes no other c3a evidence or renderer behavior.

Narrow mutation: AP-241 rename first failed at line 329 with 'AP-241 row must be inside the AP table before the TS section; rowIndex=-1, AP=[275116,751256).'. The register row was restored byte-identically and the same isolated test passed 1/1. Diff-check passed; only packet and plan changed; no graphical client.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 14:37:40 +02:00
Erik
316193043d docs(overhaul): authorize narrow S4 c3a evidence fix 2026-09-04 14:37:37 +02:00
Erik
b6b0156045 fix(render): retain surfaceless particle metadata
Preserve a successfully decoded GfxObj ParticleGfxInfo when SurfaceId is zero and condition only texture acquisition. Missing/no-Gfx descriptors retain Default behavior; material, additive, routing, and untextured drawing remain unchanged.

Add a production-path GfxObj-backed synthetic no-surface pin with distinct authored/AABB centers, non-unit size, nonidentity orientation, object/particle merge order, visual center, and unassigned texture-slot assertions. Correct the synthetic-DAT evidence wording and advance only the S4-c3a ledger row.

Final F2 source audit found no defect: preparation holds reconstruction inputs only; Append reserves once; false and exception roll back the exact tail once; first-use rejection remains registered; accepted tokens stay stable; independent 3000-entry caps preserve row-2 immediate duplicates; flush/end/abort/next-preparation cleanup converges; retained capacity/bytes remain bounded; warmed production paths remain 0 B.

Gates: no-surface target 1/1; unchanged section 19 baseline 95/95; AP boundary/count 1/1; real allocations 2/2 at 0 B; shader/manifest 32/32; Release solution 0 warnings/0 errors; diff-check pass. No graphical client.

Mutation: restoring eea5793d2's SurfaceId-zero-to-Default ternary first failed CellTurn_GfxObjBillboardWithoutSurfaceRetainsAuthoredSortCenterAndUntexturedFallback at the authored-distance assertion, expected 40 actual 100.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 14:37:31 +02:00
Erik
8bd75ba312 docs(overhaul): bound final S4 c3a fix 2026-09-04 14:37:28 +02:00
Erik
01674bcc78 fix(render): repair particle CYpt preparation
Retain the GfxObj-authored SortCenter independently from the rendered AABB center and use its scaled, oriented world point for billboard/mode-2-5 CYpt. Keep the visual center unchanged.

Reserve prepared source payload only at Append, roll back the exact tail once on false or exception, cap retained preparation at 3000 CLIP plus 3000 ALPHA, preserve immediate duplicates, account the bounded scratch, and correct the static-record ordering comment. The lead-authorized plan edit records candidate 44e2bc227b's retail FAIL and this section 19 result.

Gates: Release solution build 0 warnings/0 errors; focused particle/driver/queue/order/bounds 95/95; register boundary/count 1/1; real allocations 2/2 at 0 B; shader/manifest 32/32; one-shot hermetic 16751/16751; InstalledDat 385 pass/10 documented fail/1 skip; diff-check pass. No graphical client.

Mutations: rendered pos first failed distance expected 40 actual 116; AABB center expected 40 actual 116; dropped size expected 40 actual 65; dropped orientation expected 40 actual 160; eager reservation first failed Assert.Empty with one payload; omitted false rollback first failed Assert.Single with two payloads; omitted exception rollback first failed Assert.Empty with one payload; removed caps first failed prepared count expected 6000 actual 6002.

Evidence note: the first ordinary InstalledDat filter produced 385 pass/2 expected fail/1 skip but excluded the eight required KnownFailure rows; the separate inclusive no-retry artifact produced the exact documented 10-failure set. Initial test fixture compilation/analyzer setup failures are recorded in packet section 19.5.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 14:37:23 +02:00
Erik
8e0c6fb145 docs(overhaul): bound S4 c3a retail fix round 2026-09-04 14:36:54 +02:00
Erik
a86ec73ece fix(render): restore retail per-cell alpha order
Reconstruct one combined static/dynamic object-part stream for each ordinary outdoor or interior cell, compute authored SortCenter CYpt keys, and stable-sort far to near before projecting opaque and delayed subsets. Prepare real cell-particle records at the leaf, preserve every S4-c2 router outcome, and merge object and particle delayed records by retained key before either source appends to the unchanged CLIP/ALPHA FIFO lists. Cell turns remain cell-major; equal cross-source ties are deterministically object-first.

File AP-241 and AP-242 for the remaining separate opaque/row-5 channels and unrepresented equal-key common ordinal. File AP-243 for the paired-binary correction: retail shares the cell CYpt/heading beyond 50 m while this bounded port always uses the more exact authored per-part center. Pin 162 active AP rows and correct world-alpha and AlphaFlushCounts prose.

Lead-approved scope clarification: RetailPViewPassExecutor.WalkLeaf.cs and RetailPViewPassExecutor.cs are the minimum existing production leaf adapter and thin particle-prepare forwarder omitted by the literal Walk/Wb file list. They contain no router, queue, mask, state, depth, or flush behavior; relocating them would create an artificial seam.

Gates: Release solution build 0W/0E; shader/manifest 32/32; focused production 210/210; real allocation 3/3 at 0 B; one-shot hermetic 16743/0/0 across 14 assemblies; InstalledDat 385 pass/10 documented fail/1 skip with all six AlphaFlushSites passing; git diff --check PASS. Initial no-restore solution build failed NETSDK1004 for 42 missing scratch assets; one solution restore preceded the official build.

Mutation proof, each restored before final gates:

1. Reverse comparator: authored-center order expected [202,101], actual [101,202].

2. Move ties left: multipart/subset order expected [11,12,21,22], actual [22,21,12,11].

3. Restore static/dynamic blocks: expected [2,3,1], actual [3,1,2].

4. Use entity origin: authored-center order expected [202,101], actual [101,202].

5. Restore particle tail: expected [Wb,Particle,Wb,Particle], actual [Wb,Wb,Particle,Particle].

6. Scope-global sort: first cell model X expected 5, actual 50.

7. Restore dead camera parameter: SubmitWalkAlphaInstance parameter count expected 2, actual 3.

8. Restore stale global-queue prose: exact Assert.DoesNotContain failure on distance-sorts one shared queue.

9. Remove AP-241 identity: Assert.Single found no matching row.

10. Allocate in real merge: expected 0 B, actual 3072 B.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-09-04 14:36:48 +02:00