docs(overhaul): contract S5 c3 fix round 2
This commit is contained in:
Erik
parent
5cc437bf98
commit
ccd88eabcc
2 changed files with 58 additions and 4 deletions
|
|
@ -691,8 +691,8 @@ Update immediately when a slice changes state. Chat is not the ledger.
|
|||
| S4-c3b | **LANDED 2026-09-04** — implementation `26e97ba41`, provenance contract `5110bf676`, packet-only correction `3f2f00c9f`; packet §22–§25. Dead classic-group `LocalSortCenters`/`CachedBatch.LocalSortCenter` storage and the alpha camera-parameter/digest chain are deleted. Live per-cell/particle CYpt keys, opaque `SortDistance`, building/private/portal distances, two FIFO lists, all state/barriers, and AP/AD rows remain. | **G3 LEAD SELF-GATE PROVISIONAL PASS; owner acceptance/owner-only rows pending. G4 UNPASSED.** | Retail/deletion lens PASS. Production lens found no code defect and one artifact-provenance omission; packet-only fix round 1 passed its narrow re-review. Fresh campaign: Release 0W/0E; App 132/132; Core 29/29; allocation 2/2 at 0 B; shader 32/32. G3: route 1 13/13, route 2 4/4, route 3 retry 3/3, all exit 0/graceful. The first route-3 attempt stopped before Nanto on registered #462. Exact PNG paths: packet §25. |
|
||||
| S5-c1 | **LANDED 2026-09-04 after the owner-authorized documentation/evidence exception.** Mandatory stop `efb075619` remains in history; final campaign tip `1718832e2`, reviewed scratch tip `b2d56f9e3`. | G4 UNPASSED | Narrow exception re-review PASS. Clean evidence: hermetic 16,760/16,760; inclusive InstalledDat 385 pass / the same documented 10 fail / 1 skip; both exact `d6592d3ac`, `WorktreeDirty=false`, manifests fully verified. Fresh campaign Release 0W/0E, Core 111/111, visibility 38/38, allocation/AP-116 4/4. Lead graphical portal-haze gate PROVISIONAL PASS, exit 0/graceful, 10 PNGs under `logs/selfgate-20260904-171137-s5c1-particle-visibility`; owner inspection pending. |
|
||||
| S5-c2 | **LANDED + REVIEW-CLOSED 2026-09-04; lead graphical gate PROVISIONAL PASS.** Campaign stack `a4de2efc4` -> `048027e71` -> `ef819eedf`; reviewed scratch tip `521f5edda54`; packet §§14–16. The opt-in IA-24 path borrows the exact prior-completed landscape set/flag, selects world casters through S2 CELLARRAY or building `EffectCellId`, selects authored terrain slots, and projects exact active instance runs without rebuilding retained topology. Pack-off remains unchanged. | G4 UNPASSED | Retail/deviation PASS; production's documentation-only fix round 1 narrowly re-reviewed PASS. Fresh campaign Release 0W/0E and affected 137/137. Official evidence: hermetic 16,768/16,768; broader InstalledDat 468 pass / 10 fail / 1 skip; canonical 385 pass / the same 10 fail / 1 skip; manifests and nonpassing identities exact. Valid lead gate `logs/selfgate-20260904-183925-s5c2-candidate-shadow-ab`: seven PNGs, exit 0, graceful logout, no fatal match, no client left. Exact parent `5c106bcdf` A/B at `s5-c2-ab-parent/logs/selfgate-20260904-183815-s5c2-parent-shadow-ab` proves the gate-visible dark lighting switch predates c2; #469/IA-24 carry it for resolution or explicit owner acceptance before G4. Owner PNG inspection pending. |
|
||||
| S5-c3 | **IMPLEMENTED IN SCRATCH; RETAIL REVIEW FAIL; FIX ROUND 1 CONTRACTED 2026-09-04.** Packet §17 is the base contract; §18 is the bounded repair. | G4 UNPASSED | The typed building selection, exact complete-body gate/order, Setup part zero, selected shell/residency, shared owner, Config wiring, census, scope, and mutations passed lead verification plus the first OpenAI retail lens. Review found one MAJOR exact-port defect: FPS, CalcDegLevel, and selector thresholds round x87 intermediates to binary32 too early (three concrete one-bit/boundary witnesses), plus one MINOR stale AP-198 claim that the already-live Landscape Draw Distance remains dead. OpenAI fix round 1 repairs only those arithmetic store boundaries and register truth; narrow retail re-review then the full sequential production review precede landing. |
|
||||
| S5 | IN FLIGHT — c1 and c2 landed/review-closed/provisionally self-gated; c3 fix round 1 contracted; c4–c5, #469 disposition, closeout, and G4 remain | G4 | Packet §§7 and 12–18 are binding; S5-c3's bounded review repair is next; never merge main before G4. |
|
||||
| S5-c3 | **IMPLEMENTED IN SCRATCH; RETAIL REVIEW PASSES 1–2 FAIL; FIX ROUND 2 CONTRACTED 2026-09-04.** Packet §17 is the base contract; §§18–19 are bounded repairs. | G4 UNPASSED | The typed building selection, exact complete-body gate/order, Setup part zero, selected shell/residency, shared owner, Config wiring, census, scope, and mutations passed lead verification. Fix round 1 corrected the FPS, selector, qword-stability, candidate witness, and AP-198 findings. Narrow review pass 2 proved one remaining MAJOR exact-port defect: CalcDegLevel stores its evolving numerator to binary32 after w0/w1/w2/w3, then adds w4 and divides wide; the implementation combined all five terms before one store. The discriminating 16.25-FPS candidate is one bit wrong. OpenAI fix round 2 is limited to that schedule and its bit pin; narrow retail review pass 3 then the full sequential production review precede landing. |
|
||||
| S5 | IN FLIGHT — c1 and c2 landed/review-closed/provisionally self-gated; c3 fix round 2 contracted; c4–c5, #469 disposition, closeout, and G4 remain | G4 | Packet §§7 and 12–19 are binding; S5-c3's bounded review repair is next; never merge main before G4. |
|
||||
|
||||
---
|
||||
|
||||
|
|
|
|||
|
|
@ -1,8 +1,8 @@
|
|||
# Campaign OVERHAUL v2 — S5 consumers, material, and closeout packet
|
||||
|
||||
**Status:** S5-c1 and S5-c2 LANDED + lead graphical gates PROVISIONAL PASS;
|
||||
S5-c3 implemented in scratch, retail review 1 FAIL, bounded fix round 1 in
|
||||
progress under §18.
|
||||
S5-c3 implemented in scratch; retail review passes 1 and 2 FAIL, and bounded
|
||||
fix round 2 is contracted under §19.
|
||||
**Branch:** `claude/campaign-w-retail-frame-walk`.
|
||||
**Gate:** G4 remains unpassed. Nothing merges to `main` before G4.
|
||||
|
||||
|
|
@ -1335,3 +1335,57 @@ first. Only its PASS unlocks the sequential OpenAI architecture/production/
|
|||
gate-honesty review over the entire S5-c3 stack. Each further code finding
|
||||
receives its own bounded contract; S5-c3 stops before an eleventh review pass.
|
||||
Documentation-only findings may be corrected directly by the lead.
|
||||
|
||||
## 19. S5-c3 fix round 2 — CalcDegLevel's four intermediate stores
|
||||
|
||||
OpenAI retail review pass 2/10 returned **FAIL** on one remaining MAJOR F1
|
||||
defect. Fix round 1 otherwise passed: the FPS witness is `0x43A6AAAB`, the
|
||||
14-FPS candidate is `0x3BB2BC0A`, the selector boundary stays at level zero,
|
||||
the qword `0.01` edge and physical FPS slot direction pass, and AP-198 now
|
||||
states the exact five-row residual while AD-78 remains 17/27. The reviewer
|
||||
also re-confirmed the paired executable/PDB identity, clean allowed scope,
|
||||
the exact installed census, and the official evidence identities.
|
||||
|
||||
### 19.1 R2-F1 — reproduce every executable-visible numerator store
|
||||
|
||||
The remaining defect is only
|
||||
`BuildingDegradeController.CalculateCandidate`. Its combined
|
||||
`float weightedNumerator` narrows once after all five terms. The paired
|
||||
`Render::CalcDegLevel @0x0054CAF0` bytes instead store the evolving numerator
|
||||
to binary32 four times: after w0 at `0x0054CC14`, after the negative w1 term
|
||||
at `0x0054CC61`, after the zero-weight w2 term at `0x0054CCA6`, and after the
|
||||
positive w3 term at `0x0054CCEB`. Retail then promotes that fourth stored
|
||||
value, adds the w4 term wide at `0x0054CD3F`, divides wide, adds/clamps wide,
|
||||
and narrows only at the final candidate store.
|
||||
|
||||
Implement that literal schedule allocation-free. Each of the first four
|
||||
stages must be an explicit `float` store followed by promotion for the next
|
||||
stage; do not algebraically combine, reassociate, or eliminate the `+0*w2`
|
||||
store. Feed every term with the existing exact binary32 coefficient. Keep the
|
||||
five membership weights, denominator, history/stability behavior, clamp,
|
||||
exceptional-value behavior, and every other fix-round-1 change untouched.
|
||||
|
||||
Add an independent bit-exact assertion:
|
||||
|
||||
- `CalculateCandidate(16.25f, 0f)` must publish `0x3CA3D70A`; the current
|
||||
combined store publishes `0x3CA3D70B`.
|
||||
|
||||
Sabotage by recombining the five terms into one store and record this witness
|
||||
as the first failure, then restore it. Re-run the three §18 witnesses, qword
|
||||
edge, FPS slot-direction pin, complete controller/selector lane, original
|
||||
S5-c3 focused surface, allocation lane, official hermetic lane, and inclusive
|
||||
InstalledDat lane with the same documented nonpassing identities.
|
||||
|
||||
### 19.2 Scope and review order
|
||||
|
||||
Production scope is exactly
|
||||
`src/AcDream.App/Rendering/BuildingDegradeController.cs`; test scope is exactly
|
||||
`tests/AcDream.App.Tests/Rendering/BuildingDegradeControllerTests.cs`. No
|
||||
other production, test, register, packet, plan, UI, renderer, RHI, shader, DAT,
|
||||
or lifecycle behavior changes. No graphical client and no commit; the lead
|
||||
owns landing.
|
||||
|
||||
Return the exact two-file diff, `git diff --check`, Release solution build
|
||||
0W/0E, every lane above, and the mutation's first failure. The same OpenAI
|
||||
retail lens performs narrow review pass 3/10 over §19 first. Only its PASS
|
||||
unlocks the sequential full architecture/production/gate-honesty review.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue