docs(overhaul): isolate issue 470 Vulkan proof
Record retail/behavior review pass 1/10: renderer behavior is correct, but the physical-device witness cannot live in the portable Release lane. Bind fix round 1 to an explicit Vulkan lane owned by the existing lavapipe job and current-machine proof.
This commit is contained in:
Erik
parent
67a8bc21f6
commit
011ab1c182
3 changed files with 95 additions and 3 deletions
|
|
@ -68,8 +68,9 @@ inspection).
|
|||
|
||||
## #470 — Atmospheric ordered world draws use absolute transform indices for local sidecars
|
||||
|
||||
**Status:** CONTRACTED — NARROWED 2026-09-05 by S5-c4; implementation contract
|
||||
is S5 packet §27; Campaign OVERHAUL v2
|
||||
**Status:** FIX ROUND 1 — renderer repair implemented at scratch `51f974da4`,
|
||||
but retail/behavior review pass 1/10 found its Vulkan hardware witness inside
|
||||
the portable gate; bounded evidence-lane repair is S5 packet §28; Campaign OVERHAUL v2
|
||||
renderer-solid/G4 scope. The residual predates S5-c3 and is present at least as
|
||||
far back as landed S4-c2 `252886e84`.
|
||||
|
||||
|
|
|
|||
|
|
@ -693,7 +693,8 @@ Update immediately when a slice changes state. Chat is not the ledger.
|
|||
| S5-c2 | **LANDED + REVIEW-CLOSED 2026-09-04; lead graphical gate PROVISIONAL PASS.** Campaign stack `a4de2efc4` -> `048027e71` -> `ef819eedf`; reviewed scratch tip `521f5edda54`; packet §§14–16. The opt-in IA-24 path borrows the exact prior-completed landscape set/flag, selects world casters through S2 CELLARRAY or building `EffectCellId`, selects authored terrain slots, and projects exact active instance runs without rebuilding retained topology. Pack-off remains unchanged. | G4 UNPASSED | Retail/deviation PASS; production's documentation-only fix round 1 narrowly re-reviewed PASS. Fresh campaign Release 0W/0E and affected 137/137. Official evidence: hermetic 16,768/16,768; broader InstalledDat 468 pass / 10 fail / 1 skip; canonical 385 pass / the same 10 fail / 1 skip; manifests and nonpassing identities exact. Valid lead gate `logs/selfgate-20260904-183925-s5c2-candidate-shadow-ab`: seven PNGs, exit 0, graceful logout, no fatal match, no client left. Exact parent `5c106bcdf` A/B at `s5-c2-ab-parent/logs/selfgate-20260904-183815-s5c2-parent-shadow-ab` proves the gate-visible dark lighting switch predates c2; #469/IA-24 carry it for resolution or explicit owner acceptance before G4. Owner PNG inspection pending. |
|
||||
| S5-c3 | **LANDED + REVIEW-CLOSED 2026-09-04** at `c673f767e` (reviewed scratch `01e5a15d0`; packet §§17–21). | **C3 SCOPE SELF-GATE PROVISIONAL PASS; whole-renderer finding #470 OPEN. G4 UNPASSED.** | OpenAI retail pass 3/10 PASS and production narrow re-review pass 5/10 PASS. Fix round 3 added ordinary landblock-lifetime ownership for every unique nonzero ladder GfxObj, rearmed walk-frame miss requests, and made the one-tick-before-BeginFrame proof discriminating. Fresh clean campaign: Release 0W/0E; focused 101/101; hermetic 16,811/16,811; InstalledDat 469 pass / the unchanged documented 10 fail / 1 skip; manifests 30/30. Self-gate `logs/selfgate-20260904-223345-s5c3-building-degrade` produced five PNGs, exited 0/gracefully, and left no client. The selected building shells are complete; the Holtburg frame also exposed pre-existing atmospheric ordered-draw sidecar defect #470, which is not a c3 regression and blocks renderer-solid/G4 until repaired. |
|
||||
| S5-c4 | **LANDED + REVIEW-CLOSED 2026-09-05; LEAD GRAPHICAL GATE PROVISIONAL PASS.** Campaign stack `75664805f` -> `15ed57a1e` -> `d5cfd1c91` -> `03a108ffa`; reviewed scratch tip `db8136448`; packet §§22–26. | G4 UNPASSED | Retail/material pass 3/10 PASS. Full production pass 4/10 found one classic/private detail-off regression; fix round 3 restored the prior AlphaBlend/coalescing path, and narrow production pass 5/10 PASS reproduced all three mutations. Fresh campaign Release 0W/0E, App 245/245, Content 71/71; scratch hermetic 16,971/16,971 and InstalledDat 469/10/1 with both manifests 32/32. Full recipe-10 bake: 2,237,865 keys, zero failures, SHA `4E0FA6C5…29B59B`. Gate `logs/selfgate-20260905-020703-s5c4-onepass-detail`: 13/13 PNGs, exit 0, graceful, no client left; visual PASS provisional. #471 DONE; #470 narrowed to local-sidecar indexing. |
|
||||
| S5 | IN FLIGHT — c1–c4 landed/review-closed/provisionally self-gated; #470 contracted in packet §27; #469, c5, closeout, and G4 remain | G4 | Packet §§7 and 12–27 are binding. Next: implement and sequentially review #470's ordered local-sidecar index split, then run its pinned graphical A/B; after that #469, c5 cleanup, closeout, and G4. Never merge main before G4. |
|
||||
| S5-#470 | **FIX ROUND 1 IN FLIGHT.** Renderer implementation `51f974da4` is correct; retail/behavior pass 1/10 found one blocking evidence-lane defect only: its physical-Vulkan witness was unconditionally inside the portable Release suite. Fix contract = packet §28. | G4 UNPASSED | Put the unchanged witness in explicit `Lane=Vulkan`, exclude that lane from the portable default, run it explicitly under the existing lavapipe CI job and current hardware, then narrow re-review pass 2/10 followed by full production pass 3/10. Nothing lands or launches yet. |
|
||||
| S5 | IN FLIGHT — c1–c4 landed/review-closed/provisionally self-gated; #470 fix round 1 contracted; #469, c5, closeout, and G4 remain | G4 | Packet §§7 and 12–28 are binding. Next: close #470's evidence-lane review finding, complete both sequential lenses, and run its pinned graphical A/B; after that #469, c5 cleanup, closeout, and G4. Never merge main before G4. |
|
||||
|
||||
---
|
||||
|
||||
|
|
|
|||
|
|
@ -2439,3 +2439,93 @@ complete data/descriptor/push/SPIR-V path, reproduce at least three mutations,
|
|||
and rule on gate sufficiency. A failed pass receives a bounded fix contract;
|
||||
the owner-authorized ceiling is ten review passes. Nothing lands or launches
|
||||
graphically before both lenses pass.
|
||||
|
||||
## 28. S5-#470 fix round 1 — keep the hardware witness out of the portable lane
|
||||
|
||||
### 28.1 Retail/behavior review pass 1/10
|
||||
|
||||
Review of clean implementation `51f974da4f2262e6afdd336774326f29fb2aec33`
|
||||
returned **FAIL** on one blocking gate-portability defect and found no renderer,
|
||||
retail-behavior, shader, descriptor, or proof-mechanism defect.
|
||||
|
||||
The production repair is correct: the ordinary shader uses the absolute
|
||||
base-instance domain only for `Instances[]`, subtracts the exact pushed prefix
|
||||
for all five live local sidecar bindings, preserves draw-ID batch indexing and
|
||||
global-light indirection, and regenerates the committed module exactly. The
|
||||
reviewer reproduced the compiled SHA-256
|
||||
`6194193764616BC88BF967D1FDC2BEA5F6F2D1EC2EF94FD492922137503F56E4`,
|
||||
ran the production headless Vulkan witness successfully, and independently
|
||||
restored mutations to both index domains. The named-retail sidecar meanings
|
||||
and paired-binary anchors are unchanged.
|
||||
|
||||
The defect is test placement. `MeshModernSharedIndexOffscreenTests` is an
|
||||
ordinary untagged `Fact`, so `tools/run-release-gate.ps1` includes it in the
|
||||
complete **portable** Release lane. It unconditionally needs a Vulkan loader,
|
||||
1.3-capable physical device/graphics queue, and coherent host-visible readback
|
||||
memory. The reviewer forced a nonexistent ICD and reproduced a hard
|
||||
`vkCreateInstance ErrorIncompatibleDriver`, not a skip. GitHub's
|
||||
`complete-release` Windows runner installs none of those prerequisites; only
|
||||
the existing `linux-vulkan` job installs lavapipe. Consequently the local
|
||||
16,975-pass artifact is hardware-conditioned and cannot be credited as a
|
||||
portable hermetic gate until the witness has an explicit capability lane.
|
||||
|
||||
### 28.2 Bounded evidence-lane repair
|
||||
|
||||
Keep every byte of the renderer, GLSL, SPIR-V, manifest, command-recording
|
||||
proof, SPIR-V structural proof, and hardware witness logic unchanged. Change
|
||||
only its ownership and execution:
|
||||
|
||||
1. mark the offscreen witness with one explicit `Lane=Vulkan` trait;
|
||||
2. exclude `Lane=Vulkan` in the default filter of
|
||||
`tools/run-release-gate.ps1`, alongside the existing platform/capability
|
||||
lanes, so a machine with no Vulkan loader/device can run the truthful
|
||||
portable gate;
|
||||
3. split the existing `linux-vulkan` test step into the platform-independent
|
||||
Vulkan tests (`FullyQualifiedName~...Gpu.Vk&Lane!=Vulkan`) and a separately
|
||||
named `Lane=Vulkan` step after lavapipe installation. The latter must run the
|
||||
real offscreen test and fail on absence or render/readback mismatch; do not
|
||||
turn missing capability into a pass; and
|
||||
4. update `docs/release-gate.md` narrowly to name the Vulkan lane, its required
|
||||
capability, its portable exclusion, the existing lavapipe CI owner, and the
|
||||
exact local command for running it.
|
||||
|
||||
Add a small contract test that reads the real test source, portable-gate
|
||||
script, and headless-portability workflow and fails if any of the three sides
|
||||
drift: the hardware witness loses its trait, the portable filter admits it, or
|
||||
the lavapipe job stops invoking it explicitly. This test itself stays portable
|
||||
and must not initialize Vulkan.
|
||||
|
||||
No product source, shader/generated output, test project option, recipe,
|
||||
package, register, issue, plan, campaign packet beyond this lead-owned section,
|
||||
or unrelated workflow/tool/doc changes are permitted. No dynamic success on
|
||||
missing hardware, broad `Gpu.Vk` exclusion, OS-name proxy, environment-only
|
||||
hidden gate, duplicated pixel oracle, copied shader, or second witness. No
|
||||
graphical client launch.
|
||||
|
||||
### 28.3 Proof and narrow re-review
|
||||
|
||||
Apply and restore these mutations, recording the first failure in the fix
|
||||
commit body:
|
||||
|
||||
1. remove the witness's `Lane=Vulkan` trait;
|
||||
2. remove `Lane!=Vulkan` from the portable Release filter;
|
||||
3. remove or weaken the explicit lavapipe `Lane=Vulkan` invocation; and
|
||||
4. point the dedicated invocation at a class/name filter that could miss the
|
||||
trait-owned witness.
|
||||
|
||||
Return one clean fix-round-1 commit atop `51f974da4`; exact changed-file and
|
||||
line counts; all mutation first failures; both diff-check forms; the portable
|
||||
contract test; the explicitly filtered `Lane=Vulkan` test on the current
|
||||
physical device; Release solution build 0W/0E; a new clean official portable
|
||||
hermetic artifact (the Vulkan witness excluded); and inclusive InstalledDat
|
||||
with every accepted nonpassing identity named. The original exact-tip
|
||||
hardware result remains supporting evidence, but the fixed exact tip must run
|
||||
the dedicated lane again. No bake or graphical gate.
|
||||
|
||||
Because pass 1 found no renderer or retail-behavior defect, the next review is
|
||||
a narrow retail/gate-honesty re-review pass 2/10 of this one finding. It must
|
||||
reproduce at least mutations 1–3, prove the ordinary portable suite no longer
|
||||
depends on Vulkan, and prove the dedicated local and lavapipe routes cannot
|
||||
silently omit or pass the hardware witness. A PASS unlocks the full production
|
||||
review as pass 3/10; a FAIL receives another bounded contract within the ten-
|
||||
pass ceiling. Nothing lands or launches before both sequential lenses pass.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue