256 commits

Author	SHA1	Message	Date
Erik	04161defd8	fix(ui): FA4 re-review REOPEN — re-declare 0x00A6 from the post-world seam, not the pre-world reset ... The FA4 fix round's MUST-FIX 3 placed the 0x00A6 reconnect re-arm at the wrong lifecycle point (re-review 8bbceff5): ResetSessionTransientUi runs via the SessionDialogs reset stage BEFORE _inWorld=true, so SetPanelOpen (world-gated, Validate requireWorld:true) returned Inactive and published nothing — yet _pageVisible was latched true anyway, so no later hook re-declared and fellow vitals stayed frozen for the whole new session. The unit test passed only because the fake recorded unconditionally. Two-part fix, both retail-faithful mechanisms not suppressions: - SocialFellowshipPageController.SetPageVisible advances the edge-trigger latch ONLY when the declaration is Accepted (published), so a dropped pre-world send leaves the latch clear and a later attempt retries. - ResetSessionDeclaration (pre-world) now ONLY clears the latch; the new RedeclareAfterWorldEntry fires from the LiveSession EnteredWorld seam (wired via RestoreLayout, idempotent if a persisted layout already re-showed the page) so a still-open Fellowship page re-declares 0x00A6 in world and vitals resume. Regression pins that actually catch it (the prior test could not): - SetPageVisible_DoesNotLatch_WhenDeclarationDropped_SoItRetriesInWorld (widget-level root, world-gated fake); - Reconnect_ReDeclares0x00A6_AfterWorldEntry_NotDuringPreWorldReset + Reconnect_StaysSilent_WhenFellowshipPageIsNotActuallyOpen (panel-level, world-gated). RED-verified: reintroducing the pre-world declaration fails the reconnect test. Full Release suite: 13,286 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 07:59:16 +02:00
Erik	55b17e15fd	fix #FA4-mechanism-SF-6: assert (not just print) the live-DAT checkbox labels and Open/Close captions ... SocialPanelLiveMountProbeTests wrote the four checkbox labels and the two Open/Close captions to the console with no assertion, yet the FA4 ledger's live-DAT paragraph cited them as verified -- the same finding FA3's own mechanism SF-3 raised for a different table ("printed but never asserted -- deserves a real assertion, not just a hope"). Now asserts each label is non-null/non-empty and the two captions equal the exact retail strings "Open"/"Close". Env-gated (ACDREAM_PROBE_LIVE_MOUNT=1, real installed DATs) -- inert in this session's build/test run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 07:33:50 +02:00
Erik	300d8189f6	fix #FA4-D6-D7,SF-8: revert three of FA4's four dimming un-dims (IgnoreFellowshipRequests, FellowshipAutoAcceptRequests, FellowshipShareLoot) ... The corrected plan D6 (docs/plans/2026-08-11-fellowship-allegiance-campaign.md) established that retail's client reads neither IgnoreFellowshipRequests nor FellowshipAutoAcceptRequests on the fellowship-invite path -- both are pure server-side filters with no client consumer, exactly like the two allegiance bits they were always meant to parallel. Their claimed consumer (RetailUiRuntime.TryAutoRespondToFellowshipInvite) is deleted in a sibling commit this fix round. Both rows revert from Live to StoreOnly. Mechanism review SF-8 additionally found FellowshipShareLoot's claimed consumer -- "a second live checkbox surface on the fellowship page" -- is not a consumer at all: nothing in acdream reads the stored value back (FormatStatsText uses snapshot.ShareXp only; the 0x00A2 Create builder carries shareXP alone), and the live-DAT dump confirms its checkbox is a child of the NOT-in-fellowship frame -- invisible whenever you actually have a fellowship to loot-share within. A second EDITOR of a value is not a CONSUMER of it under AD-78's own "drives nothing observable client-side" definition. FellowshipShareLoot reverts too. Only FellowshipShareXP survives as genuinely live -- the Create-flow click reads it directly as the sent shareXP wire bit. Net: 35 (pre-FA4) -> FA4 shipped 31 -> fix round reverts three -> 34 of 50 dimmed / 16 live, ONE net un-dim from the pre-FA4 baseline, not four. Updated the class doc's derivation table, the conformance test's ExpectedStoreOnlyIds set, and the 31/19 count assertions to 34/16. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 07:33:42 +02:00
Erik	df00030697	fix #FA4-mechanism-MUST-FIX-3,SF-4: re-arm 0x00A6 on reconnect; unsubscribe ActivePageChanged on Dispose ... MUST-FIX 3 -- SocialFellowshipPageController.SetPageVisible is edge-triggered on a bool that survives a generation reset unchanged while the panel stays open, so a reconnect never re-sends 0x00A6 and fellow vitals freeze for the rest of the new session. SocialPanelController.ResetSessionDeclaration clears the fellowship page's latch (SocialFellowshipPageController. ResetPageVisibleLatch, this commit's counterpart) and re-evaluates the existing "window shown AND Fellowship active" conjunction, wired into RetailUiRuntime.ResetSessionTransientUi -- a seam that already runs on every generation reset. A still-open Fellowship page re-declares; a closed or other-tab page correctly stays silent. SF-4 -- SocialPanelController's constructor subscribed an anonymous lambda to UiTabPanel.ActivePageChanged with no way to remove it; Dispose only set a flag. A tab switch after Dispose still reached UpdateFellowshipPageVisibility and issued a Runtime command, since Tick's own _disposed guard doesn't cover this event path. Stored the handler as a field and unsubscribe it in Dispose. Also adds the panel-level D4 conjunction test mechanism SF-5 flagged as missing (the only prior D4 test exercised the PAGE controller's own edge-trigger directly, never SocialPanelController's "window shown AND Fellowship active" logic or its ActivePageChanged subscription). Per docs/research/2026-08-12-fa4-review-mechanism.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 07:33:32 +02:00
Erik	5499f0581f	fix #FA4-mechanism-MUST-FIX-1,4: truncate (not round) the XP-share percentage; port the world->panel fellow-selection sync ... MUST-FIX 1 -- D5's percentage conversion rounds where retail truncates. gmFellowshipUI::UpdateFellowStats @0x0048ECC9 forms pct*100.0f on the x87 stack then calls _ftol2 (MSVC's round-to-truncate helper), never MathF.Round. The stored floats for 6 and 8 fellows are 0.44999998807907104 and 0.3499999940395355 (byte-read from the PDB-paired binary), so retail's own products truncate to 44/34, not 45/35 -- and (int)(pct*100f) alone does not fix it, since 0.45f*100f already rounds UP to exactly 45.0f in single precision. Fixed as (int)((double)pct * 100.0), forming the product the same wider-than-single-precision way retail's x87 does. Pinned with new [InlineData] cases for both sizes. MUST-FIX 4 -- gmFellowshipUI::UpdateFellowSelection @0x0048F0F0 (the world->panel arm of retail's two-directional selection coupling) was never ported; only the panel->world arm (SelectFellow) shipped. Selecting a fellow in the WORLD left Dismiss/Assign-Leader disabled and showed no row highlight. SyncSelectionFromWorld/SetSelectedFellow reproduce the observable contract (button-enable + a row tint) against this controller's own guid-keyed row dictionary instead of porting retail's generic ListBox SetAttribute_InstanceID/SetSelectedItem primitive (scoped disposition recorded at register row AD-82). Also in this pass over the controller: - SF-1: cache the fellowship-name LinesProvider; only reassign on an actual name change (was allocating once per Tick, even while hidden). - SF-2/SF-3: track true membership in _memberGuids, independent of which rows finished building. Fixes an unbounded DAT-locked rebuild retry when a row template permanently fails to build, and fixes Recruit's "already a fellow" check reading render rows instead of membership. - N-0: the Open/Close caption now flips optimistically on click, matching retail's pre-toggle-before-server-echo (lane B feature 11). - N-1/N-2/N-3: doc-only notes on the meter-child-text gap, the max>0 guard, and Tick's two-read non-atomicity. - ResetPageVisibleLatch: the fellowship-controller half of MUST-FIX 3 (see the SocialPanelController commit for the panel-level half). Per docs/research/2026-08-12-fa4-review-mechanism.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 07:33:18 +02:00
Erik	5bdd0528f1	feat(ui): FA4 -- fellowship page fully live ... Roster: SocialFellowshipPageController now builds one row per fellow from the authored template (0x21000030/0x10000281, live-DAT verified), diffing the member GUID set on each revision-gated Tick -- an unchanged set updates every row's bound widgets in place (no ListBox mutation, so scroll position is untouched by construction); only a real join/leave/ disband triggers a rebuild, via UiTemplateListBox.FlushPreservingScroll (FA3 carry-forward 1, both the widget-level fix and the controller-level diff). Health/stamina/mana meters bind Fill+Label; the leader's name tints gold (lane A's row template has no dedicated leader marker, so this is a flagged adaptation, not a ported mechanism). Row-click selection (SelectFellow) drives Dismiss/Leader targeting and the world selection (SelectionChangeSource.Social). D4: SocialPanelController now tracks "is the social window shown AND is Fellowship the active tab" via UiTabPanel.ActivePageChanged + OnShown/OnHidden, and calls SetPageVisible on every transition, which sends 0x00A6 (idempotent, no-op while disconnected) -- the prerequisite ACE gates its 0x02C0 vitals stream on. Create flow: the inline name field (0x1000026F, an authored Editable UiField -- live-DAT verified) gates the Create button's enabled state exactly like retail (empty name = disabled = the whole refusal mechanism, no separate error text); FellowshipShareXP's live value is read at click time. Actions + confirmations: Recruit/Dismiss/Quit/Disband/AssignLeader/ SetOpen all route through DeferredGameRuntimeStateCommands (new Fellowship* methods) rather than a raw WorldSession send, so Quit correctly picks up RuntimeFellowshipState's leader hand-off rule. Button enable states port gmFellowshipUI::UpdateButtons verbatim. The Open/Close button's caption swaps between the two DAT-resolved strings cached once at Bind (never per-tick -- DatCollection is not safe to touch unprotected from the render loop). RetailUiRuntime intercepts a type-4 confirmation request before it reaches the generic GameplayConfirmationController: IgnoreFellowshipRequests auto-declines, FellowshipAutoAcceptRequests auto-accepts, neither set falls through to the existing dialog machinery unchanged (D6). D5 display: the per-fellow stats line uses retail's byte-decoded even-split percentage table verbatim (1.0/.../.3111111/.28, default 0.0); the proportional branch omits the percentage rather than inventing a formula (no acdream ExperienceToRaiseLevel table exists yet). Both StringInfo variable substitution (row/stats/vitals text) and ACCharGenData::FormatName (create-flow name canonicalization) are unported prerequisites, so row text renders as plain numeric composites -- register rows AD-80/AD-81 (docs commit). D7: un-dims IgnoreFellowshipRequests/FellowshipAutoAcceptRequests (consumed by the D6 auto-decline/accept) and FellowshipShareXP/ FellowshipShareLoot (consumed by Create + the page's own second checkbox surface) on the Character tab -- 4 of 35 store-only rows promoted to Live (31 remain dimmed). Carry-forwards from the FA3 re-review, folded into this slice's contract: - UiTemplateListBox.FlushPreservingScroll -- preserves scroll offset across a rebuild instead of resetting to 0 (Flush's existing contract, unchanged, for Friends/Squelch). - RowTemplateResolver -- the FA3 caching row-template resolver extracted from a MountSocialPanel local function into its own hermetically-testable class; now shared by Friends/Squelch/ Fellowship's row families. - Friends/Squelch scrollbars now resolve via the built UiTemplateListBox.ScrollbarElementId (DAT property 0x72) instead of a hardcoded literal, matching ConfigOptionsPageController's own OP6 precedent. - The Fellowship roster path never advances its revision latch on a partial resolver failure until the NEXT real membership change -- never a per-frame retry loop. Live-DAT verified (ACDREAM_PROBE_LIVE_MOUNT=1, extended SocialPanelLiveMountProbeTests): the name field builds as UiField, all 11 buttons/checkboxes resolve, the row template's 5 checked fields resolve to the right widget types, every checkbox label/tooltip and the Open/Close captions resolve to real retail strings ("Open"/"Close"), and a full production-path Bind() against live DATs produces zero "not found" warnings. App tests: +30 (7 UiTemplateListBox/RowTemplateResolver unit tests, 23 SocialFellowshipPageControllerTests covering roster diff/rebuild, button enable rules, checkbox wiring, create-flow gating, D4 idempotency, and D5 formatting) plus 2 CharacterOptionsPageController counts updated for the D7 un-dim (35->31 dimmed, 15->19 live). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 04:40:53 +02:00
Erik	ae77270939	fix(ui): fellowship checkbox count, row-text + ListBox Flush doc corrections, promote probe findings to assertions ... Mechanism SHOULD-FIX 4: SocialFellowshipPageController's class doc said 0x1000026B holds "all three visible option checkboxes" — the fixture and the decomp both authors FOUR (Ignore Fellowship Requests / Auto-Accept Requests / Share XP / Share Loot, 0x10000270-0x10000273). Corrected. Mechanism SHOULD-FIX 9: SocialPanelRowText.FindDeepest's doc promised "the deepest UiText descendant" but the implementation returns the LAST match in pre-order traversal order, which only equals the deepest when the subtree is a single chain. Both real row templates ARE single chains today, so behavior is unaffected — the doc now describes what the code actually does instead of a stronger guarantee it doesn't implement. Blast SHOULD-FIX 5: UiTemplateListBox.Flush()'s doc only mentioned the ContentHeight reset; UiScrollablePanel.ClearContent() also resets scroll position to 0, which the sibling UiItemList.Flush() (same method name, different semantics) does NOT do. Documented explicitly, including the UX cost this creates for a scrolled-in Friends/Squelch roster once its scrollbar is wired (this fix round's blast MF-1) — flagged for whoever revisits Friends/Squelch scrolling next rather than silently fixed as an unasked behavior change. Mechanism SHOULD-FIX 3: SocialPanelLiveMountProbeTests printed two headline findings (the 0x10000492-authored-twice count, page exclusivity after ActivateTabBehavior) without ever asserting them — a future importer regression collapsing/dropping an instance, or breaking exclusivity, could not fail this test. Both are now real assertions (Assert.Equal(2, passupCount); exactly one page Visible and it is Allegiance). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 03:44:05 +02:00
Erik	9afa05b563	fix(ui): FA3 fix-round — wire Friends/Squelch scrollbars, gate rebuild on visibility, fix revision-latch ordering ... Campaign FA slice FA3 dual-lens review fix round. Blast MUST-FIX 1: SocialFriendsPageController/SocialSquelchPageController never wired their ListBox's own sibling scrollbar (Friends 0x10000517->0x10000518, Squelch 0x1000053E->0x10000543) — the two lists had NO scroll driver at all (no wheel fallback exists on UiScrollablePanel), making any roster past the visible extent completely unreachable, not just awkward to scroll. Both controllers now wire `scrollbar.Model = listBox.Scroll` scoped to their own page root, exactly like the four existing UiTemplateListBox consumers (Character/Chat/Config/KeyboardConfig). New tests prove the wiring AND that a >panel-height roster is actually reachable through it. Blast SHOULD-FIX 2/3: the Friends/Squelch resolver re-ran LayoutImporter.ImportInfos (a full DAT tree walk) under the shared DAT lock on EVERY row, every revision, even while the panel was closed — RetailUiRuntime.MountSocialPanel's TemplateResolver now caches each row template's ElementInfo the first time it is resolved and never re-Imports for that template id again. SocialPanelController additionally gates the Friends/Squelch Tick-driven rebuild on the panel's own visibility via the (previously unused) IRetainedPanelController OnShown/OnHidden hooks, so no DAT-locked rebuild work runs at all while the panel is closed. SocialFriendsPageController/SocialSquelchPageController also now only advance _lastRevision after every row resolves — a transient resolver miss no longer latches an empty roster until the next server-side change; it retries on the next Tick instead. Mechanism SHOULD-FIX 8: SocialPanelController.Tick() now returns early once disposed, matching every other J-slice teardown discipline (it was being ticked unconditionally forever since RetailUiRuntime never nulls the field). Mechanism SHOULD-FIX 1: IsShowingAllegiance's doc claimed the F3/F4 close-on-second-press semantics were "retail's Toggle-action semantics" — re-derived and confirmed NO retail OnAction consumer exists for either action anywhere in the binary. Relabeled as acdream's own OpenSpellbook-precedent convention; no register row added, following the same no-row precedent OpenSpellbook and every other non-toolbar Toggle panel already sets. Unknown filed as U11 in the panel-structure research doc's §8 table. Tests: 5 new (2 scrollbar-wiring pins, 2 long-roster-reachable-via- scrollbar, 1 hidden-panel-does-not-rebuild/shown-panel-catches-up); 2 existing tests updated for the new visibility gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 03:43:35 +02:00
Erik	74c3d85d37	test(ui): FA3 -- social panel fixture dump, live-mount probe, conformance tests ... - RetailLayoutFixtureGenerator dumps LayoutDesc 0x2100006E slot 0x1000018F to the committed social_panel_2100006E_1000018F.json fixture, closing lane-A unknowns U3/U4/U6/U7/U10 with real DAT data (geometry/media/fonts/base refs, the fellowship empty/full frame containment, the panel/page P0x57 properties, the row-template arrays). - SocialPanelLiveMountProbeTests exercises the PRODUCTION mount path against the live DATs (ACDREAM_PROBE_LIVE_MOUNT=1): the tab host resolves as UiTabPanel with its 4-entry table, all four pages resolve, the fellowship frame pair and allegiance signature elements resolve, 0x10000492 is confirmed authored twice under the allegiance page, and every tab button caption is non-empty (the #375 resolver class). - SocialPanelControllerTests pins the fixture-driven conformance: the real (coordinator-addendum-correcting) tab table and default entry, the Fellowship/Allegiance empty-state gates, Friends/Squelch row population and revision-driven rebuilds, and the D1 INERT-button contract (AD-79) via FriendsAndSquelchActionButtons_AreClickable_ButHaveNoHandler. - RetailPanelCatalogTests gains the SocialPanel id/window-name/ Mounted-not-Toolbar pins (lane A §6.1: no toolbar button). Note: the ACDREAM_REGENERATE_UI_FIXTURES=1 run used to produce the new fixture also touched keyboard_config_21000009.json and options_2100002B.json on this machine (unrelated installed-DAT drift, likely from local DAT-editing tooling) -- both were reverted to HEAD before this commit; only the new social panel fixture is included. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-12 02:58:28 +02:00
Erik	1226f289f3	research: Campaign FA lanes A-D + the U2 slot-table probe (social panel found) ... Four Opus research lanes for the Fellowship & Allegiance campaign: panel structure, fellowship wire (two BN zero-folds broken by byte decode: IsFull >= 9, the x87 XP-share table capping at 2.8x), allegiance wire (27+5 messages binary-verified; tree assembly discard/reversal rules; ACE zeroed-field caveats), and the acdream seams audit (H.2 scaffolding inventory, J-owner recommendation, AD-78 dimmed-row inventory, bot-gate requirements). Coordinator U2 closure (FaPanelSlotProbeTests, live DATs): Fellowship and Allegiance are two of FOUR pages of ONE tabbed social panel — slot 0x1000018F, panel id 12, Type-8 host — alongside gmFriendsUI and gmSquelchUI; lane A's separate-siblings mounting call is corrected in its addendum, and the full 16-slot dump closes every unidentified RetailPanelCatalog entry (Abuse/Book/LinkStatus/MiniGame/UA/Vitae/ Map+House/Journal). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 23:42:19 +02:00
Erik	d1c60df946	fix #382: chat-window indicator buttons invisible until first hovered ... Root cause (found via reference-identity-verified live-DAT probing, not a guess): the four main-chat-window indicator buttons (0x10000522- 0x10000525) resolve their own correct ActiveState="Normal" at construction, then get blanked to "" moments later in the SAME LayoutImporter.Build call. The indicator column's backing panel (0x10000600) authors PassToChildren=true on its own empty DirectState (confirmed live: States[0xFFFFFFFF].PassToChildren == true); when LayoutImporter.BuildWidget's post-attach state reapply runs for that panel, UiDatElement.TrySetRetailState cascades its DirectStateId to every IUiDatStateful child, including the already-correctly-resolved buttons. UiButton.TrySetRetailState's DirectStateId branch used to accept that cascade because every button structurally carries a DirectStateId entry in its States dict as a property bag (ToggleBehavior/ RolloverEnabled/etc), independent of whether it authors any blank sprite, so TryFindState(DirectStateId) found that entry and blanked ActiveState even with no "" media. A hover "fixed" it only because UiButtonStateMachine.RequestedState resolves to the same canonical Normal id regardless of PointerOver when RolloverEnabled is false. Retail's own decompiled UIElement::SetState @0x00464e70 does the exact same unconditional-commit-plus-cascade; retail avoids this specific bug purely through construction timing (UIElement::Initialize's SetState call precedes child-tree construction, so a cascade fired during import always iterates zero children). Our port's LayoutImporter.BuildWidget deliberately reapplies in the opposite order to give retained PassToChildren tabs their authored child media, so this literal state-machine port needed a compensating guard. Fix: UiButton.TrySetRetailState's DirectStateId branch now requires REAL "" media (HasStateMedia("")) before accepting the transition. Scoped to UiButton only; UiDatElement's parallel branch and the cascade mechanism are unchanged, so CharacterStatController's own PassToChildren-driven chrome children are unaffected. Register row AP-206 records the divergence from retail's literal unconditional- commit semantics. Regressed by two fast unit tests in UiButtonTests.cs (DirectStateCascade_WithoutRealMedia_DoesNotBlankAnAlreadyResolvedState, DirectStateTransition_WithRealMedia_StillSucceeds) plus a live-mount probe confirming all four buttons resolve ActiveState="Normal" immediately after import against the real installed DAT. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 23:03:31 +02:00
Erik	a31fd631ad	fix #381: Options-panel footer needs an opaque backing field ... Root cause: a live-DAT probe found retail authors NO backing element behind the Character/Chat/Config tabs' Apply/Reset/Defaults footer — each page root has exactly five children (the row ListBox, its scrollbar, and the three buttons) with zero direct-state media on the root itself. Scrolled row content therefore bled through visibly between/behind the three buttons; the bleed-through is a rendering gap in our own composition, not a missing import. Fix: new minimal widget UiSolidSpriteFill tiles RetailChromeSprites.CenterFill (the SAME panel-background sprite the Options window's own chrome already draws behind everything, not an invented color) across the footer strip's rect, derived from the three buttons' own resolved Top/Height and z-ordered strictly behind every other child so it can never intercept input or occlude the buttons. Register row AP-205 records the synthesis. Regressed by OptionsPanelControllerTests. Bind_SynthesizesOneOpaqueFooterBacking_PerPageWithApplyResetDefaults, which pins exactly one backing field per page, sized from the live button rects, z-ordered behind every sibling. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 23:01:43 +02:00
Erik	2a248c0d48	fix #380: Chat tab opacity sliders were missing their retail row captions ... Root cause: PlayerOptionPage::AddSliderOption never sets a row's own name-label text — the "Inactive Opacity"/"Active Opacity" caption comes from a SEPARATE DAT-resident runtime catalog (DID 0x78000000, resolved via the same two-level DBCache::GetDIDFromEnumStatic master-map/submap lookup ChatOptionsDatDefaults already uses for enum 0x16/category 2, here for enum 0x15/category 2) that nothing in the codebase ever queried, so both slider rows rendered with no caption at all. Fix: new ChatOptionsDatCaptions.TryRead resolves the DID-0x78000000 catalog's per-property name/tooltip entries (matched by the same owning-property enum ChatOptionsDatDefaults already keys its defaults by) and ChatOptionsPageController.BuildOpacitySliders stamps each slider's own row caption/tooltip from it — falling back to no text (never invented English) if resolution fails. Regressed by ChatOptionsPageControllerTests. Bind_WiresEachSlidersOwnRowCaption_FromTheResolvedDatCatalog and the companion Bind_MissingCaption_RendersNoText_NeverInventsEnglish case, plus a live-mount probe (OptionsPanelLiveMountProbeTests. ProbeChatOpacityCaptions) confirming the production TryRead call resolves "Inactive Opacity"/"Active Opacity" against the real DAT. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 23:01:22 +02:00
Erik	c121842664	fix #378: Config-tab dropdown menus render bare with no popup chrome ... Root cause: DatWidgetFactory builds Config-tab Type-0x10000038 menu leaves as bare UiMenu instances (matching the vendor/chat channel menu pattern), but unlike those two controllers, ConfigOptionsPageController never wired the menu's sprite/font/geometry properties after Bind — so every dropdown rendered as plain text with no button well, no arrow cap, and opened no popup on click (#374's fix only corrected click ROUTING, not the missing chrome). Fix: ConfigOptionsPageController.ApplyMenuChrome wires every Config-tab menu row with the SAME retail sprite ids VendorUiController/ ChatWindowController's channel menu already use for this shared popup catalog (LayoutDesc 0x21000043), verified against the live DAT via OptionsPanelLiveMountProbeTests' ProbeConfigMenuChrome/ ProbeConfigMenuPopupChrome probes. Regressed by ConfigOptionsPageControllerTests.MenuRow_SoundFeatures_OpensAndSelects ThroughRealHitPath_UsingAuthoredPopupGeometry, which drives the real click-to-open + item-pick path through the authored popup geometry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 23:00:29 +02:00
Erik	a8ce010d02	fix(ui): #375 residual — activate the Configure Keyboard screen's own tab control ... The gate-3 screenshot flight showed the keyboard list still rendering as overlapping text after the string-resolver + parked-prototype fixes: all SIX ActionClass pages were visible simultaneously (six stacked ListBoxes — 'EmotesterSettings' is the Emote and CharacterSettings pages interleaved) with six dead tab buttons above them. Root cause: OP8's Bind built every page's rows but never called ActivateTabBehavior() on the screen's own Type-8 tab host (0x1000049B), so no authored click bindings were wired and no default-entry switch ran. The authored table marks Movement (0x1000049D) IsDefault=true — activation now performs the same default switch OptionsPanelController runs on ITS host, hiding the other five pages and making the six tabs live. Regressed by Bind_ActivatesTheTabControl_MovementDefaultShown_OtherPagesHidden (fixture-driven: BehaviorActive, Movement visible, five pages hidden, SwitchTo flips exclusivity). Full Release suite: 13,087 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 16:11:22 +02:00
Erik	3441a71833	feat(ui): mark store-only option rows dimmed (user-directed, gate 2) ... User directive (gate 2, verbatim): "mark all options that are not implemented now, so I can clearly see what is not implemented." Store-only rows keep full interactivity (still persist/send) but render their caption in a shared dimmed grey (UiRenderContext.StoreOnlyCaptionColor, matching the existing UiMenu.TextColorGhosted convention) instead of white/DAT color. No invented marker text anywhere -- the dim IS the marker. Config tab (ConfigOptionsPageController, 21 of 27 rows dimmed): Sound Features menu, Interface Sound trio, Play Sound Only When Active (AP-199); Screen Brightness, Automatic Degrades, Graphics Performance, Degrade Distance, the four Rendering Quality menus, Building Detail Textures, Multi-Pass Alpha (AP-198); Camera Stiffness, Camera Adjustment Speed, Align To Slope, Mouse Look Sensitivity, Invert Mouselook Y Axis, Use Mouse Turning (TS-74); Chat Font Face/Size (AP-200). NOT dimmed: Sound/Ambient trios, Resolution, Full Screen (LIVE), VSync and Field of View (NEXT-LAUNCH -- still implemented, just deferred to next process start, per the controller's own doc). Character tab (CharacterOptionsPageController, 35 of 50 rows dimmed): every Group A (wire+store only) and Group D (deferred) row, plus the Group B rows the OP4 gate script's own step 16 confirms are unbound (ShowTooltips, SideBySideVitals, SpellDuration, AdvancedCombatUI, StayInChatMode, DisableMostWeatherEffects, PersistentAtDay, FilterLanguage, MainPackPreferred). NOT dimmed (15 rows): the six ListenTo*Chat ids (TurbineChatMembershipGate), DisableDistanceFog/ DisplayTimeStamps/ToggleRun (bound at GameWindow.cs), the Group-C re-point (ViewCombatTarget/VividTargetingIndicator/CoordinatesOnRadar/ AutoTarget/AutoRepeatAttack), and DragItemOnPlayerOpensSecureTrade (TS-48). Cross-checked against actual shipped consumers via source grep, not just the research doc's Group table, since OP4 only wired a subset of the doc's aspirational Group B. Configure Keyboard (KeyboardConfigController): a row whose RetailActionIdentityTable lookup fails (MappedAction null -- AP-203's Emote/CharacterSettings set) dims its synthesized caption; the key buttons stay fully bindable/persisted/conflict-checked. Chat tab (ChatOptionsPageController): audited, zero store-only rows -- every filter block and both opacity sliders already have a live consumer (ChatWindowState / RetailWindowOpacityController). Ambiguity flagged, not guessed: the character-options-map.md research doc lists AcceptLootPermits in BOTH Group A and Group C; its only code site (LiveSessionRuntimeFactory.cs, the /consent command) is a second setter for the same server bit, not a behavioral reader, so it is classified Group A / dimmed here. Register: AD-78 documents the convention (retail dims nothing; this is a deliberate acdream-only divergence that retires as consumers land). New per-surface conformance tests pin the exact dimmed/live set against a literal expected list, so wiring a future consumer without also flipping its row's literal fails the build: CharacterOptionsPageControllerTests.StoreOnlyRows_MatchTheDerivationTableExactly + Bind_AppliesDimmedCaptionColor_ForStoreOnlyRows_AndWhiteForLiveRows, ConfigOptionsPageControllerTests.CaptionDimming_MatchesTheStoreOnlySetExactly, KeyboardConfigControllerTests.UnmappedRows_DimTheirCaption_MappedRowsStayWhite. Build green; full Release suite 13,086 passed / 4 skipped / 0 failed (baseline 13,082/4/0 -- delta is exactly the four new tests above). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 15:52:20 +02:00
Erik	8bd7e3b88d	fix #375: Configure Keyboard live mount — string resolver + parked template prototypes ... Campaign OP gate 2: the screen opened as a visual mess (textless buttons/tabs, buttons above the window, overlapping text) while the fixture conformance suite stayed green — the #372 class again. Two root causes, both proven by the new env-gated live-DAT probe before fixing: 1. MountKeyboardConfig's main LayoutImporter.Build was the ONE mount in RetailUiRuntime not passing strings.Resolve — every AUTHORED caption (OK/Cancel/Defaults/Revert/Load/Save, the six ActionClass tab labels, the Command/Mapping column headers) built empty, while the controller's own resolveString row captions worked, which is why the screen was recognizable but textless. Fixed by passing the resolver like every sibling mount. 2. gmKeyboardUI authors its ListBox row templates (header 0x1000002E, action row 0x1000002F with the three 100x32 key buttons) as TOP-LEVEL siblings referenced by dat property 0x64. Retail never instantiates template-list elements as live widgets (AddItemFromTemplateList clones from the desc — the same re-import UiTemplateListBox's TemplateResolver performs), but ImportInfos built them parked at the screen's (0,0): three key buttons at y=0..32 ABOVE the framed panel (top y=62) — the 'outside the window' buttons — under a 570x40 header text overlapping them and the top chrome. ImportInfos now skips top-level elements referenced by a SAME-LAYOUT template list (the same skip class as the existing BaseElement-prototype filter; same-layout only because element ids collide across layouts — 0x10000211 is a page in BOTH the options and keyboard layouts). The probe (ACDREAM_PROBE_LIVE_MOUNT=1) pins both against the real DATs: prototypes absent from the built tree, and Defaults/Revert/OK/Cancel resolving on the resolver-passing build. Post-fix the import collapses to the framed 600x476 panel with every screen button inside its bounds. Full Release suite: 13,082 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 15:27:30 +02:00
Erik	1c5cd969b4	Merge op8-keyboard: Campaign OP slice OP8 — Configure Keyboard ... Brings b4edee97 (slice), b1968ce9 (M1/M2/M3 rework), f1d50207 (round-2 residuals). Review chain: REJECT -> rework -> REOPEN-narrow -> coordinator third round; findings docs 2026-08-11-op8-review.md / -op8-rereview.md. The merge lands OP8's six ListBoxes on top of 057d8cd7's #372 viewport fix, which auto-heals the blank-pages hazard the re-review flagged — the OP8 connected gate was contracted to run post-merge for exactly this. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 12:37:56 +02:00
Erik	f1d502072e	fix(ui): OP8 round-2 residuals — inert-row conflict exclusion, DAT-default display, injectivity pin ... R1 (code half): store-only rows (MappedAction null) are excluded from the conflict universe — they never reach the InputDispatcher, so a chord they display cannot collide; counting them made the ten Camera Alternate arrow-key defaults trip a false N-way confirm on any arrow rebind. Mapped cross-context sharing (retail's ConflictingMaps — the combat cluster) remains deferred as ISSUES #373 with the OP8 gate script now carrying the explicit do-not-file warning. SHOULD: unmapped rows with no persisted chords display their DAT defaults (retail shows the arrow keys; blank read as 'unbound') — display-only, the store is untouched until the row itself is edited; the independence test updated to pin the new display semantics while keeping its storage-isolation asserts. Injectivity of RetailActionIdentityTable is now test-enforced (load-bearing for both M1's per-row activation capture and M2's de-alias). R2: AP-203 addendum names the ten same-verb-sibling-live rows and the conflict exclusion. Full Release suite in this worktree: 13,155 passed / 4 skips / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 12:37:45 +02:00
Erik	348d794359	fix(ui): #372 — Chat filter labels resolve from their real table 0x2300000D ... The 13 ID_ChatOption_TextFilter_* labels (and their _Desc tooltips) live in string table 0x2300000D, not the 0x23000003 options table the section headers and slider labels use. Dat-verified: the targeted sweep missed (0x23000001-0A), the control key resolved ('Auto Target' — machinery fine), and the exhaustive all-tables sweep (ProbeFilterLabelHome, now a permanent env-gated probe) hit exactly once: 0x2300000D -> 'Combat'. The initializer decomp confirms the hash KEYS are the symbol names verbatim (the vftable-member operands at 0x006f04cd are the known pooled-string artifact); only the research doc's table attribution was inferred rather than dat-verified — corrected in §8. All 13 rows now render their captions instead of the honest-fallback blanks the first connected gate saw. Full Release suite green (one Core.Net loss-simulation timing flake on the first run, green targeted and on rerun). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 12:28:43 +02:00
Erik	b1968ce980	fix(ui): OP8 rework — activation/scope preservation, camera-row de-alias, conflict-confirm dialog ... Fixes the three MUST-FIX findings from the 2026-08-11 combined dual-lens review of commit b4edee97 (docs/research/2026-08-11-op8-review.md). M1 — SetForAction destroyed ActivationType/InputScope on every write, collapsing walk-mode's Hold, the three combat-scoped bindings, and CameraInstantMouseLook's mouse chord the instant a row (including Defaults, which touches all ~140 mapped rows at once) wrote back. Widened the Bindings seam to carry the full Binding (chord + activation + scope), not a bare chord: KeyboardConfigController captures each row's live Activation/Scope ONCE at build time (every multi-chord action in KeyBindings.RetailDefaults() shares one pair across all its bindings) and reapplies it on every write — rebind, Cancel/Revert, and Defaults (which restores DAT-sourced KEYS only, never touches the pair). New tests pin this across both Defaults and Cancel for a Hold+MeleeCombat-scoped action. M2 — InputMap 0x5 (CameraControls) and 0x6 (CameraAlternateControls) aliased one InputAction each: both rows read/wrote the same live target, so they showed identical stale chords, a rebind of one silently wiped the other, and a row could conflict with its own twin. Building real per-scheme dual-binding storage (or new InputAction members plus the camera-dispatch code to consume them) is a feature, not a one-line fix. Chose the third option: only ctx 0x5 — the scheme RetailDefaults() actually has live support for — maps to InputAction; ctx 0x6 falls through to the existing unmapped/store-only path (AP-203), fully rendered, bindable, and persisted, honestly carrying no live effect. This also retired 10 stale allowlist entries in the DAT-vs- RetailDefaults() round-trip test: with the alias gone, ctx 0x5 alone matches RetailDefaults() exactly for all twelve Camera actions. M3 — the auto-reassign-on-conflict path was wired silent in production (NotifyReassigned: _ => "") though the contract asked for a prompt and retail confirms before overwriting (OpenOverwriteBindingDialog). Wired a real confirm dialog through RetailDialogFactory.MakeConfirmation — the same seam GameplayConfirmationController already uses — read lazily since DialogFactory mounts after MountKeyboardConfig in Initialize()'s order. Only reassigns on accept; decline leaves every row untouched. AP-204 (which recorded the narrowing) is RETIRED; the still-true OK/Cancel left-click-vs-right-click-release note moves to a code comment (zero observable difference, doesn't warrant a register row). Reverted the gate script's step 9 from documenting the silent shape back to the real confirm-prompt behavior. SHOULD-FIX addressed as one-liners in files already touched: - S1: non-user-bindable conflicts are now checked BEFORE any row conflict (retail's own order), and ALL conflicting rows are collected (N-way), not just the first match. - S3: Save wraps the file-write pair in the same try/catch RuntimeKeyBindingTarget.Apply already uses for keybinds.json. - S4: assigning "Mapping 3" on a row with no existing bindings now lands on display index 2, not index 0 — ReplaceSlotValue trims only TRAILING empty slots instead of stripping every default(KeyChord). Right-click on an already-empty slot is now a no-op instead of shifting later bindings. - S6: UiButton.OnRightClick returns false (unhandled, bubbles to parent) when no handler is set, disabled or not — matching the pre-existing behavior the class doc already claimed. Left for a future pass (not one-liners): S2 (ActionMap.ConflictingMaps is still unread — the conflict scan treats all 306 rows as one flat universe instead of respecting the DAT's own legitimately-shared-key table) and S5 (the ~330 DAT layout imports still run eagerly at mount instead of lazily on first open). 19 KeyboardConfigControllerTests (was 12): +2 activation/scope preservation (Defaults, Cancel), +1 camera de-alias, +2 confirm-dialog accept/decline, +1 non-bindable-takes-priority-over-row-conflict, +1 sparse-row third-slot placement. Full solution suite 13,154 passed / 4 skipped / 0 failed (this round's baseline 13,147/4/0, zero regressions). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 09:53:10 +02:00
Erik	c3ed32fb5a	docs+test: #372 — Options tabs blank + Gameplay buttons dead at first connected gate ... The user's first Campaign OP connected gate (ACDREAM_RETAIL_UI=1, live ACE) failed: Character/Chat/Config tabs render blank, only Exit Game of the seven Gameplay buttons visibly acted. A live-DAT mount probe (committed, env-gated) proves the panel BUILDS completely — root UiTabPanel with a 4-entry tab table, all four page slots, all three page ListBoxes as UiTemplateListBox with row templates, all seven buttons as UiButton — and the three page controllers' Bind() run at mount. So the defect is in the live render/input path the whole fixture suite never exercises (mount -> ActivateTabs -> tab-click SwitchTo -> row draw / button hit-test): the OP2-blast structural-false-negative class. Blocks the OP3-OP6 gates; needs a dedicated debug slice + a gate-representative test, not a guess. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 09:48:58 +02:00
Erik	b4edee970f	feat(ui): Campaign OP slice OP8 — Configure Keyboard ... Ports retail's Configure Keyboard screen (gmKeyboardUI, LayoutDesc 0x21000009) — its own separate full-screen window, not a fifth Options- panel tab. Retires OP3's INERT contract for the Gameplay tab's Configure Keyboard button (0x10000204). DAT reader (src/AcDream.Core/Input/RetailActionMap.cs): reads the ActionMap singleton (DID 0x26000000, empirically the only one — not 0x27000000 as GetDBOType's Turbine-internal tag would suggest) and both MasterInputMap defaults (0x14000000 "gmDefaultMap"/0x14000002 "DefaultMap"), union-merged per (InputMapId, ActionId) — proven order- independent since the two maps' one shared context (0x5) has disjoint action-id sets. Empirically resolved three lane-D unknowns against the live DAT: the six ActionClass values (1=Movement, 2=Camera, 3=UI, 4=Combat, 5=Emote, 7=CharacterSettings — 6 is genuinely absent), that the six unnamed InputMaps are 100% non-bindable (render nothing, not an unlabeled group), and that the enum-to-DID pairing for the two master maps is inconsequential to the merge result. Identity table (src/AcDream.UI.Abstractions/Input/RetailActionIdentityTable.cs): maps DAT (InputMapId, ActionId) pairs to acdream's InputAction where a live consumer exists (~140 of 306 user-bindable rows — Movement/Camera/ Combat map almost completely; UI/Quickslot/Chat partially; only 5 of 87 Emotes and none of 48 CharacterSettings hotkeys, since acdream has no general emote player or hotkey-to-option-toggle dispatcher yet). Every entry cross-verified by label match AND a DAT-default-vs- KeyBindings.RetailDefaults() byte comparison (RetailActionIdentityRoundTripTests), which caught a real off-by-one in the Quickslot 13-18 block before it shipped and found three genuine pre-existing RetailDefaults() gaps (walk-mode's Shift-echoed chord, ten CameraAlternateControls arrow-key alternates, and the Quickslot Ctrl+N use-vs-select ambiguity) — none introduced by this slice, all documented rather than silently patched. KeyboardConfigController: six ActionClass list boxes built from the DAT, merged with live KeyBindings for mapped rows (rebind applies immediately through the same InputDispatcher every other input path uses) and a new sibling RetailUnmappedKeyBindings store for rows with no InputAction yet. Left-click a key button opens real InputDispatcher modal capture; right-click erases that slot. N-way conflict detection scans every other row plus the live KeyBindings table for acdream-only actions (Ctrl+M mute, debug F-keys) as the non-user-bindable refusal analogue, using retail's own byte-verified "Could not overwrite " string (table 0x23000004). OK/Cancel/Defaults/Revert reuse the OptionPage/IOptionRow verb model via a new ActionKeyMapOptionRow. Persistence is keybinds.json only (D4 — no .keymap file interchange). Five register rows: AP-202 (.keymap interchange narrowing), AP-203 (store-only rows with no live consumer), AP-204 (silent auto-reassign instead of retail's confirm dialog; OK/Cancel ported as left-click not right-click-release). Small supporting additions: UiButton.OnRightClick (additive, no existing behavior changed), InputDispatcher.Bindings getter (the screen's single live-truth read seam), RetailScanCodeMap (DIK scan code <-> Silk.NET Key, keyboard + the one mouse-device row). 19 new tests (6 ActionMap reader conformance incl. live-DAT row-count/ label pins, 1 DAT-vs-RetailDefaults round-trip, 12 controller behavior tests against the committed keyboard_config_21000009.json fixture) — full solution suite 13,147 passed / 4 skipped / 0 failed (baseline 13,128/4/0, zero regressions). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 09:19:54 +02:00
Erik	472525b99e	fix(ui): OP6 rework — six range captions, un-invert Sound enabled flags, five font faces ... Fixes all three MUST-FIX findings from the OP6 REJECT review (docs/research/2026-08-11-op6-review.md) plus its SHOULD-FIXes and NOTEs. M1 — the "retail ships zero range captions" claim was a Binary Ninja constant-folding artifact (the same class the header-string globals a few lines above already worked around). The six SetSliderLabel call sites byte-decode to reads of runtime-filled ID_Graphics_Value_* globals, not immediate zeros (PE-byte-verified against the PDB-paired acclient.exe, independently re-derived in this session, not just re-asserted from the review). ConfigOptionsPageController.BuildSliderRow gained optional rangeLowKey/rangeHighKey parameters wired for all six idx6 sliders (Camera Stiffness Soft/Hard, Adjustment Speed Slow/Fast, FOV Narrow/Wide, Screen Brightness Dark/Bright, Graphics Performance Speed/Detail, Degrade Distance Close/Far) via the same SetRangeLabel mechanism OP5's Chat opacity sliders already established. Mouse Look Sensitivity (idx3) correctly stays uncaptioned — the one genuine SetSliderLabel omission. Class doc corrected; gate-script lines 535/653-equivalent corrected in place. M2 — the three Sound "Disabled" toggles were semantically inverted: SoundManager::effect_sounds_enabled/ambient_sounds_enabled/ interface_sounds_enabled are all compiled = 1 in .data, and UserPreferences::RegisterPreference binds the checkbox's boolean value DIRECTLY onto those enabled-sense statics — checked-by-default means enabled-by-default, not disabled. AudioSettings.SfxDisabled/AmbientDisabled/ InterfaceDisabled renamed to SfxEnabled/AmbientEnabled/InterfaceEnabled (fresh JSON keys — the rejected slice's keys never shipped in an accepted build); RuntimeSettingsStartupTargets.ApplyAudio now computes effective volume through the extracted, independently-unit-tested pure function ComputeEffectiveCategoryVolumes (enabled ? slider : 0f). This closes the blast radius the review flagged: a missing key in an EXISTING settings.json now falls back to AudioSettings.Default, which is enabled=true, so a fresh launch is audible, not muted. AP-199's wording and gate-script step 6 corrected; the enshrined-inversion test rewritten to assert the correct default and a new SettingsStore test pins the legacy-file fallback path. M3 — UI_ChatFontFace now ships all five of retail's authored choices (Arial, CourierNew, PalatinoLinotype, Tahoma, TimesNewRoman — a fixed compile-time array at gmClient::InitUIPreferences, PE-byte-verified present verbatim in .rdata, not a per-machine runtime enumeration as the rejected slice's comment claimed). Default index 2 (PalatinoLinotype) now indexes a real entry. S1 — Bind() now emits the sixth trailing AddSeperator retail's own InitOptions ends with (0x0049E80D), matching retail's 39-item ListBox (6 headers + 6 separators + 27 option-widget-rows) instead of 38. S2 — Screen Brightness gets its own DisplaySettings.ScreenBrightness field ([-1,1], default 0) instead of overloading Gamma, which has a different unit system (default 1.0, legacy [0.5,2.0] slider) and its own live Settings-panel consumer. S3 — UiScrollbar and UiMenu gained a settable TooltipText surfaced through GetTooltipText (UiButton's existing pattern). Every slider and menu row's own interactive widget (not just toggle/trio rows) now carries retail's "<label>_Help" tooltip, verified as a universal suffix convention across every AttachPreference site touched by this tab. S4 — "800x600" added to DisplaySettings.AvailableResolutions: a genuine retail display mode (Device::ForceDisplayResolution(1,0x320,0x258) at startup) and the Config tab's own byte-verified Resolution row default, not an invented preset. Defaults now lands on a highlighted, re-selectable dropdown entry instead of an orphaned value. S5 — four new/extended tests: ComputeEffectiveCategoryVolumes gets a dedicated pure-function value assertion (Theory + a default-profile-is- audible Fact) in RuntimeSettingsControllerTests, closing the "only event order was asserted" gap that let M2 ship; a label/choice-key conformance table in ConfigOptionsPageControllerTests enumerates every key this tab queries (traced directly from the fixed code paths, not guessed) and fails on an invented OR a dropped key; a per-row DefaultValue pin asserts every row's default against the retail literal directly, independent of the underlying settings-record defaults; and the S1 separator fix gets its own 39-item stacked-ListBox count pin. NOTEs — AP-198's row count was always ten (its own enumeration never said nine); the commit-message inconsistency N1 flagged is reconciled in both the row and the section-summary line, and its Screen Brightness sub-clause now matches S2. N2: Bind() now reads the scrollbar id from UiTemplateListBox.ScrollbarElementId (dat property 0x72) instead of a hardcoded constant. N3 (batch Defaults writes) and N4 (AfterApply on Config-tab entry, needs no action) are left as recorded — out of this rework's scope per the review's own disposition. Full Release suite: 13,125 passed / 4 skipped / 0 failed (baseline 13,117/4/0 — net +8 tests added, 0 regressions, 0 removed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 08:06:20 +02:00
Erik	6d0b0f9285	fix(ui): OP5 review fixes — thumb sync, batched opacity writes, cull register row, tests ... Fixes the OP5 (Chat tab) dual-lens review findings against e71e5a96: - M1 (MUST-FIX): each opacity row's own apply closure now pushes its OWN slider's thumb from the post-link truth (bindings.Current*Opacity()), mirroring the OP4 binding pattern. Before this, a single-slider drag followed by Reset reverted the live value/link but left that slider's own thumb stuck at the dragged position. - S1 (SHOULD-FIX): the Chat tab's two opacity sliders no longer round-trip the whole settings.json on every drag MouseMove tick. UiScrollbar gains IsDragging + a DragCompleted callback (fires once, at the MouseUp that ends an actual thumb drag); the opacity apply closures flush immediately when not mid-drag (Reset/Defaults/discrete edits, same as before) and defer to DragCompleted otherwise, collapsing dozens of per-tick writes into exactly one per drag gesture. Live opacity still applies every tick. - S2 (SHOULD-FIX): filed register row AP-201 and issue #371 for the UiScrollablePanel whole-row-cull-vs-clip divergence the review found (predates OP5, made user-visible by OP5's 240-260px filter blocks). Not fixed in this round (a renderer-level scissor stack is out of scope here) — corrected the OP5 connected-gate script instead so a straddling block's disappear-then-reappear-whole is no longer reported as a self-sizing regression. - S3 (SHOULD-FIX): the chatWindowMainFilter round-trip test already existed in e71e5a96 (the review missed it scrolling past line 330); added the genuinely missing coverage instead — a composed test pinning RetailUiRuntime.MountChat's window-0 SettingsStore -> ChatWindowState seed (MountChat itself needs live DAT access and isn't unit-testable directly). - N11: ScrollbarLinkage_ModelPointsAtTheChatListBoxScroll now asserts through the scoped page-slot lookup (UiElement.FindDescendant) instead of the flat layout.FindElement, which passed for the wrong reason given the shared scrollbar id 0x10000201 — matches OP6's own scrollbar-linkage test pattern. Also updated ConfigOptionsPageControllerTests' local ChatOptionsPageController Bindings fake for the new FlushOpacity parameter. Full Release suite: 13,117 passed / 4 skipped / 0 failed (baseline 13,107/4/0 post-OP6 — 10 tests added, zero skips added, zero failures). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 07:36:54 +02:00
Erik	f5ac1742ba	feat(ui): Campaign OP slice OP6 — the Config tab ... Binds the retail Options panel's Config tab (LayoutDesc 0x21000029, 27 authored rows across 6 sections) through OP2's template mechanism and OP3's per-page OptionPage model, matching the Character/Chat tab controllers' established pattern. The row table is transcribed directly from two decompiled sources — gmConfigUI::InitOptions @0x0049E400 (row order, widget shape, defaults) and gmClient::InitUIPreferences @0x004035b0 (the complete UIPreferences::AttachPreference registration: every label/tooltip key, every slider's real-unit range, every menu's enum choices) — which resolves the research docs' own "U4" unverified slider-caption pairing: retail ships ZERO range captions on this tab (every SetSliderLabel call passes literal string id 0). Consumer disposition: LIVE — Sound/Ambient volume-trio sliders and their toggle halves (AudioSettings.SfxDisabled/AmbientDisabled now gate the already-live engine write; RuntimeSettingsController.SaveAudio newly pushes into OpenAlAudioEngine on every change, not just at startup), Resolution/Full Screen (immediate window resize on save). NEXT-LAUNCH (pre-existing precedent): Sync To Refresh, Field of View. STORE-ONLY (register rows AP-198/199/200, TS-74 extended): Sound Features/Interface trio/Play-Only-When-Active, the nine Graphics/Rendering-Quality rows (Vulkan has no per-feature render knobs), Camera/Input's six rows and Use Mouse Turning (no persistent mouse-turning camera mode), Chat Font Face/Size (distinct new fields from the existing live ChatSettings.FontSize). AudioSettings/DisplaySettings/CameraTurningSettings/ChatSettings each gain new fields for their slice of the 27 rows, backed by SettingsStore round-trips. A real bug caught by testing: the scrollbar scope lookup used the standalone-layout root id (0x100001FF), which does not survive base-merge into the host-mounted tree — fixed to scope from the tab host's own page-slot id (0x10000213), matching Chat's established pattern for the same shared-scrollbar-id hazard (0x10000201, authored by both the Chat and Config ListBoxes). 30 new tests (27 authored rows register as 30 IOptionRow instances — the three toggle+slider trios each register two). Full Release suite: 13,107 passed / 4 skipped / 0 failed (was 13,083/4/0 — net +24, the one existing RuntimeSettingsControllerTests case updated for SaveAudio's new live-apply call, not a regression). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 07:16:35 +02:00
Erik	ac0304dcf0	fix(ui,runtime): OP4 re-review residuals R1-R4 (coordinator pass) — OP4 CLOSED ... R1: the timestamp prefix moves from ChatLog.Append (which stamped the stored BODY, rendering 'Alice says, "13:05:09 hi"') to ChatVM's display composition — FormatTimestampPrefix(entry.Received) prepends the COMPOSED line, matching retail's separate-leading-string model (fprintf("%ls%ls", ts, text) @0x00563e5b; AddTextToScroll receives composed lines). The prefix renders entry.Received in LOCAL time (retail strftime), invariant literal colons. The ten defect-pinning test cases across ChatLogTests/RuntimeCommunicationStateTests are rewritten to pin the corrected contract (stored bodies stay clean; the composed line carries the stamp outside the quotes — ChatVMTests). R2: open option-bearing panels converge on every PlayerDescription seed: OptionPage.ReloadFromLive (per-row live re-read + gating re-eval, NO AfterApply flush — the seed just cleared the dirty module), OptionsPanelController.OnServerOptionsSeeded (active page), CombatUiController.OnServerOptionsSeeded (SyncControls), wired through RuntimeSettingsController.ServerOptionsSeeded from the same factory hook LockUI already uses. Retail cannot reach this state (its panels close across login); the adaptation exists because retained panels survive the session boundary — documented at the seam. R3: tests drive the refresh widget push (model AND checkbox converge) and ReloadFromLive's no-flush contract. R4: AP-196 addendum names the headless AutoRepeatAttack false->true effective-default flip and the characterOptions escape hatch. Full Release suite: 13,083 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 06:36:14 +02:00
Erik	e71e5a9614	feat(ui): Campaign OP slice OP5 — the Chat tab ... Binds LayoutDesc 0x2100005C through OP2's template-list mechanism and OP3's per-page OptionPage model: the General Options header + two DualHash-linked opacity sliders (Option_DefaultOpacity_Property 0x10000080 / Option_ActiveOpacity_Property 0x10000081, live-apply on drag through RetailWindowOpacityController, defaults read from the installed DAT's DBProperties collection at DID 0x78000001 via ChatOptionsDatDefaults), and the five per-window text-filter blocks (main window 12 rows minus Gameplay, four floaties 13 rows each — the byte-verified authored order cross-checked against the raw gmChatOptionsUI::InitOptions/AddCheckboxBitfield64Option pseudo-C, not just the research doc's own table) writing AcDream.Core.Chat. ChatWindowState directly, the same state CH6's chat windows already read. AP-195 retired: ported both halves left open at the OP2 re-review — the ALL-set LED media swap (new UiButton.FaceFileOverride, driven by the block-level P0x10000082/P0x10000083 sprites now threaded through ElementInfo/DatWidgetFactory) and the CreateChildren self-sizing tail (UiCheckboxBitfield64.Height grows with its stacked row content; the enclosing ListBox reflows around the block's FINAL height via the new UiTemplateListBox.AddPrebuiltRow, reusing the ListBox's own stacking rather than a third stacking path). AP-187 broadened to cover the main window's own filter (previously only the four floaties) and the new live-editing write path. The main chat window's filter (retail window id 8, ChatWindowState id 0) gains its own settings.json persistence (ChatSettings. ChatWindowMainFilter) alongside the pre-existing floaty 1-4 fields; opacity persistence is now wired on every live slider change, not only through the old dev-scaffold Settings panel. Fixture regeneration (ACDREAM_REGENERATE_UI_FIXTURES=1) picked up the new ElementInfo.LedCheckedSprite/LedUncheckedSprite fields across all 19 committed layout fixtures — purely additive, confirmed against the live installed DAT (0x10000520's own 0x82/0x83 properties resolve to 0x06004D17/0x06004D19 exactly as AP-195 documented). Conformance: FilterRows/FilterBlocks pinned against the byte-verified authored order and ChatWindowState's own default constants; the AP-195 LED swap and self-sizing behavior; the DAT opacity-default extraction against the live installed DAT; live filter/opacity writes reaching ChatWindowState/RetailWindowOpacityController; OnShown re-seed and Reset/Defaults ghosting per the OP4 binding-pattern discipline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 06:25:59 +02:00
Erik	bc43fb1d1d	fix(ui,runtime): OP4 review fixes — live re-seed, enable-gating, Combat panel re-point, universal timestamps ... Both OP4 reviews converged on one headline bug (Character-tab rows never re-read live server truth after their pre-login constructor-word seed) plus overlapping MUST-FIXes. All ten converged/consolidated findings land here: MUST-FIX: - BoolOptionRow.SaveCurrentValue now re-reads its live binding (retail's GetValue()-into-SaveCurrentValue) on every OnShown — panel open, tab switch in, initial activation — instead of trusting the pre-login constructor word it was built with. Reset/tab-switch can now only restore values that were actually live at the last show. LockUI's host.Root.UiLocked one-shot mount seed now also converges on every PlayerDescription via the existing OnCharacterOptionsChanged hook. - Apply/Reset are wired to OptionPage.OnOptionChanged in production (Ghosted when nothing changed, Normal when dirty, run once at bind so both start disabled per retail's PostInit); Defaults stays ungated. - The Combat panel's three LEDs (Repeat Attacks/Auto Target/Keep in View) now read/write the same RuntimeCharacterOptionsState seam the Character tab uses instead of a disconnected client-local GameplaySettings copy — closes the "two writable copies" divergence. The three now-orphaned GameplaySettings fields and RuntimeSettingsController's mirror properties/SetCombatGameplay are deleted outright; the headless host's hardcoded AutoRepeatAttack/AutoTarget now read the live option bit. - RuntimeSettingsController.SetUiLocked's convergence guard now compares against the last value actually applied to the runtime target instead of the persisted GameplaySettings.LockUI snapshot, which could already match a server-derived request without ever having been pushed. SHOULD-FIX: - DisplayTimeStamps now prefixes every chat producer (ChatLog.Append is the one seam all of them funnel through), not just AddText's own callers — heard speech, emotes, Turbine channels, and combat text were previously missed. The prefix format escapes its colons and forces InvariantCulture instead of the culture-dependent TimeSeparator placeholder. - sky.frag now honors uFogParams.w (fog mode) like the mesh/terrain shaders, so Disable Distance Fog stops the sky dome's horizon band from blending toward fog color too. - Corrected the "byte-verified" overclaim on the timestamp format string doc comment (BN-sourced, wire doc U6) and the AP-194 anchor-column class-name typo; the RunAsDefaultMovement doc comments now cite retail's actual acclient.h enumerator name. - Added: DispatcherMovementInputSource's option x modifier truth table (incl. || AutoRunActive with the option off), the per-page Apply/Reset enable-gate tests, a real checkbox.OnClick/ToggleBehavior-driven click test, and hash-pins for the six header string keys. - Gate script step 8 corrected for the logout-flush false-failure (closing the panel before relogging is load-bearing); a new step documents the enable-gate sequence and the Combat-panel/Character-tab cross-check. Register: AP-196 (the Group-C default-source change + GameplaySettings retirement) and AP-197 (the ignored per-character timestamp format override) filed in this commit. Full Release suite: 13,044 passed / 4 skipped / 0 failed (was 13,008/4/0; net +36 tests from new coverage and legitimate assertion updates from the GameplaySettings retirement). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 05:30:26 +02:00
Erik	22b86b9ff4	feat(ui): Campaign OP slice OP4 — the Character tab ... Binds LayoutDesc 0x21000028 (gmCharacterSettingsUI) through OP2's template-list mechanism and OP3's OptionPage model: 6 authored group headers + 50 toggle rows (49 from the 2013 build + D3's "Listen to PK death messages", AP-193) in research doc §2's authored order, each row resolved by PlayerOption id through CharacterOptionTable, seeded from live RuntimeCharacterOptionsState, defaulted from CharacterOptionTable. ClientDefault (byte-verified against UIOption_Checkbox::SetPlayerOption @0x00486e80's own GetDefaultOptionValue call — AP-194 updated to confirm the directive was followed), labels/tooltips resolved by name from string table 0x23000003 (never hard-coded English), and registered with OptionsPanelController.CharacterPage. Apply/Reset/Defaults (0x100001FC/FD/FE) are now wired per-page via a scoped subtree search (UiElement.FindDescendant, promoted from UiTabPanel) since Character/ Chat/Config each author their own physical instance under the SAME element ids. Consumers: Group A (29 ids) wire+store only via the existing SetSingleCharacterOptionRuntimeCmd/TrySetOption seam. Group B: Display Timestamps prefixes new transcript lines (RuntimeCommunicationState. DisplayTimestampsSource); Disable Distance Fog forces FogMode.Off (WeatherSystem.DisableDistanceFogSource, retiring half of TS-73); Run as Default Movement inverts the walk-mode modifier's default (RuntimeLocalPlayerMovementState.RunAsDefaultMovementSource). Group C re-points AutoTarget/AutoRepeatAttack/ViewCombatTarget (CharacterOptionCombatSettingsSource), VividTargetingIndicator/ CoordinatesOnRadar/LockUI/AcceptLootPermits from the client-local GameplaySettings record to the canonical server bit — closing two previously-unfiled divergences where AutoRepeatAttack and AcceptCorpseLootingPermissions never reached the wire despite being retail auto-save ids. TS-73 narrowed to its two still-open cases; TS-75..TS-80 file the genuine gaps (no day/night force, no weather- particle/profanity-filter/salvage/housing/pickup-preference subsystem, fellowship-create's unaudited client-sourced field) rather than inventing stand-ins. Conformance: CharacterOptionsPageControllerTests pins all 50 rows against CharacterOptionTable in both directions (an invented or dropped row fails the build), the authored group/order row-by-row, and the build/seed/Apply/Reset/Defaults/wire-publish behavior end-to-end against the committed fixture. 52 new tests; full solution suite 13,008 passed / 4 skipped / 0 failed (was 12,956/4/0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 04:31:34 +02:00
Erik	cb3346907d	fix(ui): OP3 re-review residuals R1/R2/R3 (coordinator pass) ... R1: the gate script no longer promises a timestamp prefix on the Magic macro lines — acdream renders no chat timestamps yet (the Display Timestamps consumer is OP4 scope; no chat-log file exists, TS-69). A bare light-blue transcript line is the CORRECT gate outcome. R2: IsGrounded yields null (silent) for a NULL controller in player mode — the prior pattern returned false and fired the mid-air refusal retail cannot produce in that state; comments now match the code. R3: the dormant-ActivePageChanged pin now applies the real stimulus — every authored tab button on a dormant host must carry NO click handler (RetailTabBinding.SetClick never ran), which is AD-73's actual dormancy mechanism; SwitchTo deliberately has no guard. OP3 is CLOSED: dual APPROVE-WITH-FIXES -> fix round 386076af -> re-review REOPEN(narrow) -> this pass. Connected gate now READY. Full Release suite: 12,956 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 03:25:40 +02:00
Erik	386076af0f	fix(ui): OP3 review fixes — byte-verified Magic chat lines, Gameplay/OptionPage shape, mid-air tri-state, shared geometry ... Consolidated fix round for the two OP3 dual-lens reviews (docs/research/2026-08-11-op3-review-{mechanism,blast}.md), both APPROVE-WITH-FIXES. MUST-FIX: - The six "Use Mouse Turning Settings" chat lines were typed RetailLogTextType.ClientLocal (0x1A); retail types them 0x07 (Magic). BYTE-VERIFIED against the PDB-paired binary at all six gmConfigUI::SetMouseTurningDefaults call sites (0x0049E972/E9E2/EA52/ EAA4/EAF6/EB48): every site pushes `6a 07` (type=7) immediately before the text-pointer push and the AddTextToScroll call. Added a dedicated OptionsRuntimeBindings.DisplayMouseTurningMacroLine seam routed at Magic (scrolling chat transcript, light blue, timestamped) instead of the 4-slot SpewBox ClientLocal uses; the mid-air refusal and UA/RA keep ClientLocal (both independently confirmed correct). - Filed AD-77: the client-wide floating-only gmPanelUI host divergence (retail also exposes a docked 0x21000017 host) the plan §5 delegated to this review, scoped to every main panel, not just Options. SHOULD-FIX: - gmGameplayOptionsUI is not an OptionPage in retail (acclient.h:55857, UIElement_Field). OptionsPanelController now constructs the Gameplay slot's OptionPage with AfterApply deliberately null, so entering/ leaving that tab never publishes SaveCharacterOptionsRuntimeCmd. Corrected OptionPageModel's doc comment and rewrote the two tests that pinned the wrong (Gameplay-flushes) shape. - Added the OptionPage.OnOptionChanged seam (PlayerOptionPage:: OnOptionChanged @0x004F27D0) — fires as the last step of Apply/ Reset/Defaults, plus once per live LED edit via a new IOptionRow.AttachPageNotify hook (BoolOptionRow wires it into SetCurrentValue only, matching retail's Apply(1)-only HandleDialogAndNotices path). OP4-6 will bind Apply/Reset enable state to this. - Exit to Character Selection's mid-air refusal is now tri-state (Func<bool?> IsGrounded): retail's UseTime only reaches the airborne test inside `else if (smartbox->player)`, so outside player mode (or with no live controller) the button is a SILENT no-op, not a refusal. Fixed the inverted comment at both call sites. - Options panel geometry now matches its nine gmPanelUI siblings sharing RetailPanelUiController's one main-panel rectangle (ResizeX=false, bottom-edge-only resize, no invented Min/MaxWidth/ Height) instead of being the only all-four-edge/horizontal-resize outlier whose width silently reverted whenever a sibling was shown. - Added the three missing test pins: Options/Character mutual exclusion through a REAL RetailPanelUiController registration, RetailDialogFactory.MakeConfirmation's omitted-queueKey overload sharing DefaultQueueKey, and UiTabPanel.ActivePageChanged never firing on a dormant (non-activated) host. - TS-74's What/Where now names the five store-only CameraTurning preferences explicitly instead of only mentioning them in Risk. - Test script gains the toolbar-button ghosted->enabled+highlight check, UseMouseTurning-survives-relogin and the five prefs-survive- relaunch steps, a UA/RA legibility eye-item, and the corrected bottom-edge-only geometry description for step 5. One-liners fixed in files already touched: symmetric close-button resolve-failure logging in OptionsPanelController.Bind (blast NOTE 8). Full Release suite: 12,947 passed / 4 skipped / 0 failed (baseline 12,935/4/0 post-OP7 — 12 net new tests; the two OptionPageModelTests "wrong-shape" tests were renamed/rewritten in place, not removed). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 03:05:27 +02:00
Erik	9d26ecc623	feat(ui): Campaign OP slice OP3 — Options panel shell, open paths, Gameplay tab ... Mounts retail's Options panel (LayoutDesc 0x2100002B resolved through host 0x2100006E slot 0x1000018D, gmPanelUI key 10) via the same catalog-import pattern CharacterController already validates, registered through RetailPanelUiController so it shares retail's "one active gmPanelUI child" mutual exclusion with every other sibling panel for free. F11 and the toolbar's options button (0x1000019B, already authoring panel id 10) both now open it; the close button fires the same ToggleOptionsPanel action. OptionPageModel (OptionPage/BoolOptionRow) ports retail's exact Apply/Reset/Defaults/visibility semantics from UIOption_Checkbox/PlayerOptionPage — LED clicks apply live immediately, Apply commits every row unconditionally + flushes the batched blob, Reset reverts only Changed rows, Defaults restores without committing, and tab-switch/window-hide revert uncommitted edits. Wired for all four tabs; this slice registers real rows on none of them (Gameplay authentically has none — a pure button list). UiTabPanel gains an ActivePageChanged event so the page model can hook every tab transition, including the initial default-tab activation. The seven Gameplay-tab buttons: Exit Game reuses the existing graceful window-close path; Exit to Character Selection gets retail's confirmation dialog and byte-verified mid-air refusal but still behaves as Exit Game (AD-74 — no pre-world character-select flow exists); Configure Keyboard and In-Game Help Files are inert this slice (AD-76 for Help — the plugin retail depends on doesn't exist); Urgent Assistance/Report Abuse short-circuit to their own byte-verified failure text through the interface-text seam instead of ShellExecute against a dead URL (AD-75); Use Mouse Turning Settings runs the pure MouseTurningSettingsMacro port, persisting five new CameraTurningSettings preferences and sending PlayerOption.UseMouseTurning — TS-74 records that acdream has no persistent mouse-turning camera mode for the bit to drive yet. Full Release suite: 12,918 passed / 4 skipped / 0 failed (baseline 12,871/4/0 — only new tests added). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 02:14:40 +02:00
Erik	5242de9f15	fix(ui): OP2 re-review closure (coordinator pass) — AP-195, tooltip port, zero-children pin ... Closes the mechanism lens's REOPEN (one MUST-FIX) and both lenses' small residuals on the OP2 rework (b236a442); the blast lens re-review was CLOSED outright. Fable-direct per the two-failure escalation rule. - AP-195 filed: UIOption_CheckboxBitfield64 ports HALF of Refresh @0x004859C0 — the ANY-set checkbox predicate is exact, but the ALL-set LED media swap (P0x10000082=0x06004D17 / P0x10000083=0x06004D19) and the ListBox self-sizing tail (ResizeTo/CalculatePaperSize — the block IS a UIElement_ListBox in retail) are unported, and the block's row stacking is a second divergent implementation beside UiTemplateListBox. All due at OP5 before the Chat tab's connected gate; the IsSet doc comment now names both halves instead of quoting only the ported one. - Row tooltips: UiButton gains settable TooltipText surfaced through the shared GetTooltipText hover pipeline (UiCatalogSlot's pattern); UiCheckboxBitfield64.AddChild applies the row tooltip retail stamps in CreateChildren @0x00485DF0, and documents that the 0x10000084 row-index attribute stamp is deliberately replaced by the typed mask closure. - AD-73 addendum: UiTemplateListBox.ConsumesDatChildren=true is inert only while no authored Type-5 element carries children — that premise is now conformance-PINNED across all 32 fixtures (a future DAT regeneration surfacing an authored child fails the build instead of silently dropping it). - Plan doc: OP2's contract names UiTabPanel.cs (retail UIElement_Panel), not the fictional-class-named UiTabControl.cs; ledger records OP1 and OP2 both CLOSED. Full Release suite: 12,871 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 01:26:29 +02:00
Erik	b236a44279	fix(ui): OP2 rework — dormant UiDatElement subclasses, fixed Panel/CheckboxBitfield64 mechanism ... OP2 (df9c7a35) was double-REJECTed: an unconditional Type-8/Type-5 factory mapping silently re-classed 15 elements across 7 shipped panels (vendor backdrop lost its fill, character/spellbook roots stopped passing clicks through, combat gained a phantom import-time tab takeover, ten ListBoxes gained a spurious hit-testable viewport) because the stale 27 pre-existing fixtures never exercised the new fields — and the mechanism itself cited a nonexistent "UIElement_TabControl" class, inverted UiCheckboxBitfield64's checked-state predicate, and synthesized fake per-row geometry instead of using the widget's own authored template. Shape change: UiTabPanel (renamed from UiTabControl) and UiTemplateListBox now derive from UiDatElement (unsealed) and stay DORMANT by default — an imported Type-8/Type-5 element gets authored-media drawing, ClickThrough generic-decoration default, and IUiDatStateful propagation identical to the pre-OP2 UiDatElement fallback, with zero import-time side effects. The factory's Type-8/Type-5 arms are unconditional again (no more guard whose premise the blast-radius sweep proved false), because dormancy makes an unactivated instance behaviorally indistinguishable from the old fallback. UiTabPanel.ActivateTabBehavior() and UiTemplateListBox's lazy viewport creation are the explicit, controller-driven opt-ins Campaign OP slice OP3+ will call; today nothing does, so the four pre-existing shipped Type-8 hosts (character/spellbook/vendor/combat) and ten pre-existing Type-5 ListBoxes keep their pre-OP2 behavior exactly. Filed AD-73 for this dormant-vs-retail's-unconditional-activation adaptation. Mechanism fixes (docs/research/2026-08-11-op2-review-mechanism.md): - UiTabPanel cites UIElement_Panel (Type 8 is UIElement_Panel; no UIElement_TabControl exists in the PDB), resolves buttons/pages via a GetChildRecursive-equivalent descendant search (not direct-children-only), performs no switch when no entry authors 0x32 (deleted the _tabs[0] fallback), and surfaces unresolved tab-table entries via UnresolvedEntries + a diagnostic line instead of a silent no-op. - ElementReader.ReadTabTable skips entries missing 0x30/0x31, matching retail's SetupTabPageHash @0x0046C2E0 entry filter. - UiCheckboxBitfield64 now builds every row from its OWN authored template (property 0x64 -> {0x2100002B, 0x10000521}) via AddItemFromTemplateList, deleting the synthesized ElementInfo + invented RowHeight=14 — matching retail's CreateChildren @0x00485DF0, which is itself a UIElement_ListBox call. IsSet is now retail's ANY-bit-set predicate (Refresh @0x004859C0), not all-bits-set. TS-72 retired: the click-toggle bit math is now fully decomp-confirmed (SetBitsOnOrOff via ListenToElementMessage @0x00485AE0). Regenerated all 32 UI fixtures against real DAT (ACDREAM_REGENERATE_UI_FIXTURES=1) and committed them — 27 pre-existing fixtures now carry Outline/OutlineColor/ TabTable/TemplateList/ScrollbarElementId; the 5 Options fixtures were already current. Updated EffectsUiControllerTests' now-correct UiTemplateListBox class-identity assertion. Added: 6 built-widget behavior pins for all five pre-existing Type-8 elements + a representative Type-5 element the dormancy model protects (OP2ReworkBlastRadiusConformanceTests.cs); 5 reader-level tests driving ReadTabTable/ReadTemplateList/the 0x72 reader from raw property bags (ElementReaderTests.cs); a multi-bit-mask UiCheckboxBitfield64 test proving the any-bit predicate (the prior single-bit test couldn't distinguish it from all-bits); an activation-idempotency test and a before-activation click-is-inert test for UiTabPanel. Full Release suite: 12,868 passed / 4 skipped / 0 failed (baseline 12,853/4/0 post-OP1-fixes; +15 net new tests, zero regressions). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 01:08:08 +02:00
Erik	df9c7a35eb	feat(ui): Campaign OP slice OP2 — tab control, template ListBox, UIOption widget mappings ... Ships the two new widget primitives the retail Options panel needs plus the four remaining UIOption_* factory mappings, so every tab page (OP3-OP6) has somewhere to mount. - ElementReader/ElementInfo gain three new dat-property readers, following the existing effective-state-resolution pattern (never a per-state first-wins scan, per the round-5 N1 lesson): the Type-8 tab table (property 0x2E -> TabTable), a ListBox's row-template list (property 0x64 -> TemplateList), and scrollbar linkage (property 0x72 -> ScrollbarElementId). LayoutImporter gains one hook (IUiChildrenAttachedListener) so a widget can resolve cross-references its own dat properties name by id once its subtree actually exists. - UiTabControl (Type 8): switches exactly one page-slot child visible, syncs each tab button's Open/Closed state via the existing RetailTabBinding helper, and honors the authored default tab on mount. - UiTemplateListBox (Type 5 with an authored template list): wraps a UiScrollablePanel viewport (sealed, so composition not inheritance) and ports AddItemFromTemplateList(index) — the resolver seam a page controller wires with real DAT access via the SAME LayoutImporter.ImportInfos(dats, layoutId, elementId) overload RetailDialogFactory already uses for its catalog LayoutDesc. - DatWidgetFactory maps the four remaining UIOption_* widgets, each verified against the regenerated options_2100002B.json fixture before writing any code: 0x10000037 (Slider) is structurally an ordinary horizontal UIElement_Scrollbar, so it reuses BuildScrollbar directly; 0x10000038 (Menu) is structurally identical to the vendor category dropdown UiMenu already models, so it reuses `new UiMenu()` like the Type-6 case; 0x10000036 (CheckboxSlider) composes an existing UIOption_Checkbox child + UIOption_Slider child via the new UiOptionToggleSlider wrapper; 0x10000044 (CheckboxBitfield64) authors zero children in the dat (every row is added at runtime via retail's own AddChild(lowMask, highMask, label, tooltip) call shape), so it's a new UiCheckboxBitfield64 composing UiButton per row. No new drawing code anywhere in this set. - Five new committed fixtures (options_2100002B/2100002A/21000028/ 2100005C/21000029) plus 25 new conformance tests pinning the tab table (4 entries, Gameplay default), all three template arrays, scrollbar linkage, every new widget-type mapping, and a UiTabControl behavioral test (switch -> exactly one page visible, click-through the tab button). The Character ListBox's authored 6-header/49-toggle shape (lane B section counts) is proven reachable end-to-end through AddItemFromTemplateList against the committed fixture. - Regenerating fixtures also touched 27 PRE-EXISTING, unrelated fixtures (an Outline/OutlineColor field pair added by an earlier commit, bcc34ee3, that predates when those fixtures were last regenerated). Per the slice contract, that drift was NOT committed — reverted back to HEAD, only the five new Options-panel fixtures are new files here. - Filed TS-72: UiCheckboxBitfield64's click-toggle bit math (AND/OR set/clear semantics) is a documented approximation — the decompiled excerpt this campaign pulled covers UIOption_CheckboxBitfield64::Apply's WRITE side, not its own click-handler's bit math. Flagged for OP5 (the Chat tab controller, the first consumer that reaches the wire) to verify against the real decomp before any live transaction depends on it; nothing user-reachable can observe this yet. Full Release suite: 12,770 passed / 4 skipped / 0 failed (was 12,745/4/0 post-OP1 — 25 net new tests, zero regressions). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 00:06:43 +02:00
Erik	bcc34ee301	feat(chat): retail text style — two-plane glyph outlines, authored SpewBox/chat styles ... Campaign CH round 4, user-gate items 1+2. Root cause: retail ships a second (background) glyph atlas per font, dilated 2px on every side, plus two border-pixel scalars (Font.NumHorizontalBorderPixels/ NumVerticalBorderPixels) that acdream's font reader never read — so even the pre-existing outline parameter drew almost nothing once enabled. Landed together (either half alone is a no-op or a regression): - UiDatFont carries BorderX/BorderY from the DAT font resource. - UiRenderContext.DrawStringDat inflates the background blit's source and destination rect by that margin and restructures into retail's exact two-pass whole-string outline-then-fill model (UIElement_Text::DrawSelf), plus the 8-neighbour +-1px fallback for fonts with no background atlas. Corrects the stale "property 0xd" comment to the real ids, 0x21 (Outline) / 0x22 (OutlineColor). - LayoutDesc property 0x21/0x22 import (ElementInfo.Outline/ OutlineColor, LayoutImporter.ReadState, ElementReader.Merge/ ApplyCanonicalLegacyProjection, DatWidgetFactory.BuildText) so every authored-outline element across the DAT set is correct at once. - SpewBox: RetailFontId corrected from a round-3 heuristic (0x40000025) to the actually-authored 0x40000001 (18px bold serif), Outline=true set on the controller's UiText. Fill colour stays the user-gate-round-1-pinned yellow — font atlases are alpha-only (PFID_A8), so there is no baked shading that could explain the screenshot's gold as anything other than the outline itself. - Chat transcript: default fill now seeds from its authored ARGB(255,204,204,204) instead of an unrelated color-table slot (ChatTranscriptRenderer.BuildLines takes the transcript's own DefaultColor as a parameter); the 34-entry LogTextType table is untouched, and every existing CH1 conformance test stays green unmodified. Regenerated the committed chat_2100006f.json fixture from the real installed DAT, confirming end to end (not by missing-field default) that the transcript carries no outline. Tests: font-reader border fields + inflation math pinned against the real DAT font, two-pass draw ordering/tint/inflation via a new TextRenderer.DebugSpriteSegmentVerts test seam, property 0x21/0x22 import at both the ElementReader.Merge and StateDesc-property layers, SpewBox font/outline, and the chat default-shade seed with the color table proven untouched. Full Release suite: 12,610 passed / 4 skipped / 0 failed (AcDream.slnx, complete solution). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-10 19:28:34 +02:00
Erik	5b54387b8e	fix(chat): round 4 — no user-visible meta text, real /help groups, indicator buttons toggle ... Item 3 (#364): every honesty marker is now gone from user-visible /help text. AllegianceOverview/HouseOverview's "[IMPLEMENTED]" tags and trailing "Subcommands NOT marked..." sentences, and Day/Log/Render/Motd's appended "NOT YET IMPLEMENTED in acdream" tails, are removed; the underlying retail text is corrected/completed against the pseudo-C's own pristine consolidated data dumps (Log and Motd had been silently truncated; Render was entirely acdream-authored and is replaced with the real retail usage string). The three PARTIAL /help group topics (channels/chatting/commands) are now COMPLETE verbatim listings: HelpStupidChannelHack's three "vtable slot" operands, previously believed undecodable, are the same pooled/mislabeled-data artifact this campaign has hit before (AP-113's precedent) — reading the function's own disassembly for the push imm32 preceding each constructor call resolves all three directly. messagetypes is now a real ported construction (IsLegalChannel's 14-id whitelist + LogTextTypeToString's name table + the exact join/wrap format) instead of an acdream summary. Register row AP-184 retired. Item 5: the main window's 1/2/3/4 indicator buttons now toggle their floating chat window on click, per the user's retail memory overruling the earlier decomp-only reading. UIElement_Button::HandleButtonClick has its own generic click-driven action dispatch (property 0x12) reaching the same DoVisibilityToggleAction the Alt+1..4 keybinds use; the button fixture confirms this half is genuinely armed, but the floating-window fixture authors no matching listener-registration property, so the generic mechanism has no proven target in the data on hand. Per CLAUDE.md, the user's retail memory is the axiom regardless: ChatWindowController.BindIndicatorClicks wires each indicator's click through the same ToggleFloatingChatWindow chokepoint the keybinds use, as explicit user-directed retail behavior. SetIndicatorOpen stays the sole writer of the Selected mirror so the visual stays consistent through the click round trip. Full reconciliation in docs/research/2026-08-09-chat-retail-window-shell.md §1.4. Campaign plan gets the round-4 findings section; items 1+2 (text-style) are under parallel research, item 4 passed, item 6 deferred to the settings track. Suite: 12,579 passed / 4 skipped / 0 failed (Release, complete solution), up from baseline 12,553/4/0 — net +26 tests, zero regressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-10 18:46:34 +02:00
Erik	a819687cf0	feat(chat): Campaign CH slice CH6c — window opacity + transparency setting ... Retail's ChatInterface::SetOpacity (0x004F3120) fades the WHOLE composited window surface with one alpha; UiRenderContext.ApplyAlpha already gated DrawSprite/DrawRect/DrawFill (since 1da697ec, pre-CH6) but DrawStringDat and DrawString still passed applyAlpha:false, so text stayed sharp over a translucent window. Both now route through the same chokepoint. RetailWindowOpacityController (new) subscribes to a new RetailWindowManager.WindowRegistered event and drives every registered window's live Opacity from keyboard-focus state, applied to EVERY window (chat, floaties, vitals, toolbar, ...) rather than retail's ChatInterface-only scope — register row AP-190, retiring the stale AP-40 "fixed 0.75, no focus transition" row in the same commit. Verified retail's shipped opacity defaults from the decomp (constructor literals, no cdb needed): the base ChatInterface ctor sets DefaultOpacity=0.5/ActiveOpacity=1.0, kept unmodified by the four floating windows; gmMainChatUI's own ctor overrides the main window to 1.0/1.0 (always fully opaque). acdream ships one shared global default (0.5/1.0) rather than replicating the per-class override — also AP-190. The linking invariant (raising default above active drags active UP; lowering active below default drags default DOWN — never a clamp) is ported verbatim as ChatOpacityLink in AcDream.UI.Abstractions, shared by the live controller and the new Settings -> Chat tab's two linked opacity sliders. Persistence: ChatSettings.DefaultOpacity/ActiveOpacity round-trip through SettingsStore; Save pushes both through IRuntimeSettingsTargets.SetChatOpacity into the live controller, no restart required. Rider (CH6a/b re-review): strengthened the grip-media regression guard past a bare SpriteFile != 0 check — ChatLayoutConformanceTests now drives each live grip through a real UiRenderContext/TextRenderer (backed by the in-memory RecordingGpuDevice test double) and asserts the draw call chain actually queued sprite geometry, via a new TextRenderer.DebugSpriteSegments test-only accessor. Full Release suite 12,459 passed / 4 skipped / 0 failed (baseline 12,420/4/0). No subagents, no client launches (session hard constraints); pending the next connected user gate for visual confirmation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-10 14:00:55 +02:00
Erik	1aa7709988	fix(chat): CH6a/b rework — grip media, retail window-id model, floaty fixture ... Applies docs/research/2026-08-10-ch6ab-review-findings.md in full: - BLOCKER 1: UiResizeGrip now carries its ElementInfo/resolve pair and draws its own authored DirectState media (a synthetic parameterless grip still draws nothing, preserving existing resize-drag tests). DatWidgetFactory.BuildResizeGrip threads resolve through. All seven live grips on the main chat window now resolve a non-zero sprite, restoring the visible borders/corners CH6a silently dropped. - SHOULD-FIX 2: ChatWindowState gains BroadcastTargetWindow, a sentinel distinct from every real window id (0-4), fixing the bug where the main window's explicit-addressing branch coincided with the broadcast check (both were literal 0). SetFilter's main-window no-op is dropped — the main window's filter is now genuinely settable. ChatWindowController .Bind takes a ChatWindowState (the same canonical instance the floating windows already share) and GetTranscriptLines builds a real accept predicate instead of accept:null. Verified safe: ClientLocal (0x1A) never reaches ChatLog (AddText routes it to the SpewBox and returns), so nothing observable regresses. - SHOULD-FIX 3: UiButton.SuppressSelfToggle stops the four chat-window indicator buttons (DAT property 0x0B=true, no retail click handler) from flipping their own Selected mirror on a stray click. - SHOULD-FIX 4: generated and committed chat_floaty_2100005b.json from the real installed dats; added the permanent RetailLayoutFixtureGenerator entry. All three flagged FloatingChatWindowController assumptions (input field, title bar, close button) are confirmed correct against real data — no controller code changes needed. New finding: unlike the main window, ALL EIGHT floaty border/corner elements are live Type-9 grips (the floaty's own title bar is its move handle), so a floaty window resizes from every edge and corner. - SHOULD-FIX 5: register row AP-189 documents the shared-500-entry/ 200-line-tail vs retail's per-window 10,000-line scrollback depth gap. - NITs 1-5: documented the filter-persistence-only-on-/saveautoui asymmetry and the reconnect-preserves-filters intent; corrected the research doc's modifier-mask mislabel and the "ONLY function" false superlative; moved WrapText off ChatWindowController onto ChatTranscriptRenderer, closing the circular dependency. Full Release suite: 12,420 passed / 4 skipped / 0 failed (baseline 12,392/4/0 at 22020ef2; net +28 tests, zero regressions). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-10 13:09:32 +02:00
Erik	22020ef2c4	feat(chat): Campaign CH slice CH6b — floating chat windows 1-4 ... Mounts retail's four floating chat windows as always-resident, born-hidden children per gmGamePlayUI::SetupChildren @0x004E9EC0, all sharing LayoutDesc 0x2100005B (window ids 0x10000505/0x1000050E/0x1000050F/0x10000510). New FloatingChatWindowController (AcDream.App/UI/Layout) binds each window's own widget tree — built fresh per instance from one shared imported ElementInfo — reusing ChatWindowController's word-wrap + retail color-carry algorithm via the extracted ChatTranscriptRenderer instead of duplicating it. A floaty window has no talk-focus menu (research doc §2.2), so its entry field always sends on Say; the mismatch against retail's possible shared-channel behavior is UNVERIFIED and filed as #369/AP-188. Runtime owns the per-window filter/open state: ChatWindowState (new, AcDream.Core.Chat) seeds retail's exact PostInit defaults per window (window 1 0x0000101C Speech/Tell/DirectSend/Emote, window 2 0x00040C00 Social/SocialSend/Allegiance, window 3 0x00080000 Fellowship, window 4 0x78000000 Turbine General/Trade/LFG/Roleplay) and implements the full ShouldDisplay(windowId, targetWindowId, logTextType) display predicate from ChatInterface::RecvNotice_DisplayFinalStringInfo @0x004F4640. It lives on RuntimeCommunicationState.ChatWindows so every host borrows the same instance. The main window's filter (0xFBFFFFFF, "no user filter") never actually gates anything because its own explicit-address branch already covers every broadcast line — that's why UpdateFromPlayerModule early-returns for window 0 in retail, ported here by construction rather than a special case. Keybind wiring: InputAction.ToggleFloatingChatWindow1..4 and their KeyBindings.RetailDefaults() chords already existed since Phase K.1c (unwired until now). The MetaKeys table confirms retail's default is Alt+1 through Alt+4 (index 3 = bit 0x00000004, cross-checked against the same file's Alt+A/D strafe and Alt+Enter/Tab/F4 rows). Routes through GameplayInputCommandController -> RetainedGameplayWindowCommands -> RetailUiRuntime.ToggleFloatingChatWindow -> the generic UiHost.ToggleWindow, whose visibility-change event is the single chokepoint that syncs ChatWindowState.SetOpen and mirrors the main window's 1-4 indicator button regardless of what changed a window's visibility (keybind, close button, or a restored layout). A direct decomp read of gmMainChatUI::ListenToElementMessage @0x004CDA80 — the only function in the whole binary that branches on a click message — settles what the research doc had left as a hedge: it handles exactly 0x1000046f (max/min) and the talk-focus menu's selection message, with NO case for 0x10000522-0x10000525. The four indicator buttons are PURE one-directional mirrors in retail; clicking them does nothing. ChatWindowController.SetIndicatorOpen ports this with no OnClick at all. Corrected research doc §1.4 accordingly. Persistence is local-only (register row AP-187; the retail 0x1000008C GameplayOptions wire remains deferred to CH6f): window geometry and open/visible state ride the existing generic RetailWindowLayoutPersistence path for free once each window registers under its own WindowNames entry; the four filter masks get a dedicated ChatSettings round-trip (ChatWindow1Filter..ChatWindow4Filter, defaulting to the retail PostInit constants) loaded at mount and saved alongside SaveLayout(). Tests: ChatWindowStateTests (defaults, TypeIsActive, the full display-rule matrix, toggle/reset, revision counter), FloatingChatWindowControllerTests (bind smoke tests against a synthetic 0x2100005B tree, per-window filter routing, filter-change cache invalidation, fixed-Say submit), new ChatWindowController.SetIndicatorOpen tests (Highlight/Normal state, cross-window isolation, range validation), GameplayInputCommandController routing for the four toggle actions, and a SettingsStore filter round-trip. Full Release suite: 12,392 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-10 12:10:20 +02:00
Erik	1fd515436c	feat(chat): Campaign CH slice CH6a — retail chat-window layout + 8-grip resize ... Swap ChatWindowController's imported main-chat LayoutDesc from the wrong 0x21000006 (an unrelated layout whose root and 800px resize bar appear nowhere in the EoR gameplay UI) to retail's ACTUAL main chat window, 0x2100006F (window root 0x10000600, authored 410x100 — confirmed by a direct DAT dump, found in dats.Local not dats.Portal). Every downstream compensation that existed only to paper over the wrong import is deleted: the hand-cropped 490px content width, the dropped 800px resize bar, the 9px transcript patch, the orphan-sibling pruning, the max/min-vs-scrollbar overlap shift, and the scrollbar top-reclaim. The window now mounts with RetailWindowChrome.Imported (0x2100006F's own 8 border/corner elements are its complete chrome) instead of the universal nine-slice wrapper. LayoutImporter/DatWidgetFactory gain a Type-9 (UIElement_Resizebar) case: UiResizeGrip decodes retail's exact four-bool BorderLocation algorithm (0x2A=bottom/0x2B=left/0x2C=right/0x2D=top, UIElement_Resizebar::StartMouseResizing @0x0046B7E0) into a ResizeEdges bitmask. A direct DAT dump established the true shape: only 7 of the 8 grip-position ids are Type 9 — the straight top-EDGE strip (0x1000069C) is a Type-2 Dragbar (move handle), not a Resizebar, because the main window has no title bar. UiRoot now gives a directly-hit grip's own edges priority over its generic proximity heuristic, and a directly-hit move handle the same priority over ambient proximity — so the plain top strip moves the window while its two corner grips resize it including the Y axis, and all 4 edges + 4 corners work everywhere else. This also fixes the reported "no diagonal cursor at corners" (CursorFeedbackController's existing RetailCursorCatalog cursor ids already matched the DAT exactly; they just never received a genuine diagonal edge combination) and "cannot grow in Y from the bottom-right corner" (the old NineSlice+crop mount's indirection is gone; the Imported mount uses the DAT's real minH=100/maxH=2000/minW=300/maxW=2000 directly). The 8 cosmetic "_Locked" border-art twins default hidden (register row AP-185 — retail's UiLocked-driven art swap between the two skins is not ported; UiRoot.UiLocked continues to gate the underlying interaction correctly either way). The 4 chat-window-1..4 indicator buttons import generically (visible, inert) for CH6b to wire. The two hand-drawn translucent-black tints on the transcript/input are removed now that their parent panels draw their own authored background sprites. Filed #366 (chat window's new-unseen-text indicator 0x1000048C is swallowed by UiText.ConsumesDatChildren, pre-existing and out of scope). Corrected the research doc's "all eight grips" claim against the direct DAT dump. Full Release suite: 12,317 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-10 09:38:27 +02:00
Erik	47e40900f3	fix(chat): Campaign CH user-gate round 1 — jump-in-air edge, portal cue cadence, wrap/prefix/color fixes ... The user tested Campaign CH's CODE-COMPLETE build live and reported ten defects (docs/plans/2026-08-09-chat-parity-campaign.md, "User gate — round 1"). Items A-G are fixed here; the remaining three (extra chat windows on 1/2/3/4, resize working in only one corner, transparency/ artifacts) are out of scope for a fix and filed as slice CH6. A. Jump-in-air refusal never fired live: the jump block only ever evaluated input.Jump inside the grounded-charge or already-charging branches. PlayerMovementController now detects the press RISING EDGE while airborne and reports WeenieError.NotGrounded once per press, leaving the grounded charge/fire path untouched. B. ChatVM's invented "[System] " prefix is dropped — retail prints system text bare. [Popup] is unchanged (AP-175). C. SpewBoxController's color is now the user-pinned exact value (1, 1, 0.247, 1), the same bright yellow as an incoming Tell. Register row AP-178 updated: color CLOSES, size/position/font stay open per the user's live report that they still differ. D. Closes #329: PortalTunnelPresentation now emits the portal wait cue unconditionally on every rotation-segment boundary, matching gmSmartBoxUI::UseTime's decompiled else-arm exactly instead of gating on a 5-second hold local transits never reached. PortalWaitNotice Controller now renders it in the same pinned yellow as item C. Register row AP-150 retired. E. Closes #362: new ClientCommandResponses.cs parses and renders the four previously-unhandled inbound GameEvents (ChannelIndex, ChannelList, AvailableHouses, AllegianceInfoResponse), each ported line-for-line from the named-retail decomp's inbound handlers. Register row TS-70 retired. F. ChatWindowController.WrapText now splits on embedded '\n'/'\r\n' first, then word-wraps each segment independently — server text like /help's reply no longer collapses onto one line. G. The chat input field's right edge no longer holds a fixed absolute pixel position across a window resize; Bind now upgrades it to retail edge-mode 1 (UiLayoutPolicy) or the AnchorEdges.Right stretch fallback so it tracks the window's client width instead of overflowing past a narrower resize. Full Release suite: 12,247 passed / 4 skipped / 0 failed (baseline 12,221/4/0 + 26 new tests across items A, E, F, G). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-09 23:42:32 +02:00
Erik	5d247d5518	fix(chat): CH4 re-review fixes — dialog-queue reentrancy, settings option-bit chokepoint ... Should-fix 1: RetailDialogFactory.CloseDialog's queued branch removed the active DialogInfo, ran DialogDone (whose callback can synchronously open a new dialog under the SAME queue key — the two-stage house-abandon confirmation does exactly this), then called OpenNextDialog, which did an unconditional Dictionary.Add on a key the reentrant dialog had already re-occupied. Retail's HashTable::add tolerates the duplicate; Dictionary throws. OpenNextDialog now returns early when the queue key is already active — the reentrant dialog's own eventual close drains the queue. Should-fix 2: @join/@leave wrote the local RuntimeCharacterOptionsState bit before sending, but the Settings Chat toggles reached a second binding (SendSingleCharacterOption) that only sent the wire message, leaving the Turbine membership gate stale until the next PlayerDescription. LiveSessionRuntimeFactory.CreateCommandBindings now has one shared local function for both entrances. Should-fix 3: corrected TS-68/#360 wording again — retail's DoAllegiance dispatcher table EXECUTES boot/ban/officer/title/motd/name/lock/house/ chat/broadcast locally through their own handlers; acdream shows the unrecognized-subcommand refusal for all nine pending the #360 port. What matches retail is the ownership rule (the verb never reaches DoChannelCommand/the server), not the subcommand behavior itself. Removed the inaccurate "matching retail, not merely harmless" / "now matches this" claims from both the register row and the issue. Nits: corrected the HouseAbandonDialogCallback_First citation (0x00580E1A is DoHouse's load site for the callback pointer, not the function entry — the entry is 0x00580240, with the stage-2 confirmation string built at 0x005802D8) in both ClientCommandController.cs and the mirrored test comment; added an InlineData case pinning "@clist allegiance" to RequestChannelList(0x02000000); converted RetailClientCommandCatalog. KnownVerbs from a plain array to a FrozenSet<string> with StringComparer.OrdinalIgnoreCase, matching the file's other lookup tables. Suite: 12,221 passed / 4 skipped / 0 failed (Release), up from CH4's 12,216/4/0 — net +5 tests, no removals. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-09 22:24:43 +02:00
Erik	34d8a3c0e7	fix(chat): CH1 review fixes — sbb-idiom channel catch-all, command-output typing ... Applies the Opus review findings on CH1 (172c6f9a), the exact retail chat color table. Two blockers plus should-fixes/nits, one commit: BLOCKER 1 — LegacyChannelChatType.Resolve's channel-bit table was wrong. Binary Ninja renders retail's `neg esi; sbb esi, esi` idiom (a branchless select between Channel 0x08 and Channel_Send 0x09) as the trivial pseudo-C `esi - esi` (always 0), hiding the real values. Corrected by decoding the raw bytes at the PDB-paired binary: HEAR sbb site VA 0x00570F0A (mask -6 -> 0x08), SEND sbb site VA 0x00570D4F (mask -5 -> 0x09). The generic admin/audit/sentinel catch-all is Channel/Channel_Send, NOT Abuse (0x0E) — Abuse is retail's ONLY 0x0E producer (bit 0x0001). The unnamed FellowBroadcast bit (0x4000000) is hear=Channel(0x08)/send=Fellowship(0x13), not a flat 0x13. ACE's PDB-sourced Channel enum corroborates. Introduces `RetailLogTextType`, the 34-value named enum for the wire LogTextType space (values only, no color — Core stays presentation-free). BLOCKER 2 — three ChatLog.OnSystemMessage sinks (ChatVM.ShowSystemMessage, LiveSessionRuntimeFactory's ShowSystemMessage delegate, HeadlessGameplayOperations.DisplayMessage) were typing ALL ClientCommandController output 0x1A (bright red), including informational command output (@version, /loc, friends list, usage lines). Retail types the great majority of that output 0x00 Default (green) and reserves 0x1A for genuine refusals/errors. Reverted to 0x00 with a comment noting the refusal-vs-info split lands with CH2's SpewBox producer rewiring. The five App composition sites that pass 0x1A for actual refusal text (InteractionRetainedUiComposition, SessionPlayerComposition) were already correct and are untouched (aside from converting the literal to the new enum). Also: AP-176 divergence-register row for OnWeenieError/OnCombatLine's single-type approximation of retail's per-code/per-message dispatch; a carry-forward test for the out-of-range LogTextType color fallback in ChatWindowController; decomp-confirmed anchors replacing ACE-inferred citations in CombatChatTranslator and ChatLog.OnPlayerKilled; required (non-optional) logTextType parameters on OnLocalSpeech/OnTellReceived/ OnCombatLine/OnSelfSent since no production caller relied on a default; LegacyChannelChatType.Resolve's parameter renamed channelBit -> channelId with a doc note on multi-bit ids; corrections to the color-table research doc's §3.3 wire tables; and issue #359 for the pre-existing (not CH1-introduced) 0x019E PlayerKilled participant-suppression gap retail has and acdream lacks. dotnet build clean; full Release suite 11,835 passed / 4 skipped / 0 failed (11,839 total), up from the CH1 baseline of 11,833/4/0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-09 16:03:13 +02:00
Erik	6bb4cfa795	feat(ui): the spell-bar drop ring — retail's authored drag-accept state, and the ring exposed a real drop off-by-one ... The green ring is retail's own art: every UIItem cell carries an authored DragAccept child (catalog 0x21000037, child 0x1000045A), and the spell bar's drag-over handler (SpellCastSubMenu::OnItemListDragOver @0x004C5990) flips it to the Accept state (0x10000040 -> surface 0x060011F9) for any spell payload. Ported through a per-slot SetDragAcceptVisual seam + a catalog DragOverAcceptance hook; other lists are untouched (null acceptance = neutral). A polarity error in our older docs (Accept/Reject state ids swapped) was corrected against three independent sources; the shipped art was always right, only the labels lied. The ring shares ONE landing computation with the drop (FavoriteDropIndex) — and that requirement exposed a genuine #354 off-by-one: the empty-tail path double-applied the -1 adjustment (retail gates it on the lift's removal @0x004C7157), landing a reordered spell second-to-last instead of last. Fixed; discriminator-verified both ways. AP-172 narrowed + its false empty-tail claim corrected. Clean-room complete solution: 11,545 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-08-08 20:18:51 +02:00
Erik	81a9d85a1d	fix(ui): spell-bar drag-reorder works — the per-frame rebuild was destroying the dragged cell (#354) ... Everything already existed — the drag payloads, the favorite wire pair (0x1E3 add-at-position / 0x1E4 remove, byte-confirmed against retail's Event_AddSpellFavorite @0x006A0F70 and ACE), the insert-shift state ops. The bug: lifting a favorite fires SpellbookChanged, the next per-frame Tick rebuilt the bar, the rebuild flushed and recreated every cell, and UiRoot's subtree-removal safety net canceled the in-flight drag whose source had just been destroyed — one frame after every lift, before any drop could land. The rebuild now defers for the duration of the drag gesture, and the drop ports retail's own -1-if-lifted-before-target index adjustment (SpellCastSubMenu::AddFavorite @0x004C7060) so final positions are byte-identical: insert-shift, not swap; drag-out still deletes (the lift's removal stands on a missed drop, retail's shape). The real-pointer-pipeline test fails against the pre-fix code with the exact cancellation and passes after; a discriminator pins that physical-item drop handlers reject the spell payload. AP-172 files the one presentation divergence (mid-drag reflow happens on release, not continuously) — renumbered from the agent's AP-171 draft, which collided with the same-day double-click row. #354 filed and closed. Clean-room complete solution: 11,541 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-08-08 18:28:47 +02:00
Erik	d674b99f56	feat(ui): double-click-to-buy (AP-171, user-approved) + #353 toolbar text fixes — authored right-justify and two-line name wrap (Fable) ... Double-clicking a vendor shop item now buys through the Buy button's exact quantity/price path — retail has NO double-click-to-buy (the named table sweep's negative evidence stands); the user chose the addition explicitly and AP-171 records it. #353 (pre-existing, user-reported): the stack-count entry is AUTHORED HJustify=2 — right-justified flush against the slider on its own row — and UiField already supported RightAligned; nobody had honored the authored value. The name element is AUTHORED two lines tall (H=31, W=140): long names now word-wrap at the authored pixel width onto a second centered row via two stacked one-line labels reusing the existing centered draw path (WrapNameTwoLines: greedy word break, no hyphenation, second row clips like retail). Ten SelectedObjectController structure tests updated from single-label to first-label access. Lesson re-learned the hard way: the first "green" run used a stale TEST assembly (only the App project had been rebuilt) — the clean-room caught it, per feedback_stale_build_artifacts. Full App 4,329/3 and Core 4,381/1 verified green on properly rebuilt assemblies; the one transient Core Release failure did not reproduce and is noted on #351. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-08 17:42:02 +02:00
Erik	02b735ba4a	fix(vendor): evidence-based pass — max-first stack ceiling; the local player resolves never-animated MoveTo targets ... Both chains pinned by the live [vendor-diag] run (vendor-diag.log) after three code-reading rounds each failed: The split bar: ACE serializes descStackSize=1 for EVERY browse row (live wire, log 343-348) — the R1-era "ACE never populates desc" claim is retracted with the line quoted. Retail's vendor sites read pwd._maxStackSize directly (four sites, incl. UpdateItemsList @0x004c1ea0 stamping min(remaining, _maxStackSize)); ResolveAuthoredStackSize flips to max-first for its vendor-only consumers. Taper ceiling 1000, scarab 100, seed 1 for exempt. Pricing still reads the desc (per-1 values on ACE). Walk-to-use: the local player's getObjectA seam was bound to TryGetPhysicsHost, which resolves only INSTALLED physics hosts — a never-animated vendor has none, so TargetManager.SetTarget got null, the MoveToObject armed with zero nodes, and UseTime never dispatched. The log's natural=False completions were the user's own movement keys (retail-correct input-edge cancels); attempt 4 worked because the greeting animation had installed a host. RuntimePhysicsState gains the retail CObjectMaint::GetObjectA seam (bound canonical resolver with installed-host fallback); the graphical host binds the SAME lazy-minimal-host resolver every remote already uses — whose own doc comment names this exact never-animated hazard. The reservation release was already correct (2b premise refuted with evidence); the production-wiring invariants are now pinned by four new tests including the pre-fix pathology as a permanent sabotage control. AP-169 rewritten a second time, honestly. The [vendor-diag] probe family (ACDREAM_DUMP_VENDOR) lands env-gated for future live triage. Clean-room complete solution: 11,536 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-08-08 17:17:04 +02:00
Erik	d003449bb4	fix(vendor): re-gate residuals — MaxStackSize is the stack operand, wire-authored use radius, purse summaries ... R1 the split bar's operand is the item's authored MaxStackSize — three retail sites read pwd._maxStackSize directly (InqListSlotCount pc:200052, buy-button cases pc:203996/204086) where ACE never fills the desc stack and standard stock is unlimited. Threaded StackSizeMax end to end with one shared resolver; the two literal _maxStackSize sites are now byte-exact; AP-165 retired, AP-169 corrected. R2 walk-to-vendor never opened because GetUseRadius used an UNCITED 3m Creature heuristic as the local stop distance while ACE's poll demands the authored radius (default 0.6 m) — the walk stopped and the Use fired far outside acceptance. Now reads the wire-authored spawn UseRadius with ACE's exact fallback; heuristic constants deleted. A first sabotage attempt was non-discriminating (coincidental 0.6) and was corrected — the discriminating version is what landed. R3 the Buying/Selling purse summaries ("Buying %d %s worth %hsp" / "You have %hsp") recovered from the binary data segment where BN mis-attributes the Buy-side literal; wired to staging and money changes on the four authored text elements; AP-166 narrowed to the pending-sell highlight. Clean-room complete solution: 11,528 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-08-08 15:23:10 +02:00