81a9d85a1d
Some checks are pending
Headless portability / portable-headless (ubuntu-latest) (push) Waiting to run
Headless portability / portable-headless (windows-latest) (push) Waiting to run
Headless portability / linux-graphical (push) Waiting to run
Headless portability / linux-vulkan (push) Waiting to run
Everything already existed — the drag payloads, the favorite wire pair (0x1E3 add-at-position / 0x1E4 remove, byte-confirmed against retail's Event_AddSpellFavorite @0x006A0F70 and ACE), the insert-shift state ops. The bug: lifting a favorite fires SpellbookChanged, the next per-frame Tick rebuilt the bar, the rebuild flushed and recreated every cell, and UiRoot's subtree-removal safety net canceled the in-flight drag whose source had just been destroyed — one frame after every lift, before any drop could land. The rebuild now defers for the duration of the drag gesture, and the drop ports retail's own -1-if-lifted-before-target index adjustment (SpellCastSubMenu::AddFavorite @0x004C7060) so final positions are byte-identical: insert-shift, not swap; drag-out still deletes (the lift's removal stands on a missed drop, retail's shape). The real-pointer-pipeline test fails against the pre-fix code with the exact cancellation and passes after; a discriminator pins that physical-item drop handlers reject the spell payload. AP-172 files the one presentation divergence (mid-drag reflow happens on release, not continuously) — renumbered from the agent's AP-171 draft, which collided with the same-day double-click row. #354 filed and closed. Clean-room complete solution: 11,541 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| AppraisalUiControllerTests.cs | ||
| CharacterControllerTests.cs | ||
| CharacterLayoutImportProbe.cs | ||
| CharacterSheetProviderTests.cs | ||
| CharacterStatControllerTests.cs | ||
| ChatLayoutConformanceTests.cs | ||
| ChatLayoutFixtureGenerator.cs | ||
| ChatWindowControllerTests.cs | ||
| CombatLayoutConformanceTests.cs | ||
| CombatUiControllerTests.cs | ||
| CreatureAppraisalRowsTests.cs | ||
| DatWidgetFactoryFontResolveTests.cs | ||
| DatWidgetFactoryTests.cs | ||
| EffectsUiControllerTests.cs | ||
| ElementReaderTests.cs | ||
| ExternalContainerControllerTests.cs | ||
| FixtureLoader.cs | ||
| IndicatorBarControllerTests.cs | ||
| IndicatorDetailPanelControllerTests.cs | ||
| InventoryControllerTests.cs | ||
| InventoryFrameImportProbe.cs | ||
| ItemAppraisalTextFormatterTests.cs | ||
| ItemCooldownUiControllerTests.cs | ||
| ItemListCellTemplateTests.cs | ||
| JumpPowerbarControllerTests.cs | ||
| JumpPowerbarLayoutConformanceTests.cs | ||
| LayoutConformanceTests.cs | ||
| LayoutImporterTests.cs | ||
| PaperdollClickMapTests.cs | ||
| PaperdollControllerTests.cs | ||
| PaperdollSlotBackgroundTests.cs | ||
| PaperdollToggleTests.cs | ||
| RadarControllerTests.cs | ||
| RadarLayoutConformanceTests.cs | ||
| RadarLayoutFixtureGenerator.cs | ||
| RadarSnapshotProviderTests.cs | ||
| RetailDialogFactoryTests.cs | ||
| RetailFixtureConformanceTests.cs | ||
| RetailFpsControllerTests.cs | ||
| RetailLayoutFixtureGenerator.cs | ||
| RetailPanelUiControllerTests.cs | ||
| RetailWindowFrameTests.cs | ||
| SelectedObjectControllerTests.cs | ||
| SpellbookRowStyleTests.cs | ||
| SpellbookWindowControllerTests.cs | ||
| SpellcastingUiControllerTests.cs | ||
| SpellExamineComponentTemplateFactoryTests.cs | ||
| ToolbarControllerTests.cs | ||
| ToolbarInputControllerTests.cs | ||
| UiDatElementTests.cs | ||
| UiPropertyBagTests.cs | ||
| UiTextLayoutCacheTests.cs | ||
| UiViewportFactoryTests.cs | ||
| VendorUiControllerTests.cs | ||
| VitalsBindingTests.cs | ||
| VividTargetIndicatorLayoutTests.cs | ||