acdream/src/AcDream.App/Composition
Erik cd1cdee0e5 fix(render) #443: private viewports take the ring transform path
The paperdoll was visible only in portal space. Root cause: the classic
WbDrawDispatcher.Draw path appended its transforms into the SHARED world
transform frame (WorldTransformFrameArena.Append) with a non-zero base
instance, but the default mesh shaders index every parallel per-instance
array - clip slots, light sets, indoor, OPACITY, selection lighting,
detail category - zero-based; only the packed world submission's shader
convention subtracts the shared-arena prefix. With a world frame active
the doll drew all instances at per-instance opacity 0 into a cleared
target: counted draws, blank pixels, deterministic. Portal space worked
because no world transform frame is active there, so the same code took
the ring path with base 0. The private viewports are the only production
consumers of the classic path, hiding the defect everywhere else.

Fix: WbDrawDispatcher.NextClassicDrawIsPrivatePass - the private
viewport renderer marks its draw and WriteWorldTransformSection routes
private passes onto the plain ring path unconditionally (self-contained
render state: the private pass owns its own camera, lighting, and
target, and must not depend on the world frame's pose address space).

Also landed, each independently justified:
- Per-GPU-flight-slot private targets (PrivateViewportFlightTargets),
  restoring the pre-f6fe0f2a design: that revert's claim that frame
  submission order protects the single target's write->sample transition
  is not guaranteed across Vulkan command buffers. Per-slot completed
  scenes fix the cleared-sibling-after-reveal wart the old attempt had.
- Paperdoll resource preparation moved to the frame resource phase
  (IPrivateEntityViewportResourcePreparation) before world draws consume
  the bounded composite-upload budget.
- The presenter redresses on every dirty edge (an appearance-equal clone
  can pin retired readiness across generations; the renderer's two-phase
  promote keeps the last completed image visible during replacement),
  publishes only non-zero handles, and clears the viewport exactly once
  at the explicit character-session boundary.

Verified live on the clean build: doll visible in the NORMAL world,
visible through portal space, and still visible after arrival - the
exact reported repro cycle. 26 paperdoll/private-viewport/preparation
tests plus 60 renderer-suite tests pass; owner visual gate pending.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-29 16:51:32 +02:00
..
AnimationHookRegistrationSet.cs refactor(app): compose live presentation startup 2026-07-22 17:55:15 +02:00
CompositionAcquisitionScope.cs feat(render): Campaign V slice V6h — the Vulkan composition host 2026-07-28 11:47:37 +02:00
ContentEffectsAudioComposition.cs feat(launcher): stabilize prepared content updates 2026-08-25 19:17:13 +02:00
FrameRootComposition.cs fix(render) #443: private viewports take the ring transform path 2026-08-29 16:51:32 +02:00
GameWindowCompositionPipeline.cs refactor(app): close ordered startup composition 2026-07-22 19:20:20 +02:00
GameWindowGraphics.cs feat(render): Vulkan campaign V11 step 2 — delete the OpenGL backend 2026-07-29 02:19:53 +02:00
GameWindowPlatformAcquisition.cs refactor(app): define ordered composition contract 2026-07-22 15:03:40 +02:00
HostInputCameraComposition.cs feat(render): implement Campaign AR and terrain fidelity 2026-08-22 13:13:29 +02:00
InteractionRetainedUiComposition.cs fix: complete retail parity stability pass 2026-08-28 20:01:39 +02:00
InteractionUiRuntimeSources.cs feat(ui): Campaign CT slice CT3 — Titles page live via standard GUI classes 2026-08-24 22:59:40 +02:00
LivePresentationComposition.cs fix(client): restore retail interaction parity 2026-08-26 20:45:11 +02:00
LivePresentationRuntimeBindings.cs refactor(app): key live projections by runtime identity 2026-07-25 21:50:58 +02:00
PreparedSetupResolver.cs perf(content): remove exception-driven setup probes 2026-07-24 15:12:21 +02:00
SessionPlayerComposition.cs fix: complete retail parity stability pass 2026-08-28 20:01:39 +02:00
SessionPlayerRuntimeBindings.cs refactor(app): compose session and player startup 2026-07-22 18:28:32 +02:00
SessionStartComposition.cs fix(plugins): close LA5 host lifecycle review 2026-08-14 19:05:13 +02:00
SettingsDevToolsComposition.cs fix(client): restore retail interaction parity 2026-08-26 20:45:11 +02:00
VulkanHostInputCameraCompositionFactory.cs feat(render): implement Campaign AR and terrain fidelity 2026-08-22 13:13:29 +02:00
WorldRenderComposition.cs feat(render): implement Campaign AR and terrain fidelity 2026-08-22 13:13:29 +02:00