acdream/docs/superpowers/plans
Erik b5da17db76 feat(retail): Commit B — retail-faithful AP cadence + screen-rect picker
Retires divergences flagged in the 2026-05-16 faithfulness audit:

1. AP cadence. Replaces the 1 Hz idle / 10 Hz active flat heartbeat
   with a diff-driven model gated on `Contact && OnWalkable`
   (acclient_2013_pseudo_c.txt:700327 SendPositionEvent). Sends on
   position or cell change while grounded on walkable, plus a 1 sec
   heartbeat; suppressed entirely airborne. PlayerMovementController
   exposes `NotePositionSent(pos, cellId, now)` which GameWindow stamps
   after each AutonomousPosition / MoveToState send — mirrors retail's
   shared `last_sent_position_time` between SendPositionEvent
   (0x006b4770) and SendMovementEvent (0x006b4680). Known divergence
   from retail: ours is per-frame-while-moving, retail's effective rate
   is ~1 Hz during smooth motion (cell/plane checks). Filed as #74,
   blocked by #63 — when #63 lands we revert to retail's narrower gate.

2. Workaround retirement. Removes TinyMargin (0.05 m inside arrival)
   and the AP-flush before re-send (`SendAutonomousPositionNow`). The
   diff-driven cadence makes both obsolete. Close-range turn-first
   deferred Use is kept (it IS retail — ACE Player_Move.cs:66-87
   mirrors retail's CreateMoveToChain pre-callback rotation), renamed
   `OnAutoWalkArrivedSendDeferredAction` to clarify it's a FIRST send.
   `isRetryAfterArrival` parameter dropped.

3. Far-range Use/PickUp retry. Restored — was load-bearing, not the
   "redundant cleanup" the Group 2 audit thought. Issue #63 means ACE
   drops the first Use as too-far without re-polling on subsequent APs;
   the arrival re-send is what makes far-range Use complete. Logs
   include `(queued for arrival re-send pending #63)` to make this
   explicit. Removes when #63 closes.

4. Screen-rect picker. New `AcDream.Core.Selection.ScreenProjection`
   helper shared by `WorldPicker` and `TargetIndicatorPanel`. The
   `Setup.SelectionSphere` projects to a screen-space square (retail
   anchor `SmartBox::GetObjectBoundingBox` 0x00452e20); picker
   hit-tests the mouse pixel against the same rect the indicator draws,
   inflated by 8 px (`TriangleSize`). Guarantees what-you-see is
   what-you-click — including rect corners that were dead zones under
   the old ray-sphere picker. Per-type radius (1.0/1.6/2.0 m) and
   vertical-offset (0.2/0.9/1.0/1.5 m) heuristic lambdas retired;
   `IsTallSceneryGuid` deleted; `EntityHeightFor` trimmed to 1.5 m × scale
   defensive default. No defensive sphere synth — entities without a
   baked `SelectionSphere` are skipped, matching retail's
   `GfxObjUnderSelectionRay` (0x0054c740).

5. Rotation rate run multiplier (Commit A precursor). `TurnRateFor(running)`
   helper applies retail's `run_turn_factor = 1.5f` (PDB-named
   0x007c8914) under HoldKey.Run, matching `apply_run_to_command` at
   0x00527be0 (line 305098). Effective: walking ≈ 90°/s, running ≈ 135°/s.
   Keyboard A/D + ApplyAutoWalkOverlay both use it.

6. Useability gate (Commit A precursor). `IsUseableTarget` corrected to
   `useability != 0` per `ItemUses::IsUseable` at 256455 — ANY non-zero
   passes (USEABLE_NO=1, USEABLE_CONTAINED=8, etc.), not just the
   USEABLE_REMOTE bit. Cross-checked against 4 call sites in retail
   (ItemHolder::UseObject 0x00588a80, DetermineUseResult 0x402697,
   UsingItem 0x367638, disable-button-state 0x198826). Added
   `ProbeUseabilityFallbackEnabled` diagnostic
   (`ACDREAM_PROBE_USEABILITY_FALLBACK=1`) to measure how often the
   creature/BF_DOOR fallback fires for ACE-seed-DB entities with
   null useability.

CLAUDE.md updated with the graceful-shutdown rule for relaunch:
Stop-Process bypasses the logout packet, leaving ACE's session marked
logged-in for ~3+ min. CloseMainWindow() sends WM_CLOSE so the
shutdown hook runs and the logout packet reaches ACE.

Tests: +3 ScreenProjectionTests + 6 WorldPickerRectOverloadTests = +9.
Core.Net 294/294 pass; Core 1073/1081 (8 pre-existing Physics failures
unchanged). Visual-verified 2026-05-16: rotation rate, useability,
screen-rect click area, double-click + R-key + F-key Use/PickUp at
short and long range — dialogue/door/pickup fire on arrival.

Filed follow-ups #70 (triangle apex/size DAT sprite), #71 (picker
Stage B polygon refine), #72 (cdb omega.z probe), #73 (retail-message
sweep pattern), #74 (per-frame AP chattier than retail — blocked by
#63). Old ray-sphere `WorldPicker.Pick(origin, direction, ...)`
overload kept for back-compat; no callers in acdream proper.

Plan: docs/superpowers/plans/2026-05-16-retail-faithfulness-fixes.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-16 13:56:08 +02:00
..
2026-04-11-foundation-a1-streaming.md fix(app): Phase A.1 — separate Visible from Resident in StreamingRegion 2026-04-11 22:08:17 +02:00
2026-04-12-b3-complete-movement.md docs(plans): Phase B.3 Complete — movement + world navigation plan 2026-04-12 15:59:29 +02:00
2026-04-12-physics-collision-engine.md docs(plans): Phase B.3 physics collision engine implementation plan 2026-04-12 09:48:06 +02:00
2026-04-12-player-movement.md docs(plans): Phase B.2 player movement implementation plan 2026-04-12 14:10:13 +02:00
2026-04-13-movement-completion.md docs: movement completion implementation plan (7 tasks) 2026-04-13 23:08:48 +02:00
2026-05-02-l3-1-interpolation-manager.md docs(plan): Phase L.3.1 — InterpolationManager core implementation plan 2026-05-02 18:26:02 +02:00
2026-05-02-l3-positionmanager-jump.md docs(plan): Phase L.3.1+L.3.2 PositionManager + retail-faithful jump plan 2026-05-03 10:10:16 +02:00
2026-05-08-phase-n1-scenery-via-wb-helpers.md plan(N.1): scenery via WorldBuilder helpers — implementation plan 2026-05-08 09:05:53 +02:00
2026-05-08-phase-n3-texture-decode-via-wb.md docs(N.3): mark Phase N.3 shipped + commit implementation plan 2026-05-08 11:37:52 +02:00
2026-05-08-phase-n4-rendering-foundation.md phase(N.4): SHIP — flag default-on + finalize plan + roadmap 2026-05-08 18:01:23 +02:00
2026-05-08-phase-n5-modern-rendering.md docs: defer per-instance highlight to open backlog (no scheduled phase) 2026-05-08 22:22:23 +02:00
2026-05-09-phase-a5-two-tier-streaming.md docs(A.5 T27): spec + plan amendments for T22.5 + ship 2026-05-10 10:06:26 +02:00
2026-05-09-phase-n5b-terrain-modern.md phase(N.5b): SHIP — terrain on modern rendering path 2026-05-09 13:05:12 +02:00
2026-05-10-issue-13-pd-trailer.md refactor(net): #13 Parsed.TrailerTruncated + diag logging 2026-05-10 08:26:08 +02:00
2026-05-10-issue-53-tier1-cache.md docs(post-A.5 #53): Tier 1 cache — implementation plan (writing-plans) 2026-05-10 17:06:42 +02:00
2026-05-11-phase-n6-slice1.md docs(perf): Phase N.6 slice 1 — implementation plan 2026-05-11 11:12:26 +02:00
2026-05-12-phase-c1.5a-portals.md docs(vfx #C.1.5a): implementation plan + spec wiring-location fixes 2026-05-11 13:36:18 +02:00
2026-05-12-phase-l2g-slice1.md docs(phys L.2g): slice 1 implementation plan 2026-05-12 21:52:31 +02:00
2026-05-13-phase-b4b-plan.md docs(B.4b): implementation plan — 6 tasks, TDD picker + handler wiring 2026-05-13 17:37:09 +02:00
2026-05-13-phase-b4c-plan.md docs(B.4c): implementation plan — 4 tasks, door spawn-time sequencer + UM diagnostic 2026-05-14 06:50:51 +02:00
2026-05-13-phase-c1.5b.md docs(vfx #C.1.5b): design + plan for issue #56 + EnvCell DefaultScript 2026-05-11 23:51:44 +02:00
2026-05-14-phase-b5-pickup.md docs(B.5): implementation plan from writing-plans skill 2026-05-14 15:10:23 +02:00
2026-05-16-retail-faithfulness-fixes.md feat(retail): Commit B — retail-faithful AP cadence + screen-rect picker 2026-05-16 13:56:08 +02:00