erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions
acdream/src/AcDream.Core.Net/Messages
History
Erik e77ebf100f CC2 review fix round: latch scope narrowed, AD-100, creationFailed reason key 
F1 (MEDIUM): the correlation-latch docs claimed replies are never
misattributed; in truth an overlapping send OVERWRITES the latch and the
first reply routes to the newest request's event. Narrowed all three doc
sites to the exact contract (single outstanding request; overlap refusal
is CC3's Runtime verification gate, retail's DoFinish UNDEF-state rule)
and pinned the overwrite behavior with
OverlappingSend_OverwritesTheLatch_ReplyRoutesToNewestRequest.

F2 (LOW): filed register AD-100 for the drop-unless-armed deviation —
retail's Handle_CharGenVerificationResponse@0x0055E8B0 has no armed gate
and processes whatever arrives against its persistent verification state.

F3 (LOW): doc note in CharacterCreate.cs — ACE double-sends NameInUse
(IsCharacterNameAvailable runs twice; the first callback's return exits
only the lambda), so the second reply hitting the drop path during a
connected gate is EXPECTED, not a defect.

F4 (LOW): creationFailed's enum-member key renamed name -> reason and the
ATTEMPTED character name added as name, before any consumer shipped —
one status vocabulary must not give the same key two meanings
(characterCreated.name is a character name). Contract, writer, tailer,
and shape-pinning tests updated in lockstep.

F5 (LOW): the thread-id probe-note pointer now cites
ProbeNetLogOutbound's doc comment, where the note actually lives.

Fidelity fold (reviewer's positive note): the latch is retail's OWN
discriminator one layer down — 0x0055E8B0 case 1 branches on
GetVerificationState()==PENDING (create) vs not (restore) — now cited in
both the latch doc and CharGenVerificationResponse.cs.

Core.Net 994, Runtime 1667, Launcher.Core 324, all green Release.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-15 13:10:24 +02:00
..
AllegianceRequests.cs fix(net): FA1 review round -- zero-id tree rejection, monarch clear, 0x001F builder 2026-08-12 00:46:42 +02:00
AppraiseInfoParser.cs fix #234: port retail appraisal floaty and inscriptions 2026-07-23 12:12:57 +02:00
AppraiseRequest.cs feat(items): Phase F.2 ItemRepository + AppraiseRequest round-trip 2026-04-18 16:55:36 +02:00
AttackTargetRequest.cs fix(net): Phase L.1c conform combat wire events 2026-04-28 10:54:50 +02:00
AutonomousPosition.cs feat(net): Phase B.2 — MoveToState + AutonomousPosition message builders 2026-04-12 14:28:35 +02:00
CastSpellRequest.cs feat(spells): Phase E.5 CastSpellRequest + Spellbook/enchantment state 2026-04-18 17:00:32 +02:00
CharacterActions.cs fix(net): xpSpent is a dword on the wire, and we were sending eight bytes 2026-07-29 01:59:47 +02:00
CharacterCreate.cs CC2 review fix round: latch scope narrowed, AD-100, creationFailed reason key 2026-08-15 13:10:24 +02:00
CharacterDelete.cs fix(net): Campaign LA LA7a review fixes — AD-97 register row, corrected restore justification 2026-08-14 16:01:52 +02:00
CharacterEnterWorld.cs feat(net): acdream enters the world — CharacterList parsed + CharacterEnterWorld sent + 68 CreateObject received (Phase 4.7) 2026-04-11 15:14:31 +02:00
CharacterError.cs fix(net): Campaign LA LA7a review fixes — AD-97 register row, corrected restore justification 2026-08-14 16:01:52 +02:00
CharacterList.cs fix(net): conform character entry and session shutdown 2026-07-21 10:33:03 +02:00
CharacterLogOff.cs fix(net): conform character entry and session shutdown 2026-07-21 10:33:03 +02:00
CharacterRestore.cs feat(net,runtime): Campaign CC CC2 — CharacterCreate wire, 0xF643 correlation, creation status events 2026-08-15 12:49:52 +02:00
CharGenVerificationResponse.cs CC2 review fix round: latch scope narrowed, AD-100, creationFailed reason key 2026-08-15 13:10:24 +02:00
ChatRequests.cs fix(chat): BuildTell wire field order + retail-style FormatEntry + suppress duplicate Channel echo 2026-04-25 20:49:02 +02:00
ClientCommandRequests.cs feat(chat): Campaign CH slice CH4 — command registry completion 2026-08-09 21:10:17 +02:00
ClientCommandResponses.cs fix(net,runtime): FA2 fix-round SHOULD-FIX -- fellowship mechanism parity, lookup reuse, router test, checkpoint defaults 2026-08-12 02:17:56 +02:00
CreateObject.cs refactor(net): Slice 5.0 — extract the PublicWeenieDesc body parser for shared use (behavior-preserving) 2026-08-07 14:41:09 +02:00
DddInterrogationResponse.cs feat(net): Phase 4.10 — DddInterrogationResponse + correct LoginComplete trigger 2026-04-11 23:48:37 +02:00
DeleteObject.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
EmoteText.cs perf(net): borrow inbound packet storage 2026-07-25 05:58:55 +02:00
EnchantmentWireReader.cs feat: port retail magic lifecycle and retained spell UI 2026-07-15 10:55:22 +02:00
Encodings.cs feat(net): #18 holtburger inbound chat parity - EmoteText, SoulEmote, ServerMessage, PlayerKilled, WeenieError + Windows-1252 codec 2026-04-25 19:06:01 +02:00
GameActionLoginComplete.cs fix(session): acknowledge login after first placement 2026-08-03 12:10:42 +02:00
GameEventDispatcher.cs perf(net): borrow inbound packet storage 2026-07-25 05:58:55 +02:00
GameEventEnvelope.cs perf(net): borrow inbound packet storage 2026-07-25 05:58:55 +02:00
GameEvents.cs feat: secure trade with other players - wire, RuntimeTradeState, the 2026-08-14 11:49:13 +02:00
GameEventType.cs feat(net): Phase F.1 GameEvent (0xF7B0) envelope dispatcher 2026-04-18 16:52:46 +02:00
GameMessageFragment.cs perf(net): frame recurring sends in place 2026-07-25 06:02:52 +02:00
HearSpeech.cs feat(chat): Campaign CH slice CH1 — retail LogTextType color table 2026-08-09 15:24:09 +02:00
InteractRequests.cs feat(B.5): InteractRequests.BuildPickUp — PutItemInContainer 0x0019 2026-05-14 15:01:24 +02:00
InventoryActions.cs fix #234: port retail appraisal floaty and inscriptions 2026-07-23 12:12:57 +02:00
InventoryRemoveObject.cs feat(net): D.2b-B B-Wire — InventoryRemoveObject (0x0024) parser 2026-06-21 18:52:21 +02:00
JumpAction.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
MoveToState.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
ObjDescEvent.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
ParentEvent.cs feat(combat): port retail held weapon parenting 2026-07-11 13:02:26 +02:00
PhysicsSpawnData.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
PickupEvent.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
PlayerDescriptionParser.cs feat(chat): Campaign CH slice CH3 — side-channel membership, wire, and echo parity 2026-08-09 19:39:44 +02:00
PlayerKilled.cs perf(net): borrow inbound packet storage 2026-07-25 05:58:55 +02:00
PlayPhysicsScript.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
PlayPhysicsScriptType.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
PrivateUpdatePropertyInt.cs feat(net): D.2b-B B-Wire — PrivateUpdatePropertyInt (0x02CD) parser 2026-06-21 18:50:56 +02:00
PrivateUpdatePropertyInt64.cs fix(ui): port live experience quality updates (#217) 2026-07-13 20:43:48 +02:00
PrivateUpdateVital.cs feat(player): #5 PlayerDescription parser — Stam/Mana via attribute block 2026-04-25 16:42:24 +02:00
PublicUpdatePropertyInt.cs feat(D.5.2): PublicUpdatePropertyInt (0x02CE) parser 2026-06-17 18:29:23 +02:00
PublicWeenieDescBody.cs refactor(net): Slice 5.0 — extract the PublicWeenieDesc body parser for shared use (behavior-preserving) 2026-08-07 14:41:09 +02:00
RawMotionStatePacker.cs feat(L.2b): outbound movement wire parity — RawMotionState default-difference, JumpPack, contact byte 2026-06-30 22:30:01 +02:00
ServerMessage.cs perf(net): borrow inbound packet storage 2026-07-25 05:58:55 +02:00
ServerName.cs fix(ui,net): Campaign LA gate round 2 — char-select exit confirmation, authored row justify, world name 2026-08-15 11:50:45 +02:00
SetStackSize.cs feat(net): D.2b-B B-Wire — SetStackSize (0x0197) parser 2026-06-21 18:51:42 +02:00
SetState.cs feat(phys L.2g slice 1): WorldSession dispatches SetState (0xF74B) + hex probe 2026-05-12 22:28:04 +02:00
SetTurbineChatChannels.cs feat(net+chat): #19 TurbineChat (0xF7DE) codec + ChatChannelInfo + SetTurbineChatChannels parser 2026-04-25 19:44:56 +02:00
SocialActions.cs fix(net): FA1 review round -- zero-id tree rejection, monarch clear, 0x001F builder 2026-08-12 00:46:42 +02:00
SocialStateMessages.cs feat(chat): port retail client command families 2026-07-13 14:50:15 +02:00
SoulEmote.cs perf(net): borrow inbound packet storage 2026-07-25 05:58:55 +02:00
SoundEvent.cs feat(audio): Campaign A slice A3 — the server sound channel (0xF750) 2026-08-08 22:07:23 +02:00
StringReader.cs feat(net): #18 holtburger inbound chat parity - EmoteText, SoulEmote, ServerMessage, PlayerKilled, WeenieError + Windows-1252 codec 2026-04-25 19:06:01 +02:00
TradeRequests.cs feat: secure trade with other players - wire, RuntimeTradeState, the 2026-08-14 11:49:13 +02:00
TurbineChat.cs perf(net): borrow inbound packet storage 2026-07-25 05:58:55 +02:00
UpdateMotion.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
UpdatePosition.cs feat(net): port retail physics spawn and event timestamps 2026-07-14 00:22:17 +02:00
VectorUpdate.cs fix(net): VectorUpdate parser was reading guid from opcode bytes — remote jumps invisible 2026-04-26 21:51:36 +02:00
VendorApproach.cs feat(net): Slice 5.1 — ApproachVendor (GameEvent 0x0062) inbound parser 2026-08-07 15:05:47 +02:00
VendorRequests.cs feat(vendor): Slice 6b/6c — move-to-use, buy staging, selling; the vendor arc is functionally complete 2026-08-08 11:43:11 +02:00