Erik 98de4f5ab3 fix(chat): Campaign CH round 3 — SpewBox flush-top/font, /help exact print sequence

User-gate round 3 findings (a)-(c):

(a) SpewBox: TopOffset moves from the round-1 60px placeholder to 0 (flush
to the viewport top). SpewBoxController never wired DatFont/Font at all
before this round, so it silently rendered through the 15px debug
BitmapFont fallback; it now resolves retail dat Font 0x40000025
(MaxCharHeight=11px) through a new RetailUiRuntime.Assets accessor —
the smallest font id confirmed in use by any currently-imported retail
LayoutDesc fixture, cross-referenced against every
tests/AcDream.App.Tests/UI/Layout/fixtures/*.json dump and confirmed
against the installed DAT via AcDream.Cli dump-font-atlas. It is also the
chat window's own smallest font (the 0x2100006F floating-window 1/2/3/4
indicator badges), so both selection criteria the brief offered agree.
Both remain best-available approximations, not resolved retail values —
register row AP-178 updated accordingly.

(b)/(c) /help and /help death: round 2 extracted the individual retail
strings byte-exact but never traced ClientCommunicationSystem::DoHelp's
complete print sequence. Byte-swept DoHelp's own range plus the five
Summary-branch functions it calls into (HelpEmote/HelpSquelch/
HelpStatusGroup/HelpTextGroup/HelpAllGroup) against the PDB-paired
acclient.exe. Retail's real shape: bare /help prints exactly TWO scroll
entries (HelpPrefixNote, then the 13-item AvailableHelpListing built from
DoHelp's own literals and each group's Summary_HelpType branch, in exact
source order) — not the acdream-invented cheat sheet BuildHelpText()
built before. Any resolved /help <verb> gets the SAME two-entry shape:
HelpPrefixNote, then ForMoreInformationPrefix concatenated directly onto
the verb's own Detail text (retail's own unsubstituted "<command>"
literal, ported verbatim). ChatCommandRouter.EmitVerbHelp applies this
uniformly to every resolved verb, not just death. An unresolved verb now
shows retail's real "Unknown command" fallback text; that fallback types
0x1A (ClientLocal), which retail routes to the SpewBox exclusively — a
gap ChatVM's UI.Abstractions layer can't yet reach, filed as ISSUES #367
/ register AP-186 rather than left silently unregistered.

Jump-in-air (round 2's open item 1) was root-caused and fixed separately
at a5a7eb4f between rounds — recorded in the campaign ledger.

Debug suite (all projects): 12,329 passed / 4 skipped / 1 failed — the
one failure is issue #351, a pre-existing Debug-only streaming flake
confirmed reproducing identically on the pristine pre-round-3 commit via
git stash, not a regression. Release verification covers every project
reachable without rebuilding AcDream.App: a live client process (PID
15064) held its own Release binaries locked for the session and was not
killed per project policy — AcDream.UI.Abstractions.Tests (867/867, the
layer both /help fixes live in) plus every other non-App-dependent
project, all 0 failed. AcDream.App/AcDream.App.Tests/AcDream.Core.Tests
(the SpewBox fix's layer) are green in Debug only this session.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-08-10 10:40:19 +02:00

4.7 KiB

Raw Blame History

Campaign CH — in-client user test script

One connected session against local ACE, retail GUI (ACDREAM_RETAIL_UI=1). For the color checks, running the retail client side-by-side is ideal but optional — the hex values are byte-verified; what needs eyes is "does it FEEL right".

1. On-screen interface text (CH2 — the SpewBox)

Jump, and press jump again while airborne → "You can't jump while in the air" appears as transient text flush to the very TOP of the viewport (round 3, 2026-08-10 — moved off the earlier 60px-down placeholder), NOT in the chat window. Chat gets no line at all.
Spam it 5+ times fast: the line refreshes in place (no stacking of identical text); distinct refusals stack newest-on-top, max 4 lines.
Try @version → its output goes to CHAT (green), not the SpewBox.
The SpewBox text should now read visibly SMALLER than round 2 (retail dat Font 0x40000025, 11px, replacing the earlier 15px debug font).
Report presentation impressions: position and font are now best-available approximations, not resolved retail values (register AP-178); line lifetime is still a placeholder (AP-177) — say what looks wrong vs your retail memory.

2. Chat colors (CH1)

Side-by-side vs retail if possible:

Say something → white. Emote (:waves works now) → grey.
Tell someone → your "You tell ..." line is DARK yellow (210,210,100); an incoming tell is BRIGHT yellow.
Magic self-cast lines → light blue. Combat: damage you take → salmon, damage you deal → dark red.
@version / @loc output → green (retail types command output 0x00).
Fellowship chat (if you form one) → bright yellow.

3. Side channels (CH3)

/general hi → round-trips (ACE echoes it back; blue-grey color). Same for /trade, /lfg.
Roleplay: with "Hear Roleplay Chat" OFF (the ACE default), sending to Roleplay → "You are not listening to the Roleplay channel!" and nothing is sent. Enable it in Settings → Chat → ACE reports entering the channel; sending now works. (@join roleplay / @leave roleplay also flip it, effective immediately.)
Legacy family single-print: /f hi (in a fellowship) shows ONE line, not two. Same for /v /p /m /cv if you have the allegiance structure.
/a hi without an allegiance → refusal, not a silent drop.

4. Commands (CH4)

:waves and ;waves → emote. @f, hi (trailing comma) works.
@t Two Word Name, hello → comma splits the name (needs an alt with a multi-word name to fully verify).
@g hi → goes to FELLOWSHIP (not the global General room!). Without a fellowship expect a server-side error — the important thing is it does NOT broadcast globally.
@allegiance boot Bob → "Please see @help Allegiance for more information..." locally; nothing broadcast, nothing sent.
@house abandon → TWO confirmation dialogs. Decline (unless you really want to abandon a house). Declining either stage sends nothing.
@mr → help text only. @clist general → channel list from ACE.
An unknown verb like @somenonsense → passes through to ACE (server answers, client does not swallow it).

5. Help text (round 3, 2026-08-10)

/help (no args) → TWO lines in the chat window: a "Note: You may substitute a forward slash..." line, then "Available help:" followed by 13 real retail topic one-liners (allegiances/channels/chatting/death/ emote/fillcomps/friends/house/squelch/status/text/commands). This replaced an acdream-invented cheat sheet ("Chat: /say...", "Client: /help...") — that text should no longer appear at all.
/help death → the SAME "Note:" line first, then a SECOND line starting "For more information, type @help ." immediately followed by the 8-line corpse/death command listing — not just the 8 lines alone.
/help somenonsenseverb → "Unknown command" (no "Note:" line before it; retail's fallback skips the wrapper). This still shows in the CHAT window rather than the SpewBox — a known, tracked gap (#367/AP-186), not a new bug to report.

Known-open, do not report as new

Ctrl+M mute chord (#358) — still broken, separate from this campaign.
SpewBox line lifetime is still a placeholder (AP-177) pending a retail measurement session; position/font are now best-available approximations (AP-178), not confirmed retail pixel values.
/help <verb> fallback ("Unknown command") shows in the chat window, not the SpewBox — retail types it for the SpewBox exclusively, but ChatCommandRouter has no path there yet (#367/AP-186).
Allegiance management subcommands print the help refusal instead of executing (#360); @day/@log/@render deferred (#361); four request commands send but responses aren't rendered yet (#362).

4.7 KiB Raw Blame History