acdream/tests/AcDream.Content.Tests
Erik 255b0aaeda
All checks were successful
CI / linux-portable (push) Successful in 3m18s
CI / windows-gate (push) Successful in 5m23s
CI / release (push) Successful in 2m3s
fix(magic): the foci map never loaded — casts demanded full components a focus should waive
User report: with the correct focus, scarab and tapers in the pack, a level 1
spell would not cast, and the spell examine window listed the full legacy
component recipe where retail shows only scarab and taper. The question asked
was whether the 2013 client data is too old for foci. It is not -- the EoR
dats carry the map, and the whole client-side mechanism (the requirement
service, the scarab-only formula port, the examine-window routing) was already
built and wired. It was fed an empty table.

MagicCatalog resolved the school-to-foci map with
Resolve(enumValue: 0x10000001, enumCategory: 0x28). Retail's
SpellComponentTable::SchoolOfMagic2WCID @ 0x005BC1F0 calls
DBObj::GetByEnum(0x10000001, 4): master map -> category 0x10000001 -> key 4
-> the school->WCID EnumIDMap. The 0x28 on that call is the EnumIDMap DBTYPE
tag, and it had been read as a lookup category. The master map has no
category 0x28, the resolver returned 0, and the foci map loaded EMPTY --
silently, so a carried focus was never detected: HasRequiredComponents
demanded the full account-customized formula (refusing the cast) and
GetExamineComponents displayed it.

Found by measurement rather than re-reading the code: a SpellDump --foci probe
proved category 0x28 absent, then brute-forced the portal enum tree for ACE's
FociWCIDs and found them at 0x27000003 under category 0x10000001 key 4:

    school 1 -> 15271 Foci of Strife       (War)
    school 2 -> 15270 Foci of Verdancy     (Life)
    school 3 -> 15269 Foci of Artifice     (Item)
    school 4 -> 15268 Foci of Enchantment  (Creature)
    school 5 -> 43173 Foci of Shadow       (Void)

The new Lane=InstalledDat test pins exactly that: the loaded catalog must map
every school to ACE's FociWCIDs -- external constants from the server-side
authority, deliberately not derived from the code under test, so an empty or
wrongly-resolved map cannot pass vacuously.

The infusion-augmentation half of the retail gate (properties 0x126-0x129,
0x148) was already correct against the decomp, as were the scarab-only ID set
{1..6, 0x6E, 0x6F, 0x70, 0xC0, 0xC1} and the taper-count table.

Complete Release suite: 14,469 tests pass on the standard hermetic lane
filter, 0 failures; the new installed-DAT test passes against the real dats.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-20 21:28:22 +02:00
..
CharGen test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
Spells test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
Vfx test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
AcDream.Content.Tests.csproj build: make release restore reproducible 2026-08-18 10:29:00 +02:00
BoundedDatObjectCacheTests.cs perf(diag): per-frame history export + checkpoint LOH/cache counters + soak capped mode (2026-07-24 audit review) 2026-07-24 12:00:30 +02:00
ContentConformanceDats.cs test(pipeline): MP1b - live-vs-pak equivalence suite (dat-gated) 2026-07-05 21:33:32 +02:00
Crc32Tests.cs fix(pipeline): MP1b review - pak format/reader hardening 2026-07-05 22:08:59 +02:00
DatResolutionPrecedenceTests.cs perf(content): remove exception-driven setup probes 2026-07-24 15:12:21 +02:00
DecodedTextureCacheTests.cs perf(diag): per-frame history export + checkpoint LOH/cache counters + soak capped mode (2026-07-24 audit review) 2026-07-24 12:00:30 +02:00
FlatCollisionAssetSerializerTests.cs feat(content): bake and read flat collision assets 2026-07-25 15:22:08 +02:00
InstalledMagicCatalogFociTests.cs fix(magic): the foci map never loaded — casts demanded full components a focus should waive 2026-08-20 21:28:22 +02:00
InstalledPreparedCollisionCatalogTests.cs test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
InstalledSetupBspPrimitiveDispatchTests.cs test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
InstalledSetupCollisionReachabilityTests.cs test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
Issue334NeftetFormationCellMembershipTests.cs test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
LandblockPhysicsContentBuilderStaticSphereTests.cs fix(physics): S2 — static publication emits authored Spheres as Spheres (AP-155 narrowed) 2026-08-07 08:07:02 +02:00
ObjectMeshDataEquality.cs perf(render): consume prepared mesh package at runtime 2026-07-24 15:07:25 +02:00
ObjectMeshDataSerializerTests.cs perf(render): consume prepared mesh package at runtime 2026-07-24 15:07:25 +02:00
packages.neutral.lock.json build: make release restore reproducible 2026-08-18 10:29:00 +02:00
PakAliasTests.cs feat(content): add physical blob aliases to pak writer 2026-07-24 13:33:53 +02:00
PakEquivalenceTests.cs test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
PakFormatTests.cs feat(pipeline): MP1b - pak key + header/TOC primitives 2026-07-05 21:14:10 +02:00
PakKeyTests.cs feat(content): bake and read flat collision assets 2026-07-25 15:22:08 +02:00
PakRoundTripTests.cs feat(bake): publish validated pak artifacts atomically 2026-07-24 13:40:58 +02:00
PreparedAssetSourceTests.cs perf(content): add typed prepared asset source 2026-07-24 14:52:12 +02:00
SharedPreparedCollisionCacheTests.cs feat(headless): share immutable gameplay content 2026-07-27 09:00:48 +02:00
SolidColorTextureCacheTests.cs test: make prerequisite lanes fail honestly 2026-08-18 12:09:41 +02:00
StaticSpherePopulationMeasurementTests.cs test: replace campaign labels with behavior names 2026-08-18 12:25:00 +02:00