d73125d3b0
Some checks are pending
Headless portability / portable-headless (ubuntu-latest) (push) Waiting to run
Headless portability / portable-headless (windows-latest) (push) Waiting to run
Headless portability / linux-graphical (push) Waiting to run
Headless portability / linux-vulkan (push) Waiting to run
Campaign S slice S4, the half that landed. Retail's CTransition:: adjust_offset @0x0050a370 branches on dot(offset, contactPlane.N) at 0x0050a4fa: moving INTO the plane subtracts the normal component (0x0050a529), moving AWAY calls Plane::snap_to_plane @0x00509c50 — which preserves X and Y and re-solves ONLY Z so the offset lies in the plane (the d terms cancel algebraically), no-op under the 0.000199999995f |N.z| epsilon. acdream ran the orthogonal projection in BOTH directions, shrinking downhill XY travel by cos^2(theta): 25% at 30 degrees, 50% at 45 — AD-65's recorded shortfall, now retired. The combined Opus review independently re-derived the algebra, the branch polarity, the epsilon's bit-identity (17b75139), and the sabotage magnitude (the re-instated projection yields X = 0.75 = cos^2 30 exactly), and verified the delta is 4 non-comment lines with the into-plane arm, the crease arm, and both no-plane arms untouched. Its blast-radius sweep found the away arm exercised but NOT discriminated by any pre-existing test — every one asserts lower bounds the snap over-satisfies — so the two new exact-value tests are the only discriminating coverage, recorded in the test's class doc, and the felt 33-100% downhill speed-up is the morning gate's one row. AD-66 (the push-out's bare radius) is WITHHELD: byte-confirmed twice, implemented, then pulled after the same clean-room binaries measured contradictory absorbed-tick outcomes flipping with nothing but test assert shape — issue #341 carries the observation matrix and the apparatus plan; its two exact-value tests are [Skip]-ed; the retained substitution's rationale is restored at the site per review F1, with the review's remaining findings (F2/F3/F4/F5/F6) applied and F8 filed as #342. AD-69 filed: the same block omits retail's get_block_offset seam-frame correction, deferred to the AD-66 relanding for attributability. #340 filed: a fifth load-sensitive flake. Review verdict: PASS. AD-65 is provably unable to reach the #341 anomaly's code path (the absorb scenario takes the crease arm). Clean-room suite: 11,239 passed / 6 skipped / 0 failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
116 lines
6 KiB
Markdown
116 lines
6 KiB
Markdown
# S4 contract (Campaign S) — AdjustOffset's two substitutions: AD-65 + AD-66
|
||
|
||
**Date:** 2026-08-07 (overnight). **Scoped by:** the session lead.
|
||
**Implementer:** one Sonnet agent. **Review:** dual Opus. **This is FEEL
|
||
work** — the morning slope-feel gate covers it; nothing here can be
|
||
visually accepted overnight.
|
||
|
||
Both rows live in `Transition.AdjustOffset`
|
||
(`src/AcDream.Core/Physics/TransitionTypes.cs`), retail
|
||
`CTransition::adjust_offset` @0x0050a370. One function, one slice.
|
||
|
||
## AD-65 — the away-from-plane arm must SNAP, not project
|
||
|
||
**Retail, pinned at scoping (pseudo-C 272300–272340 + 271852):** in the
|
||
non-sliding path (`sliding_normal` not set), retail computes
|
||
`arg3 = dot(offset, contact_plane.N)` and branches on it @0x0050a4fa with
|
||
`test ah,0x41`:
|
||
|
||
- `arg3 <= 0` (moving INTO the plane): `offset -= N * arg3` — the
|
||
component subtraction (block @0x0050a529).
|
||
- `arg3 > 0` (moving AWAY): `Plane::snap_to_plane(&contact_plane, &offset)`
|
||
@0x0050a50e. Semantics @0x00509c50, verbatim: if `|N.z| <= 0.000199999995f`
|
||
do NOTHING; else `offset.z = -(offset.x*N.x + offset.y*N.y) / N.z`
|
||
(the `d` terms cancel algebraically — show this in your pseudocode doc).
|
||
**XY is PRESERVED; only Z is re-solved so the offset lies in the plane.**
|
||
|
||
acdream's `else` arm (the one whose comment already names snap_to_plane
|
||
without calling it) does `result -= N * collisionAngle` in BOTH directions —
|
||
an orthogonal projection that shrinks XY by the cos²θ factor AD-65 recorded
|
||
(25% at 30°, 50% at 45°). Port the branch exactly: subtraction arm for
|
||
`<= 0`, snap for `> 0`, including the |N.z| epsilon no-op.
|
||
|
||
**Watch item carried from #32 (read before coding):** the #32 fix narrowed
|
||
last-known-contact-plane validity, and `AdjustOffset` consumers sit in its
|
||
blast radius (research doc §3.5). Your tests must cover the case where the
|
||
contact plane is the ONLY valid plane and where none is valid.
|
||
|
||
## AD-66 — the safety push-out uses the BARE radius
|
||
|
||
Byte evidence already in the register row (do not re-derive, but DO read the
|
||
row): retail loads the bare `global_sphere->radius` for BOTH the trigger
|
||
comparison (`0050a5c4 fld [ecx+0xc]`, then subtracts F_EPSILON) and the
|
||
`zDist` numerator (`0050a5dc fsubr [ecx+0xc]`), dividing by
|
||
`contact_plane.N.z` (`0050a5df fdiv [esi+8]`). Neither site multiplies by
|
||
N.z. acdream substitutes `naturalRestingDist = radius * ContactPlane.Normal.Z`
|
||
in both places, with a long code comment arguing the sphere-origin geometry.
|
||
|
||
**The comment's argument may be geometrically sincere, but the register's
|
||
posture is decided: retail-faithful first.** Port the bare radius in both
|
||
sites. THEN — because the original substitution was empirically motivated
|
||
("the uncorrected threshold broke ValidateWalkable's contact check on steep
|
||
slopes and flickered the Falling animation while running uphill") — your
|
||
test set MUST include the scenario the old comment claims regresses: a mover
|
||
running uphill on a steep-but-walkable slope, asserting no contact-flap
|
||
across ticks. If that test genuinely reds with the faithful port, STOP —
|
||
do not tune, do not blend. Report the failing scenario in full; the session
|
||
lead decides (that outcome would mean the register row's risk column was
|
||
right and the divergence may be re-filed as deliberate rather than fixed).
|
||
|
||
## Deliverables
|
||
|
||
1. Pseudocode doc first (`docs/research/2026-08-07-s4-pseudocode.md`) for
|
||
`adjust_offset`'s full branch tree — including the sliding-normal arm
|
||
@0x0050a42a (cross products + normalize_check_small) which you must VERIFY
|
||
against our existing port and report on, but not change unless it
|
||
diverges.
|
||
2. The two fixes above, minimal diff, comments carrying the addresses.
|
||
3. Conformance tests: exact-value tests for snap (XY preserved, Z re-solved,
|
||
epsilon no-op), for the into-plane subtraction, for bare-radius trigger +
|
||
numerator; the uphill no-flap scenario; sabotage-verify the snap test by
|
||
re-instating the projection and watching it redden.
|
||
4. Full suite `dotnet test AcDream.slnx -c Release -m:1` green, totals
|
||
reported; nothing committed.
|
||
|
||
## Scope — OUT
|
||
|
||
Registers/ISSUES (session lead). `calc_friction` (S5, separate). Anything
|
||
outside `AdjustOffset` and its tests.
|
||
|
||
## Process
|
||
|
||
Only `C:\Users\erikn\source\repos\acdream`, absolute paths, no subagents.
|
||
Contradictions between this contract and the source: STOP and report.
|
||
|
||
---
|
||
|
||
# OUTCOME (appended 2026-08-07, end of the overnight session)
|
||
|
||
**AD-65: LANDED.** The away-from-plane arm performs retail's snap_to_plane
|
||
verbatim; conformance exact-value tests sabotage-verified (the re-instated
|
||
projection reproduces the recorded cos²30° = 0.75 shrinkage exactly); the
|
||
named uphill no-flap STOP scenario passed; register row retired.
|
||
|
||
**AD-66: WITHHELD — issue #341.** The bare-radius port was implemented and
|
||
then pulled, not because the bytes were doubted (they are now DOUBLE
|
||
byte-confirmed) but because its interaction with the #331 absorb
|
||
characterization pin produced a measurement that contradicted itself: the
|
||
same clean-room binaries measured both a one-time resting lift and an exact
|
||
latch on the absorbed-tick scenario, flipping with nothing but the shape of
|
||
the test's post-tick asserts. Three contradictory reads is the
|
||
apparatus-not-a-fourth-guess threshold; #341 carries the observation matrix
|
||
and the instrumentation plan. The production site carries a comment block;
|
||
the two exact-value tests are [Skip]-ed pointing at #341.
|
||
|
||
**Third finding from the pseudocode pass: AD-69 filed** — the push-out's
|
||
`dist` omits retail's `get_block_offset` cell-relative correction, wrong
|
||
exactly at landblock seams. Deliberately not folded into tonight's landing;
|
||
fix alongside the AD-66 relanding so the anomaly investigation stays
|
||
attributable.
|
||
|
||
**Process note for the record:** tonight's session hit the stale-artifact
|
||
plague again mid-recalibration and burned roughly an hour on contradictory
|
||
evidence before applying its own clean-room rule; and the recalibration was
|
||
attempted twice on empirics before the withhold decision. The
|
||
morning-after reading of #341 should start from the observation matrix, not
|
||
from this contract.
|