acdream

erik/acdream

Fork 0

Commit graph

Author	SHA1	Message	Date
Erik	48ce52c6ed	docs(B.4b): final-review polish — file #59 #60 follow-ups + handoff correction Final whole-branch code review (Opus) surfaced two Important post-merge follow-ups + a one-word inaccuracy in the handoff doc: - #59: tighten WorldPicker per-entity Setup.Radius (M1-deferred; the ServerGuid==0 invariant is load-bearing and worth documenting before L.2d's CBuildingObj port lands). - #60: port retail's obstruction_ethereal downstream path so combat-HUD contact reporting works for ethereal creatures (M2-combat). - handoff: corrected "Added a _entitiesByServerGuid reverse-lookup" to "Used the pre-existing _entitiesByServerGuid" — the dict has existed since Phase 6.6/6.7; slice 1c used it, didn't add it. Review verdict: branch ready to merge to main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 19:43:38 +02:00
Erik	2c9bdb512b	docs(B.4b): ship handoff + close #57 + file #58 + roadmap/CLAUDE update Phase B.4b shipped end-to-end 2026-05-13. Holtburg inn doorway double-click verified: pick -> BuildUse -> ACE SetState reply -> ID-translated registry update -> CollisionExemption exempts -> player walks through. M1 demo target "open the inn door" met. 9 commits on this branch: - Tasks 1-4 per plan (BuildRay, Pick, rename, handler wiring) - 4 bonus visual-test discoveries: * InputDispatcher double-click detection (was dead code) * DoubleClick activation gate fix in OnInputAction * L.2g slice 1b: CollisionExemption widened to ETHEREAL alone * L.2g slice 1c: ServerGuid -> entity.Id translation (silent blocker) Closes #57. Files #58 for door swing animation (UpdateMotion routing for non-creature entities, M1 deferred polish). Updates roadmap and CLAUDE.md Phase L.2 paragraph. Memory file project_interaction_pipeline.md updated outside the repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-13 19:33:27 +02:00

Author

SHA1

Message

Date

Erik

48ce52c6ed

docs(B.4b): final-review polish — file #59 #60 follow-ups + handoff correction

Final whole-branch code review (Opus) surfaced two Important post-merge
follow-ups + a one-word inaccuracy in the handoff doc:

- #59: tighten WorldPicker per-entity Setup.Radius (M1-deferred; the
  ServerGuid==0 invariant is load-bearing and worth documenting before
  L.2d's CBuildingObj port lands).
- #60: port retail's obstruction_ethereal downstream path so combat-HUD
  contact reporting works for ethereal creatures (M2-combat).
- handoff: corrected "Added a _entitiesByServerGuid reverse-lookup" to
  "Used the pre-existing _entitiesByServerGuid" — the dict has existed
  since Phase 6.6/6.7; slice 1c used it, didn't add it.

Review verdict: branch ready to merge to main.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-13 19:43:38 +02:00

Erik

2c9bdb512b

docs(B.4b): ship handoff + close #57 + file #58 + roadmap/CLAUDE update

Phase B.4b shipped end-to-end 2026-05-13. Holtburg inn doorway
double-click verified: pick -> BuildUse -> ACE SetState reply ->
ID-translated registry update -> CollisionExemption exempts ->
player walks through. M1 demo target "open the inn door" met.

9 commits on this branch:
- Tasks 1-4 per plan (BuildRay, Pick, rename, handler wiring)
- 4 bonus visual-test discoveries:
  * InputDispatcher double-click detection (was dead code)
  * DoubleClick activation gate fix in OnInputAction
  * L.2g slice 1b: CollisionExemption widened to ETHEREAL alone
  * L.2g slice 1c: ServerGuid -> entity.Id translation (silent blocker)

Closes #57. Files #58 for door swing animation (UpdateMotion routing
for non-creature entities, M1 deferred polish). Updates roadmap and
CLAUDE.md Phase L.2 paragraph. Memory file project_interaction_pipeline.md
updated outside the repo.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-13 19:33:27 +02:00

2 commits