acdream

erik/acdream

Fork 0

Commit graph

Author	SHA1	Message	Date
Erik	745a92bbae	feat(core): D.5.3/B.2 — ShortcutStore + AddShortcut/RemoveShortcut wire + senders ShortcutStore lands in AcDream.Core.Net.Items (not AcDream.Core.Items) because it depends on PlayerDescriptionParser.ShortcutEntry; placing it in AcDream.Core would create a circular dependency (Core.Net already references Core). The test lives in AcDream.Core.Tests which gets Core.Net transitively via App. BuildAddShortcut signature corrected from the old (seq, slotIndex, objectType, targetId) 4×u32 layout to the retail ShortCutData wire format confirmed in the action-bar deep-dive: Index(u32), ObjectId(u32), SpellId(u16), Layer(u16). The old BuildAddShortcut_ThreeFields test is replaced by two new tests that verify both item and spell shortcut packing. WorldSession gains SendAddShortcut / SendRemoveShortcut following the SendChangeCombatMode sender pattern. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-20 15:09:58 +02:00
Erik	d8c68c6648	feat(net): InventoryActions — stack merge/split + give + shortcut + poi recall Outbound GameActions for the inventory/drag-drop UI and quickbar: - StackableMerge (0x0054): u32 mergeFrom, u32 mergeTo, u32 amount. Combine two same-type stacks. - StackableSplitToContainer (0x0055): u32 stack, u32 container, u32 placement, u32 amount. Drag a portion of a stack into a pack slot. - StackableSplitTo3D (0x0056): u32 stack, u32 amount. Drop N items to the ground. - StackableSplitToWield (0x019B): u32 stack, u32 equipLoc, u32 amount. Split off and immediately equip (e.g. split an arrow stack to missile-ammo slot). - GiveObjectRequest (0x00CD): u32 target, u32 item, u32 amount. Give to NPC / other player. - AddShortcut (0x019C): u32 slot, u32 objectType, u32 targetId. Pin an item / spell to a quickbar. - RemoveShortcut (0x019D): u32 slot. Unpin. - TeleToPoi (0x00B1): u32 poiId. Quest-driven recall. Tests (8 new): byte-exact encoding of each action, including size assertions so breaking changes surface immediately. Build green, 190 Core.Net tests pass (up from 182). Ref: r08 §3 inventory / shortcut rows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-19 10:28:35 +02:00

Author

SHA1

Message

Date

Erik

745a92bbae

feat(core): D.5.3/B.2 — ShortcutStore + AddShortcut/RemoveShortcut wire + senders

ShortcutStore lands in AcDream.Core.Net.Items (not AcDream.Core.Items) because
it depends on PlayerDescriptionParser.ShortcutEntry; placing it in AcDream.Core
would create a circular dependency (Core.Net already references Core). The test
lives in AcDream.Core.Tests which gets Core.Net transitively via App.

BuildAddShortcut signature corrected from the old (seq, slotIndex, objectType,
targetId) 4×u32 layout to the retail ShortCutData wire format confirmed in the
action-bar deep-dive: Index(u32), ObjectId(u32), SpellId(u16), Layer(u16).
The old BuildAddShortcut_ThreeFields test is replaced by two new tests that
verify both item and spell shortcut packing.

WorldSession gains SendAddShortcut / SendRemoveShortcut following the
SendChangeCombatMode sender pattern.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-20 15:09:58 +02:00

Erik

d8c68c6648

feat(net): InventoryActions — stack merge/split + give + shortcut + poi recall

Outbound GameActions for the inventory/drag-drop UI and quickbar:

- StackableMerge (0x0054): u32 mergeFrom, u32 mergeTo, u32 amount.
  Combine two same-type stacks.
- StackableSplitToContainer (0x0055): u32 stack, u32 container,
  u32 placement, u32 amount. Drag a portion of a stack into a pack slot.
- StackableSplitTo3D (0x0056): u32 stack, u32 amount. Drop N items to
  the ground.
- StackableSplitToWield (0x019B): u32 stack, u32 equipLoc, u32 amount.
  Split off and immediately equip (e.g. split an arrow stack to
  missile-ammo slot).
- GiveObjectRequest (0x00CD): u32 target, u32 item, u32 amount. Give to
  NPC / other player.
- AddShortcut (0x019C): u32 slot, u32 objectType, u32 targetId.
  Pin an item / spell to a quickbar.
- RemoveShortcut (0x019D): u32 slot. Unpin.
- TeleToPoi (0x00B1): u32 poiId. Quest-driven recall.

Tests (8 new): byte-exact encoding of each action, including size
assertions so breaking changes surface immediately.

Build green, 190 Core.Net tests pass (up from 182).

Ref: r08 §3 inventory / shortcut rows.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-19 10:28:35 +02:00

2 commits