3 commits

Author	SHA1	Message	Date
Erik	e71e5a9614	feat(ui): Campaign OP slice OP5 — the Chat tab ... Binds LayoutDesc 0x2100005C through OP2's template-list mechanism and OP3's per-page OptionPage model: the General Options header + two DualHash-linked opacity sliders (Option_DefaultOpacity_Property 0x10000080 / Option_ActiveOpacity_Property 0x10000081, live-apply on drag through RetailWindowOpacityController, defaults read from the installed DAT's DBProperties collection at DID 0x78000001 via ChatOptionsDatDefaults), and the five per-window text-filter blocks (main window 12 rows minus Gameplay, four floaties 13 rows each — the byte-verified authored order cross-checked against the raw gmChatOptionsUI::InitOptions/AddCheckboxBitfield64Option pseudo-C, not just the research doc's own table) writing AcDream.Core.Chat. ChatWindowState directly, the same state CH6's chat windows already read. AP-195 retired: ported both halves left open at the OP2 re-review — the ALL-set LED media swap (new UiButton.FaceFileOverride, driven by the block-level P0x10000082/P0x10000083 sprites now threaded through ElementInfo/DatWidgetFactory) and the CreateChildren self-sizing tail (UiCheckboxBitfield64.Height grows with its stacked row content; the enclosing ListBox reflows around the block's FINAL height via the new UiTemplateListBox.AddPrebuiltRow, reusing the ListBox's own stacking rather than a third stacking path). AP-187 broadened to cover the main window's own filter (previously only the four floaties) and the new live-editing write path. The main chat window's filter (retail window id 8, ChatWindowState id 0) gains its own settings.json persistence (ChatSettings. ChatWindowMainFilter) alongside the pre-existing floaty 1-4 fields; opacity persistence is now wired on every live slider change, not only through the old dev-scaffold Settings panel. Fixture regeneration (ACDREAM_REGENERATE_UI_FIXTURES=1) picked up the new ElementInfo.LedCheckedSprite/LedUncheckedSprite fields across all 19 committed layout fixtures — purely additive, confirmed against the live installed DAT (0x10000520's own 0x82/0x83 properties resolve to 0x06004D17/0x06004D19 exactly as AP-195 documented). Conformance: FilterRows/FilterBlocks pinned against the byte-verified authored order and ChatWindowState's own default constants; the AP-195 LED swap and self-sizing behavior; the DAT opacity-default extraction against the live installed DAT; live filter/opacity writes reaching ChatWindowState/RetailWindowOpacityController; OnShown re-seed and Reset/Defaults ghosting per the OP4 binding-pattern discipline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 06:25:59 +02:00
Erik	b236a44279	fix(ui): OP2 rework — dormant UiDatElement subclasses, fixed Panel/CheckboxBitfield64 mechanism ... OP2 (df9c7a35) was double-REJECTed: an unconditional Type-8/Type-5 factory mapping silently re-classed 15 elements across 7 shipped panels (vendor backdrop lost its fill, character/spellbook roots stopped passing clicks through, combat gained a phantom import-time tab takeover, ten ListBoxes gained a spurious hit-testable viewport) because the stale 27 pre-existing fixtures never exercised the new fields — and the mechanism itself cited a nonexistent "UIElement_TabControl" class, inverted UiCheckboxBitfield64's checked-state predicate, and synthesized fake per-row geometry instead of using the widget's own authored template. Shape change: UiTabPanel (renamed from UiTabControl) and UiTemplateListBox now derive from UiDatElement (unsealed) and stay DORMANT by default — an imported Type-8/Type-5 element gets authored-media drawing, ClickThrough generic-decoration default, and IUiDatStateful propagation identical to the pre-OP2 UiDatElement fallback, with zero import-time side effects. The factory's Type-8/Type-5 arms are unconditional again (no more guard whose premise the blast-radius sweep proved false), because dormancy makes an unactivated instance behaviorally indistinguishable from the old fallback. UiTabPanel.ActivateTabBehavior() and UiTemplateListBox's lazy viewport creation are the explicit, controller-driven opt-ins Campaign OP slice OP3+ will call; today nothing does, so the four pre-existing shipped Type-8 hosts (character/spellbook/vendor/combat) and ten pre-existing Type-5 ListBoxes keep their pre-OP2 behavior exactly. Filed AD-73 for this dormant-vs-retail's-unconditional-activation adaptation. Mechanism fixes (docs/research/2026-08-11-op2-review-mechanism.md): - UiTabPanel cites UIElement_Panel (Type 8 is UIElement_Panel; no UIElement_TabControl exists in the PDB), resolves buttons/pages via a GetChildRecursive-equivalent descendant search (not direct-children-only), performs no switch when no entry authors 0x32 (deleted the _tabs[0] fallback), and surfaces unresolved tab-table entries via UnresolvedEntries + a diagnostic line instead of a silent no-op. - ElementReader.ReadTabTable skips entries missing 0x30/0x31, matching retail's SetupTabPageHash @0x0046C2E0 entry filter. - UiCheckboxBitfield64 now builds every row from its OWN authored template (property 0x64 -> {0x2100002B, 0x10000521}) via AddItemFromTemplateList, deleting the synthesized ElementInfo + invented RowHeight=14 — matching retail's CreateChildren @0x00485DF0, which is itself a UIElement_ListBox call. IsSet is now retail's ANY-bit-set predicate (Refresh @0x004859C0), not all-bits-set. TS-72 retired: the click-toggle bit math is now fully decomp-confirmed (SetBitsOnOrOff via ListenToElementMessage @0x00485AE0). Regenerated all 32 UI fixtures against real DAT (ACDREAM_REGENERATE_UI_FIXTURES=1) and committed them — 27 pre-existing fixtures now carry Outline/OutlineColor/ TabTable/TemplateList/ScrollbarElementId; the 5 Options fixtures were already current. Updated EffectsUiControllerTests' now-correct UiTemplateListBox class-identity assertion. Added: 6 built-widget behavior pins for all five pre-existing Type-8 elements + a representative Type-5 element the dormancy model protects (OP2ReworkBlastRadiusConformanceTests.cs); 5 reader-level tests driving ReadTabTable/ReadTemplateList/the 0x72 reader from raw property bags (ElementReaderTests.cs); a multi-bit-mask UiCheckboxBitfield64 test proving the any-bit predicate (the prior single-bit test couldn't distinguish it from all-bits); an activation-idempotency test and a before-activation click-is-inert test for UiTabPanel. Full Release suite: 12,868 passed / 4 skipped / 0 failed (baseline 12,853/4/0 post-OP1-fixes; +15 net new tests, zero regressions). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-11 01:08:08 +02:00
Erik	c721830e71	feat(ui): Slice 5.4 — the authored vendor browse panel (LayoutDesc 0x21000012) ... The vendor window is retail's own: LayoutDesc 0x21000012, root 0x100000B7, found by enumerating all 101 layouts for the one containing both known tab controls and clinched by the root's Type 0x10000017 — the literal UIElement::RegisterElementClass id for gmVendorUI (pc:202075). Discovery evidence and the D0 read live in the research doc's new §B.4. D0 corrected two assumptions: retail's category "tabs" are a UiMenu DROPDOWN fed by a hardcoded 18-row ordered category table (ported bit-for-bit against our ItemType enum; list always scoped to exactly one category, first-present wins, selection preserved across refresh per retail's clamp), and the layout authors THREE tabs — Items (browse, this slice), Buying and Selling (staged-transaction review, Slice 6) — decision 4's "browse/Buy tab" names the Items tab retail's mode-2 OpenTab opens. The non-default tabs render and switch pages but stay inert, fenced in comments. VendorUiController mounts Items: category dropdown, icon-cell item row with the retained scrollbar, per-unit retail pricing via VendorPricing.SellPrice (the vendor-stock path VendorProfile:: VendorSellPrice feeds), name/cost on selection. The panel is a pure projection of VendorState — opens on populate, closes on clear; the close button's VendorState.Close() is its only permitted mutation. Nothing on the wire. AP-110 narrowed (vendor leaves the absent-panels list); AP-161 files the precise Slice-6 remainder (Buying/Selling unwired, Buy/Add buttons, InqAcceptability). Twelve controller tests on a real-dat fixture. Clean-room complete solution: 11,323 passed / 4 skipped / 0 failed. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-08-07 17:00:21 +02:00