erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions

docs(AS): AS2 REVIEW-CLOSED in the ledger; paperdoll-bullet phrasing polish

Browse source 
Re-review of cc5290af accepted all six findings; the retail port is exact.
The paperdoll ruling bullet now reads cleanly (the retail-colors clause was
dangling off the decomp citation) and points at AD-114. The three remaining
Core-side PK-bit copies are flagged as a follow-up chip outside AS scope.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-25 09:05:08 +02:00
parent cc5290af7d
commit bde5cae031
1 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

26
docs/plans/2026-08-25-assess-window-parity-campaign.md
View file

@ -23,17 +23,19 @@ Missing vs retail:
Explicit owner rulings: Explicit owner rulings:
- **The animated 3D paperdoll is an INTENTIONAL acdream deviation.** Retail's - **The animated 3D paperdoll is an INTENTIONAL acdream deviation**
examine preview clone is NOT a static tinted preview — it is (register row AD-114, filed at AS2). Retail's examine preview clone is
INDEPENDENTLY ANIMATED, just decoupled from the live target: NOT a static tinted preview — it is INDEPENDENTLY ANIMATED, just
`BasicCreatureExamineUI::Init @0x004AB9C0` clones the selected object via decoupled from the live target: `BasicCreatureExamineUI::Init
`CPhysicsObj::makeObject @0x005144B0` (which runs `MorphToExistingObject` @0x004AB9C0` clones the selected object via `CPhysicsObj::makeObject
then `play_script_internal(setup->default_script_id)`), sets the clone's @0x005144B0` (which runs `MorphToExistingObject` then
`play_script_internal(setup->default_script_id)`), sets the clone's
heading to 191.367905°, and `CreatureMode::Render @0x004529D0` runs heading to 191.367905°, and `CreatureMode::Render @0x004529D0` runs
`update_position` on it every frame — its colors are buggy in retail. `update_position` on it every frame. acdream's deviation is that our
acdream's deviation is that our preview mirrors the target's LIVE motion preview mirrors the target's LIVE motion instead of playing its own
instead of playing its own private, decoupled cycle. Keep ours. Register private, decoupled cycle. Keep ours. (Retail's preview colors are also
row required (added in the first slice that touches the window). buggy on the owner's reference setup, so porting the decoupled clone
would not even be a faithfulness win.)
- Retail comparison is the oracle for text composition; all strings come - Retail comparison is the oracle for text composition; all strings come
from DAT StringTables per the decomp — **never hardcoded English from DAT StringTables per the decomp — **never hardcoded English
literals**. literals**.
@ -135,8 +137,8 @@ round → narrow re-review → REVIEW-CLOSED.
| Slice | State | Land / fix commits | Notes | | Slice | State | Land / fix commits | Notes |
|---|---|---|---| |---|---|---|---|
| AS1 | **DONE 2026-08-25** | (docs commit) | 3-agent research; ground-truth doc committed | | AS1 | **DONE 2026-08-25** | (docs commit) | 3-agent research; ground-truth doc committed |
| AS2 | review fix round | `f8a22589` | fix round (this commit) | | AS2 | **REVIEW-CLOSED 2026-08-25** | `f8a22589` / `cc5290af` | port exact per dual-lens review; 6 findings (docs/test/refactor) fixed; +AD-114 (animated paperdoll), +AD-115 (title clear-vs-stale), PK bits promoted to `PublicWeenieFlags`; carried follow-up chip: 3 more Core PK-bit copies |
| AS3 | pending AS2 review-close | — | | | AS3 | dispatched 2026-08-25 | — | |
| AS4 | pending AS3 review-close | — | | | AS4 | pending AS3 review-close | — | |
| AS5 | pending AS4 review-close | — | | | AS5 | pending AS4 review-close | — | |
| AS6 | pending AS5 review-close | — | | | AS6 | pending AS5 review-close | — | |