From bde5cae03181cad5c49bd42f8c8370058576b832 Mon Sep 17 00:00:00 2001 From: Erik Date: Tue, 25 Aug 2026 09:05:08 +0200 Subject: [PATCH] docs(AS): AS2 REVIEW-CLOSED in the ledger; paperdoll-bullet phrasing polish Re-review of cc5290af accepted all six findings; the retail port is exact. The paperdoll ruling bullet now reads cleanly (the retail-colors clause was dangling off the decomp citation) and points at AD-114. The three remaining Core-side PK-bit copies are flagged as a follow-up chip outside AS scope. Co-Authored-By: Claude Fable 5 --- ...026-08-25-assess-window-parity-campaign.md | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/docs/plans/2026-08-25-assess-window-parity-campaign.md b/docs/plans/2026-08-25-assess-window-parity-campaign.md index 98747359..88985783 100644 --- a/docs/plans/2026-08-25-assess-window-parity-campaign.md +++ b/docs/plans/2026-08-25-assess-window-parity-campaign.md @@ -23,17 +23,19 @@ Missing vs retail: Explicit owner rulings: -- **The animated 3D paperdoll is an INTENTIONAL acdream deviation.** Retail's - examine preview clone is NOT a static tinted preview — it is - INDEPENDENTLY ANIMATED, just decoupled from the live target: - `BasicCreatureExamineUI::Init @0x004AB9C0` clones the selected object via - `CPhysicsObj::makeObject @0x005144B0` (which runs `MorphToExistingObject` - then `play_script_internal(setup->default_script_id)`), sets the clone's +- **The animated 3D paperdoll is an INTENTIONAL acdream deviation** + (register row AD-114, filed at AS2). Retail's examine preview clone is + NOT a static tinted preview — it is INDEPENDENTLY ANIMATED, just + decoupled from the live target: `BasicCreatureExamineUI::Init + @0x004AB9C0` clones the selected object via `CPhysicsObj::makeObject + @0x005144B0` (which runs `MorphToExistingObject` then + `play_script_internal(setup->default_script_id)`), sets the clone's heading to 191.367905°, and `CreatureMode::Render @0x004529D0` runs - `update_position` on it every frame — its colors are buggy in retail. - acdream's deviation is that our preview mirrors the target's LIVE motion - instead of playing its own private, decoupled cycle. Keep ours. Register - row required (added in the first slice that touches the window). + `update_position` on it every frame. acdream's deviation is that our + preview mirrors the target's LIVE motion instead of playing its own + private, decoupled cycle. Keep ours. (Retail's preview colors are also + buggy on the owner's reference setup, so porting the decoupled clone + would not even be a faithfulness win.) - Retail comparison is the oracle for text composition; all strings come from DAT StringTables per the decomp — **never hardcoded English literals**. @@ -135,8 +137,8 @@ round → narrow re-review → REVIEW-CLOSED. | Slice | State | Land / fix commits | Notes | |---|---|---|---| | AS1 | **DONE 2026-08-25** | (docs commit) | 3-agent research; ground-truth doc committed | -| AS2 | review fix round | `f8a22589` | fix round (this commit) | -| AS3 | pending AS2 review-close | — | | +| AS2 | **REVIEW-CLOSED 2026-08-25** | `f8a22589` / `cc5290af` | port exact per dual-lens review; 6 findings (docs/test/refactor) fixed; +AD-114 (animated paperdoll), +AD-115 (title clear-vs-stale), PK bits promoted to `PublicWeenieFlags`; carried follow-up chip: 3 more Core PK-bit copies | +| AS3 | dispatched 2026-08-25 | — | | | AS4 | pending AS3 review-close | — | | | AS5 | pending AS4 review-close | — | | | AS6 | pending AS5 review-close | — | |