feat(runtime): C3c - production placement cutover: both hosts on the residence conductors (routes 1+8)
Campaign P remaining-physics-divergence, placement cutover slice C3c
(docs/plans/2026-08-02-placement-cutover.md). Both production hosts now
register every initial Create through the residence + continuation-
executor + first-entry-conductor machinery (C0-C3b):
- Graphical (route 1): RegisterEntityWithInitialResidence at Create; the
shared RuntimeFirstEntryDriveController pumps both conductors from the
placement-receipt flow; MaterializeProjection and RebucketLiveEntity
are presentation-only while a residence is ACTIVE (ExecutorCompleted is
the presentation-binding receipt); post-residence entities take the
full legacy path including the prepare_to_enter_world clock edges.
PlayerModeController attaches presentation to the Runtime-published
controller; its legacy resolve/step-heights/host-construction path is
deleted; presentation-only rollback (retail has no entry-flow rollback).
- Headless (route 8): OnSpawned registers with residence when a drive
exists; content-less sessions keep the pre-flip direct registration;
SynchronizeLocalPlayer/CreateController/ApplySetupStepHeights deleted;
prepared-collision read failure is a typed AwaitingCollisionSource
retry; far remotes outside the service window complete celless.
- RuntimeLocalPlayerMovementState.Controller setter sealed internal; all
controller mutation flows through the publication lifecycle.
Fix slices landed within this cutover, each dual-gated:
- F1: live movement-stat/server-physics application routed through the
Runtime ownership seam (post-logout ingest crash on the retired
controller eliminated; RuntimeMovementSkillProjection deleted).
- F2: login activation wedge - collision-admission prefix gate factored
out of the seal (reentrant-commit RejectedAuthority), rearm generation
identity corrected, PlayerModeAutoEntry requires the Runtime-published
controller (world reveal can no longer seal unmaterialized).
- F3: landblock-prefix 0-sentinel replaced by explicit absent-id guards;
map-corner landblocks (grid row/col 0) fully legal through admission,
park/rearm/retire, quiescence, and outdoor shadow seeds.
- F5: local-player first-entry ground contact seeded by the shared
SpawnPlacementSettler (moved App->Core) at FinalizeActivation - the
retail first-gravity-frame touch (enter_world 0x00516170 carries no
seed); the legacy unconditional force-seed is overwritten by a real
floor-found contact; airborne spawns stay airborne; outbound contact
bit verified end-to-end. Fixes the standing-cast 'You can't do that
while in the air!' rejections.
- R1 (dual-review round): login constraint leash armed at the committed
placement (HandleReceivedPosition 0x00453FD0 analog); register rows
AD-61 (settle-timing compression now covering the local player) and
AD-42 (repointed off the deleted resolve split) in this commit;
residence-conversion owner API; wire-landblock guards; drive-pending
ledger in IsConverged; route attach/detach latch; executor-drain drift
model documented + source-pinned.
Gates: Runtime 1,003, App 4,039/3 skips, Headless 79, complete solution
10,816/0 failed/4 skips (Release, -m:1); connected lifecycle/reconnect
gate PASS (logs/connected-world-gate-20260802-175401; graceful exits,
world-visible, zero airborne rejections). The nine-stop soak remains red
for the pre-existing 6b28ff99 whole-world collision-clone throughput
regression (attributed with evidence; scheduled as its own slice before
C5). Dual Opus reviews (retail-conformance + adversarial): delta PASS.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik
parent
78f1eb1896
commit
529e0e9d88
68 changed files with 5977 additions and 831 deletions
|
|
@ -244,4 +244,261 @@ public sealed class RuntimeLocalPlayerMovementStateTests
|
|||
|
||||
Assert.Equal(0L, allocated);
|
||||
}
|
||||
|
||||
// ── C3c-F1 (2026-08-02): movement-stats application seam ──────────────
|
||||
//
|
||||
// The typed seam is the ONLY route by which server stat recomputes
|
||||
// reach the controller; the publication lifecycle decides whether the
|
||||
// write lands (live/dormant) or is a typed displaced drop (terminal).
|
||||
|
||||
private static RuntimeMovementSkillState CompleteSkillState()
|
||||
{
|
||||
var skills = new RuntimeMovementSkillState();
|
||||
skills.Update(runSkill: 240, jumpSkill: 180);
|
||||
skills.UpdateBurden(0.5f);
|
||||
skills.UpdateStamina(37);
|
||||
// BF_PLAYER (0x8) + BF_PLAYER_KILLER (0x20) → ObjectInfoState.IsPK.
|
||||
skills.UpdateOwnPwdBitfield(0x28u);
|
||||
skills.UpdatePlayerKillerStatus(1, 123.5f);
|
||||
return skills;
|
||||
}
|
||||
|
||||
private static PlayerMovementController NewDormantRuntimeController()
|
||||
{
|
||||
PlayerMovementController controller =
|
||||
PlayerMovementController.CreatePublicationCandidate(
|
||||
new PhysicsEngine(),
|
||||
PlayerMovementConstructionOptions.Fallback);
|
||||
controller.SealPublicationCandidate();
|
||||
controller.CommitRuntimeOwnership(new RetailObjectQuantumClock());
|
||||
return controller;
|
||||
}
|
||||
|
||||
private static (float RunRate, float JumpVz, bool CanJump, int JumpCost,
|
||||
ObjectInfoState PvpFlags) CaptureStatObservables(
|
||||
PlayerMovementController controller)
|
||||
{
|
||||
IWeenieObject weenie = controller.Motion.WeenieObj!;
|
||||
Assert.True(weenie.InqRunRate(out float runRate));
|
||||
Assert.True(weenie.InqJumpVelocity(1.0f, out float jumpVz));
|
||||
bool canJump = weenie.CanJump(1.0f);
|
||||
Assert.True(((PlayerWeenie)weenie).JumpStaminaCost(1.0f, out int cost));
|
||||
return (runRate, jumpVz, canJump, cost, controller.OwnPvpFlags);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ApplyCharacterMovementStats_LiveApplicationIsByteIdenticalToTheRetiredDirectPath()
|
||||
{
|
||||
RuntimeMovementSkillState skills = CompleteSkillState();
|
||||
RuntimeMovementSkillSnapshot snapshot = skills.Snapshot;
|
||||
|
||||
// Old direct path (the deleted RuntimeMovementSkillProjection.ApplyTo
|
||||
// body), applied through the public gated setters.
|
||||
var direct = new PlayerMovementController(new PhysicsEngine());
|
||||
direct.SetCharacterSkills(snapshot.RunSkill, snapshot.JumpSkill);
|
||||
direct.SetCharacterBurden(snapshot.Burden);
|
||||
direct.SetCharacterStamina(snapshot.CurrentStamina);
|
||||
direct.OwnPvpFlags = EntityCollisionFlagsExt
|
||||
.FromPwdBitfield(snapshot.OwnPwdBitfield)
|
||||
.ToMoverState();
|
||||
direct.SetCharacterPkStatus(
|
||||
snapshot.PlayerKillerStatus,
|
||||
snapshot.LastPkAttackTimestamp);
|
||||
|
||||
var routed = new PlayerMovementController(new PhysicsEngine());
|
||||
using var movement = new RuntimeLocalPlayerMovementState
|
||||
{
|
||||
Controller = routed,
|
||||
};
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeMovementStatsApplication.AppliedLive,
|
||||
movement.ApplyCharacterMovementStats(skills));
|
||||
Assert.Equal(
|
||||
CaptureStatObservables(direct),
|
||||
CaptureStatObservables(routed));
|
||||
Assert.Equal(ObjectInfoState.IsPK, routed.OwnPvpFlags);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ApplyCharacterMovementStats_DormantWindowWriteLandsOnTheControllerThatGoesLive()
|
||||
{
|
||||
RuntimeMovementSkillState skills = CompleteSkillState();
|
||||
PlayerMovementController controller = NewDormantRuntimeController();
|
||||
using var movement = new RuntimeLocalPlayerMovementState
|
||||
{
|
||||
Controller = controller,
|
||||
};
|
||||
|
||||
// The committed-but-unactivated first-entry window: the dormant
|
||||
// controller is installed in the movement owner while activation
|
||||
// waits on cell streaming, and inbound recomputes keep pumping.
|
||||
Assert.True(controller.IsRuntimeOwnedDormant);
|
||||
Assert.Throws<InvalidOperationException>(
|
||||
() => controller.SetCharacterSkills(1, 1));
|
||||
Assert.Equal(
|
||||
RuntimeMovementStatsApplication.AppliedDormant,
|
||||
movement.ApplyCharacterMovementStats(skills));
|
||||
|
||||
// Activation flips the SAME instance live — the applied values are
|
||||
// already current when movement starts.
|
||||
controller.ActivateRuntimePublication();
|
||||
Assert.True(controller.IsRuntimePublished);
|
||||
(float runRate, _, _, _, ObjectInfoState pvp) =
|
||||
CaptureStatObservables(controller);
|
||||
Assert.Equal(
|
||||
PlayerWeenie.GetRunRate(0.5f, 240),
|
||||
runRate,
|
||||
precision: 5);
|
||||
Assert.Equal(ObjectInfoState.IsPK, pvp);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ApplyCharacterMovementStats_TerminalControllerReportsTypedDisplacedDrop()
|
||||
{
|
||||
RuntimeMovementSkillState skills = CompleteSkillState();
|
||||
PlayerMovementController controller = NewDormantRuntimeController();
|
||||
using var movement = new RuntimeLocalPlayerMovementState
|
||||
{
|
||||
Controller = controller,
|
||||
};
|
||||
controller.ActivateRuntimePublication();
|
||||
var before = CaptureStatObservables(controller);
|
||||
// The Motion surface is gated once terminal; capture the weenie
|
||||
// reference while the controller is still published.
|
||||
IWeenieObject weenie = controller.Motion.WeenieObj!;
|
||||
|
||||
// Post-teardown transient truth: the controller retired while still
|
||||
// reachable through a displaced recompute callback. The public
|
||||
// setter still throws (the seal working); the seam reports the
|
||||
// typed drop instead and mutates nothing.
|
||||
controller.RetireRuntimePublication();
|
||||
Assert.Throws<InvalidOperationException>(
|
||||
() => controller.SetCharacterSkills(1, 1));
|
||||
Assert.Equal(
|
||||
RuntimeMovementStatsApplication.DroppedDisplacedController,
|
||||
movement.ApplyCharacterMovementStats(skills));
|
||||
|
||||
Assert.True(weenie.InqRunRate(out float runRate));
|
||||
Assert.Equal(before.RunRate, runRate);
|
||||
Assert.Equal(before.PvpFlags, controller.OwnPvpFlags);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ApplyCharacterMovementStats_SealedCandidateIsATypedDisplacedDrop()
|
||||
{
|
||||
// Defensive lifecycle-matrix row: a sealed candidate is frozen for
|
||||
// the Prepare→Commit validation handshake and never installed into
|
||||
// the movement owner in production (Prepare requires the owner
|
||||
// empty; Commit installs it already-dormant within the same
|
||||
// synchronous conductor step), so only a direct controller-level
|
||||
// call can observe this row.
|
||||
PlayerMovementController controller =
|
||||
PlayerMovementController.CreatePublicationCandidate(
|
||||
new PhysicsEngine(),
|
||||
PlayerMovementConstructionOptions.Fallback);
|
||||
controller.SealPublicationCandidate();
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeMovementStatsApplication.DroppedDisplacedController,
|
||||
controller.ApplyCharacterMovementStats(
|
||||
CompleteSkillState().Snapshot));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ApplyCharacterMovementStats_AbsentControllerAndIncompleteSnapshotDropSilently()
|
||||
{
|
||||
var skills = new RuntimeMovementSkillState();
|
||||
using var movement = new RuntimeLocalPlayerMovementState();
|
||||
|
||||
Assert.Equal(
|
||||
RuntimeMovementStatsApplication.DroppedNoController,
|
||||
movement.ApplyCharacterMovementStats(skills));
|
||||
|
||||
movement.Controller = new PlayerMovementController(new PhysicsEngine());
|
||||
Assert.Equal(
|
||||
RuntimeMovementStatsApplication.DroppedIncompleteSnapshot,
|
||||
movement.ApplyCharacterMovementStats(skills));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ApplyCharacterMovementStats_DisposedOwnerToleratesTheDisplacedCallback()
|
||||
{
|
||||
var movement = new RuntimeLocalPlayerMovementState
|
||||
{
|
||||
Controller = new PlayerMovementController(new PhysicsEngine()),
|
||||
};
|
||||
movement.Dispose();
|
||||
|
||||
// The displaced-callback-rejection pattern: a recompute landing
|
||||
// after terminal disposal observes a typed drop, never a fault.
|
||||
Assert.Equal(
|
||||
RuntimeMovementStatsApplication.DroppedNoController,
|
||||
movement.ApplyCharacterMovementStats(CompleteSkillState()));
|
||||
Assert.False(movement.ReportExhaustion());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ReportExhaustion_DispatchesOnlyThroughALiveController()
|
||||
{
|
||||
using var movement = new RuntimeLocalPlayerMovementState();
|
||||
Assert.False(movement.ReportExhaustion());
|
||||
|
||||
PlayerMovementController controller = NewDormantRuntimeController();
|
||||
movement.Controller = controller;
|
||||
Assert.False(movement.ReportExhaustion());
|
||||
|
||||
controller.ActivateRuntimePublication();
|
||||
Assert.True(movement.ReportExhaustion());
|
||||
|
||||
controller.RetireRuntimePublication();
|
||||
Assert.False(movement.ReportExhaustion());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ApplyServerPhysicsState_DormantDropsForActivationAndLiveAppliesExactly()
|
||||
{
|
||||
// The second connected-gate crash chain
|
||||
// (logs/connected-world-gate-20260802-125907): an inbound local-
|
||||
// player SetState pushed ApplyPhysicsState at the dormant
|
||||
// first-entry controller. The typed entry decides by lifecycle.
|
||||
PlayerMovementController controller =
|
||||
PlayerMovementController.CreatePublicationCandidate(
|
||||
new PhysicsEngine(),
|
||||
PlayerMovementConstructionOptions.Fallback);
|
||||
PhysicsBody body = controller.PhysicsBody;
|
||||
PhysicsStateFlags initial = body.State;
|
||||
PhysicsStateFlags pushed =
|
||||
PhysicsStateFlags.Gravity
|
||||
| PhysicsStateFlags.ReportCollisions
|
||||
| PhysicsStateFlags.Ethereal;
|
||||
Assert.NotEqual(initial, pushed);
|
||||
|
||||
controller.SealPublicationCandidate();
|
||||
controller.CommitRuntimeOwnership(new RetailObjectQuantumClock());
|
||||
|
||||
// Dormant: the activation transaction owns the dormant body's
|
||||
// physics state; the push is dropped and the body is untouched.
|
||||
Assert.Equal(
|
||||
RuntimeServerPhysicsStateApplication.DroppedDormantActivationOwned,
|
||||
controller.ApplyServerPhysicsState(pushed));
|
||||
Assert.Equal(initial, body.State);
|
||||
|
||||
// Published: byte-identical to the direct ApplyPhysicsState body.
|
||||
controller.ActivateRuntimePublication();
|
||||
Assert.Equal(
|
||||
RuntimeServerPhysicsStateApplication.AppliedLive,
|
||||
controller.ApplyServerPhysicsState(pushed));
|
||||
Assert.Equal(pushed, body.State);
|
||||
|
||||
// Terminal: a displaced push, typed instead of a fault, mutating
|
||||
// nothing.
|
||||
controller.RetireRuntimePublication();
|
||||
Assert.Throws<InvalidOperationException>(
|
||||
() => controller.ApplyPhysicsState(initial));
|
||||
Assert.Equal(
|
||||
RuntimeServerPhysicsStateApplication.DroppedDisplacedController,
|
||||
controller.ApplyServerPhysicsState(initial));
|
||||
Assert.Equal(pushed, body.State);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue