feat(chat): #20 CombatChatTranslator - retail-faithful combat -> ChatLog templates
Subscribes to CombatState's DamageDealtAccepted / DamageTaken /
MissedOutgoing / EvadedIncoming / AttackDone / KillLanded events
and emits chat-line text into ChatLog.OnCombatLine, mirroring
holtburger's templates verbatim from references/holtburger/apps/
holtburger-cli/src/pages/game/panels/chat.rs:221-308.
Pieces:
- ChatLog: new ChatKind.Combat value; new CombatLineKind enum
(Info / Warning / Error) on ChatEntry; OnCombatLine(text, kind)
adapter.
- CombatChatTranslator (Core, IDisposable). Static formatters:
FormatDamageType (slashing/piercing/bludgeoning/fire/cold/acid/
electric/nether), FormatDamageLocation (head/chest/abdomen/
upper arm/lower arm/hand/upper leg/lower leg/foot), FormatPercent,
FormatAttackConditionsSuffix.
- ChatVM.RecentLinesDetailed() returns FormattedLine records with
kind metadata so panels can render combat lines colored.
- ChatPanel switches on Kind/CombatKind: combat-Info -> yellow,
combat-Warning -> red incoming-damage, combat-Error -> deep red,
all others -> existing renderer.Text path.
- GameWindow constructs translator after GameEventWiring.WireAll;
disposes in OnClosing + live-session failure path.
Templates landed:
Attacker: "You hit {def} for {dmg} {dtype} damage ({hp%}). [Crit]{suffix}"
Defender: "{atk} hit you for {dmg} {dtype} damage to your {loc} ({hp%})..."
Evade-out: "{def} evaded your attack."
Evade-in: "You evaded {atk}'s attack."
AttackErr: "Attack sequence finished with {error}."
Kill: synthesized "You killed {name}." + server PlayerKilled
death-message arrives separately via ChatLog.OnPlayerKilled.
Deviations from holtburger templates (documented in source):
- DamageDealt omits Critical-hit suffix until CombatState.DamageDealt
carries the flag (defender-side has it; attacker-side doesn't yet).
- DamageTaken omits (health%) until CombatState.DamageIncoming
parses the wire health-percent field.
- AttackConditions suffix is implemented but always empty until the
bitflag is plumbed into CombatState records.
18 new tests (12 translator + 4 ChatVMCombat + 2 ChatLog).
Solution total: 978 green (243 Core.Net + 639 Core + 96 UI).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
ca968fc766
commit
3d26c8efde
9 changed files with 699 additions and 2 deletions
|
|
@ -1,4 +1,5 @@
|
|||
using AcDream.Core.Chat;
|
||||
using AcDream.Core.Combat;
|
||||
using Xunit;
|
||||
|
||||
namespace AcDream.Core.Tests.Chat;
|
||||
|
|
@ -172,4 +173,30 @@ public sealed class ChatLogTests
|
|||
log.OnLocalSpeech(sender: "Alice", text: "hi", senderGuid: 0xAA, isRanged: false);
|
||||
Assert.Equal("Alice", log.Snapshot()[0].Sender);
|
||||
}
|
||||
|
||||
// ── Phase I.7: combat-line adapter ────────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void OnCombatLine_DefaultsInfoKind_TagsEntryAsCombat()
|
||||
{
|
||||
var log = new ChatLog();
|
||||
log.OnCombatLine("You hit Mosswart for 5 slashing damage (50.0%).");
|
||||
var e = log.Snapshot()[0];
|
||||
Assert.Equal(ChatKind.Combat, e.Kind);
|
||||
Assert.Equal(CombatLineKind.Info, e.CombatKind);
|
||||
Assert.Equal("You hit Mosswart for 5 slashing damage (50.0%).", e.Text);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void OnCombatLine_PreservesExplicitKind()
|
||||
{
|
||||
var log = new ChatLog();
|
||||
log.OnCombatLine("Mosswart hit you for 8 fire damage to your chest.",
|
||||
CombatLineKind.Warning);
|
||||
Assert.Equal(CombatLineKind.Warning, log.Snapshot()[0].CombatKind);
|
||||
|
||||
log.OnCombatLine("Attack sequence finished with WeenieError 0x1234.",
|
||||
CombatLineKind.Error);
|
||||
Assert.Equal(CombatLineKind.Error, log.Snapshot()[1].CombatKind);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue