erik/acdream
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs: fix HousePageController doc — correct a claim about unshipped RuntimeHouseState wiring

Browse source 
The class doc referenced RuntimeHouseState.PurchaseAvailabilityText as
already wired this session; it isn't (deferred to #413, the
RuntimeHouseState owner integration). Corrected to accurately describe
what shipped (mount + wire parsing groundwork) vs what's still open.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Erik 2026-08-17 02:31:53 +02:00
parent 8799acd285
commit 22b6281192
1 changed files with 18 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

31
src/AcDream.App/UI/Layout/HousePageController.cs
View file

@ -25,15 +25,19 @@ namespace AcDream.App.UI.Layout;
/// </para>
///
/// <para>
/// <b>Scope (Batch C, 2026-08-17 recon doc).</b> Of the seven
/// <c>Display*</c> line builders <c>DisplayHouseData</c> calls, only
/// <c>DisplayPurchaseTimeText @0x004a3110</c>'s two simple, fully-recovered
/// literal strings ("You may buy another house immediately." / "...after
/// you abandon this one.") are wired end-to-end this session — see
/// <c>RuntimeHouseState.PurchaseAvailabilityText</c>. The other six
/// (BuyPayment/RentPayment/BuyTime/RentTimes/Location/WarningText) only
/// matter once a house is actually owned and are filed as an ISSUES entry
/// rather than guessed at from FPU-mangled decomp.
/// <b>Scope (Batch C, 2026-08-17) — see ISSUES #413 for the full ledger.</b>
/// This session shipped the mount (this class) and the wire PARSING
/// groundwork (<c>GameEvents.ParseHouseData</c>/<c>ParseHouseStatus</c>/
/// <c>ParseUpdateRentTime</c>/<c>ParseUpdateRentPayment</c>,
/// <c>GameEventWiring</c>'s four delegate holes, the outbound HouseQuery
/// action). <see cref="Bindings.Lines"/>/<see cref="Bindings.OnShown"/> are
/// NOT yet wired to real data — no <c>RuntimeHouseState</c> owner exists,
/// and none of the seven <c>Display*</c> line builders
/// <c>DisplayHouseData</c> calls (including
/// <c>DisplayPurchaseTimeText @0x004a3110</c>'s two fully-recovered
/// literal strings) are ported. Until #413 closes, this page mounts with
/// genuinely empty content — matching retail's own <c>PostInit</c>, which
/// never calls <c>Update</c>/<c>DisplayHouseData</c> either.
/// </para>
/// </summary>
public sealed class HousePageController
@ -43,10 +47,11 @@ public sealed class HousePageController
public sealed record Bindings(
Func<IReadOnlyList<string>> Lines,
// Fires once when the page transitions to visible — the seam that
// sends the outbound HouseQuery (0x021E) so the server has a
// reason to answer with fresh HouseData/HouseStatus. NOT a ported
// retail call site (PostInit never triggers a query) — an acdream
// convention, documented as such (recon doc open item).
// WILL send the outbound HouseQuery (0x021E, already implemented as
// WorldSession.SendHouseQuery) once a caller wires OnShown to it —
// see ISSUES #413. NOT a ported retail call site (PostInit never
// triggers a query) — an acdream convention, documented as such
// (recon doc open item).
Action? OnShown = null);
private readonly UiTemplateListBox _listBox;