From 22b62811920a73fc09a6b7f50bf1a52e4511e05b Mon Sep 17 00:00:00 2001 From: Erik Date: Mon, 17 Aug 2026 02:31:53 +0200 Subject: [PATCH] =?UTF-8?q?docs:=20fix=20HousePageController=20doc=20?= =?UTF-8?q?=E2=80=94=20correct=20a=20claim=20about=20unshipped=20RuntimeHo?= =?UTF-8?q?useState=20wiring?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The class doc referenced RuntimeHouseState.PurchaseAvailabilityText as already wired this session; it isn't (deferred to #413, the RuntimeHouseState owner integration). Corrected to accurately describe what shipped (mount + wire parsing groundwork) vs what's still open. Co-Authored-By: Claude Fable 5 --- .../UI/Layout/HousePageController.cs | 31 +++++++++++-------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/AcDream.App/UI/Layout/HousePageController.cs b/src/AcDream.App/UI/Layout/HousePageController.cs index 577bcd52..9ceb219d 100644 --- a/src/AcDream.App/UI/Layout/HousePageController.cs +++ b/src/AcDream.App/UI/Layout/HousePageController.cs @@ -25,15 +25,19 @@ namespace AcDream.App.UI.Layout; /// /// /// -/// Scope (Batch C, 2026-08-17 recon doc). Of the seven -/// Display* line builders DisplayHouseData calls, only -/// DisplayPurchaseTimeText @0x004a3110's two simple, fully-recovered -/// literal strings ("You may buy another house immediately." / "...after -/// you abandon this one.") are wired end-to-end this session — see -/// RuntimeHouseState.PurchaseAvailabilityText. The other six -/// (BuyPayment/RentPayment/BuyTime/RentTimes/Location/WarningText) only -/// matter once a house is actually owned and are filed as an ISSUES entry -/// rather than guessed at from FPU-mangled decomp. +/// Scope (Batch C, 2026-08-17) — see ISSUES #413 for the full ledger. +/// This session shipped the mount (this class) and the wire PARSING +/// groundwork (GameEvents.ParseHouseData/ParseHouseStatus/ +/// ParseUpdateRentTime/ParseUpdateRentPayment, +/// GameEventWiring's four delegate holes, the outbound HouseQuery +/// action). / are +/// NOT yet wired to real data — no RuntimeHouseState owner exists, +/// and none of the seven Display* line builders +/// DisplayHouseData calls (including +/// DisplayPurchaseTimeText @0x004a3110's two fully-recovered +/// literal strings) are ported. Until #413 closes, this page mounts with +/// genuinely empty content — matching retail's own PostInit, which +/// never calls Update/DisplayHouseData either. /// /// public sealed class HousePageController @@ -43,10 +47,11 @@ public sealed class HousePageController public sealed record Bindings( Func> Lines, // Fires once when the page transitions to visible — the seam that - // sends the outbound HouseQuery (0x021E) so the server has a - // reason to answer with fresh HouseData/HouseStatus. NOT a ported - // retail call site (PostInit never triggers a query) — an acdream - // convention, documented as such (recon doc open item). + // WILL send the outbound HouseQuery (0x021E, already implemented as + // WorldSession.SendHouseQuery) once a caller wires OnShown to it — + // see ISSUES #413. NOT a ported retail call site (PostInit never + // triggers a query) — an acdream convention, documented as such + // (recon doc open item). Action? OnShown = null); private readonly UiTemplateListBox _listBox;