SawatoMosswartsEnjoyersClub/openac-mosswartmassacre
3
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

Review fixes: logoff inventory, socket stop, connect order, relog leftovers

Browse source 
F2: the logoff inventory is skipped when the host already let go of the
items (it may reset the session before reporting the logoff): an empty list
would have emptied the backend's inventory and overwritten the saved copy.
F3/F4: each socket start owns its run; Stop no longer blocks the game thread
and gives the run up to ten seconds to send what was queued (a large logoff
inventory) before closing, flushing that run's own send loop; a relog never
hears the previous run's frames.
F7: on connect, share_subscribe goes out before the first telemetry frame, as
the original sent them.
F8: a rare announcement still waiting at logoff is dropped rather than sent
as the next character.
F9: each dungeon map is sent once per login, as the original (reloaded per
login) did.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Erik 2026-09-25 13:06:50 +02:00
parent 71f14473c6
commit aec0ddb8d7
8 changed files with 223 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

37
tests/OpenAC.MosswartMassacre.Tests/ReviewFixTests.cs Normal file
View file

@ -0,0 +1,37 @@
namespace OpenAC.MosswartMassacre.Tests;
/// <summary>Pins for the fixes a review of the port asked for.</summary>
public sealed class ReviewFixTests
{
[Fact]
public void On_connect_the_sharing_subscribe_goes_out_before_the_first_telemetry()
{
using var harness = new PluginHarness("Mossy");
harness.Login();
harness.Context.Settings.Current.VitalSharingEnabled = true;
harness.Frames.Clear();
harness.SimulateConnected();
string[] types = [.. harness.Frames.Select(f => (string)Newtonsoft.Json.Linq.JObject.Parse(f)["type"]!)];
Assert.Equal(["share_subscribe", "telemetry"], types.Take(2));
}
[Fact]
public void A_rare_announcement_still_waiting_at_logoff_is_dropped()
{
using var harness = new PluginHarness("Mossy");
harness.Login();
harness.Host.Automation.Chat.Deliver("Mossy has discovered the Pearl of Blood Drinking!", kind: 4);
harness.Host.Automation.Chat.Submitted.Clear();
harness.Plugin.OnLogoff();
harness.Host.Automation.Character.Name = "Horan";
harness.Plugin.OnLogin();
harness.Host.Automation.Chat.Submitted.Clear();
harness.Run(4);
Assert.DoesNotContain(harness.Host.Automation.Chat.Submitted, line => line.StartsWith("/a ", StringComparison.Ordinal));
}
}