lundberg/porchlight
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
porchlight/tests
History
Johan Lundberg 1bb76899a5
fix(security): make self-service last-credential guard atomic 
The self-service credential delete handlers counted credentials and then
deleted in separate steps, so concurrent deletes could each see >1 and both
proceed, removing the user's last credential and locking them out.

Add atomic delete_password_if_not_last / delete_webauthn_if_not_last repo
methods (count + delete in one conditional statement) and use them in the
manage delete handlers. Removes the now-unused _count_credentials helper.

Refs: porchlight-2nv

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 15:00:08 +02:00
..
e2e test: allow disabling rate limiting for e2e runs 2026-06-03 16:32:32 +02:00
test_admin fix: resolve all ruff lint errors and type checker warnings 2026-03-31 15:48:46 +02:00
test_auth_routes fix(security): reset session on login to prevent fixation 2026-06-04 14:23:08 +02:00
test_authn fix: resolve all ruff lint errors and type checker warnings 2026-03-31 15:48:46 +02:00
test_invite fix(security): consume magic-link tokens atomically 2026-06-04 10:46:38 +02:00
test_manage chore: create package structure with src layout 2026-02-12 14:39:07 +01:00
test_oidc fix(security): escape error text in OIDC error pages 2026-06-04 11:06:08 +02:00
test_store fix(security): make self-service last-credential guard atomic 2026-06-04 15:00:08 +02:00
__init__.py chore: create package structure with src layout 2026-02-12 14:39:07 +01:00
conftest.py feat: add rate limiting middleware for authentication endpoints 2026-03-31 15:23:51 +02:00
test_admin_groups_validation.py fix(security): reset session on login to prevent fixation 2026-06-04 14:23:08 +02:00
test_admin_invite_validation.py fix(security): reset session on login to prevent fixation 2026-06-04 14:23:08 +02:00
test_app.py fix: resolve all ruff lint errors and type checker warnings 2026-03-31 15:48:46 +02:00
test_authn_active.py style: apply ruff formatting to new files 2026-03-31 15:36:08 +02:00
test_cli.py feat: add initial-admin CLI command 2026-02-18 11:29:13 +01:00
test_client_registration.py refactor: fix lint warnings and remove stale type: ignore comments 2026-02-18 13:08:03 +01:00
test_config.py refactor: fix lint warnings and remove stale type: ignore comments 2026-02-18 13:08:03 +01:00
test_csrf.py feat: wire CSRF middleware and harden session cookie 2026-02-19 13:45:58 +01:00
test_manage_profile.py feat: wire ProfileUpdate validation into manage profile route 2026-03-10 15:36:47 +01:00
test_models.py update all imports in test files: fastapi_oidc_op → porchlight 2026-02-16 15:34:53 +01:00
test_password_change.py fix(security): reset session on login to prevent fixation 2026-06-04 14:23:08 +02:00
test_rate_limit.py feat: add rate limiting middleware for authentication endpoints 2026-03-31 15:23:51 +02:00
test_userid.py update all imports in test files: fastapi_oidc_op → porchlight 2026-02-16 15:34:53 +01:00
test_validation.py fix(security): escape user input in validation error HTML 2026-06-04 10:23:32 +02:00