lundberg/porchlight
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

test: update all tests to include CSRF tokens

Browse source
This commit is contained in:
Johan Lundberg 2026-02-19 14:19:47 +01:00
parent 9e5773f52f
commit f648422227
No known key found for this signature in database
GPG key ID: A6C152738D03C7D1
12 changed files with 105 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

20
tests/test_oidc/test_consent_flow.py
View file

@ -5,6 +5,7 @@ from urllib.parse import parse_qs, urlparse
from argon2 import PasswordHasher
from httpx import AsyncClient
from tests.conftest import get_csrf_token
from porchlight.authn.password import PasswordService
from porchlight.models import PasswordCredential, User
@ -16,10 +17,11 @@ async def test_authorization_shows_consent_for_new_client(client: AsyncClient) -
await _create_test_user(app)
# Login
token = await get_csrf_token(client)
await client.post(
"/login/password",
data={"username": "consentuser", "password": "testpass"},
headers={"HX-Request": "true"},
headers={"HX-Request": "true", "X-CSRF-Token": token},
)
# Authorization request
@ -58,9 +60,11 @@ async def test_consent_allow_redirects_with_code(client: AsyncClient) -> None:
await _create_test_user(app)
await _login_and_start_auth(client)
token = await get_csrf_token(client)
res = await client.post(
"/consent",
data={"action": "allow", "scope": ["openid", "profile"]},
headers={"X-CSRF-Token": token},
follow_redirects=False,
)
assert res.status_code == 303
@ -77,9 +81,11 @@ async def test_consent_deny_redirects_with_error(client: AsyncClient) -> None:
await _create_test_user(app)
await _login_and_start_auth(client)
token = await get_csrf_token(client)
res = await client.post(
"/consent",
data={"action": "deny"},
headers={"X-CSRF-Token": token},
follow_redirects=False,
)
assert res.status_code == 303
@ -97,9 +103,11 @@ async def test_saved_consent_skips_consent_screen(client: AsyncClient) -> None:
# First flow: login, authorize, consent
await _login_and_start_auth(client)
token = await get_csrf_token(client)
await client.post(
"/consent",
data={"action": "allow", "scope": ["openid", "profile"]},
headers={"X-CSRF-Token": token},
follow_redirects=False,
)
@ -130,9 +138,11 @@ async def test_new_scopes_reshows_consent(client: AsyncClient) -> None:
# First flow: consent to openid only
await _login_and_start_auth(client, scope="openid")
token = await get_csrf_token(client)
await client.post(
"/consent",
data={"action": "allow", "scope": ["openid"]},
headers={"X-CSRF-Token": token},
follow_redirects=False,
)
@ -158,10 +168,11 @@ async def test_manage_app_skips_consent(client: AsyncClient) -> None:
settings = app.state.settings
await _create_test_user(app)
token = await get_csrf_token(client)
await client.post(
"/login/password",
data={"username": "consentuser", "password": "testpass"},
headers={"HX-Request": "true"},
headers={"HX-Request": "true", "X-CSRF-Token": token},
)
manage_cdb = app.state.oidc_server.context.cdb[settings.manage_client_id]
@ -193,9 +204,11 @@ async def test_partial_consent_filters_scopes(client: AsyncClient) -> None:
# Request openid + profile + email, approve only openid + profile
await _login_and_start_auth(client, scope="openid profile email")
token = await get_csrf_token(client)
res = await client.post(
"/consent",
data={"action": "allow", "scope": ["openid", "profile"]},
headers={"X-CSRF-Token": token},
follow_redirects=False,
)
assert res.status_code == 303
@ -250,10 +263,11 @@ async def _create_test_user(app) -> None:
async def _login_and_start_auth(client: AsyncClient, scope: str = "openid profile") -> None:
token = await get_csrf_token(client)
await client.post(
"/login/password",
data={"username": "consentuser", "password": "testpass"},
headers={"HX-Request": "true"},
headers={"HX-Request": "true", "X-CSRF-Token": token},
)
await client.get(
"/authorization",