lundberg/porchlight
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: update existing tests to handle consent step

Browse source
This commit is contained in:
Johan Lundberg 2026-02-19 11:13:11 +01:00
parent 078892a413
commit b8464284c2
No known key found for this signature in database
GPG key ID: A6C152738D03C7D1
3 changed files with 28 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/test_oidc/test_e2e_flow.py
View file

@ -87,13 +87,22 @@ async def test_full_authorization_code_flow(client: AsyncClient) -> None:
f"Expected HX-Redirect to /authorization/complete, got '{hx_redirect}'"
)
# -- Step 3: Complete authorization → redirect to callback with code + state --
# -- Step 3: Complete authorization → redirect to consent --
complete_res = await client.get("/authorization/complete", follow_redirects=False)
assert complete_res.status_code in (302, 303), (
f"Expected redirect to callback, got {complete_res.status_code}: {complete_res.text}"
f"Expected redirect to /consent, got {complete_res.status_code}: {complete_res.text}"
)
assert "/consent" in complete_res.headers["location"]
location = complete_res.headers["location"]
# -- Step 3b: Approve consent → redirect to callback with code + state --
consent_res = await client.post(
"/consent",
data={"action": "allow", "scope": ["openid", "profile", "email"]},
follow_redirects=False,
)
assert consent_res.status_code in (302, 303)
location = consent_res.headers["location"]
parsed = urlparse(location)
assert parsed.netloc == "localhost:9000"
assert parsed.path == "/callback"

10
tests/test_oidc/test_token.py
View file

@ -59,6 +59,8 @@ async def _get_authorization_code(client: AsyncClient) -> str:
"""Run full auth flow and extract the authorization code."""
_register_test_client(client)
app = client._transport.app # type: ignore[union-attr]
# Start authorization (unauthenticated — stores in session)
await client.get(
"/authorization",
@ -74,9 +76,13 @@ async def _get_authorization_code(client: AsyncClient) -> str:
)
# Create user and log in
await _create_user_and_login(client)
userid = await _create_user_and_login(client)
# Complete authorization (now authenticated, session has oidc_auth_request)
# Pre-seed consent so the consent screen is skipped
consent_repo = app.state.consent_repo
await consent_repo.set_consent(userid, "test-rp", ["openid", "profile", "email"])
# Complete authorization (now authenticated, consent exists → redirects to callback)
complete_res = await client.get("/authorization/complete", follow_redirects=False)
assert complete_res.status_code in (302, 303), (
f"Expected redirect, got {complete_res.status_code}: {complete_res.text}"

10
tests/test_oidc/test_userinfo.py
View file

@ -61,6 +61,8 @@ async def _get_access_token(client: AsyncClient) -> str:
"""Run full auth + token flow and return the access_token."""
client_secret = _register_test_client(client)
app = client._transport.app # type: ignore[union-attr]
# Start authorization (unauthenticated — stores in session)
await client.get(
"/authorization",
@ -76,9 +78,13 @@ async def _get_access_token(client: AsyncClient) -> str:
)
# Create user and log in
await _create_user_and_login(client)
userid = await _create_user_and_login(client)
# Complete authorization (now authenticated, session has oidc_auth_request)
# Pre-seed consent so the consent screen is skipped
consent_repo = app.state.consent_repo
await consent_repo.set_consent(userid, "test-rp", ["openid", "profile", "email"])
# Complete authorization (now authenticated, consent exists → redirects to callback)
complete_res = await client.get("/authorization/complete", follow_redirects=False)
assert complete_res.status_code in (302, 303), (
f"Expected redirect, got {complete_res.status_code}: {complete_res.text}"