From 752bf87b7c11d0e4cc2a7bdfddff6dad4dace0c3 Mon Sep 17 00:00:00 2001
From: Johan Lundberg <lundberg@sunet.se>
Date: Fri, 13 Mar 2026 20:46:12 +0100
Subject: [PATCH] style: apply ruff SIM108 ternary to validation error handling

---
 src/porchlight/admin/routes.py  | 5 +----
 src/porchlight/manage/routes.py | 6 +-----
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/porchlight/admin/routes.py b/src/porchlight/admin/routes.py
index acf4d0f..b6692cd 100644
--- a/src/porchlight/admin/routes.py
+++ b/src/porchlight/admin/routes.py
@@ -168,10 +168,7 @@ async def update_user_profile(
             "locale": "Locale",
         }
         label = labels.get(str(field), str(field))
-        if error["type"] == "value_error":
-            display_msg = msg.removeprefix("Value error, ")
-        else:
-            display_msg = f"{label}: {msg}"
+        display_msg = msg.removeprefix("Value error, ") if error["type"] == "value_error" else f"{label}: {msg}"
         return HTMLResponse(f'<div role="alert">{display_msg}</div>')
 
     user_repo = request.app.state.user_repo
diff --git a/src/porchlight/manage/routes.py b/src/porchlight/manage/routes.py
index 207c749..a3c4887 100644
--- a/src/porchlight/manage/routes.py
+++ b/src/porchlight/manage/routes.py
@@ -240,11 +240,7 @@ async def update_profile(
         }
         label = labels.get(str(field), str(field))
         # Use custom message for value errors (e.g. picture URL), generic pydantic message otherwise
-        if error["type"] == "value_error":
-            # Strip Pydantic's "Value error, " prefix to get the original message
-            display_msg = msg.removeprefix("Value error, ")
-        else:
-            display_msg = f"{label}: {msg}"
+        display_msg = msg.removeprefix("Value error, ") if error["type"] == "value_error" else f"{label}: {msg}"
         return HTMLResponse(f'<div role="alert">{display_msg}</div>')
 
     user_repo = request.app.state.user_repo