acdream/tests/AcDream.Runtime.Tests/Gameplay
Erik ef567bfa20 fix(ui): morning gate — House tab renders retail's TWO houseless lines, not one
User finding 2 (retail screenshot, houseless character): the House tab
shows "You do not currently own a house." ABOVE "You may buy another
house immediately." — ours showed only the second line, and the prior
session had REFUTED the first line outright ("no such string exists
anywhere in the 2013 dump").

Re-derivation: the string exists in the binary at data_7ab688 — it is
gmHouseUI::DisplayBuyPayment @0x004a2b30's HOUSELESS branch. Two
compounding misreads hid it: (a) DisplayBuyPayment was mislabeled
houseless-silent, but its m_pHouseData gate only selects WHICH text
(jne 0x4a2b63) — the ListBox emit (@0x004a2b80 onward,
AddItemFromTemplateList + SetTextWithFont) runs in BOTH branches; and
(b) BN's pseudo-C renders both push-literal operands as spurious
&vftable.RecvNotice_* symbol matches (the TS-85/F3 artifact class), so
text sweeps of the dump find nothing — capstone byte-decode of the
PDB-paired binary resolves houseless @0x004a2b57 push 0x7ab688 =
"You do not currently own a house." and owned @0x004a2b63 push
0x7ab65c = "The purchase price for this dwelling is:\n" (+
HousePaymentList::ComposeText, still #413 item-3 scope). The morning
brief's alternate DAT-string-table hypothesis was checked and is NOT
the mechanism — plain exe string-pool literal.

RuntimeHouseState.Recompute now renders the houseless case as retail's
exact two lines in gmHouseUI::Update's fixed builder order
(DisplayBuyPayment first, DisplayPurchaseTimeText last); the owned case
is unchanged (its DisplayBuyPayment content needs ComposeText, #413
item 3). Class doc + ISSUES #413 corrected honestly — the user's retail
evidence supersedes the earlier refutation. Runtime house tests updated
to pin both lines; 9/9 pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-17 08:54:55 +02:00
..
CharacterOptionTableTests.cs fix(runtime,net): OP1 review fixes — server-seed gate, tick-wired auto-save/logout flush, fellowship mutual exclusion 2026-08-11 00:39:51 +02:00
InteractionStateTests.cs refactor(runtime): own canonical action state 2026-07-26 10:44:09 +02:00
LocalPlayerImmediatePositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
LocalPlayerOutboundCombatStyleTests.cs refactor(runtime): own local movement and outbound cadence 2026-07-26 12:33:53 +02:00
PlayerMouseLookMovementTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerMovementControllerTests.cs fix: airborne jump refusal fires at RELEASE, not press (user retail 2026-08-14 08:31:22 +02:00
PlayerOutboundPositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerPhysicsQuantumCaptureTests.cs fix(physics): port retail slope landing stop 2026-07-31 09:10:53 +02:00
RuntimeActionStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeActionTestFactory.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeAllegianceStateTests.cs fix(net,runtime): FA2 fix-round MUST-FIX -- allegiance clears at reset, 0x027C stops seeding 2026-08-12 02:17:04 +02:00
RuntimeCharacterStateTests.cs feat(ui): Campaign OP slice OP4 — the Character tab 2026-08-11 04:31:34 +02:00
RuntimeCombatAttackStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatModeStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatTargetStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCommunicationStateTests.cs fix(ui,runtime): OP4 re-review residuals R1-R4 (coordinator pass) — OP4 CLOSED 2026-08-11 06:36:14 +02:00
RuntimeFellowshipStateTests.cs feat(runtime): FA4 -- fellowship roster enumeration + Social selection source 2026-08-12 04:40:19 +02:00
RuntimeFriendlyTargetQueryTests.cs fix(headless): FA6 — name-match the Recruit bot instead of nearest-any-player 2026-08-12 09:53:46 +02:00
RuntimeGameplayOwnershipTests.cs feat: secure trade with other players - wire, RuntimeTradeState, the 2026-08-14 11:49:13 +02:00
RuntimeHostileTargetQueryTests.cs feat(headless): complete deterministic bot command parity 2026-07-27 08:23:36 +02:00
RuntimeHouseStateTests.cs fix(ui): morning gate — House tab renders retail's TWO houseless lines, not one 2026-08-17 08:54:55 +02:00
RuntimeInteractionTransactionStateTests.cs fix(vendor): grand-gate findings — wire-truth container counts, the live split bar, arrival-gated use, prepend-order race 2026-08-08 14:03:57 +02:00
RuntimeInventoryStateTests.cs refactor(runtime): close canonical gameplay ownership 2026-07-26 09:48:51 +02:00
RuntimeLocalPlayerFirstEntryStateTests.cs feat(physics): C4 route 4b-3 — remote teleport + cell-less through the canonical placement 2026-08-04 16:00:10 +02:00
RuntimeLocalPlayerFrameControllerTests.cs fix(headless): #365 — collision-admission-open window drove the first-entry conductor into a permanent seal refusal 2026-08-10 11:34:36 +02:00
RuntimeLocalPlayerMovementStateTests.cs feat(ui): Campaign OP slice OP4 — the Character tab 2026-08-11 04:31:34 +02:00
RuntimeLocalPlayerPhysicsPublicationStateTests.cs fix(runtime): transient collision-seal failure no longer terminal for login (#357) 2026-08-09 12:32:53 +02:00
RuntimeSpellCastStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeTradeStateTests.cs feat: secure trade with other players - wire, RuntimeTradeState, the 2026-08-14 11:49:13 +02:00
RuntimeVendorLifecycleTests.cs fix(vendor): gate-findings pass — the X button HIDES like retail, clicks return, the dropdown scrolls, pyreal suffix, staged-tab slots 2026-08-08 10:29:39 +02:00
RuntimeVendorRangeQueryTests.cs fix(runtime/core): Slice 5.3 review corrections — retirement/transit close, per-unit pricing, guarded auto-close dispatch 2026-08-07 16:15:57 +02:00
TurbineChatMembershipGateTests.cs fix(chat): CH4 review fixes — allegiance ownership guard, house-abandon confirmation 2026-08-09 21:59:35 +02:00
VendorShopItemMaterializerTests.cs fix(vendor): evidence-based pass — max-first stack ceiling; the local player resolves never-animated MoveTo targets 2026-08-08 17:17:04 +02:00