Unify the toolbar shortcut manager with Runtime inventory state, route retail-ordered shortcut and spellbook command effects through the canonical owners, and make retained controllers borrow those exact instances. Remove the item-interaction transaction fallback and add graphical/no-window parity plus failure-safe terminal ownership-ledger coverage. Co-authored-by: Codex <codex@openai.com>
217 lines
8.2 KiB
C#
217 lines
8.2 KiB
C#
using AcDream.Core.Items;
|
|
using AcDream.Runtime.Entities;
|
|
using AcDream.Runtime.Gameplay;
|
|
|
|
namespace AcDream.Runtime.Tests.Gameplay;
|
|
|
|
public sealed class RuntimeInventoryStateTests
|
|
{
|
|
[Fact]
|
|
public void ViewBorrowsTransactionShortcutAndManaOwners()
|
|
{
|
|
using var entities = new RuntimeEntityObjectLifetime();
|
|
using var inventory = new RuntimeInventoryState(entities);
|
|
inventory.Shortcuts.Load(
|
|
[
|
|
new AcDream.Core.Items.ShortcutEntry(3, 0x80000001u, 0u),
|
|
new AcDream.Core.Items.ShortcutEntry(4, 0u, 42u),
|
|
]);
|
|
inventory.ItemMana.OnQueryItemManaResponse(
|
|
0x80000001u,
|
|
0.75f,
|
|
valid: true);
|
|
inventory.Transactions.IncrementBusyCount();
|
|
|
|
RuntimeInventoryStateSnapshot snapshot = inventory.View.Snapshot;
|
|
|
|
Assert.Equal(2, snapshot.ShortcutCount);
|
|
Assert.Equal(1, snapshot.ItemManaCount);
|
|
Assert.Equal(1, snapshot.BusyCount);
|
|
Assert.False(snapshot.CanBeginRequest);
|
|
Assert.True(inventory.View.TryGetShortcut(
|
|
3,
|
|
out RuntimeShortcutSnapshot itemShortcut));
|
|
Assert.Equal(
|
|
new RuntimeShortcutSnapshot(3, 0x80000001u, 0u),
|
|
itemShortcut);
|
|
Assert.True(inventory.View.TryGetShortcut(
|
|
4,
|
|
out RuntimeShortcutSnapshot spellShortcut));
|
|
Assert.Equal(new RuntimeShortcutSnapshot(4, 0u, 42u), spellShortcut);
|
|
Assert.True(inventory.View.TryGetItemMana(
|
|
itemShortcut.ObjectId,
|
|
out float fraction));
|
|
Assert.Equal(0.75f, fraction);
|
|
}
|
|
|
|
[Fact]
|
|
public void OwnsOneGameplayGraphOverExactEntityObjectTable()
|
|
{
|
|
using var entities = new RuntimeEntityObjectLifetime();
|
|
using var inventory = new RuntimeInventoryState(entities);
|
|
IReadOnlyList<ShortcutEntry> shortcuts =
|
|
[new ShortcutEntry(2, 0x50000001u, 0u)];
|
|
|
|
inventory.ExternalContainers.RequestOpen(0x70000001u);
|
|
inventory.ExternalContainers.ApplyViewContents(0x70000001u);
|
|
inventory.ItemMana.OnQueryItemManaResponse(0x50000001u, 0.75f, true);
|
|
inventory.Shortcuts.Load(shortcuts);
|
|
|
|
Assert.Same(entities.Objects, inventory.Objects);
|
|
Assert.Equal(0x70000001u, inventory.ExternalContainers.CurrentContainerId);
|
|
Assert.Equal(0.75f, inventory.ItemMana.GetManaPercent(0x50000001u));
|
|
Assert.Equal(shortcuts, inventory.Shortcuts.Items);
|
|
Assert.Equal(1, inventory.Shortcuts.Revision);
|
|
}
|
|
|
|
[Fact]
|
|
public void ResetOperationsClearOnlyTheirOwnedLifetimeGroup()
|
|
{
|
|
using var entities = new RuntimeEntityObjectLifetime();
|
|
using var inventory = new RuntimeInventoryState(entities);
|
|
inventory.ExternalContainers.RequestOpen(0x70000001u);
|
|
inventory.ExternalContainers.ApplyViewContents(0x70000001u);
|
|
inventory.ItemMana.OnQueryItemManaResponse(0x50000001u, 0.75f, true);
|
|
inventory.Shortcuts.Load([new ShortcutEntry(1, 2u, 3u)]);
|
|
inventory.Transactions.IncrementBusyCount();
|
|
|
|
inventory.ResetExternalContainer();
|
|
Assert.Equal(0u, inventory.ExternalContainers.CurrentContainerId);
|
|
Assert.True(inventory.ItemMana.HasMana(0x50000001u));
|
|
Assert.NotEmpty(inventory.Shortcuts.Items);
|
|
Assert.Equal(1, inventory.Transactions.BusyCount);
|
|
|
|
inventory.ResetTransactions();
|
|
inventory.ResetItemMana();
|
|
inventory.ResetPlayerSnapshots();
|
|
|
|
Assert.Equal(0, inventory.Transactions.BusyCount);
|
|
Assert.False(inventory.ItemMana.HasMana(0x50000001u));
|
|
Assert.Empty(inventory.Shortcuts.Items);
|
|
}
|
|
|
|
[Fact]
|
|
public void IndependentRuntimeInstancesNeverShareState()
|
|
{
|
|
using var firstEntities = new RuntimeEntityObjectLifetime();
|
|
using var secondEntities = new RuntimeEntityObjectLifetime();
|
|
using var first = new RuntimeInventoryState(firstEntities);
|
|
using var second = new RuntimeInventoryState(secondEntities);
|
|
|
|
first.Shortcuts.Load([new ShortcutEntry(1, 2u, 3u)]);
|
|
first.Transactions.IncrementBusyCount();
|
|
|
|
Assert.NotSame(first.Objects, second.Objects);
|
|
Assert.Single(first.Shortcuts.Items);
|
|
Assert.Empty(second.Shortcuts.Items);
|
|
Assert.Equal(1, first.Transactions.BusyCount);
|
|
Assert.Equal(0, second.Transactions.BusyCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void DisposeDetachesTransactionsAndClearsOwnedState()
|
|
{
|
|
using var entities = new RuntimeEntityObjectLifetime();
|
|
var inventory = new RuntimeInventoryState(entities);
|
|
inventory.ExternalContainers.RequestOpen(0x70000001u);
|
|
inventory.ExternalContainers.ApplyViewContents(0x70000001u);
|
|
inventory.ItemMana.OnQueryItemManaResponse(0x50000001u, 0.5f, true);
|
|
inventory.Shortcuts.Load([new ShortcutEntry(1, 2u, 3u)]);
|
|
|
|
inventory.Dispose();
|
|
inventory.Dispose();
|
|
|
|
Assert.True(inventory.IsDisposed);
|
|
Assert.True(inventory.Transactions.IsDisposed);
|
|
Assert.Equal(0u, inventory.ExternalContainers.CurrentContainerId);
|
|
Assert.False(inventory.ItemMana.HasMana(0x50000001u));
|
|
Assert.Empty(inventory.Shortcuts.Items);
|
|
}
|
|
|
|
[Fact]
|
|
public void DisposalFailureIsReportedAfterTerminalOwnerConvergence()
|
|
{
|
|
using var entities = new RuntimeEntityObjectLifetime();
|
|
var inventory = new RuntimeInventoryState(entities);
|
|
inventory.ExternalContainers.RequestOpen(0x70000001u);
|
|
inventory.ExternalContainers.ApplyViewContents(0x70000001u);
|
|
bool fail = true;
|
|
inventory.ExternalContainers.Changed += _ =>
|
|
{
|
|
if (fail)
|
|
{
|
|
fail = false;
|
|
throw new InvalidOperationException("transient");
|
|
}
|
|
};
|
|
|
|
Assert.Throws<AggregateException>(inventory.Dispose);
|
|
Assert.True(inventory.IsDisposed);
|
|
Assert.True(inventory.Transactions.IsDisposed);
|
|
inventory.Dispose();
|
|
|
|
Assert.True(inventory.CaptureOwnership().IsConverged);
|
|
Assert.Equal(0u, inventory.ExternalContainers.CurrentContainerId);
|
|
}
|
|
|
|
[Fact]
|
|
public void ShortcutCommandsUseRetailSendThenLocalOrderOnTheExactOwner()
|
|
{
|
|
using var entities = new RuntimeEntityObjectLifetime();
|
|
using var inventory = new RuntimeInventoryState(entities);
|
|
var order = new List<string>();
|
|
inventory.Shortcuts.Changed += () => order.Add("local");
|
|
var entry = new ShortcutEntry(3, 0x80000001u, 0u);
|
|
|
|
Assert.True(inventory.TryAddShortcut(
|
|
entry,
|
|
() =>
|
|
{
|
|
Assert.Null(inventory.Shortcuts.GetEntry(3));
|
|
order.Add("send");
|
|
}));
|
|
Assert.Equal(["send", "local"], order);
|
|
Assert.Equal(entry, inventory.Shortcuts.GetEntry(3));
|
|
|
|
order.Clear();
|
|
Assert.True(inventory.TryRemoveShortcut(
|
|
3,
|
|
() =>
|
|
{
|
|
Assert.Equal(entry, inventory.Shortcuts.GetEntry(3));
|
|
order.Add("send");
|
|
}));
|
|
Assert.Equal(["send", "local"], order);
|
|
Assert.Null(inventory.Shortcuts.GetEntry(3));
|
|
|
|
Assert.Throws<InvalidOperationException>(
|
|
() => inventory.TryAddShortcut(
|
|
entry,
|
|
() => throw new InvalidOperationException("transport")));
|
|
Assert.Equal(entry, inventory.Shortcuts.GetEntry(3));
|
|
|
|
int sends = 0;
|
|
Assert.False(inventory.TryAddShortcut(
|
|
new ShortcutEntry(ShortcutStore.SlotCount, 1u, 0u),
|
|
() => sends++));
|
|
Assert.False(inventory.TryRemoveShortcut(-1, () => sends++));
|
|
Assert.Equal(0, sends);
|
|
}
|
|
|
|
[Fact]
|
|
public void DisposalRetiresShortcutObserversAndTransactionSubscriptions()
|
|
{
|
|
using var entities = new RuntimeEntityObjectLifetime();
|
|
var inventory = new RuntimeInventoryState(entities);
|
|
inventory.Shortcuts.Changed += static () => { };
|
|
inventory.Shortcuts.Load([new ShortcutEntry(1, 2u, 3u)]);
|
|
|
|
inventory.Dispose();
|
|
|
|
Assert.True(inventory.IsDisposed);
|
|
Assert.True(inventory.Shortcuts.IsDisposed);
|
|
Assert.True(inventory.Transactions.IsDisposed);
|
|
Assert.Equal(0, inventory.Shortcuts.SubscriberCount);
|
|
Assert.Empty(inventory.Shortcuts.Items);
|
|
}
|
|
}
|