Commit 2 deleted the GL rendering backend's implementations; this step removes the package references and shader vocabulary they leave behind, so nothing in the App project still spells Silk.NET.OpenGL. Silk.NET.OpenGL and Silk.NET.OpenGL.Extensions.ARB are dropped from AcDream.App.csproj. Chorizite.Core stays — the audit is NOT clean: its Render.Enums (TextureFormat, BufferUsage) and Lib.BoundingBox types are used directly and extensively across the Wb texture/mesh pipeline, independent of the deleted GL IUniformBuffer implementers the package comment used to cite. The stale comment is corrected in place. IMeshPipelineDevice.Gl is removed along with the GL? gl parameter threaded through WbMeshAdapter's four constructors, WorldRenderComposition's CreateMeshAdapter, and VulkanMeshPipelineDevice's Gl => null implementation — nothing read any of them once the legacy per-mesh upload bodies were gone (confirmed by grep: the sole non-doc-comment hit was a test assertion). While in WbMeshAdapter.Dispose(), found and fixed a real bug along the way: its teardown still pattern-matched the deleted GL GpuFrameFlightController to decide whether to wait for submitted work, which VulkanFrameFlightController replaced at slice V6a without this site being updated — so the wait had been silently dead on every Vulkan run since then. Retargeted to VulkanFrameFlightController, which carries the same WaitForSubmittedWork(). The GL pixel-format vocabulary (Silk.NET.OpenGL.PixelFormat/PixelType) that WorldTextureArray/TextureFormatExtensions/TextureAtlasManager used for upload validation is replaced by AcDream.Content's existing Silk.NET-free UploadPixelFormat/UploadPixelType enums (added at MP1a to keep the bake tool GL-free); two new members (Rgb, Red, Float) extend that enum with their GL ABI constants to cover the full vocabulary WorldTextureArray needs, since MP1a's original set only covered what the extractor itself emits. ObjectMeshManager's App-boundary cast `(Silk.NET.OpenGL.PixelFormat?)batch.UploadPixelFormat` becomes a direct pass-through now that both sides share the type. GpuBindingModel.StorageTextureTable (the GL-only binding=9 emulation of the Vulkan texture table) is deleted and StorageBindingCount drops from 10 to 9; the descriptor-set-layout code that builds from that count (VulkanPipelineLayouts, VulkanFrameBindings) is untouched and just allocates one fewer always-dummy-seeded, always-unused binding. Several fully dead GL-only classes came along for the ride, confirmed by zero construction sites: SilkFramebufferViewportTarget (NullFramebufferViewportTarget is the sole production IFramebufferViewportTarget), SilkRenderGlStateReader (NullRenderGlStateReader.Instance is the sole IRenderGlStateReader), RuntimeRenderFrameClearPhase (VulkanRenderFrameClearPhase is the sole IRenderFrameClearPhase, expressing the same atmosphere-clear logic as a pass load-op instead), and GpuFrameTimer plus FrameProfiler's GL-owning FrameBoundary(GL) overload and BeginGpuFrame/EndGpuFrame bracket (RecordGpuSample is the only GPU-timing path any backend uses now — the ACDREAM_WB_DIAG nested-query exclusion these existed for no longer applies, since WbDrawDispatcher's own diagnostic GPU sampling already moved to the device's Vulkan timer pool). GpuFrameFlightController itself stays (never constructed with a real fence API in production, but its retirement-ledger/serial-ring logic is backend-neutral and still covered by its own unit tests) — only its GL-specific parts (the public GL constructor overload, SilkGpuFenceApi) are deleted, since removing the whole class would mean restructuring the frozen Slice-8 composition shape's GpuFrameFlightController? threading, which is out of this commit's scope. TextureParameters.cs and BufferUsageExtensions.cs (zero callers each) are deleted outright. common.glsl is deleted: nothing in the actual Vulkan .spv build reads it. tools/ShaderCompiler/Program.cs compiles each .vert/.frag pair directly and tools/ShaderCompiler/VulkanGlslPreamble.cs injects its own complete self-contained preamble per file; common.glsl's textual concatenation was exclusively Shader.cs's GL-only mechanism, deleted at Commit 2. The five shader files that named it in comments (mesh_modern.vert, particle.vert, particle.frag, sky.frag, terrain_modern.frag) are corrected to point at VulkanGlslPreamble.cs instead. mesh.vert/mesh.frag — the pre-N.5 legacy shader pair the mandatory modern path already made unreachable, with zero C# consumers and no compiled .spv — are deleted too. Regenerated via tools/compile-shaders.ps1: 9/9 remaining shader pairs compile (previously 9/10, with mesh the sole failure — the VulkanShaderManifestTests doc comment's "nine of ten are not Vulkan-expressible" was already stale before this commit). Test fallout: dead-subject test methods/files are deleted rather than patched (TextRendererFailureSafetyTests.cs, ClipFrameUploadTests.cs, GpuResourceRetirementTransactionTests.cs's GL queue tests, one WorldRenderDiagnosticsTests source-order test, one RenderFrameResourceControllerTests clear-phase-order test); tests whose subject moved or was renamed are updated in place rather than deleted (GpuContractTests, VulkanCapabilityGateTests, MeshPipelineDeviceSeamTests' pinned seven-member surface now reads six, ParticleBindlessInstanceTests' cross-dialect check now covers the one surviving dialect, WbMeshAdapterTests' misleadingly-named null-gl test — gpuDevice was always the parameter that actually threw). Build: `dotnet build AcDream.slnx -c Release` — 0 warnings, 0 errors, with the Silk.NET.OpenGL/.Extensions.ARB package references physically removed from the csproj (not just unreferenced in code). Tests: full-solution `dotnet test` green across every project. Zero remaining `using Silk.NET.OpenGL` anywhere in src/ or tests/. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
89 lines
4.3 KiB
C#
89 lines
4.3 KiB
C#
using System.Reflection;
|
|
using System.Runtime.InteropServices;
|
|
using AcDream.App.Rendering;
|
|
|
|
namespace AcDream.App.Tests.Rendering;
|
|
|
|
public sealed class ParticleBindlessInstanceTests
|
|
{
|
|
[Fact]
|
|
public void BillboardGpuInstance_MatchesVertexAttributeAbi()
|
|
{
|
|
// Campaign V slice V2c (2026-07-27): TextureHandleLow/High (the split
|
|
// halves of a raw 64-bit ARB_bindless_texture handle, 8 bytes) became
|
|
// one TextureIndex (a binding=9 handle-table slot, 4 bytes), so the
|
|
// struct shrank by 4 bytes; TextureIndex keeps TextureHandleLow's
|
|
// former offset (64 — right after the four vec4 fields).
|
|
Assert.Equal(68, Marshal.SizeOf<ParticleRenderer.BillboardGpuInstance>());
|
|
Assert.Equal(
|
|
new IntPtr(64),
|
|
Marshal.OffsetOf<ParticleRenderer.BillboardGpuInstance>(
|
|
nameof(ParticleRenderer.BillboardGpuInstance.TextureIndex)));
|
|
}
|
|
|
|
[Fact]
|
|
public void BillboardShaders_ConsumeOneBindlessTextureHandlePerInstance()
|
|
{
|
|
string shadersDirectory = Path.Combine(
|
|
AppContext.BaseDirectory,
|
|
"Rendering",
|
|
"Shaders");
|
|
string vertex = File.ReadAllText(Path.Combine(shadersDirectory, "particle.vert"));
|
|
string fragment = File.ReadAllText(Path.Combine(shadersDirectory, "particle.frag"));
|
|
|
|
// Campaign V slice V2c: the per-instance attribute carries a binding=9
|
|
// table slot, not the raw handle.
|
|
//
|
|
// Campaign V slice V6e: the SLOT is what crosses the stage boundary now,
|
|
// and the fragment stage does the lookup — a varying cannot carry a
|
|
// Vulkan descriptor. The untextured particle is spelled by the reserved
|
|
// index rather than by a null handle, because Vulkan's descriptor array
|
|
// cannot be asked whether an element was ever written.
|
|
Assert.Contains("layout(location = 6) in uint aTextureIndex;", vertex);
|
|
Assert.Contains("flat out uint vTextureIndex;", vertex);
|
|
Assert.Contains("vTextureIndex = aTextureIndex;", vertex);
|
|
Assert.Contains("#extension GL_ARB_bindless_texture : require", fragment);
|
|
Assert.Contains("flat in uint vTextureIndex;", fragment);
|
|
Assert.Contains("ACDREAM_SAMPLE_ARRAY(vTextureIndex, vec3(vTex, 0.0))", fragment);
|
|
Assert.Contains("vTextureIndex != ACDREAM_TEXTURE_NONE", fragment);
|
|
Assert.DoesNotContain("uniform sampler2D uParticleTexture", fragment);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Campaign V slice V6e: "this particle has no texture" is a reserved index
|
|
/// rather than a null handle, and that value is written in two places — the
|
|
/// CPU that produces it and the Vulkan preamble that tests it in the shader.
|
|
/// Before Campaign V slice V11 deleted the GL arm there was a third copy in
|
|
/// common.glsl, which this test also cross-checked; two copies of a magic
|
|
/// number is still a drift waiting to happen, and its failure mode is
|
|
/// silent: a particle would sample slot 0xFFFFFFFF instead of drawing the
|
|
/// procedural blob.
|
|
/// </summary>
|
|
[Fact]
|
|
public void TheReservedNoTextureSlotAgreesBetweenCpuAndTheVulkanPreamble()
|
|
{
|
|
const string literal = "0xFFFFFFFF";
|
|
|
|
object? cpuValue = typeof(ParticleRenderer)
|
|
.GetField("NoTextureSlot", BindingFlags.NonPublic | BindingFlags.Static)
|
|
?.GetRawConstantValue();
|
|
Assert.Equal(0xFFFFFFFFu, Assert.IsType<uint>(cpuValue));
|
|
|
|
// The Vulkan half is injected by the offline compiler at compile time,
|
|
// not carried in a shared GLSL source, so it is a separate declaration
|
|
// that has to say the same thing.
|
|
string preamble = File.ReadAllText(Path.Combine(
|
|
RepositoryRoot(), "tools", "ShaderCompiler", "VulkanGlslPreamble.cs"));
|
|
Assert.Contains($"#define ACDREAM_TEXTURE_NONE {literal}u", preamble);
|
|
}
|
|
|
|
private static string RepositoryRoot()
|
|
{
|
|
var directory = new DirectoryInfo(AppContext.BaseDirectory);
|
|
while (directory is not null && !File.Exists(Path.Combine(directory.FullName, "AcDream.slnx")))
|
|
directory = directory.Parent;
|
|
return directory?.FullName
|
|
?? throw new InvalidOperationException(
|
|
"Could not locate the repository root from the test binary.");
|
|
}
|
|
}
|