26feba8186
Opus review of LA3 returned FIX FIRST; this addresses every finding in
scope (F1-F5, F7-F12; F6 CI-lane addition excluded per instructions):
- F1 (CRITICAL): SessionProcessSettings.Paths is now nullable and left
null by SessionConfigComposer unless a caller supplies overrides, so
the JSON key is entirely absent instead of "paths":{} — the App-side
loader's strict UnmappedMemberHandling.Disallow would otherwise reject
every gui/guiSelect session-config document at load.
- F2: added SessionConfigComposer.ComposeProbe and a nullable
SessionDescriptor.Mode field ("probe", omitted for normal play) per
the pinned contract — no character/policy/plugins/loginCommands.
- F3: LauncherProcessSupervisor.Stop now tries
ILauncherChildProcess.TryRequestGracefulStop (Linux: libc SIGINT via
LibraryImport, K4-proven graceful headless logout) before
CloseMainWindow. Windows has no reliable no-window-console equivalent
today; filed docs/ISSUES.md #397 with the CREATE_NEW_PROCESS_GROUP +
CTRL_BREAK fix direction. Stop()'s blocking-timeout contract is now
documented for LA4.
- F4: LauncherProfileStore.Save chmods the Linux temp file to 0600
immediately after creation, before any credential is serialized;
failure paths and Load() clean up a stale .tmp.
- F5: added LauncherCoreDependencyBoundaryTests asserting Launcher.Core
references exactly AcDream.Platform and no packages.
- F7: StatusEventParser.Parse no longer throws on a whitespace/null
line; StatusFileTailer.ReadNewEvents swallows the File.Exists/open
TOCTOU window (FileNotFoundException/DirectoryNotFoundException/
IOException) instead of throwing.
- F8: Start() now kills (entire process tree) and disposes a child that
started successfully but failed while being fed its stdin password,
instead of orphaning it.
- F9: SetState is monotonic — once Exited, no later transition applies
or fires StateChanged, closing a Start()-path race where a
synchronously-exiting child could be "resurrected" to Running.
- F10: CharacterIdFormat.TryParse now requires the "0x" prefix (an
unprefixed hand-typed decimal id is also valid hex and was silently
misread); a parsed id of 0 is treated as unusable and falls back to
the name selector; LauncherProfileStore.MergeRoster normalizes both
sides through TryParse/ToHexString instead of raw string equality, so
a legacy unprefixed-hex row self-heals via name match instead of
duplicating.
- F11: StatusCharacterEntry.SecondsGreyedOut is now uint, matching
CharacterRosterEntry and the host writer.
- F12: added MalformedStatusEvent, returned for a recognized `e` whose
payload doesn't match its shape, distinguished from UnknownStatusEvent
(an unrecognized `e`).
AllowUnsafeBlocks was added to AcDream.Launcher.Core.csproj — required
by the LibraryImport source generator's function-pointer marshalling
stub for F3's Linux SIGINT P/Invoke.
Verification: dotnet build AcDream.slnx -c Release green (0 errors);
dotnet test tests/AcDream.Launcher.Core.Tests -c Release green at 94/94
on native Windows and under WSL (Ubuntu, verified across multiple runs
for the timing-sensitive SIGINT/sharing-violation tests, no flakes
observed).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
50 lines
1.7 KiB
C#
50 lines
1.7 KiB
C#
using AcDream.Launcher.Core.Profiles;
|
|
|
|
namespace AcDream.Launcher.Core.Tests.Profiles;
|
|
|
|
public sealed class CharacterIdFormatTests
|
|
{
|
|
[Fact]
|
|
public void ToHexStringFormatsEightDigitUppercaseWithPrefix()
|
|
{
|
|
Assert.Equal("0x5000000A", CharacterIdFormat.ToHexString(0x5000000Au));
|
|
Assert.Equal("0x00000001", CharacterIdFormat.ToHexString(1u));
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("0x5000000A", 0x5000000Au)]
|
|
[InlineData("0x5000000a", 0x5000000Au)]
|
|
[InlineData("0X5000000A", 0x5000000Au)]
|
|
public void TryParseAcceptsThe0xPrefixCaseInsensitively(string text, uint expected)
|
|
{
|
|
Assert.True(CharacterIdFormat.TryParse(text, out uint id));
|
|
Assert.Equal(expected, id);
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(null)]
|
|
[InlineData("")]
|
|
[InlineData(" ")]
|
|
[InlineData("not-hex")]
|
|
[InlineData("5000000A")]
|
|
[InlineData("12345678")]
|
|
public void TryParseRejectsNullEmptyNonHexOrAnUnprefixedString(string? text)
|
|
{
|
|
// "5000000A"/"12345678" are all-hex-digit strings that would
|
|
// parse fine as hex WITHOUT the "0x" prefix — review finding F10
|
|
// requires the prefix precisely so a hand-typed decimal id (which
|
|
// is ALSO syntactically valid hex) is never silently
|
|
// misinterpreted as one.
|
|
Assert.False(CharacterIdFormat.TryParse(text, out uint id));
|
|
Assert.Equal(0u, id);
|
|
}
|
|
|
|
[Fact]
|
|
public void RoundTripsThroughToHexStringAndTryParse()
|
|
{
|
|
const uint original = 0x5000000Au;
|
|
string text = CharacterIdFormat.ToHexString(original);
|
|
Assert.True(CharacterIdFormat.TryParse(text, out uint parsed));
|
|
Assert.Equal(original, parsed);
|
|
}
|
|
}
|