Owner direction 2026-09-06: the owner visually accepted all three connected
gates from the plugin-shelf/DAT-icon work — the movable plugin shelf
(Slice A), the DAT icon markup (Slice B), and the retained-UI outline-order
fix (761a7519f). With that gate passed, the Smoke plugin's job as the gate
artifact is done, so it is deleted outright rather than merely hidden:
src/AcDream.Plugins.Smoke/ (SmokePlugin.cs, SmokeIconPanel.cs, csproj, lock
files).
Reference sites cleaned:
- AcDream.slnx: removed the project entry.
- src/AcDream.App/AcDream.App.csproj: removed the Smoke ProjectReference and
the CopySmokePluginToBuildOutput/CopySmokePluginToPublishOutput targets;
the MossTank equivalents are untouched.
- .github/workflows/headless-portability.yml: the Linux package-contract
step no longer asserts a Smoke plugin.dll/plugin.json pair — repointed at
MossTank's, since the step's job was to prove the plugin-copy packaging
mechanism works end to end, not specifically to prove Smoke.
- tests/AcDream.Core.Tests/Plugins/PluginManifestTests.cs: the inline JSON
fixture used Smoke's manifest values as arbitrary test data; swapped for
MossTank's so the parser test still proves the same thing.
- tests/AcDream.App.Tests/Rendering/LinuxPlatformBoundaryTests.cs: the
shipped-plugin-copy shape test counted 4 GetTargetPath targets (Smoke +
MossTank, build + publish); now 2 (MossTank only).
- tests/AcDream.App.Tests/Plugins/AppAutomationSurfaceIconInstalledDatTests.cs:
reworded a doc comment that named the now-deleted SmokeIconPanel.
- README.md, docs/plugin-ui-markup.md: dropped Smoke-specific mentions,
kept the icon markup example/grammar (now citing MossTank's own real
IconSurfaceId).
- docs/plans/2026-09-06-plugin-shelf-and-dat-icons.md: recorded the owner's
2026-09-06 acceptance and the Smoke removal in the review ledger; deleted
the now-moot "before shipment" Smoke-in-release-zip warning.
- docs/reviews/coverage-ledger.md, docs/reviews/findings-ledger.md: left
untouched — both are frozen audit snapshots ("complete for baseline
<hash>"), so their Smoke rows are historical record, not live claims.
- docs/ISSUES.md: left untouched — its Smoke mentions are inside closed
issue #193's historical write-up of a past investigation.
MossTank plugin shelf icon: MossTankPlugin.cs's PluginPanelDescriptor now
sets IconSurfaceId = 0x06002C41 (IconText = "MT" remains the fallback).
Verified against the installed retail DAT with a new InstalledDat-lane test,
tests/AcDream.App.Tests/UI/MossTankIconInstalledDatTests.cs, mirroring
RetailMarkupIconResolverInstalledDatTests's convention: confirms the id is a
real Portal/HighRes RenderSurface and that RetailMarkupIconResolver.ResolveDid
returns a non-zero texture for it.
Verified: dotnet build AcDream.slnx -c Release green; a stale
plugins/AcDream.Plugins.Smoke output folder from a prior build was deleted
and a fresh build does not recreate it. Full App suite: 7,363 passed / 97
skipped / 36 failed (was 7,362/97/36) — the failing set is unchanged and
none are plugin-related; the one new pass is the MossTank DAT-icon test.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
108 lines
3 KiB
C#
108 lines
3 KiB
C#
using AcDream.Core.Plugins;
|
|
|
|
namespace AcDream.Core.Tests.Plugins;
|
|
|
|
public class PluginManifestTests
|
|
{
|
|
[Fact]
|
|
public void Parse_ValidManifest_ReturnsManifest()
|
|
{
|
|
const string json = """
|
|
{
|
|
"id": "acdream.mosstank",
|
|
"displayName": "MossTank",
|
|
"version": "0.1.0",
|
|
"entryDll": "AcDream.Plugins.MossTank.dll",
|
|
"apiVersion": 1
|
|
}
|
|
""";
|
|
|
|
var manifest = PluginManifest.Parse(json);
|
|
|
|
Assert.Equal("acdream.mosstank", manifest.Id);
|
|
Assert.Equal("MossTank", manifest.DisplayName);
|
|
Assert.Equal("0.1.0", manifest.Version);
|
|
Assert.Equal("AcDream.Plugins.MossTank.dll", manifest.EntryDll);
|
|
Assert.Equal(1, manifest.ApiVersion);
|
|
Assert.Equal([PluginKind.Gameplay], manifest.Kinds);
|
|
}
|
|
|
|
[Fact]
|
|
public void Parse_MissingRequiredField_Throws()
|
|
{
|
|
const string json = """
|
|
{ "id": "x", "version": "0.1.0", "entryDll": "x.dll", "apiVersion": 1 }
|
|
""";
|
|
|
|
var ex = Assert.Throws<PluginManifestException>(() => PluginManifest.Parse(json));
|
|
Assert.Equal("missing required field: displayName", ex.Message);
|
|
}
|
|
|
|
[Fact]
|
|
public void Parse_MalformedJson_Throws()
|
|
{
|
|
Assert.Throws<PluginManifestException>(() => PluginManifest.Parse("{ not json"));
|
|
}
|
|
|
|
[Fact]
|
|
public void Parse_EmptyDependencies_DefaultsToEmptyList()
|
|
{
|
|
const string json = """
|
|
{
|
|
"id": "x",
|
|
"displayName": "X",
|
|
"version": "0.1.0",
|
|
"entryDll": "x.dll",
|
|
"apiVersion": 1
|
|
}
|
|
""";
|
|
|
|
var manifest = PluginManifest.Parse(json);
|
|
Assert.Empty(manifest.Dependencies);
|
|
}
|
|
|
|
[Fact]
|
|
public void Parse_RenderPackAndHybridKinds_AreExplicitAndDeduplicated()
|
|
{
|
|
const string json = """
|
|
{
|
|
"id": "x",
|
|
"displayName": "X",
|
|
"version": "1.0.0",
|
|
"entryDll": "x.dll",
|
|
"apiVersion": 1,
|
|
"kinds": ["renderPack", "gameplay", "RENDERPACK"]
|
|
}
|
|
""";
|
|
|
|
PluginManifest manifest = PluginManifest.Parse(json);
|
|
|
|
Assert.Equal(
|
|
[PluginKind.RenderPack, PluginKind.Gameplay],
|
|
manifest.Kinds);
|
|
Assert.True(manifest.Declares(PluginKind.RenderPack));
|
|
Assert.True(manifest.Declares(PluginKind.Gameplay));
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData("[]", "kinds must contain at least one entry")]
|
|
[InlineData("[\"nativeCode\"]", "unknown plugin kind: nativeCode")]
|
|
public void Parse_InvalidKinds_Throws(string kindsJson, string expected)
|
|
{
|
|
string json = $$"""
|
|
{
|
|
"id": "x",
|
|
"displayName": "X",
|
|
"version": "1.0.0",
|
|
"entryDll": "x.dll",
|
|
"apiVersion": 1,
|
|
"kinds": {{kindsJson}}
|
|
}
|
|
""";
|
|
|
|
PluginManifestException error = Assert.Throws<PluginManifestException>(
|
|
() => PluginManifest.Parse(json));
|
|
|
|
Assert.Equal(expected, error.Message);
|
|
}
|
|
}
|