acdream/tests/AcDream.App.Tests/UI/Layout/CharacterStatControllerTests.cs
Erik ed652ed8ad feat(ui): Campaign CT slice CT4 — header identity block retail-exact
Retires the rest of AP-109's UI half: the character panel's Name/Heritage/
PkStatus/Level header identity block is now live and DAT-faithful on both
Attributes and Skills pages (verified: CharacterStatController.Bind already
scopes Label/LabelAuthoredColor to the ONE physically-visible page container,
so both tabs share the same bound widgets).

- Name/Heritage/PkStatus/Level switch from hand-picked Body/Gold runtime
  colors to the widget's own authored DefaultColor (LabelAuthoredColor) —
  CT1's live-DAT pin (HeaderElements_AuthorExpectedFontsAndColors) confirmed
  all four already carry the correct FontColor (white/white/white/pale-gold
  with Outline); the former "runtime color, dat carries none" comment was
  false.
- PkStatus resolves through StringTable 0x23000001 by key
  (ID_StatManagement_Header_PKStatus_PK/_PKL/_NPK) with a bitwise
  IsPK/IsPKLite test (gmStatManagementUI::UpdatePKStatus @0x004F00A0) instead
  of the prior exact-equality switch, which silently dropped combined-flag
  PlayerKillerStatus values. Live-DAT-verified strings: "Player Killer" /
  "Player Killer Lite" / "Non-Player Killer" (new InstalledDat pin
  PkStatusKeys_ResolveExpectedAuthoredStrings).
- Level shows "%d"-formatted InqInt(0x19) or the PE-recovered literal "???"
  when absent (CharacterSheet.Level is now int?).
- Heritage line appends CT2/CT3's resolved RuntimeCharacterTitleState
  display title through CharacterTitleResolver, refreshing live on both
  TableReplaced (0x0029) and DisplayTitleChanged (0x002B) —
  CharacterSheetProvider's ChangeBinding now subscribes to both.
- Name-line ruling: ships the PLAIN-NAME case only. Retail's allegiance
  rank-title prefix (AllegianceData::GetFullName @0x005B6950 ->
  AllegianceSystem::GetTitle @0x005B8DD0) needs a ~200-string, 22-function
  heritage x gender table (verbatim decomp literals, e.g.
  GetAluvianMaleTitle @0x005B7BC0's Yeoman/Baronet/.../High King) judged out
  of reasonable size for this slice. RuntimeAllegianceState already carries
  the local player's own rank; only the string table is missing. Registered,
  not silently omitted.
- Luminance pair (0x100005C5/0x100005C6): CharacterSheet.AvailableLuminance/
  MaximumLuminance (PropertyInt64 6/7) already flow generically through both
  the PlayerDescription snapshot and the live 0x02CF private-update parsers
  (no wiring gap). The retail show/hide gate (Level >= 200 &&
  MaximumLuminance != 0, UpdateExperience @0x004F0A70) is wired and toggles
  Visible on both elements every sheet refresh; the exact caption/value text
  could not be recovered this slice (retail's SetText source resolves
  through a Binary-Ninja-mislabeled data pointer, not a StringTable key — a
  DAT string-table sweep found no match), so content stays unbound rather
  than guessed.
- AP-109 narrowed accordingly (register row amended in the same commit).

Tests: CharacterStatControllerTests (heritage composition + live title
update, name stays plain, level int/"???" with authored — not constant —
color across 3 cases, PK line shows resolved text in authored color across
3 statuses, luminance visibility across 5 level/luminance combinations) and
CharacterSheetProviderTests (PK key-by-status resolution including a
combined-flag case, no-resolver leaves PkStatus null, Level null-vs-present,
title resolution + live refresh on both title events + unsubscribe-on-
dispose, luminance Int64 read-through). Full hermetic solution suite green
under Release (0 failures across all 14 test projects); InstalledDat pins
green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-25 00:02:11 +02:00

2311 lines
91 KiB
C#
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

using AcDream.App.UI;
using AcDream.App.UI.Layout;
using System.Numerics;
namespace AcDream.App.Tests.UI.Layout;
/// <summary>
/// Unit tests for <see cref="CharacterStatController"/> — the Attributes-tab controller that
/// binds the REAL importer-mounted header + 9-row list + footer elements (no created overlay).
/// Pure data wiring against fake layouts; no dats, no GL.
///
/// <para>Pass 1 tests verify header/XP meter/attribute list/footer State-A binding.
/// Pass 2 tests verify: (a) row click → selection toggle; (b) footer State-B content;
/// (c) raise-button affordability; (d) tab button states.</para>
/// </summary>
public class CharacterStatControllerTests
{
// ── Header labels bind to the sheet ──────────────────────────────────────
[Fact]
public void Bind_SetsNameLabel()
{
var name = new UiText();
var layout = Fake((CharacterStatController.NameId, name));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("Studio Player", name.LinesProvider()[0].Text);
}
[Fact]
public void Bind_SetsLevelLabel()
{
var level = new UiText();
var layout = Fake((CharacterStatController.LevelId, level));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("126", level.LinesProvider()[0].Text);
}
[Fact]
public void Bind_SetsHeritageAndPkLabels()
{
var heritage = new UiText();
var pk = new UiText();
var layout = Fake((CharacterStatController.HeritageId, heritage),
(CharacterStatController.PkStatusId, pk));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("Female Aluvian Adventurer", heritage.LinesProvider()[0].Text);
Assert.Equal("Non-Player Killer", pk.LinesProvider()[0].Text);
}
[Fact]
public void Bind_WindowChromeButton_InvokesCloseCallback()
{
var close = MakeButton(WindowChromeController.CharacterCloseButtonId);
var layout = Fake((WindowChromeController.CharacterCloseButtonId, close));
int closes = 0;
CharacterStatController.Bind(layout, SampleData.SampleCharacter, onClose: () => closes++);
close.OnEvent(new UiEvent(0u, close, UiEventType.Click));
Assert.Equal(1, closes);
}
[Fact]
public void CharacterIdentityText_StatHeaderLine_ComposesRetailGenderHeritageTitle()
{
var sheet = new CharacterSheet
{
Gender = "Female",
Heritage = "Aluvian",
Title = "the Adventurer",
};
Assert.Equal("Female Aluvian Adventurer", CharacterIdentityText.StatHeaderLine(sheet));
}
[Theory]
[InlineData(1, "Male")]
[InlineData(2, "Female")]
[InlineData(0, null)]
public void CharacterIdentityText_GenderDisplayName_UsesRetailEnum(int value, string? expected)
=> Assert.Equal(expected, CharacterIdentityText.GenderDisplayName(value));
[Theory]
[InlineData(1, "Aluvian")]
[InlineData(2, "Gharu'ndim")]
[InlineData(5, "Umbraen")]
[InlineData(13, "Olthoi")]
[InlineData(99, null)]
public void CharacterIdentityText_HeritageGroupDisplayName_UsesRetailEnum(int value, string? expected)
=> Assert.Equal(expected, CharacterIdentityText.HeritageGroupDisplayName(value));
[Fact]
public void Bind_HeaderElements_UseVisibleAttributesPageWhenIdsAreDuplicated()
{
var root = new UiPanel { Width = 300, Height = 600 };
var attrPage = MakeDatElement(CharacterStatController.AttributesPageId, top: 25, width: 300, height: 575);
var hiddenPage = MakeDatElement(CharacterStatController.SkillsPageId, top: 25, width: 300, height: 575);
var visibleName = new UiText { ElementId = CharacterStatController.NameId };
var hiddenName = new UiText { ElementId = CharacterStatController.NameId };
var visibleHeritage = new UiText { ElementId = CharacterStatController.HeritageId };
var hiddenHeritage = new UiText { ElementId = CharacterStatController.HeritageId };
var visibleLevel = new UiText { ElementId = CharacterStatController.LevelId };
var hiddenLevel = new UiText { ElementId = CharacterStatController.LevelId };
var visibleTotalXp = new UiText { ElementId = CharacterStatController.TotalXpId };
var hiddenTotalXp = new UiText { ElementId = CharacterStatController.TotalXpId };
var visibleTotalXpLabel = new UiText { ElementId = CharacterStatController.TotalXpLabelId };
var hiddenTotalXpLabel = new UiText { ElementId = CharacterStatController.TotalXpLabelId };
var visibleMeter = new UiMeter { ElementId = CharacterStatController.XpMeterId };
var hiddenMeter = new UiMeter { ElementId = CharacterStatController.XpMeterId };
var visibleXpNext = new UiText { ElementId = CharacterStatController.XpNextValueId };
var hiddenXpNext = new UiText { ElementId = CharacterStatController.XpNextValueId };
visibleMeter.AddChild(visibleXpNext);
hiddenMeter.AddChild(hiddenXpNext);
attrPage.AddChild(visibleName);
attrPage.AddChild(visibleHeritage);
attrPage.AddChild(visibleLevel);
attrPage.AddChild(visibleTotalXpLabel);
attrPage.AddChild(visibleTotalXp);
attrPage.AddChild(visibleMeter);
hiddenPage.AddChild(hiddenName);
hiddenPage.AddChild(hiddenHeritage);
hiddenPage.AddChild(hiddenLevel);
hiddenPage.AddChild(hiddenTotalXpLabel);
hiddenPage.AddChild(hiddenTotalXp);
hiddenPage.AddChild(hiddenMeter);
root.AddChild(attrPage);
root.AddChild(hiddenPage);
var layout = new ImportedLayout(root, new Dictionary<uint, UiElement>
{
[CharacterStatController.NameId] = hiddenName,
[CharacterStatController.HeritageId] = hiddenHeritage,
[CharacterStatController.LevelId] = hiddenLevel,
[CharacterStatController.TotalXpLabelId] = hiddenTotalXpLabel,
[CharacterStatController.TotalXpId] = hiddenTotalXp,
[CharacterStatController.XpMeterId] = hiddenMeter,
[CharacterStatController.XpNextValueId] = hiddenXpNext,
});
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("Studio Player", visibleName.LinesProvider()[0].Text);
Assert.Equal("Female Aluvian Adventurer", visibleHeritage.LinesProvider()[0].Text);
Assert.Equal("126", visibleLevel.LinesProvider()[0].Text);
Assert.Equal("Total Experience (XP):", visibleTotalXpLabel.LinesProvider()[0].Text);
Assert.Equal((1_250_000_000L).ToString("N0"), visibleTotalXp.LinesProvider()[0].Text);
Assert.Equal((42_000_000L).ToString("N0"), visibleXpNext.LinesProvider()[0].Text);
Assert.Empty(hiddenName.LinesProvider());
Assert.Empty(hiddenXpNext.LinesProvider());
}
// ── Campaign CT slice CT4: header identity block ───────────────────────
/// <summary>CT4 item 2: the heritage line composes Gender + Heritage +
/// " " + the resolved display title (CharacterIdentityText.StatHeaderLine),
/// and — because the label's <c>text()</c> provider re-reads <c>data()</c>
/// on every draw — reflects a live title change with no rebind, exactly
/// how <c>CharacterSheetProvider</c>'s own <c>DisplayTitleChanged</c>/
/// <c>TableReplaced</c> subscription drives a real sheet rebuild in
/// production.</summary>
[Fact]
public void Bind_HeritageLine_ComposesGenderHeritageTitle_AndUpdatesLiveOnDisplayTitleChange()
{
var heritage = new UiText();
var layout = Fake((CharacterStatController.HeritageId, heritage));
CharacterSheet sheet = new() { Gender = "Female", Heritage = "Aluvian" };
CharacterStatController.Bind(layout, () => sheet);
Assert.Equal("Female Aluvian", heritage.LinesProvider()[0].Text);
// Simulates RuntimeCharacterTitleState.DisplayTitleChanged firing and
// CharacterSheetProvider rebuilding the sheet with the newly resolved
// title — CharacterStatController never rebinds, the label's own
// provider just re-reads the (reassigned) sheet.
sheet = new CharacterSheet { Gender = "Female", Heritage = "Aluvian", Title = "War Mage" };
Assert.Equal("Female Aluvian War Mage", heritage.LinesProvider()[0].Text);
}
/// <summary>CT4 item 1 ruling: the Name line ships the PLAIN-NAME case
/// only — retail's allegiance rank-title prefix
/// (<c>AllegianceData::GetFullName @0x005b6950</c>) needs a ~200-string
/// 22-function heritage×gender table judged out of reasonable size for
/// this slice (AP-109). The Name label must show exactly
/// <see cref="CharacterSheet.Name"/>, with no rank prefix synthesized
/// from anywhere.</summary>
[Fact]
public void Bind_NameLine_ShowsPlainNameOnly_NoRankPrefix()
{
var name = new UiText();
var layout = Fake((CharacterStatController.NameId, name));
CharacterStatController.Bind(layout, () => new CharacterSheet { Name = "Dww" });
Assert.Equal("Dww", name.LinesProvider()[0].Text);
}
/// <summary>CT4 item 4: the level shows a bare <c>"%d"</c>-formatted
/// integer when <see cref="CharacterSheet.Level"/> is present, and the
/// PE-recovered literal <c>"???"</c> when it is null (retail InqInt(0x19)
/// absent). Both cases use the WIDGET's own authored
/// <see cref="UiText.DefaultColor"/> — not a hardcoded constant — proving
/// the CT1 "authored color/font wins" fix (the former "Gold" constant is
/// deleted from the controller entirely).</summary>
[Theory]
[InlineData(126, "126")]
[InlineData(0, "0")]
[InlineData(null, "???")]
public void Bind_LevelLine_FormatsIntegerOrShowsQuestionMarks_InAuthoredColor(int? level, string expectedText)
{
var authoredColor = new Vector4(0.11f, 0.22f, 0.33f, 1f);
var levelText = new UiText { DefaultColor = authoredColor };
var layout = Fake((CharacterStatController.LevelId, levelText));
CharacterStatController.Bind(layout, () => new CharacterSheet { Level = level });
UiText.Line line = Assert.Single(levelText.LinesProvider());
Assert.Equal(expectedText, line.Text);
Assert.Equal(authoredColor, line.Color);
}
/// <summary>CT4 item 3: the PK line shows exactly whatever
/// <see cref="CharacterSheet.PkStatus"/> carries (the resolved
/// StringTable text — see <c>CharacterSheetProviderTests</c> for the
/// three-key resolution itself) in the widget's own authored color, not
/// the deleted parchment "Body" constant.</summary>
[Theory]
[InlineData("Player Killer")]
[InlineData("Player Killer Lite")]
[InlineData("Non-Player Killer")]
public void Bind_PkStatusLine_ShowsResolvedText_InAuthoredColor(string resolvedText)
{
var authoredColor = new Vector4(0.4f, 0.5f, 0.6f, 1f);
var pk = new UiText { DefaultColor = authoredColor };
var layout = Fake((CharacterStatController.PkStatusId, pk));
CharacterStatController.Bind(layout, () => new CharacterSheet { PkStatus = resolvedText });
UiText.Line line = Assert.Single(pk.LinesProvider());
Assert.Equal(resolvedText, line.Text);
Assert.Equal(authoredColor, line.Color);
}
/// <summary>An unresolved PK key (CT4 contract: "no invented English; if
/// a key fails to resolve, show nothing") shows an empty line rather
/// than a fabricated English fallback.</summary>
[Fact]
public void Bind_PkStatusLine_NullPkStatus_ShowsEmptyText()
{
var pk = new UiText();
var layout = Fake((CharacterStatController.PkStatusId, pk));
CharacterStatController.Bind(layout, () => new CharacterSheet { PkStatus = null });
Assert.Equal(string.Empty, pk.LinesProvider()[0].Text);
}
/// <summary>CT4 item 5: the luminance pair (0x100005C5/0x100005C6)
/// toggles Visible per retail's exact gate — <c>UpdateExperience</c>
/// (0x004f0a70): "InqInt(0x19) &lt; 200 || MaximumLuminance == 0" hides
/// both elements; otherwise both show. The elements' own content is left
/// unbound this slice (register row AP-109) — only visibility is
/// asserted here.</summary>
[Theory]
[InlineData(126, 0L, false)] // below level 200 — hidden regardless of luminance
[InlineData(200, 0L, false)] // level gate met, but MaximumLuminance == 0 — hidden
[InlineData(200, 1_000_000L, true)] // both conditions met — visible
[InlineData(275, 500L, true)]
[InlineData(null, 500L, false)] // absent level — treated as "not level 200+"
public void Bind_LuminancePair_TogglesVisibility_PerRetailGate(int? level, long maxLuminance, bool expectedVisible)
{
var label = new UiDatElement(
new ElementInfo { Id = CharacterStatController.LuminanceLabelId, Type = 3 },
static _ => (0u, 0, 0));
var value = new UiDatElement(
new ElementInfo { Id = CharacterStatController.LuminanceValueId, Type = 3 },
static _ => (0u, 0, 0));
var layout = Fake(
(CharacterStatController.LuminanceLabelId, label),
(CharacterStatController.LuminanceValueId, value));
CharacterStatController.Bind(layout, () => new CharacterSheet
{
Level = level,
MaximumLuminance = maxLuminance,
});
Assert.Equal(expectedVisible, label.Visible);
Assert.Equal(expectedVisible, value.Visible);
}
// ── XP meter fill ────────────────────────────────────────────────────────
[Fact]
public void Bind_SetsXpMeterFill()
{
var meter = new UiMeter();
var layout = Fake((CharacterStatController.XpMeterId, meter));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var fill = meter.Fill();
Assert.NotNull(fill);
Assert.True(System.MathF.Abs(fill!.Value - 0.63f) < 0.001f, $"expected ~0.63, got {fill}");
}
// ── Attribute list — 9 rows in list box 0x1000023D ───────────────────────
[Fact]
public void Bind_AttributeList_Has9Rows()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
// Rows are UiClickablePanel which inherits UiPanel, so OfType<UiPanel> matches.
var rows = list.Children.OfType<UiPanel>().ToList();
Assert.Equal(9, rows.Count);
}
[Fact]
public void Bind_AttributeList_RowsAreClickablePanels()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
Assert.Equal(9, rows.Count);
// All rows must have an OnClick wired (not null) and ClickThrough = false.
foreach (var row in rows)
{
Assert.NotNull(row.OnClick);
Assert.False(row.ClickThrough, "clickable row must accept pointer hits");
}
}
[Fact]
public void Bind_AttributeList_EachRowHasRightAlignedValueLabel()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiPanel>().ToList();
Assert.Equal(9, rows.Count);
foreach (var row in rows)
{
var texts = row.Children.OfType<UiText>().ToList();
Assert.True(texts.Count >= 2, "each row must have at least name + value UiText");
var valueEl = texts[^1];
Assert.True(valueEl.RightAligned, "value label must be RightAligned");
}
}
[Fact]
public void Bind_AttributeList_RowNamesInRetailOrder()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiPanel>().ToList();
Assert.Equal(9, rows.Count);
string[] expectedNames =
{
"Strength", "Endurance", "Coordination", "Quickness", "Focus", "Self",
"Health", "Stamina", "Mana",
};
for (int i = 0; i < 9; i++)
{
var texts = rows[i].Children.OfType<UiText>().ToList();
Assert.True(texts.Count >= 2, $"row {i} must have name + value");
string rowName = texts[1].LinesProvider()[0].Text;
Assert.Equal(expectedNames[i], rowName);
}
}
[Fact]
public void Bind_AttributeList_RowValues_AttributeIntegersAndVitalsCurMax()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiPanel>().ToList();
string ValueOf(UiPanel row) => row.Children.OfType<UiText>().ToList()[^1].LinesProvider()[0].Text;
Assert.Equal("200", ValueOf(rows[0])); // Strength
Assert.Equal("10", ValueOf(rows[1])); // Endurance
Assert.Equal("10", ValueOf(rows[2])); // Coordination
Assert.Equal("200", ValueOf(rows[3])); // Quickness
Assert.Equal("10", ValueOf(rows[4])); // Focus
Assert.Equal("10", ValueOf(rows[5])); // Self
Assert.Equal("5/5", ValueOf(rows[6])); // Health
Assert.Equal("10/10", ValueOf(rows[7])); // Stamina
Assert.Equal("10/10", ValueOf(rows[8])); // Mana
}
[Fact]
public void Bind_AttributeList_IconHasBackgroundSpriteWhenResolverProvided()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
var rows = list.Children.OfType<UiPanel>().ToList();
Assert.Equal(9, rows.Count);
var iconEl = rows[0].Children.OfType<UiText>().First();
Assert.Equal(0x060002C8u, iconEl.BackgroundSprite);
var healthIcon = rows[6].Children.OfType<UiText>().First();
Assert.Equal(0x06004C3Bu, healthIcon.BackgroundSprite);
}
[Fact]
public void Bind_AttributeList_IconBackgroundSprite_ZeroWhenNoResolver()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter, spriteResolve: null);
var rows = list.Children.OfType<UiPanel>().ToList();
Assert.Equal(9, rows.Count);
foreach (var row in rows)
{
var iconEl = row.Children.OfType<UiText>().First();
Assert.Equal(0u, iconEl.BackgroundSprite);
}
}
// ── Footer State A ────────────────────────────────────────────────────────
[Fact]
public void Bind_FooterStateA_TitleIsSelectPrompt()
{
var title = new UiText();
var layout = Fake((CharacterStatController.FooterTitleId, title));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
// Initial state (nothing selected): State-A title.
Assert.Equal("Select an Attribute to Improve", title.LinesProvider()[0].Text);
}
[Fact]
public void Bind_FooterStateA_Line1LabelIsSkillCreditsAvailable()
{
var lbl = new UiText();
var layout = Fake((CharacterStatController.FooterLine1Label, lbl));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("Skill Credits Available:", lbl.LinesProvider()[0].Text);
}
[Fact]
public void Bind_FooterStateA_Line1ValueIsSkillCredits()
{
var val = new UiText();
var layout = Fake((CharacterStatController.FooterLine1Value, val));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("96", val.LinesProvider()[0].Text);
}
[Fact]
public void Bind_FooterStateA_Line2LabelIsUnassignedExperience()
{
var lbl = new UiText();
var layout = Fake((CharacterStatController.FooterLine2Label, lbl));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("Unassigned Experience:", lbl.LinesProvider()[0].Text);
}
[Fact]
public void Bind_FooterStateA_Line2ValueIsUnassignedXp()
{
var val = new UiText();
var layout = Fake((CharacterStatController.FooterLine2Value, val));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var expected = (87_757_321_741L).ToString("N0");
Assert.Equal(expected, val.LinesProvider()[0].Text);
}
// ── Pass 2: Row selection → Footer State B ───────────────────────────────
[Fact]
public void RowClick_SelectRow4Focus_FooterStateBShowsFocusTitle()
{
// Focus is index 4 in AttrRows. SampleData Focus = 10. Cost = 110.
var title = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
// Simulate a click on row 4 (Focus).
var rows = list.Children.OfType<UiClickablePanel>().ToList();
Assert.Equal(9, rows.Count);
rows[4].OnClick!();
// Footer title should now be "Focus: 10".
Assert.Equal("Focus: 10", title.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_SelectRow4Focus_FooterLine1LabelIsExperienceToRaise()
{
var lbl = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterLine1Label, lbl),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
Assert.Equal("Experience To Raise:", lbl.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_SelectRow4Focus_FooterLine1ValueIsRaiseCost()
{
var val = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterLine1Value, val),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
// Focus raise cost = 110 (SampleData fixture).
Assert.Equal((110L).ToString("N0"), val.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_SelectRow4Focus_FooterLine2LabelIsUnassignedExperience()
{
var lbl = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterLine2Label, lbl),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
Assert.Equal("Unassigned Experience:", lbl.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_SelectRow4Focus_FooterLine2ValueIsUnassignedXp()
{
var val = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterLine2Value, val),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
// UnassignedXp = 87_757_321_741L
var expected = (87_757_321_741L).ToString("N0");
Assert.Equal(expected, val.LinesProvider()[0].Text);
}
// ── Pass 2: Toggle deselects ──────────────────────────────────────────────
[Fact]
public void RowClick_ToggleSameRow_ReturnsToFooterStateA()
{
var title = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
// Select Focus (row 4).
rows[4].OnClick!();
Assert.Equal("Focus: 10", title.LinesProvider()[0].Text);
// Click the same row again → deselect.
rows[4].OnClick!();
Assert.Equal("Select an Attribute to Improve", title.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_SwitchRow_UpdatesToNewRow()
{
var title = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
// Select Endurance (row 1, value=10).
rows[1].OnClick!();
Assert.Equal("Endurance: 10", title.LinesProvider()[0].Text);
// Select Self (row 5, value=10).
rows[5].OnClick!();
Assert.Equal("Self: 10", title.LinesProvider()[0].Text);
}
// ── Pass 2: Row highlight ─────────────────────────────────────────────────
[Fact]
public void RowClick_SelectRow_HighlightsSelectedAndClearsOthers()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
// All rows start transparent.
Assert.All(rows, r => Assert.Equal(0f, r.BackgroundColor.W));
// Select row 2 (Coordination).
rows[2].OnClick!();
Assert.NotEqual(0f, rows[2].BackgroundColor.W); // highlighted
Assert.Equal(0f, rows[0].BackgroundColor.W); // others cleared
Assert.Equal(0f, rows[1].BackgroundColor.W);
}
[Fact]
public void RowClick_Deselect_ClearsHighlight()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
rows[2].OnClick!(); // select
rows[2].OnClick!(); // deselect
Assert.Equal(0f, rows[2].BackgroundColor.W);
}
[Fact]
public void RowClick_WithSpriteResolve_SelectedRowHasHighlightSprite()
{
// When spriteResolve is provided, the selected row must use sprite 0x06001397
// (retail Button-state-6 dark bar) instead of the translucent gold BackgroundColor.
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
// Minimal sprite resolver — returns a fake non-zero handle so UiPanel draws it.
static (uint, int, int) FakeResolve(uint id) => (1u, 32, 8);
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: FakeResolve);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
rows[2].OnClick!();
Assert.Equal(0x06001397u, rows[2].BackgroundSprite); // selected → sprite
Assert.Equal(0f, rows[2].BackgroundColor.W); // no tint
Assert.Equal(0u, rows[0].BackgroundSprite); // others cleared
Assert.Equal(0u, rows[1].BackgroundSprite);
}
[Fact]
public void RowClick_WithSpriteResolve_Deselect_ClearsSprite()
{
var list = new UiPanel();
var layout = Fake((CharacterStatController.ListBoxId, list));
static (uint, int, int) FakeResolve(uint id) => (1u, 32, 8);
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: FakeResolve);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
rows[2].OnClick!(); // select
rows[2].OnClick!(); // deselect
Assert.Equal(0u, rows[2].BackgroundSprite);
}
// ── Pass 2: Raise button affordability ───────────────────────────────────
[Fact]
public void RaiseButtons_InitiallyHidden()
{
var btn1 = MakeButton();
var btn10 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.RaiseTenId, btn10),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.False(btn1.Visible, "raise×1 must start hidden");
Assert.False(btn10.Visible, "raise×10 must start hidden");
}
[Fact]
public void RaiseButtons_AffordableRow_ShowsNormalState()
{
// Focus row (index 4) cost=110, UnassignedXp=87_757_321_741 → affordable.
var btn1 = MakeButton();
var btn10 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.RaiseTenId, btn10),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!(); // select Focus
Assert.True(btn1.Visible, "raise×1 visible on selection");
Assert.True(btn10.Visible, "raise×10 visible on selection");
Assert.Equal("Normal", btn1.ActiveState);
Assert.Equal("Normal", btn10.ActiveState);
}
[Fact]
public void RaiseButtons_OnlyOneAffordable_SplitsOneAndTenStates()
{
var btn1 = MakeButton();
var btn10 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.RaiseTenId, btn10),
(CharacterStatController.ListBoxId, list));
var sheet = new CharacterSheet
{
UnassignedXp = 500L,
AttributeRaiseCosts = new long[] { 0L, 0L, 0L, 0L, 110L, 0L, 0L, 0L, 0L },
AttributeRaise10Costs = new long[] { 0L, 0L, 0L, 0L, 1_100L, 0L, 0L, 0L, 0L },
};
CharacterStatController.Bind(layout, () => sheet);
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
Assert.Equal("Normal", btn1.ActiveState);
Assert.Equal("Ghosted", btn10.ActiveState);
}
[Fact]
public void RaiseButtons_MaxedRow_ShowsGhostedState()
{
// Strength row (index 0) cost=0 → disabled. UnassignedXp is irrelevant.
var btn1 = MakeButton();
var btn10 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.RaiseTenId, btn10),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[0].OnClick!(); // select Strength (cost=0)
Assert.True(btn1.Visible, "raise button visible even when disabled");
Assert.Equal("Ghosted", btn1.ActiveState);
Assert.Equal("Ghosted", btn10.ActiveState);
}
[Fact]
public void RaiseButtons_ClickAffordableAttribute_EmitsRaiseRequest()
{
var btn1 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.ListBoxId, list));
var requests = new List<CharacterStatController.RaiseRequest>();
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
onRaiseRequest: (request, completed) => { requests.Add(request); completed(); });
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
btn1.OnClick!();
var request = Assert.Single(requests);
Assert.Equal(CharacterStatController.RaiseTargetKind.Attribute, request.Kind);
Assert.Equal(5u, request.StatId);
Assert.Equal(110L, request.Cost);
Assert.Equal(1, request.Amount);
}
[Fact]
public void RaiseButtons_ClickAffordableAttribute_KeepsNormalStateUntilCostsRefresh()
{
var btn1 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.ListBoxId, list));
var requests = new List<CharacterStatController.RaiseRequest>();
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
onRaiseRequest: (request, completed) => { requests.Add(request); completed(); });
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
Assert.Equal("Normal", btn1.ActiveState);
btn1.OnClick!();
Assert.Single(requests);
Assert.Equal("Normal", btn1.ActiveState);
}
[Fact]
public void RaiseButtons_ClickAffordableVital_EmitsMaxVitalId()
{
var btn1 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.ListBoxId, list));
var requests = new List<CharacterStatController.RaiseRequest>();
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
onRaiseRequest: (request, completed) => { requests.Add(request); completed(); });
list.Children.OfType<UiClickablePanel>().ToList()[6].OnClick!();
btn1.OnClick!();
var request = Assert.Single(requests);
Assert.Equal(CharacterStatController.RaiseTargetKind.Vital, request.Kind);
Assert.Equal(1u, request.StatId);
Assert.Equal(90L, request.Cost);
Assert.Equal(1, request.Amount);
}
[Fact]
public void RaiseButtons_ClickUnaffordableTen_DoesNotEmitRequest()
{
var btn10 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseTenId, btn10),
(CharacterStatController.ListBoxId, list));
var requests = new List<CharacterStatController.RaiseRequest>();
var sheet = new CharacterSheet
{
UnassignedXp = 500L,
AttributeRaiseCosts = new long[] { 0L, 0L, 0L, 0L, 110L, 0L, 0L, 0L, 0L },
AttributeRaise10Costs = new long[] { 0L, 0L, 0L, 0L, 1_100L, 0L, 0L, 0L, 0L },
};
CharacterStatController.Bind(layout, () => sheet,
onRaiseRequest: (request, completed) => { requests.Add(request); completed(); });
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!();
btn10.OnClick!();
Assert.Empty(requests);
}
[Fact]
public void RaiseButtons_Deselect_HidesButtons()
{
var btn1 = MakeButton();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
rows[4].OnClick!(); // select
Assert.True(btn1.Visible);
rows[4].OnClick!(); // deselect
Assert.False(btn1.Visible, "raise button hidden after deselect");
}
// ── Pass 2: DAT-authored tab states ───────────────────────────────────────
[Fact]
public void CharacterTabs_UseImportedChromeWithoutSyntheticRootChildren()
{
var layout = FixtureLoader.LoadCharacter();
int rootChildCount = layout.Root.Children.Count;
var attributes = Assert.IsType<UiText>(layout.FindElement(CharacterStatController.TabAttribId));
var skills = Assert.IsType<UiText>(layout.FindElement(CharacterStatController.TabSkillsId));
var titles = Assert.IsType<UiText>(layout.FindElement(CharacterStatController.TabTitlesId));
Assert.Equal(3, attributes.Children.Count);
Assert.Equal(3, skills.Children.Count);
Assert.Equal(3, titles.Children.Count);
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
Assert.Equal(rootChildCount, layout.Root.Children.Count);
Assert.Equal(RetailUiStateIds.Open, attributes.ActiveRetailStateId);
Assert.Equal(RetailUiStateIds.Closed, skills.ActiveRetailStateId);
Assert.Equal(RetailUiStateIds.Closed, titles.ActiveRetailStateId);
Assert.Equal(
new uint[] { 0x06005D92u, 0x06005D94u, 0x06005D96u },
attributes.Children.Cast<UiDatElement>().Select(child => child.ActiveMedia().File));
Assert.Equal(
new uint[] { 0x06005D93u, 0x06005D95u, 0x06005D97u },
skills.Children.Cast<UiDatElement>().Select(child => child.ActiveMedia().File));
// CT3 (2026-08-24): the Titles tab is no longer inert — it switches
// to a real page (previously AP-109's known gap).
Assert.False(titles.ClickThrough);
Assert.NotNull(titles.OnClick);
}
[Fact]
public void CharacterTabs_ClickUsesRetailStateColorAndPropagatesToChrome()
{
var layout = FixtureLoader.LoadCharacter();
var attributes = Assert.IsType<UiText>(layout.FindElement(CharacterStatController.TabAttribId));
var skills = Assert.IsType<UiText>(layout.FindElement(CharacterStatController.TabSkillsId));
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
skills.OnClick!();
Assert.Equal(RetailUiStateIds.Closed, attributes.ActiveRetailStateId);
Assert.Equal(RetailUiStateIds.Open, skills.ActiveRetailStateId);
Assert.Equal(127f / 255f, attributes.DefaultColor.X, 5);
Assert.Equal(204f / 255f, skills.DefaultColor.X, 5);
Assert.All(attributes.Children, child =>
Assert.Equal(RetailUiStateIds.Closed, Assert.IsAssignableFrom<IUiDatStateful>(child).ActiveRetailStateId));
Assert.All(skills.Children, child =>
Assert.Equal(RetailUiStateIds.Open, Assert.IsAssignableFrom<IUiDatStateful>(child).ActiveRetailStateId));
}
/// <summary>
/// CT3 (2026-08-24): unlike Attributes/Skills (which share ONE mounted
/// page and only rebind its content), the Titles page (0x10000539) is a
/// genuinely separate, non-duplicated subtree (CT1 ground truth §3) that
/// must actually be shown/hidden on tab switch.
/// </summary>
[Fact]
public void TitlesTab_Click_ShowsTitlesPageAndHidesAttributesSkillsContent()
{
var layout = FixtureLoader.LoadCharacter();
var titlesTab = Assert.IsType<UiText>(layout.FindElement(CharacterStatController.TabTitlesId));
var attributesTab = Assert.IsType<UiText>(layout.FindElement(CharacterStatController.TabAttribId));
var titlesPage = layout.FindElement(CharacterStatController.TitlesPageId);
var attributesPage = layout.FindElement(CharacterStatController.AttributesPageId);
Assert.NotNull(titlesPage);
Assert.NotNull(attributesPage);
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
Assert.True(attributesPage!.Visible);
Assert.False(titlesPage!.Visible);
titlesTab.OnClick!();
Assert.True(titlesPage.Visible);
Assert.False(attributesPage.Visible);
Assert.Equal(RetailUiStateIds.Open, titlesTab.ActiveRetailStateId);
Assert.Equal(RetailUiStateIds.Closed, attributesTab.ActiveRetailStateId);
// Switching back to Attributes restores the shared content page and
// re-hides Titles.
attributesTab.OnClick!();
Assert.True(attributesPage.Visible);
Assert.False(titlesPage.Visible);
Assert.Equal(RetailUiStateIds.Closed, titlesTab.ActiveRetailStateId);
}
// ── Affordability helpers (GetRaiseCost) ──────────────────────────────────
[Fact]
public void SkillsTab_Click_RebuildsListWithRetailBucketsAndRows()
{
var list = new UiPanel { Width = 300 };
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
var headerPanels = SkillHeaders(list);
var headers = headerPanels
.Select(c => c.Children.OfType<UiText>().First().LinesProvider()[0].Text)
.ToList();
Assert.Equal(new[]
{
"Specialized Skills",
"Trained Skills",
"Untrained Skills",
"Unusable Skills",
}, headers);
Assert.Equal(new[] { 0x06000F90u, 0x06000F86u, 0x06000F98u, 0x06000F89u },
headerPanels.Select(h => h.BackgroundSprite).ToArray());
Assert.All(headerPanels, h =>
Assert.Equal(Vector4.One, h.Children.OfType<UiText>().First().LinesProvider()[0].Color));
var rows = SkillRows(list);
Assert.Equal(12, rows.Count);
Assert.All(rows, row =>
{
Assert.Equal(Vector4.Zero, row.BackgroundColor);
Assert.Equal(0u, row.BackgroundSprite);
Assert.True(row.UseSelectionBars);
});
var rowNames = rows
.Select(r => r.Children.OfType<UiText>().ToList()[1].LinesProvider()[0].Text)
.ToList();
Assert.Equal(new[]
{
"Melee Defense", "War Magic",
"Arcane Lore", "Life Magic", "Missile Weapons",
"Healing", "Jump", "Loyalty", "Run",
"Alchemy", "Cooking", "Fletching",
}, rowNames);
var meleeTexts = rows[0].Children.OfType<UiText>().ToList();
Assert.Equal(Vector4.One, meleeTexts[1].LinesProvider()[0].Color);
Assert.Equal(new Vector4(0f, 1f, 0f, 1f), meleeTexts[2].LinesProvider()[0].Color);
var healingTexts = rows[5].Children.OfType<UiText>().ToList();
Assert.Equal(Vector4.One, healingTexts[1].LinesProvider()[0].Color);
Assert.Equal(Vector4.One, healingTexts[2].LinesProvider()[0].Color);
}
[Fact]
public void DataChangedRefresh_MovesATrainedSkillToItsSection_WithoutAClick()
{
// #431 CA5-gate bug: a TrainSkill's authoritative record updated the
// sheet, but rows only rebuilt on CLICKS — the skill sat in the
// untrained section (credits visibly debited) until the user clicked
// train AGAIN. Bind now returns the data-changed refresh; invoking
// it must re-bucket the rows, mirroring retail's quality-change
// broadcast (InfoRegion::OnQualityChanged @ 0x004F0EB0).
var list = new UiPanel { Width = 300 };
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterSheet sheet = SampleData.SampleCharacter();
Action refresh = CharacterStatController.Bind(layout, () => sheet,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
var untrained = sheet.Skills.First(
s => s.AdvancementClass == CharacterSkillAdvancementClass.Untrained);
int trainedBefore = sheet.Skills.Count(
s => s.AdvancementClass == CharacterSkillAdvancementClass.Trained);
Assert.Equal(trainedBefore, RowsUnderHeader(list, "Trained Skills"));
// The server record lands: the skill is now Trained. CharacterSheet
// is a plain class (init-only), so rebuild it like the provider does.
CharacterSheet updated = SampleData.SampleCharacter();
updated.GetType(); // (no-op guard for clarity)
sheet = new CharacterSheet
{
Name = sheet.Name,
UnassignedXp = sheet.UnassignedXp,
SkillCredits = sheet.SkillCredits,
Skills = sheet.Skills
.Select(s => s.Id == untrained.Id
? s with { AdvancementClass = CharacterSkillAdvancementClass.Trained }
: s)
.ToList(),
};
refresh();
Assert.Equal(trainedBefore + 1, RowsUnderHeader(list, "Trained Skills"));
}
[Fact]
public void Rows_CarryTheSharedTooltipPopupLocatorAndDescriptionText()
{
// #430: runtime-built rows author no popup locator, and the tooltip
// presenter refuses a widget without one — so the row descriptions
// could never mount. Rows must carry the shared popup skin (the only
// locator pair the character layout itself references; the same
// inference UiItemSlot ships) alongside their runtime text.
var list = new UiPanel { Width = 300 };
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
var attributeRows = list.Children.OfType<UiClickablePanel>().ToList();
Assert.NotEmpty(attributeRows);
Assert.All(attributeRows, row =>
{
Assert.Equal(
RetailTooltipPresenter.SharedPopupSkinRootElementId,
row.AuthoredTooltipRootElementId);
Assert.Equal(
RetailTooltipPresenter.SharedPopupSkinLayoutDid,
row.AuthoredTooltipLayoutDid);
});
// The six attribute rows carry the retail descriptions.
Assert.All(
attributeRows.Take(6),
row => Assert.False(string.IsNullOrEmpty(row.GetTooltipText())));
}
private static int RowsUnderHeader(UiElement list, string header)
{
// The rows live inside a nested content container; find the
// container whose ordered children interleave section headers and
// rows, then count rows between the named header and the next one.
static bool IsHeader(UiElement c, string text) =>
c is UiPanel and not UiClickablePanel
&& c.Children.OfType<UiText>().Any(
x => x.LinesProvider()[0].Text == text);
UiElement? container = new[] { list }.Concat(Descendants(list))
.FirstOrDefault(e => e.Children.Any(c => IsHeader(c, header)));
Assert.NotNull(container);
var children = container!.Children.ToList();
int start = children.FindIndex(c => IsHeader(c, header));
Assert.True(start >= 0, $"header '{header}' not found");
int count = 0;
for (int i = start + 1; i < children.Count; i++)
{
if (children[i] is UiClickablePanel) count++;
else if (children[i] is UiPanel p
&& p.Children.OfType<UiText>().Any()) break;
}
return count;
}
[Fact]
public void SkillsTab_ClickThenAttributesTab_RestoresAttributeRows()
{
var list = new UiPanel { Width = 300 };
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
Assert.Equal(12, SkillRows(list).Count);
ClickTab(layout, left: 0f);
var rows = list.Children.OfType<UiClickablePanel>().ToList();
Assert.Equal(9, rows.Count);
Assert.Equal("Strength", rows[0].Children.OfType<UiText>().ToList()[1].LinesProvider()[0].Text);
}
[Fact]
public void SkillsTab_MouseClick_RebuildsVisibleListWhenListIdIsDuplicated()
{
var root = new UiPanel { Width = 300, Height = 600 };
var attrPage = MakeDatElement(CharacterStatController.AttributesPageId, top: 25, width: 300, height: 575);
var hiddenPage = MakeDatElement(CharacterStatController.SkillsPageId, top: 25, width: 300, height: 575);
var name = new UiText();
var visibleList = MakeDatElement(CharacterStatController.ListBoxId, top: 112, width: 300, height: 398);
var hiddenDuplicateList = MakeDatElement(CharacterStatController.ListBoxId, top: 112, width: 300, height: 398);
attrPage.AddChild(name);
attrPage.AddChild(visibleList);
hiddenPage.AddChild(hiddenDuplicateList);
root.AddChild(attrPage);
root.AddChild(hiddenPage);
var skillsTab = MakeTab(CharacterStatController.TabSkillsId, left: 92f);
root.AddChild(skillsTab);
var layout = new ImportedLayout(root, new Dictionary<uint, UiElement>
{
[CharacterStatController.NameId] = name,
// Mirrors the real import: the id dictionary can point at a hidden duplicate.
[CharacterStatController.ListBoxId] = hiddenDuplicateList,
[CharacterStatController.TabSkillsId] = skillsTab,
});
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
Assert.Equal("Strength", FirstRowName(visibleList));
Assert.Equal("<no row>", FirstRowName(hiddenDuplicateList));
var ui = new UiRoot { Width = 300, Height = 600 };
ui.AddChild(root);
Assert.Same(skillsTab, ui.Pick(132, 12));
ui.OnMouseDown(UiMouseButton.Left, 132, 12);
ui.OnMouseUp(UiMouseButton.Left, 132, 12);
Assert.Equal("Melee Defense", FirstRowName(visibleList));
Assert.Equal("<no row>", FirstRowName(hiddenDuplicateList));
}
[Fact]
public void SkillsTab_SelectWarMagic_ShowsTrainedSkillFooter()
{
var list = new UiPanel { Width = 300 };
var title = new UiText();
var l1Label = new UiText();
var l1Value = new UiText();
var l2Label = new UiText();
var l2Value = new UiText();
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.FooterLine1Label, l1Label),
(CharacterStatController.FooterLine1Value, l1Value),
(CharacterStatController.FooterLine2Label, l2Label),
(CharacterStatController.FooterLine2Value, l2Value));
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
var rows = SkillRows(list);
rows[1].OnClick!();
// SampleData's War Magic row is intentionally Base=280/Current=285 (an
// illustrative buffed-skill sample — see SampleData.cs comment); issue
// #267 wires the retail "(+5)" buff-delta parenthetical onto that gap,
// which was previously computed but never surfaced in the title text.
Assert.Equal("War Magic: 285 (+5)", title.LinesProvider()[0].Text);
Assert.Equal("Experience To Raise:", l1Label.LinesProvider()[0].Text);
Assert.Equal((11_100_000L).ToString("N0"), l1Value.LinesProvider()[0].Text);
Assert.Equal("Unassigned Experience:", l2Label.LinesProvider()[0].Text);
Assert.Equal((87_757_321_741L).ToString("N0"), l2Value.LinesProvider()[0].Text);
Assert.Equal(0x06001397u, rows[1].BackgroundSprite);
Assert.True(rows[1].UseSelectionBars);
Assert.Equal(Vector4.Zero, rows[1].BackgroundColor);
Assert.Equal(0u, rows[0].BackgroundSprite);
Assert.True(rows[0].UseSelectionBars);
Assert.Equal(Vector4.Zero, rows[0].BackgroundColor);
}
[Fact]
public void SkillsTab_ClickRaiseTen_EmitsSkillRaiseRequest()
{
var list = new UiPanel { Width = 300 };
var btn10 = MakeButton();
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.RaiseTenId, btn10));
var requests = new List<CharacterStatController.RaiseRequest>();
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16),
onRaiseRequest: (request, completed) => { requests.Add(request); completed(); });
ClickTab(layout, left: 92f);
SkillRows(list)[1].OnClick!();
btn10.OnClick!();
var request = Assert.Single(requests);
Assert.Equal(CharacterStatController.RaiseTargetKind.Skill, request.Kind);
Assert.Equal(34u, request.StatId);
Assert.Equal(111_000_000L, request.Cost);
Assert.Equal(10, request.Amount);
}
[Fact]
public void SkillsTab_SelectHealing_ShowsUntrainedSkillFooter()
{
var list = new UiPanel { Width = 300 };
var title = new UiText();
var l1Label = new UiText();
var l1Value = new UiText();
var l2Label = new UiText();
var l2Value = new UiText();
var btn1 = MakeButton();
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.FooterLine1Label, l1Label),
(CharacterStatController.FooterLine1Value, l1Value),
(CharacterStatController.FooterLine2Label, l2Label),
(CharacterStatController.FooterLine2Value, l2Value),
(CharacterStatController.RaiseOneId, btn1));
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
SkillRows(list)[5].OnClick!();
Assert.Equal("Healing", title.LinesProvider()[0].Text);
Assert.Equal("Skill Credits To Raise:", l1Label.LinesProvider()[0].Text);
Assert.Equal("6", l1Value.LinesProvider()[0].Text);
Assert.Equal("Skill Credits Available:", l2Label.LinesProvider()[0].Text);
Assert.Equal("96", l2Value.LinesProvider()[0].Text);
Assert.True(btn1.Visible);
Assert.Equal("Normal", btn1.ActiveState);
}
[Fact]
public void SkillsTab_ClickUntrainedSkill_EmitsTrainSkillRequest()
{
var list = new UiPanel { Width = 300 };
var btn1 = MakeButton();
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.RaiseOneId, btn1));
var requests = new List<CharacterStatController.RaiseRequest>();
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16),
onRaiseRequest: (request, completed) => { requests.Add(request); completed(); });
ClickTab(layout, left: 92f);
SkillRows(list)[5].OnClick!();
btn1.OnClick!();
var request = Assert.Single(requests);
Assert.Equal(CharacterStatController.RaiseTargetKind.TrainSkill, request.Kind);
Assert.Equal(21u, request.StatId);
Assert.Equal(6L, request.Cost);
Assert.Equal(1, request.Amount);
}
[Fact]
public void SkillsTab_ClickTrain_RebuildsSelectedSkillAsTrained()
{
var list = new UiPanel { Width = 300 };
var btn1 = MakeButton();
var btn10 = MakeButton();
CharacterSheet sheet = new()
{
SkillCredits = 10,
UnassignedXp = 1_000,
Skills = new[]
{
new CharacterSkill(100u, "Train Me", 0x06000001u,
CharacterSkillAdvancementClass.Untrained,
BaseLevel: 5,
CurrentLevel: 5,
UsableUntrained: true,
TrainedCost: 4,
SpecializedCost: 0,
RaiseCost: 0,
Raise10Cost: 0),
},
};
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.RaiseTenId, btn10));
var requests = new List<CharacterStatController.RaiseRequest>();
CharacterStatController.Bind(layout, () => sheet,
spriteResolve: id => (id, 16, 16),
onRaiseRequest: (request, completed) =>
{
requests.Add(request);
sheet = new CharacterSheet
{
SkillCredits = 6,
UnassignedXp = 1_000,
Skills = new[]
{
new CharacterSkill(100u, "Train Me", 0x06000001u,
CharacterSkillAdvancementClass.Trained,
BaseLevel: 5,
CurrentLevel: 5,
UsableUntrained: true,
TrainedCost: 4,
SpecializedCost: 0,
RaiseCost: 10,
Raise10Cost: 100),
},
};
completed();
});
ClickTab(layout, left: 92f);
SkillRows(list).Single().OnClick!();
Assert.False(btn10.Visible);
btn1.OnClick!();
var request = Assert.Single(requests);
Assert.Equal(CharacterStatController.RaiseTargetKind.TrainSkill, request.Kind);
Assert.Equal("Train Me", SkillRows(list).Single().Children.OfType<UiText>().ToList()[1].LinesProvider()[0].Text);
Assert.True(btn1.Visible);
Assert.True(btn10.Visible);
Assert.Equal("Normal", btn1.ActiveState);
Assert.Equal("Normal", btn10.ActiveState);
}
[Fact]
public void SkillsTab_DeferredTrainRefreshesOnlyWhenRequestCompletes()
{
var list = new UiPanel { Width = 300 };
var btn1 = MakeButton();
var btn10 = MakeButton();
CharacterSheet sheet = TrainingSheet(CharacterSkillAdvancementClass.Untrained);
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.RaiseOneId, btn1),
(CharacterStatController.RaiseTenId, btn10));
Action? completeRaise = null;
CharacterStatController.Bind(layout, () => sheet,
spriteResolve: id => (id, 16, 16),
onRaiseRequest: (_, completed) => completeRaise = completed);
ClickTab(layout, left: 92f);
SkillRows(list).Single().OnClick!();
btn1.OnClick!();
sheet = TrainingSheet(CharacterSkillAdvancementClass.Trained);
Assert.NotNull(completeRaise);
Assert.False(btn10.Visible);
completeRaise!();
Assert.True(btn10.Visible);
static CharacterSheet TrainingSheet(CharacterSkillAdvancementClass advancement)
=> new()
{
SkillCredits = advancement == CharacterSkillAdvancementClass.Untrained ? 10 : 6,
UnassignedXp = 1_000,
Skills =
[
new CharacterSkill(
100u,
"Train Me",
0x06000001u,
advancement,
BaseLevel: 5,
CurrentLevel: 5,
UsableUntrained: true,
TrainedCost: 4,
SpecializedCost: 0,
RaiseCost: advancement == CharacterSkillAdvancementClass.Untrained ? 0 : 10,
Raise10Cost: advancement == CharacterSkillAdvancementClass.Untrained ? 0 : 100),
],
};
}
[Fact]
public void SkillsTab_BindsCharacterScrollbarToScrollableViewport()
{
var root = new UiPanel { Width = 300, Height = 600 };
var page = new UiPanel { Width = 300, Height = 600 };
var name = new UiText();
var list = MakeDatElement(CharacterStatController.ListBoxId, top: 137, width: 300, height: 80);
var scrollbarShell = MakeDatElement(CharacterStatController.ListScrollbarId, top: 137, width: 16, height: 80);
scrollbarShell.Left = 281;
page.AddChild(name);
page.AddChild(list);
page.AddChild(scrollbarShell);
root.AddChild(page);
var skillsTab = MakeTab(CharacterStatController.TabSkillsId, left: 92f);
root.AddChild(skillsTab);
var layout = new ImportedLayout(root, new Dictionary<uint, UiElement>
{
[CharacterStatController.NameId] = name,
[CharacterStatController.ListBoxId] = list,
[CharacterStatController.ListScrollbarId] = scrollbarShell,
[CharacterStatController.TabSkillsId] = skillsTab,
});
CharacterStatController.Bind(layout, SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
var bar = page.Children.OfType<UiScrollbar>().Single();
Assert.True(bar.Visible);
Assert.NotNull(bar.Model);
Assert.Contains(list.Children, c => c is UiScrollablePanel);
Assert.False(scrollbarShell.Visible);
}
[Fact]
public void GetRaiseCost_Index4Focus_Returns110()
{
var sheet = SampleData.SampleCharacter();
Assert.Equal(110L, CharacterStatController.GetRaiseCost(sheet, 4));
}
[Fact]
public void GetRaiseCost_Amount10Index4Focus_Returns1100()
{
var sheet = SampleData.SampleCharacter();
Assert.Equal(1_100L, CharacterStatController.GetRaiseCost(sheet, 4, amount: 10));
}
[Fact]
public void GetRaiseCost_Index0Strength_Returns0()
{
var sheet = SampleData.SampleCharacter();
Assert.Equal(0L, CharacterStatController.GetRaiseCost(sheet, 0));
}
[Fact]
public void GetRaiseCost_OutOfRange_Returns0()
{
var sheet = SampleData.SampleCharacter();
Assert.Equal(0L, CharacterStatController.GetRaiseCost(sheet, 99));
}
// ── GetRowName helper ─────────────────────────────────────────────────────
[Fact]
public void GetRowName_Index0_ReturnsStrength()
=> Assert.Equal("Strength", CharacterStatController.GetRowName(0));
[Fact]
public void GetRowName_Index4_ReturnsFocus()
=> Assert.Equal("Focus", CharacterStatController.GetRowName(4));
[Fact]
public void GetRowName_Index6_ReturnsHealth()
=> Assert.Equal("Health", CharacterStatController.GetRowName(6));
[Fact]
public void GetRowName_NegativeIndex_ReturnsEmpty()
=> Assert.Equal(string.Empty, CharacterStatController.GetRowName(-1));
// ── Issue #267 — vitae/buff delta parenthetical ──────────────────────────
// Retail format cited from gmAttributeUI::DisplaySelectionFooter_Attribute
// (0x0049d280, " (%s%d)") and gmSkillUI::DisplaySelectionFooter_Trained
// (0x0049b860, vitae segment " (%d)" + buff segment " (%s%d)").
[Fact]
public void GetAttributeDelta_ComputesEffectiveMinusBase()
{
var sheet = new CharacterSheet { Strength = 220, AttributeBaseValues = [200, 0, 0, 0, 0, 0] };
Assert.Equal(20, CharacterStatController.GetAttributeDelta(sheet, 0));
}
[Fact]
public void GetAttributeDelta_VitalRowIndex_ReturnsZero()
{
// Vitals (rows 6-8) use a "cur/max" footer format in retail
// (DisplaySelectionFooter_Vital), not this delta pattern.
var sheet = new CharacterSheet { AttributeBaseValues = [200, 0, 0, 0, 0, 0] };
Assert.Equal(0, CharacterStatController.GetAttributeDelta(sheet, 6));
}
[Fact]
public void GetAttributeDelta_EmptyBaseValues_ReturnsZero()
{
// SampleData / older sheets that don't populate AttributeBaseValues
// must not throw or fabricate a delta.
var sheet = new CharacterSheet { Strength = 220 };
Assert.Equal(0, CharacterStatController.GetAttributeDelta(sheet, 0));
}
[Fact]
public void GetSkillBuffOnlyDelta_IsolatesBuffFromVitae()
{
// CurrentLevel=251 already includes vitae (-99); the buff-only
// residual is (251 - (-99)) - 300 = 50.
var skill = new CharacterSkill(1u, "S", 0u, CharacterSkillAdvancementClass.Trained,
BaseLevel: 300, CurrentLevel: 251, UsableUntrained: true,
TrainedCost: 0, SpecializedCost: 0, RaiseCost: 0, VitaeModifier: -99);
Assert.Equal(50, CharacterStatController.GetSkillBuffOnlyDelta(skill));
}
[Fact]
public void SkillValueColor_SubtractsVitaeBeforeChoosingFontState()
{
var vitaeOnly = new CharacterSkill(
1u, "S", 0u, CharacterSkillAdvancementClass.Trained,
BaseLevel: 300, CurrentLevel: 201, UsableUntrained: true,
TrainedCost: 0, SpecializedCost: 0, RaiseCost: 0,
VitaeModifier: -99);
var vitaeAndBuff = vitaeOnly with { CurrentLevel = 211 };
Assert.Equal(Vector4.One, CharacterStatController.SkillValueColor(vitaeOnly));
Assert.Equal(
new Vector4(0f, 1f, 0f, 1f),
CharacterStatController.SkillValueColor(vitaeAndBuff));
}
[Fact]
public void AttributeAndVitalValueColors_FollowRetailResidualComparison()
{
var sheet = new CharacterSheet
{
Strength = 220,
AttributeBaseValues = [200, 0, 0, 0, 0, 0],
HealthMax = 170,
VitalBaseMaxValues = [200, 0, 0],
VitalVitaeModifiers = [-40, 0, 0],
};
Assert.Equal(
new Vector4(0f, 1f, 0f, 1f),
CharacterStatController.AttributeValueColor(sheet, 0));
Assert.Equal(
new Vector4(0f, 1f, 0f, 1f),
CharacterStatController.VitalValueColor(sheet, 0));
}
[Fact]
public void RowClick_AttributeWithBuff_FooterTitleShowsPositiveDelta()
{
var title = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.ListBoxId, list));
CharacterSheet Sheet() => new() { Strength = 220, AttributeBaseValues = [200, 0, 0, 0, 0, 0] };
CharacterStatController.Bind(layout, Sheet);
list.Children.OfType<UiClickablePanel>().ToList()[0].OnClick!(); // Strength = index 0
Assert.Equal("Strength: 220 (+20)", title.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_AttributeWithDebuff_FooterTitleShowsNegativeDelta()
{
var title = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.ListBoxId, list));
CharacterSheet Sheet() => new() { Endurance = 180, AttributeBaseValues = [0, 200, 0, 0, 0, 0] };
CharacterStatController.Bind(layout, Sheet);
list.Children.OfType<UiClickablePanel>().ToList()[1].OnClick!(); // Endurance = index 1
Assert.Equal("Endurance: 180 (-20)", title.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_AttributeZeroDelta_NoParenthetical()
{
var title = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.ListBoxId, list));
CharacterSheet Sheet() => new() { Strength = 200, AttributeBaseValues = [200, 0, 0, 0, 0, 0] };
CharacterStatController.Bind(layout, Sheet);
list.Children.OfType<UiClickablePanel>().ToList()[0].OnClick!();
Assert.Equal("Strength: 200", title.LinesProvider()[0].Text);
}
[Fact]
public void SkillClick_VitaeOnly_FooterTitleShowsVitaeParenthetical()
{
// User-reported oracle (ISSUES.md #267): a base-303 skill under 33%
// vitae shows the current (reduced) level with "(-100)".
var list = new UiPanel { Width = 300 };
var title = new UiText();
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.FooterTitleId, title));
CharacterSheet Sheet() => VitaeSkillSheet(currentLevel: 203, baseLevel: 303, vitaeModifier: -100);
CharacterStatController.Bind(layout, Sheet, spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
SkillRows(list)[0].OnClick!();
Assert.Equal("Test Skill: 203 (-100)", title.LinesProvider()[0].Text);
}
[Fact]
public void SkillClick_VitaePlusBuff_FooterTitleShowsBothParentheticals()
{
var list = new UiPanel { Width = 300 };
var title = new UiText();
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.FooterTitleId, title));
// CurrentLevel=251, base=300, vitae modifier=-99 (300*0.67-300).
// Buff-only delta = (251 - (-99)) - 300 = 50.
CharacterSheet Sheet() => VitaeSkillSheet(currentLevel: 251, baseLevel: 300, vitaeModifier: -99);
CharacterStatController.Bind(layout, Sheet, spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
SkillRows(list)[0].OnClick!();
Assert.Equal("Test Skill: 251 (-99) (+50)", title.LinesProvider()[0].Text);
}
[Fact]
public void SkillFooter_UsesAuthoredPaletteForVitaeAndBuffRuns()
{
Vector4 normal = new(0.1f, 0.1f, 0.1f, 1f);
Vector4 buff = new(0.2f, 0.3f, 0.4f, 1f);
Vector4 debuff = new(0.5f, 0.6f, 0.7f, 1f);
Vector4 vitae = new(127f / 255f, 1f, 1f, 1f);
var list = new UiPanel { Width = 300 };
var title = new UiText
{
FontColorPalette = [normal, buff, debuff, vitae],
};
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.FooterTitleId, title));
CharacterSheet Sheet() => VitaeSkillSheet(
currentLevel: 251,
baseLevel: 300,
vitaeModifier: -99);
CharacterStatController.Bind(
layout,
Sheet,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
SkillRows(list)[0].OnClick!();
IReadOnlyList<UiText.TextRun> runs = title.RunsProvider!();
Assert.Equal(3, runs.Count);
Assert.Equal(("Test Skill: 251", normal), (runs[0].Text, runs[0].Color));
Assert.Equal((" (-99)", vitae), (runs[1].Text, runs[1].Color));
Assert.Equal((" (+50)", buff), (runs[2].Text, runs[2].Color));
}
[Fact]
public void SkillRow_ValueAndColorFollowLiveSheetWithoutTabRebuild()
{
var list = new UiPanel { Width = 300 };
var layout = Fake((CharacterStatController.ListBoxId, list));
CharacterSheet sheet = VitaeSkillSheet(
currentLevel: 300,
baseLevel: 300,
vitaeModifier: 0);
CharacterStatController.Bind(
layout,
() => sheet,
spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
UiText value = SkillRows(list)[0].Children.OfType<UiText>().ToList()[2];
Assert.Equal("300", value.LinesProvider()[0].Text);
Assert.Equal(Vector4.One, value.LinesProvider()[0].Color);
sheet = VitaeSkillSheet(
currentLevel: 350,
baseLevel: 300,
vitaeModifier: 0);
Assert.Equal("350", value.LinesProvider()[0].Text);
Assert.Equal(new Vector4(0f, 1f, 0f, 1f), value.LinesProvider()[0].Color);
}
[Fact]
public void SkillClick_ZeroDelta_NoParentheticals()
{
var list = new UiPanel { Width = 300 };
var title = new UiText();
var layout = Fake(
(CharacterStatController.ListBoxId, list),
(CharacterStatController.FooterTitleId, title));
CharacterSheet Sheet() => VitaeSkillSheet(currentLevel: 300, baseLevel: 300, vitaeModifier: 0);
CharacterStatController.Bind(layout, Sheet, spriteResolve: id => (id, 16, 16));
ClickTab(layout, left: 92f);
SkillRows(list)[0].OnClick!();
Assert.Equal("Test Skill: 300", title.LinesProvider()[0].Text);
}
private static CharacterSheet VitaeSkillSheet(int currentLevel, int baseLevel, int vitaeModifier) => new()
{
SkillCredits = 0,
UnassignedXp = 1_000_000,
Skills =
[
new CharacterSkill(
200u,
"Test Skill",
0x06000001u,
CharacterSkillAdvancementClass.Trained,
BaseLevel: baseLevel,
CurrentLevel: currentLevel,
UsableUntrained: true,
TrainedCost: 0,
SpecializedCost: 0,
RaiseCost: 100,
Raise10Cost: 1000,
VitaeModifier: vitaeModifier),
],
};
// ── SampleData sanity ─────────────────────────────────────────────────────
[Fact]
public void SampleCharacter_SkillCredits_Is96()
=> Assert.Equal(96, SampleData.SampleCharacter().SkillCredits);
[Fact]
public void SampleCharacter_UnassignedXp_IsSet()
=> Assert.Equal(87_757_321_741L, SampleData.SampleCharacter().UnassignedXp);
[Fact]
public void SampleCharacter_AttributeRaiseCosts_HasNineEntries()
{
var costs = SampleData.SampleCharacter().AttributeRaiseCosts;
Assert.NotNull(costs);
Assert.Equal(9, costs.Length);
}
[Fact]
public void SampleCharacter_AttributeRaise10Costs_HasNineEntries()
{
var costs = SampleData.SampleCharacter().AttributeRaise10Costs;
Assert.NotNull(costs);
Assert.Equal(9, costs.Length);
}
[Fact]
public void SampleCharacter_AttributeRaiseCosts_FocusAt110()
=> Assert.Equal(110L, SampleData.SampleCharacter().AttributeRaiseCosts[4]);
[Fact]
public void SampleCharacter_AttributeRaise10Costs_FocusAt1100()
=> Assert.Equal(1_100L, SampleData.SampleCharacter().AttributeRaise10Costs[4]);
[Fact]
public void SampleCharacter_AttributeRaiseCosts_StrengthAt0()
=> Assert.Equal(0L, SampleData.SampleCharacter().AttributeRaiseCosts[0]);
// ── UiText flag sanity ────────────────────────────────────────────────────
[Fact]
public void UiText_RightAligned_DefaultFalse()
{
var t = new UiText();
Assert.False(t.RightAligned);
}
[Fact]
public void UiText_RightAligned_CanBeSetTrue()
{
var t = new UiText { RightAligned = true };
Assert.True(t.RightAligned);
}
// ── Header captions (new — LevelCaptionId + TotalXpLabelId) ─────────────
[Fact]
public void Bind_LevelCaptionId_SetsCharacterLevelText()
{
var caption = new UiText();
var layout = Fake((CharacterStatController.LevelCaptionId, caption));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
// 2-line caption: "Character" (top) / "Level" (bottom) so it fits the 65px element.
var lines = caption.LinesProvider();
Assert.True(lines.Count >= 1, "LevelCaption must provide at least one line");
Assert.Equal("Character", lines[0].Text);
Assert.False(caption.Centered, "LevelCaption must be left-justified (Centered=false)");
Assert.False(caption.RightAligned, "LevelCaption must be left-justified (RightAligned=false)");
}
[Fact]
public void Bind_TotalXpLabelId_SetsTotalExperienceXpText()
{
var lbl = new UiText();
var layout = Fake((CharacterStatController.TotalXpLabelId, lbl));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal("Total Experience (XP):", lbl.LinesProvider()[0].Text);
Assert.False(lbl.Centered, "TotalXpLabel must be left-justified (Centered=false)");
Assert.False(lbl.RightAligned, "TotalXpLabel must be left-justified (RightAligned=false)");
}
[Fact]
public void Bind_TotalXpValue_IsRightAligned()
{
var value = new UiText { Centered = true };
var layout = Fake((CharacterStatController.TotalXpId, value));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.Equal((1_250_000_000L).ToString("N0"), value.LinesProvider()[0].Text);
Assert.False(value.Centered);
Assert.True(value.RightAligned);
}
// ── Polish Commit 1: name white, Infinity!, white footer title ─────────────
[Fact]
public void Bind_NameColor_IsWhite()
{
// Retail: name "Horan" is WHITE, not gold. (2026-06-26 ref)
var name = new UiText();
var layout = Fake((CharacterStatController.NameId, name));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var color = name.LinesProvider()[0].Color;
Assert.Equal(1f, color.X, precision: 3);
Assert.Equal(1f, color.Y, precision: 3);
Assert.Equal(1f, color.Z, precision: 3);
Assert.Equal(1f, color.W, precision: 3);
}
[Fact]
public void RowClick_MaxedRow_FooterLine1ValueIsInfinity()
{
// Strength (index 0) cost=0 → "Infinity!" per retail spec.
var val = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterLine1Value, val),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[0].OnClick!(); // Strength
Assert.Equal("Infinity!", val.LinesProvider()[0].Text);
}
[Fact]
public void RowClick_SelectedFooterTitle_IsWhite()
{
// State B footer title must be WHITE (retail 2026-06-26 ref).
var title = new UiText();
var list = new UiPanel();
var layout = Fake(
(CharacterStatController.FooterTitleId, title),
(CharacterStatController.ListBoxId, list));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
list.Children.OfType<UiClickablePanel>().ToList()[4].OnClick!(); // Focus
var color = title.LinesProvider()[0].Color;
Assert.Equal(1f, color.X, precision: 3);
Assert.Equal(1f, color.Y, precision: 3);
Assert.Equal(1f, color.Z, precision: 3);
Assert.Equal(1f, color.W, precision: 3);
}
[Fact]
public void Bind_FooterStateA_TitleColor_IsBodyNotWhite()
{
// State A title is body (parchment), not white.
var title = new UiText();
var layout = Fake((CharacterStatController.FooterTitleId, title));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
// Body = (0.92, 0.90, 0.82, 1.0) — check it's not pure white.
var color = title.LinesProvider()[0].Color;
Assert.True(color.X < 1f || color.Y < 1f || color.Z < 1f,
"State-A title should be body/parchment color, not pure white");
}
[Fact]
public void Bind_LevelCaptionId_SetsTwoLines()
{
// Retail: level caption is "Character" / "Level" on two lines (not truncated).
var caption = new UiText();
var layout = Fake((CharacterStatController.LevelCaptionId, caption));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
var lines = caption.LinesProvider();
Assert.Equal(2, lines.Count);
Assert.Equal("Character", lines[0].Text);
Assert.Equal("Level", lines[1].Text);
}
// ── Robustness ────────────────────────────────────────────────────────────
[Fact]
public void Bind_MissingElements_DoesNotThrow()
=> CharacterStatController.Bind(Fake(), SampleData.SampleCharacter);
// ── Fix 5: XP meter text children bound via FindElement ──────────────────
/// <summary>
/// Fix 5: the XP label (0x10000237) is a dat-origin UiText child of the XP meter
/// (now built by the importer). After Bind(), FindElement must return a UiText with
/// a LinesProvider that emits "XP for next level:".
/// </summary>
[Fact]
public void Bind_XpMeter_XpNextLabel_IsBoundViaFindElement()
{
var meter = new UiMeter();
var xpLabel = new UiText();
// Attach the label as a child of the meter so it matches the real importer layout.
meter.AddChild(xpLabel);
var layout = Fake(
(CharacterStatController.XpMeterId, meter),
(CharacterStatController.XpNextLabelId, xpLabel));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.NotNull(xpLabel.LinesProvider);
var lines = xpLabel.LinesProvider();
Assert.Single(lines);
Assert.Equal("XP for next level:", lines[0].Text);
}
/// <summary>
/// Fix 5: the XP value (0x10000238) is bound to the XpToNextLevel string.
/// ClickThrough=true and RightAligned=true must be set by the controller.
/// </summary>
[Fact]
public void Bind_XpMeter_XpNextValue_IsBoundViaFindElement()
{
var meter = new UiMeter();
var xpValue = new UiText();
meter.AddChild(xpValue);
var layout = Fake(
(CharacterStatController.XpMeterId, meter),
(CharacterStatController.XpNextValueId, xpValue));
CharacterStatController.Bind(layout, SampleData.SampleCharacter);
Assert.NotNull(xpValue.LinesProvider);
Assert.True(xpValue.ClickThrough, "XP value overlay must be ClickThrough");
Assert.True(xpValue.RightAligned, "XP value overlay must be RightAligned");
var lines = xpValue.LinesProvider();
Assert.Single(lines);
// XpToNextLevel from SampleData = 42_000_000L formatted as "42,000,000"
Assert.Equal((42_000_000L).ToString("N0"), lines[0].Text);
}
/// <summary>
/// Fix 5: if XpNextLabelId / XpNextValueId are absent from the layout (the old
/// ConsumesDatChildren path, or a test layout that doesn't include them), Bind()
/// must not throw — the meter Fill is still bound.
/// </summary>
[Fact]
public void Bind_XpMeter_MissingTextChildren_DoesNotThrow()
{
var meter = new UiMeter();
var layout = Fake((CharacterStatController.XpMeterId, meter));
// No XpNextLabelId or XpNextValueId in the layout.
var ex = Record.Exception(() =>
CharacterStatController.Bind(layout, SampleData.SampleCharacter));
Assert.Null(ex);
// Fill must still be bound.
Assert.NotNull(meter.Fill());
}
[Fact]
public void ProductionFixture_MountedPagesUseRetailListFooterAndScrollbarReflow()
{
var layout = FixtureLoader.LoadCharacter();
CharacterStatController.Bind(
layout,
SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
ApplyLayoutPass(layout.Root);
var page = layout.Root.Children.Single(
e => e.DatElementId == CharacterStatController.AttributesPageId);
var list = Descendants(page).Single(
e => e.DatElementId == CharacterStatController.ListBoxId);
var statLayout = list.Parent!;
var scrollbar = statLayout.Children.OfType<UiScrollbar>().Single(
e => e.DatElementId == CharacterStatController.ListScrollbarId);
var divider = statLayout.Children.Single(
e => e.DatElementId == CharacterStatController.ListDividerId);
var footers = statLayout.Children.Where(
e => e.DatElementId is CharacterStatController.FooterStateAId
or CharacterStatController.FooterStateBId
or CharacterStatController.FooterStateCId).ToList();
Assert.Equal((112f, 398f), (list.Top, list.Height));
Assert.Equal((112f, 398f), (scrollbar.Top, scrollbar.Height));
Assert.Equal((510f, 7f), (divider.Top, divider.Height));
Assert.Equal(3, footers.Count);
Assert.All(footers, footer => Assert.Equal((520f, 55f), (footer.Top, footer.Height)));
Assert.False(
scrollbar.Visible,
$"pre-skills scrollbar: model={scrollbar.Model is not null}, " +
$"resolve={scrollbar.SpriteResolve is not null}, track=0x{scrollbar.TrackSprite:X8}");
ClickTab(layout, left: 92f);
Assert.True(scrollbar.Visible);
Assert.NotNull(scrollbar.Model);
Assert.NotNull(scrollbar.SpriteResolve);
Assert.Equal(0x06004C5Fu, scrollbar.TrackSprite);
// Retail seating (2026-08-24): top = the INCREMENT designee's
// UP-arrow art, bottom = the DECREMENT designee's DOWN-arrow.
Assert.Equal(RetailScrollbarChrome.UpNormal, scrollbar.UpSprite);
Assert.Equal(RetailScrollbarChrome.DownNormal, scrollbar.DownSprite);
Assert.Equal(RetailScrollbarChrome.UpRollover, scrollbar.UpRolloverSprite);
Assert.Equal(RetailScrollbarChrome.ThumbMidRollover, scrollbar.ThumbRolloverSprite);
}
/// <summary>
/// 2026-08-24 owner report: "hovering the scrollbar and arrows does
/// nothing" — root-level hover through the REAL mounted character
/// fixture (production element tree, overlays and z-order included).
/// </summary>
[Fact]
public void ProductionFixture_HoveringTheSkillScrollbar_SelectsRolloverMedia()
{
var layout = FixtureLoader.LoadCharacter();
CharacterStatController.Bind(
layout,
SampleData.SampleCharacter,
spriteResolve: id => (id, 16, 16));
var root = new UiRoot { Width = 800f, Height = 600f };
root.AddChild(layout.Root);
ApplyLayoutPass(layout.Root);
ClickTab(layout, left: 92f);
var page = layout.Root.Children.Single(
e => e.DatElementId == CharacterStatController.AttributesPageId);
var list = Descendants(page).Single(
e => e.DatElementId == CharacterStatController.ListBoxId);
var scrollbar = list.Parent!.Children.OfType<UiScrollbar>().Single(
e => e.DatElementId == CharacterStatController.ListScrollbarId);
Assert.True(scrollbar.Visible);
// The headless harness never measures row content; give the REAL
// bound model an overflowing extent so the bar is enabled the way
// a populated skills list is in production.
Assert.NotNull(scrollbar.Model);
scrollbar.Model!.ContentHeight = 800;
scrollbar.Model.ViewHeight = 398;
Assert.False(scrollbar.IsModelDisabled);
var screen = scrollbar.ScreenPosition;
// Over the up arrow (5px into the 16px top button).
root.OnMouseMove((int)(screen.X + 8f), (int)(screen.Y + 5f));
Assert.Equal(
RetailScrollbarChrome.UpRollover, scrollbar.ActiveStartSpriteForTest);
// Over the thumb (just below the up button; thumb starts at track top).
root.OnMouseMove((int)(screen.X + 8f), (int)(screen.Y + 24f));
Assert.Equal(
RetailScrollbarChrome.ThumbMidRollover, scrollbar.ActiveThumbSpriteForTest);
}
// ── Helpers ──────────────────────────────────────────────────────────────
private static void ClickTab(ImportedLayout layout, float left)
{
uint id = left switch
{
0f => CharacterStatController.TabAttribId,
92f => CharacterStatController.TabSkillsId,
_ => CharacterStatController.TabTitlesId,
};
var tab = Assert.IsType<UiText>(layout.FindElement(id));
tab.OnClick!();
}
private static void ApplyLayoutPass(UiElement parent)
{
foreach (var child in parent.Children)
{
child.ApplyAnchor(parent.Width, parent.Height);
ApplyLayoutPass(child);
}
}
private static string FirstRowName(UiElement list)
{
var row = Descendants(list).OfType<UiClickablePanel>().FirstOrDefault();
if (row is null) return "<no row>";
var texts = row.Children.OfType<UiText>().ToList();
return texts.Count > 1 ? texts[1].LinesProvider()[0].Text : "<no text>";
}
private static List<UiClickablePanel> SkillRows(UiElement list)
=> Descendants(list).OfType<UiClickablePanel>().ToList();
private static List<UiPanel> SkillHeaders(UiElement list)
=> Descendants(list)
.Where(c => c is UiPanel and not UiClickablePanel
&& c.Children.OfType<UiText>().Any())
.Cast<UiPanel>()
.ToList();
private static IEnumerable<UiElement> Descendants(UiElement root)
{
foreach (var child in root.Children)
{
yield return child;
foreach (var nested in Descendants(child))
yield return nested;
}
}
private static UiDatElement MakeDatElement(uint id, float top, float width, float height)
{
var info = new ElementInfo
{
Id = id,
Type = 3,
Y = top,
Width = width,
Height = height,
};
return new UiDatElement(info, static _ => (0u, 0, 0))
{
Top = top,
Width = width,
Height = height,
};
}
/// <summary>Manufacture a minimal UiButton with retail normal/ghosted states.</summary>
private static UiButton MakeButton(uint id = 0u)
{
var info = new ElementInfo { Id = id, Type = 1 };
info.StateMedia["Normal"] = (1u, 1);
info.StateMedia["Ghosted"] = (2u, 1);
return new UiButton(info, static _ => (0u, 0, 0));
}
private static UiText MakeTab(uint id, float left)
{
var info = new ElementInfo
{
Id = id,
Type = 12,
X = left,
Width = 92f,
Height = 25f,
DefaultStateId = RetailUiStateIds.Closed,
DefaultStateName = "Closed",
};
info.States[RetailUiStateIds.Closed] = new UiStateInfo
{
Id = RetailUiStateIds.Closed,
Name = "Closed",
PassToChildren = true,
};
info.States[RetailUiStateIds.Open] = new UiStateInfo
{
Id = RetailUiStateIds.Open,
Name = "Open",
PassToChildren = true,
};
return Assert.IsType<UiText>(DatWidgetFactory.Create(info, static _ => (0u, 0, 0), null));
}
private static ImportedLayout Fake(params (uint id, UiElement e)[] items)
{
var dict = new Dictionary<uint, UiElement>();
var root = new UiPanel();
foreach (var (id, e) in items)
{
root.AddChild(e);
dict[id] = e;
}
foreach ((uint id, float left) in new[]
{
(CharacterStatController.TabAttribId, 0f),
(CharacterStatController.TabSkillsId, 92f),
(CharacterStatController.TabTitlesId, 184f),
})
{
if (dict.ContainsKey(id)) continue;
UiText tab = MakeTab(id, left);
root.AddChild(tab);
dict[id] = tab;
}
return new ImportedLayout(root, dict);
}
}