cc58289967
BLOCKER: ChatSettings.DefaultOpacity shipped retail's base ChatInterface value (0.5) as ONE shared global default applied to every RetailWindowManager-registered window, not just the four floating chat windows retail itself fades. That faded the whole out-of-box registered UI (radar, vitals, toolbar, main chat, ...) to 50% opacity, including several windows that can never take keyboard focus and so were stuck at 0.5 permanently. Fixed to gmMainChatUI's 1.0/1.0 override (0x004CD0F0) instead — retail-identical opaque presentation for the 11 non-chat windows and the main chat window; only the four floating chat windows now diverge from retail's 0.5-while-idle default, and the Settings -> Chat transparency slider remains fully user-settable. AP-190 reworded and gains two new decomp-verified clauses: (3) retail eases opacity toward its target by 5% of the delta per tick (ChatInterface::ListenToGlobalMessage @0x004F3840, armed from the focus element-messages at @0x004F5275) where acdream snaps -- deferred, needs a UI frame-tick hook the opacity controller doesn't have; (4) retail's focus predicate is the chat ENTRY FIELD specifically (ChatInterface::IsTextEntryFocused @0x004F30A0) where acdream uses any-focusable-descendant. Both findings + the pre-existing UiMenu.cs PushAlphaAbsolute(1f) popup bypass are folded into the window-shell research doc's opacity section. NITs: fixed the stale "text bypasses the alpha" comment in UiElement.DrawSelfAndChildren (CH6c already routed DrawStringDat/ DrawString through the same ApplyAlpha chokepoint as sprites/rects); added RetailWindowManager.WindowUnregistered + wired RetailWindowOpacityController to detach and forget a window unregistered while it held focus (previously only Dispose detached, leaking any window unregistered mid-focus for the rest of the session); added post-Dispose no-op guards to the three Set* opacity mutators; added a DrawString (BitmapFont path) alpha regression test and a DrawStringDat outline/background-pass alpha test (the existing tests only ever exercised the foreground/fill pass). Also fixes RuntimeSettingsControllerTests.SettingsViewModelSavePreserves SectionAndTargetOrder's now-stale "target-chat-opacity:0.5:1" expectation (caught by the full-suite run this fix requires) to match the new 1.0 default. Campaign ledger CH6c row updated to APPROVE-WITH-FIXES. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
64 lines
2.6 KiB
C#
64 lines
2.6 KiB
C#
using AcDream.UI.Abstractions.Panels.Settings;
|
|
|
|
namespace AcDream.UI.Abstractions.Tests.Panels.Settings;
|
|
|
|
/// <summary>
|
|
/// L.0: <see cref="ChatSettings"/> default-pin tests.
|
|
/// </summary>
|
|
public sealed class ChatSettingsTests
|
|
{
|
|
[Fact]
|
|
public void Default_values_match_AceCharacterOptions2Default_stance()
|
|
{
|
|
// N4 (CH3 Opus review): ACE's real CharacterOptions2.Default
|
|
// (0x00948700) turns General/Trade/LFG on but leaves Roleplay
|
|
// (0x800) and Society (0x80000) off — this is no longer an
|
|
// invented "all channels on" stance.
|
|
var d = ChatSettings.Default;
|
|
Assert.True(d.HearGeneralChat);
|
|
Assert.True(d.HearTradeChat);
|
|
Assert.True(d.HearLFGChat);
|
|
Assert.False(d.HearRoleplayChat);
|
|
Assert.False(d.HearSocietyChat);
|
|
Assert.False(d.AppearOffline);
|
|
Assert.True(d.ShowTimestamps);
|
|
Assert.True(d.FilterProfanity);
|
|
Assert.Equal(12f, d.FontSize);
|
|
|
|
// Campaign CH slice CH6c: retail's base ChatInterface constructor
|
|
// (0x004F4550) sets DefaultOpacity=0.5/ActiveOpacity=1.0 — the value
|
|
// every gmFloatyChatUI (the four floating windows) keeps unmodified.
|
|
// CH6c review fix (2026-08-10): shipping the base pair as acdream's
|
|
// ONE shared global default faded every registered window (radar,
|
|
// vitals, toolbar, main chat, ...) to 50% opacity out of the box,
|
|
// including several that can never take keyboard focus and so were
|
|
// permanently half-transparent. acdream now ships gmMainChatUI's own
|
|
// 1.0/1.0 override (0x004CD0F0) as the shared global default instead
|
|
// — retail-identical opaque presentation for the 11 non-chat windows
|
|
// and the main chat window; only the four floating chat windows
|
|
// diverge from retail's 0.5-while-idle fade, and the Settings → Chat
|
|
// transparency slider remains fully user-settable (register row
|
|
// AP-190).
|
|
Assert.Equal(1.0f, d.DefaultOpacity);
|
|
Assert.Equal(1.0f, d.ActiveOpacity);
|
|
}
|
|
|
|
[Fact]
|
|
public void Equality_is_value_based()
|
|
{
|
|
var a = ChatSettings.Default;
|
|
var b = ChatSettings.Default with { HearTradeChat = false };
|
|
var c = ChatSettings.Default with { HearTradeChat = false };
|
|
Assert.NotEqual(a, b);
|
|
Assert.Equal(b, c);
|
|
}
|
|
|
|
[Fact]
|
|
public void With_expression_clones_one_field()
|
|
{
|
|
var d = ChatSettings.Default with { FontSize = 16f };
|
|
Assert.Equal(16f, d.FontSize);
|
|
Assert.True(d.HearGeneralChat);
|
|
Assert.True(d.ShowTimestamps);
|
|
}
|
|
}
|