9f152d9754
Final code review of Phase 1 flagged that the three flag-mutating tests leaked static state across test boundaries. Wrap each in try/finally that snapshots IndoorAll on entry and restores it on exit, matching the PhysicsDiagnosticsTests pattern at line 30-49. Tests now safe under parallel test runs + future additions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
92 lines
3.4 KiB
C#
92 lines
3.4 KiB
C#
using AcDream.Core.Rendering;
|
|
using Xunit;
|
|
|
|
namespace AcDream.Core.Tests.Rendering;
|
|
|
|
public sealed class RenderingDiagnosticsTests
|
|
{
|
|
// Each flag-mutating test snapshots the IndoorAll state on entry and
|
|
// restores it via try/finally. RenderingDiagnostics is a process-wide
|
|
// static (env-var-initialized); without restoration a mutated state
|
|
// leaks into other tests + into parallel test runs. Mirrors the
|
|
// PhysicsDiagnosticsTests pattern at line 30-49.
|
|
|
|
[Fact]
|
|
public void IndoorAll_True_TurnsAllFlagsOn()
|
|
{
|
|
bool initial = RenderingDiagnostics.IndoorAll;
|
|
try
|
|
{
|
|
// Reset all flags off first to make the test deterministic
|
|
// regardless of env-var state on the test runner.
|
|
RenderingDiagnostics.ProbeIndoorWalkEnabled = false;
|
|
RenderingDiagnostics.ProbeIndoorLookupEnabled = false;
|
|
RenderingDiagnostics.ProbeIndoorUploadEnabled = false;
|
|
RenderingDiagnostics.ProbeIndoorXformEnabled = false;
|
|
RenderingDiagnostics.ProbeIndoorCullEnabled = false;
|
|
|
|
RenderingDiagnostics.IndoorAll = true;
|
|
|
|
Assert.True(RenderingDiagnostics.ProbeIndoorWalkEnabled);
|
|
Assert.True(RenderingDiagnostics.ProbeIndoorLookupEnabled);
|
|
Assert.True(RenderingDiagnostics.ProbeIndoorUploadEnabled);
|
|
Assert.True(RenderingDiagnostics.ProbeIndoorXformEnabled);
|
|
Assert.True(RenderingDiagnostics.ProbeIndoorCullEnabled);
|
|
Assert.True(RenderingDiagnostics.IndoorAll);
|
|
}
|
|
finally
|
|
{
|
|
RenderingDiagnostics.IndoorAll = initial;
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void IndoorAll_False_TurnsAllFlagsOff()
|
|
{
|
|
bool initial = RenderingDiagnostics.IndoorAll;
|
|
try
|
|
{
|
|
RenderingDiagnostics.IndoorAll = true; // start from all-on
|
|
RenderingDiagnostics.IndoorAll = false;
|
|
|
|
Assert.False(RenderingDiagnostics.ProbeIndoorWalkEnabled);
|
|
Assert.False(RenderingDiagnostics.ProbeIndoorLookupEnabled);
|
|
Assert.False(RenderingDiagnostics.ProbeIndoorUploadEnabled);
|
|
Assert.False(RenderingDiagnostics.ProbeIndoorXformEnabled);
|
|
Assert.False(RenderingDiagnostics.ProbeIndoorCullEnabled);
|
|
Assert.False(RenderingDiagnostics.IndoorAll);
|
|
}
|
|
finally
|
|
{
|
|
RenderingDiagnostics.IndoorAll = initial;
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void IndoorAll_OneOff_ReadsAsFalse()
|
|
{
|
|
bool initial = RenderingDiagnostics.IndoorAll;
|
|
try
|
|
{
|
|
RenderingDiagnostics.IndoorAll = true;
|
|
RenderingDiagnostics.ProbeIndoorCullEnabled = false; // flip one off
|
|
Assert.False(RenderingDiagnostics.IndoorAll);
|
|
}
|
|
finally
|
|
{
|
|
RenderingDiagnostics.IndoorAll = initial;
|
|
}
|
|
}
|
|
|
|
[Theory]
|
|
[InlineData(0x00000029ul, false)] // outdoor cell 0x29 in 8x8 grid
|
|
[InlineData(0xA9B40029ul, false)] // outdoor cell with landblock prefix
|
|
[InlineData(0x00000100ul, true)] // indoor cell minimum
|
|
[InlineData(0x00000105ul, true)] // typical Holtburg Inn interior
|
|
[InlineData(0xA9B40105ul, true)] // indoor with landblock prefix
|
|
[InlineData(0xA9B401FFul, true)] // indoor near top of range
|
|
public void IsEnvCellId_DistinguishesOutdoorVsIndoorByLow16Bits(ulong id, bool expected)
|
|
{
|
|
Assert.Equal(expected, RenderingDiagnostics.IsEnvCellId(id));
|
|
}
|
|
}
|