OP2 (df9c7a35) was double-REJECTed: an unconditional Type-8/Type-5 factory
mapping silently re-classed 15 elements across 7 shipped panels (vendor
backdrop lost its fill, character/spellbook roots stopped passing clicks
through, combat gained a phantom import-time tab takeover, ten ListBoxes
gained a spurious hit-testable viewport) because the stale 27 pre-existing
fixtures never exercised the new fields — and the mechanism itself cited a
nonexistent "UIElement_TabControl" class, inverted UiCheckboxBitfield64's
checked-state predicate, and synthesized fake per-row geometry instead of
using the widget's own authored template.
Shape change: UiTabPanel (renamed from UiTabControl) and UiTemplateListBox
now derive from UiDatElement (unsealed) and stay DORMANT by default — an
imported Type-8/Type-5 element gets authored-media drawing, ClickThrough
generic-decoration default, and IUiDatStateful propagation identical to the
pre-OP2 UiDatElement fallback, with zero import-time side effects. The
factory's Type-8/Type-5 arms are unconditional again (no more guard whose
premise the blast-radius sweep proved false), because dormancy makes an
unactivated instance behaviorally indistinguishable from the old fallback.
UiTabPanel.ActivateTabBehavior() and UiTemplateListBox's lazy viewport
creation are the explicit, controller-driven opt-ins Campaign OP slice OP3+
will call; today nothing does, so the four pre-existing shipped Type-8
hosts (character/spellbook/vendor/combat) and ten pre-existing Type-5
ListBoxes keep their pre-OP2 behavior exactly. Filed AD-73 for this
dormant-vs-retail's-unconditional-activation adaptation.
Mechanism fixes (docs/research/2026-08-11-op2-review-mechanism.md):
- UiTabPanel cites UIElement_Panel (Type 8 is UIElement_Panel; no
UIElement_TabControl exists in the PDB), resolves buttons/pages via a
GetChildRecursive-equivalent descendant search (not direct-children-only),
performs no switch when no entry authors 0x32 (deleted the _tabs[0]
fallback), and surfaces unresolved tab-table entries via UnresolvedEntries
+ a diagnostic line instead of a silent no-op.
- ElementReader.ReadTabTable skips entries missing 0x30/0x31, matching
retail's SetupTabPageHash @0x0046C2E0 entry filter.
- UiCheckboxBitfield64 now builds every row from its OWN authored template
(property 0x64 -> {0x2100002B, 0x10000521}) via AddItemFromTemplateList,
deleting the synthesized ElementInfo + invented RowHeight=14 — matching
retail's CreateChildren @0x00485DF0, which is itself a UIElement_ListBox
call. IsSet is now retail's ANY-bit-set predicate (Refresh @0x004859C0),
not all-bits-set. TS-72 retired: the click-toggle bit math is now fully
decomp-confirmed (SetBitsOnOrOff via ListenToElementMessage @0x00485AE0).
Regenerated all 32 UI fixtures against real DAT (ACDREAM_REGENERATE_UI_FIXTURES=1)
and committed them — 27 pre-existing fixtures now carry Outline/OutlineColor/
TabTable/TemplateList/ScrollbarElementId; the 5 Options fixtures were already
current. Updated EffectsUiControllerTests' now-correct UiTemplateListBox
class-identity assertion. Added: 6 built-widget behavior pins for all five
pre-existing Type-8 elements + a representative Type-5 element the dormancy
model protects (OP2ReworkBlastRadiusConformanceTests.cs); 5 reader-level
tests driving ReadTabTable/ReadTemplateList/the 0x72 reader from raw
property bags (ElementReaderTests.cs); a multi-bit-mask UiCheckboxBitfield64
test proving the any-bit predicate (the prior single-bit test couldn't
distinguish it from all-bits); an activation-idempotency test and a
before-activation click-is-inert test for UiTabPanel.
Full Release suite: 12,868 passed / 4 skipped / 0 failed (baseline 12,853/4/0
post-OP1-fixes; +15 net new tests, zero regressions).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
481 lines
20 KiB
C#
481 lines
20 KiB
C#
using System.Numerics;
|
|
using AcDream.App.UI;
|
|
using AcDream.App.UI.Layout;
|
|
namespace AcDream.App.Tests.UI.Layout;
|
|
|
|
public class ElementReaderTests
|
|
{
|
|
// ── ToAnchors (decomp-backed: UIElement::UpdateForParentSizeChange @0x00462640) ─────────────
|
|
|
|
/// <summary>
|
|
/// Top edge (L=1,T=1,R=1,B=2): LeftEdge==1 → Left; RightEdge==1 → Right (stretch);
|
|
/// TopEdge==1 → Top; BottomEdge==2 (not 1/4, top≠2) → no Bottom.
|
|
/// This is the top chrome edge — it pins left, stretches width, pins top, fixed height.
|
|
/// Real vitals values from format doc §11 (0x10000634).
|
|
/// </summary>
|
|
[Fact]
|
|
public void ToAnchors_TopEdge_StretchesWidth()
|
|
{
|
|
var a = ElementReader.ToAnchors(left: 1, top: 1, right: 1, bottom: 2);
|
|
Assert.True(a.HasFlag(AnchorEdges.Left));
|
|
Assert.True(a.HasFlag(AnchorEdges.Top));
|
|
Assert.True(a.HasFlag(AnchorEdges.Right));
|
|
Assert.False(a.HasFlag(AnchorEdges.Bottom));
|
|
}
|
|
|
|
/// <summary>
|
|
/// TL corner (L=1,T=1,R=2,B=2): LeftEdge==1 → Left; RightEdge==2 (not 1/4), left≠2 → no Right;
|
|
/// TopEdge==1 → Top; BottomEdge==2, top≠2 → no Bottom. Fixed size, pinned top-left.
|
|
/// Real vitals values from format doc §11 (0x10000633).
|
|
/// </summary>
|
|
[Fact]
|
|
public void ToAnchors_TlCorner_PinsTopLeftFixed()
|
|
{
|
|
var a = ElementReader.ToAnchors(left: 1, top: 1, right: 2, bottom: 2);
|
|
Assert.True(a.HasFlag(AnchorEdges.Left));
|
|
Assert.True(a.HasFlag(AnchorEdges.Top));
|
|
Assert.False(a.HasFlag(AnchorEdges.Right));
|
|
Assert.False(a.HasFlag(AnchorEdges.Bottom));
|
|
}
|
|
|
|
/// <summary>
|
|
/// TR corner (L=2,T=1,R=1,B=2): LeftEdge==2 → triggers Right (track-right); RightEdge==1 → Right;
|
|
/// left≠1 → no Left; TopEdge==1 → Top; BottomEdge==2, top≠2 → no Bottom.
|
|
/// Fixed-width element whose left and right both track the parent's right edge.
|
|
/// Real vitals values from format doc §11 (0x10000635).
|
|
/// </summary>
|
|
[Fact]
|
|
public void ToAnchors_TrCorner_TracksRight()
|
|
{
|
|
var a = ElementReader.ToAnchors(left: 2, top: 1, right: 1, bottom: 2);
|
|
Assert.False(a.HasFlag(AnchorEdges.Left));
|
|
Assert.True(a.HasFlag(AnchorEdges.Top));
|
|
Assert.True(a.HasFlag(AnchorEdges.Right));
|
|
Assert.False(a.HasFlag(AnchorEdges.Bottom));
|
|
}
|
|
|
|
/// <summary>
|
|
/// Left edge (L=1,T=1,R=2,B=1): LeftEdge==1 → Left; RightEdge==2, left≠2 → no Right;
|
|
/// TopEdge==1 → Top; BottomEdge==1 → Bottom. Pins left+top+bottom, fixed width, stretches height.
|
|
/// Real vitals values from format doc §11 (0x10000636).
|
|
/// </summary>
|
|
[Fact]
|
|
public void ToAnchors_LeftEdge_StretchesHeight()
|
|
{
|
|
var a = ElementReader.ToAnchors(left: 1, top: 1, right: 2, bottom: 1);
|
|
Assert.True(a.HasFlag(AnchorEdges.Left));
|
|
Assert.True(a.HasFlag(AnchorEdges.Top));
|
|
Assert.False(a.HasFlag(AnchorEdges.Right));
|
|
Assert.True(a.HasFlag(AnchorEdges.Bottom));
|
|
}
|
|
|
|
/// <summary>
|
|
/// All-ones (L=1,T=1,R=1,B=1): all four flags fire — Left, Right, Top, Bottom.
|
|
/// A piece pinned to all four sides stretches both horizontally and vertically.
|
|
/// </summary>
|
|
[Fact]
|
|
public void ToAnchors_Meter_StretchesBoth()
|
|
{
|
|
var a = ElementReader.ToAnchors(left: 1, top: 1, right: 1, bottom: 1);
|
|
Assert.True(a.HasFlag(AnchorEdges.Left));
|
|
Assert.True(a.HasFlag(AnchorEdges.Top));
|
|
Assert.True(a.HasFlag(AnchorEdges.Right));
|
|
Assert.True(a.HasFlag(AnchorEdges.Bottom));
|
|
}
|
|
|
|
/// <summary>
|
|
/// All-zero edge flags (prototype-only elements) fall back to Left|Top default.
|
|
/// </summary>
|
|
[Fact]
|
|
public void EdgeFlagsToAnchors_AllZero_DefaultsToTopLeft()
|
|
{
|
|
var a = ElementReader.ToAnchors(left: 0, top: 0, right: 0, bottom: 0);
|
|
Assert.Equal(AnchorEdges.Left | AnchorEdges.Top, a);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Value 3 on left and right axes contributes no Left/Right anchor;
|
|
/// TopEdge==1 → Top; BottomEdge==1 → Bottom.
|
|
/// left=3 (not 1/4) → no Left; right=3 (not 1/4), left≠2 → no Right;
|
|
/// top=1 → Top; bottom=1 → Bottom. Result: Top|Bottom.
|
|
/// </summary>
|
|
[Fact]
|
|
public void EdgeFlagsToAnchors_ValueThree_HorizAxes_YieldsTopBottom()
|
|
{
|
|
var a = ElementReader.ToAnchors(left: 3, top: 1, right: 3, bottom: 1);
|
|
Assert.False(a.HasFlag(AnchorEdges.Left));
|
|
Assert.True(a.HasFlag(AnchorEdges.Top));
|
|
Assert.False(a.HasFlag(AnchorEdges.Right));
|
|
Assert.True(a.HasFlag(AnchorEdges.Bottom));
|
|
}
|
|
|
|
// ── Merge ────────────────────────────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public void Merge_BaseThenOverride_DerivedWins()
|
|
{
|
|
var base_ = new ElementInfo { Type = 0, FontDid = 0x40000000, Width = 150, Height = 16 };
|
|
var derived = new ElementInfo { Type = 0, Width = 200 }; // overrides width, inherits font + height
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(200, merged.Width); // override
|
|
Assert.Equal(16, merged.Height); // inherited
|
|
Assert.Equal(0x40000000u, merged.FontDid);// inherited
|
|
}
|
|
|
|
[Fact]
|
|
public void Merge_DerivedHasFontDid_OverridesBase()
|
|
{
|
|
var base_ = new ElementInfo { FontDid = 0x40000000, Width = 100, Height = 10 };
|
|
var derived = new ElementInfo { FontDid = 0x40000001, Width = 100 };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(0x40000001u, merged.FontDid);
|
|
}
|
|
|
|
[Fact]
|
|
public void Merge_DerivedStateMediaOverridesBase()
|
|
{
|
|
var base_ = new ElementInfo();
|
|
base_.StateMedia[""] = (0x06001000u, 1);
|
|
base_.StateMedia["HideDetail"] = (0x06001001u, 1);
|
|
|
|
var derived = new ElementInfo();
|
|
derived.StateMedia[""] = (0x06002000u, 3); // overrides base default state
|
|
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
// derived's "" overrides base's ""
|
|
Assert.Equal((0x06002000u, 3), merged.StateMedia[""]);
|
|
// base's "HideDetail" is kept (derived didn't provide it)
|
|
Assert.Equal((0x06001001u, 1), merged.StateMedia["HideDetail"]);
|
|
}
|
|
|
|
[Fact]
|
|
public void Merge_DerivedStateCursorOverridesBase()
|
|
{
|
|
var base_ = new ElementInfo();
|
|
base_.StateCursors[""] = new UiCursorMedia(0x06003000u, 1, 2);
|
|
base_.StateCursors["Drag_rollover_accept"] = new UiCursorMedia(0x06003001u, 3, 4);
|
|
|
|
var derived = new ElementInfo();
|
|
derived.StateCursors[""] = new UiCursorMedia(0x06004000u, 5, 6);
|
|
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
|
|
Assert.Equal(new UiCursorMedia(0x06004000u, 5, 6), merged.StateCursors[""]);
|
|
Assert.Equal(new UiCursorMedia(0x06003001u, 3, 4), merged.StateCursors["Drag_rollover_accept"]);
|
|
}
|
|
|
|
[Fact]
|
|
public void Merge_ChildrenComeFromDerived()
|
|
{
|
|
var base_ = new ElementInfo();
|
|
base_.Children.Add(new ElementInfo { Id = 0x1u });
|
|
|
|
var derived = new ElementInfo();
|
|
derived.Children.Add(new ElementInfo { Id = 0x2u });
|
|
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
// children must come from derived only
|
|
Assert.Single(merged.Children);
|
|
Assert.Equal(0x2u, merged.Children[0].Id);
|
|
}
|
|
|
|
// ── HJustify / VJustify — Merge propagation ─────────────────────────────
|
|
|
|
/// <summary>
|
|
/// When the derived element has a non-Center HJustify, the derived value wins
|
|
/// (same "non-default wins" rule as FontDid).
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedHJustifyRight_OverridesBaseCenter()
|
|
{
|
|
var base_ = new ElementInfo { HJustify = HJustify.Center };
|
|
var derived = new ElementInfo { HJustify = HJustify.Right };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(HJustify.Right, merged.HJustify);
|
|
}
|
|
|
|
/// <summary>
|
|
/// When the derived element has the default HJustify (Center), the base value
|
|
/// is inherited — Center from the derived does NOT override a Left base.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedHJustifyCenter_InheritsBaseLeft()
|
|
{
|
|
var base_ = new ElementInfo { HJustify = HJustify.Left };
|
|
var derived = new ElementInfo { HJustify = HJustify.Center }; // default — no explicit dat property
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(HJustify.Left, merged.HJustify);
|
|
}
|
|
|
|
/// <summary>
|
|
/// VJustify=Top from the base propagates when the derived element has no explicit
|
|
/// (Center) vertical justification.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_BaseVJustifyTop_InheritedWhenDerivedIsCenter()
|
|
{
|
|
var base_ = new ElementInfo { VJustify = VJustify.Top };
|
|
var derived = new ElementInfo { VJustify = VJustify.Center }; // default
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(VJustify.Top, merged.VJustify);
|
|
}
|
|
|
|
/// <summary>
|
|
/// VJustify=Bottom from the derived element wins over a Center base.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedVJustifyBottom_OverridesBaseCenter()
|
|
{
|
|
var base_ = new ElementInfo { VJustify = VJustify.Center };
|
|
var derived = new ElementInfo { VJustify = VJustify.Bottom };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(VJustify.Bottom, merged.VJustify);
|
|
}
|
|
|
|
// ── FontColor — Merge propagation (Fix B) ────────────────────────────────
|
|
|
|
/// <summary>
|
|
/// When the derived element has an explicit (non-null) FontColor, the derived value
|
|
/// wins in Merge — same "non-null derived wins" rule used for FontDid and HJustify.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedFontColor_OverridesBaseNull()
|
|
{
|
|
var base_ = new ElementInfo { FontColor = null };
|
|
var derived = new ElementInfo { FontColor = new Vector4(1f, 0f, 0f, 1f) };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(new Vector4(1f, 0f, 0f, 1f), merged.FontColor);
|
|
}
|
|
|
|
/// <summary>
|
|
/// When the derived element has no FontColor (null), the base's FontColor is inherited.
|
|
/// A null-derived must NOT override a non-null base.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedFontColorNull_InheritsBaseColor()
|
|
{
|
|
var gold = new Vector4(1f, 0.82f, 0.36f, 1f);
|
|
var base_ = new ElementInfo { FontColor = gold };
|
|
var derived = new ElementInfo { FontColor = null }; // default — no dat property
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(gold, merged.FontColor);
|
|
}
|
|
|
|
/// <summary>
|
|
/// When neither base nor derived carries a FontColor, the merged result is null.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_BothFontColorNull_MergedIsNull()
|
|
{
|
|
var base_ = new ElementInfo { FontColor = null };
|
|
var derived = new ElementInfo { FontColor = null };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Null(merged.FontColor);
|
|
}
|
|
|
|
// ── Outline / OutlineColor — property 0x21/0x22 (Campaign CH round 4) ──────
|
|
|
|
/// <summary>
|
|
/// A derived element that authors 0x21=true wins over an un-outlined base —
|
|
/// same "derived wins" convention as FontDid. This is the SpewBox line
|
|
/// template's own shape: its base style (0x10000377) authors no outline; the
|
|
/// line template's own state does.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedOutlineTrue_OverridesBaseFalse()
|
|
{
|
|
var base_ = new ElementInfo { Outline = false };
|
|
var derived = new ElementInfo { Outline = true };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.True(merged.Outline);
|
|
}
|
|
|
|
/// <summary>
|
|
/// A derived element that does NOT author 0x21 (stays at the false default)
|
|
/// inherits an outlined base rather than clobbering it — the same "false/zero
|
|
/// derived never overrides a set base" rule HJustify/FontDid already use.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedOutlineFalse_InheritsOutlinedBase()
|
|
{
|
|
var base_ = new ElementInfo { Outline = true };
|
|
var derived = new ElementInfo { Outline = false };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.True(merged.Outline);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Neither base nor derived authors 0x21 — the chat transcript's own shape
|
|
/// (style 0x10000372 authors no outline anywhere in its chain).
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_NeitherOutlines_MergedStaysFalse()
|
|
{
|
|
var base_ = new ElementInfo { Outline = false };
|
|
var derived = new ElementInfo { Outline = false };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.False(merged.Outline);
|
|
}
|
|
|
|
/// <summary>
|
|
/// OutlineColor follows the exact same "non-null derived wins" rule as
|
|
/// FontColor — property 0x22 is authored on only 9 elements in the whole DAT
|
|
/// set, so most outlined elements inherit null here and fall back to the
|
|
/// widget's own black default.
|
|
/// </summary>
|
|
[Fact]
|
|
public void Merge_DerivedOutlineColor_OverridesBaseNull()
|
|
{
|
|
var base_ = new ElementInfo { OutlineColor = null };
|
|
var derived = new ElementInfo { OutlineColor = new Vector4(0f, 0f, 0.4f, 1f) };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(new Vector4(0f, 0f, 0.4f, 1f), merged.OutlineColor);
|
|
}
|
|
|
|
[Fact]
|
|
public void Merge_DerivedOutlineColorNull_InheritsBaseColor()
|
|
{
|
|
var authored = new Vector4(17f / 255f, 15f / 255f, 7f / 255f, 1f);
|
|
var base_ = new ElementInfo { OutlineColor = authored };
|
|
var derived = new ElementInfo { OutlineColor = null };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Equal(authored, merged.OutlineColor);
|
|
}
|
|
|
|
[Fact]
|
|
public void Merge_BothOutlineColorNull_MergedIsNull()
|
|
{
|
|
var base_ = new ElementInfo { OutlineColor = null };
|
|
var derived = new ElementInfo { OutlineColor = null };
|
|
var merged = ElementReader.Merge(base_, derived);
|
|
Assert.Null(merged.OutlineColor);
|
|
}
|
|
|
|
// ── OP2 rework: reader-level tests for 0x2E/0x64/0x72 ───────────────────────
|
|
// docs/research/2026-08-11-op2-review-mechanism.md §1.4 SHOULD-FIX: the OP2
|
|
// conformance tests only ever read the SERIALIZED ElementInfo.TabTable/
|
|
// TemplateList/ScrollbarElementId fields off a committed fixture, so a future
|
|
// regression in ReadTabTable/ReadTemplateList/the 0x72 reader would not fail a
|
|
// single test. These drive ApplyCanonicalLegacyProjection directly from a
|
|
// synthetic raw property bag — the readers themselves, not a fixture snapshot.
|
|
|
|
private static UiPropertyValue EnumProp(uint value) => new()
|
|
{
|
|
Kind = UiPropertyKind.Enum,
|
|
UnsignedValue = value,
|
|
};
|
|
|
|
private static UiPropertyValue BoolProp(bool value) => new()
|
|
{
|
|
Kind = UiPropertyKind.Bool,
|
|
BoolValue = value,
|
|
};
|
|
|
|
private static ElementInfo WithDirectProperty(uint propertyId, UiPropertyValue value)
|
|
{
|
|
var info = new ElementInfo();
|
|
var direct = new UiStateInfo { Id = UiStateInfo.DirectStateId, Name = "" };
|
|
direct.Properties.Values[propertyId] = value;
|
|
info.States[UiStateInfo.DirectStateId] = direct;
|
|
return info;
|
|
}
|
|
|
|
[Fact]
|
|
public void ReadTabTable_DecodesButtonPageDefaultInAuthoredOrder()
|
|
{
|
|
var entry0 = new UiPropertyValue { Kind = UiPropertyKind.Struct };
|
|
entry0.StructValue[0x30u] = EnumProp(0x1000AAAAu);
|
|
entry0.StructValue[0x31u] = EnumProp(0x1000BBBBu);
|
|
entry0.StructValue[0x32u] = BoolProp(true);
|
|
|
|
var entry1 = new UiPropertyValue { Kind = UiPropertyKind.Struct };
|
|
entry1.StructValue[0x30u] = EnumProp(0x1000CCCCu);
|
|
entry1.StructValue[0x31u] = EnumProp(0x1000DDDDu);
|
|
// no 0x32 -> IsDefault false
|
|
|
|
var array = new UiPropertyValue { Kind = UiPropertyKind.Array };
|
|
array.ArrayValue.Add(entry0);
|
|
array.ArrayValue.Add(entry1);
|
|
|
|
ElementInfo info = WithDirectProperty(0x2Eu, array);
|
|
ElementReader.ApplyCanonicalLegacyProjection(info);
|
|
|
|
Assert.Equal(2, info.TabTable.Count);
|
|
Assert.Equal(new UiTabTableEntry(0x1000AAAAu, 0x1000BBBBu, true), info.TabTable[0]);
|
|
Assert.Equal(new UiTabTableEntry(0x1000CCCCu, 0x1000DDDDu, false), info.TabTable[1]);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Retail <c>UIElement_Panel::SetupTabPageHash @0x0046C2E0</c> skips a struct
|
|
/// entry whose <c>InqProperty(0x30)</c> or <c>InqProperty(0x31)</c> is missing —
|
|
/// a partial entry never enters <c>m_TabPageHash</c> (OP2 rework,
|
|
/// docs/research/2026-08-11-op2-review-mechanism.md §1.1).
|
|
/// </summary>
|
|
[Fact]
|
|
public void ReadTabTable_SkipsEntriesMissingButtonOrPage()
|
|
{
|
|
var missingPage = new UiPropertyValue { Kind = UiPropertyKind.Struct };
|
|
missingPage.StructValue[0x30u] = EnumProp(0x1000EEEEu);
|
|
// no 0x31
|
|
|
|
var missingButton = new UiPropertyValue { Kind = UiPropertyKind.Struct };
|
|
missingButton.StructValue[0x31u] = EnumProp(0x1000FFFFu);
|
|
// no 0x30
|
|
|
|
var wellFormed = new UiPropertyValue { Kind = UiPropertyKind.Struct };
|
|
wellFormed.StructValue[0x30u] = EnumProp(0x10001111u);
|
|
wellFormed.StructValue[0x31u] = EnumProp(0x10002222u);
|
|
|
|
var array = new UiPropertyValue { Kind = UiPropertyKind.Array };
|
|
array.ArrayValue.Add(missingPage);
|
|
array.ArrayValue.Add(missingButton);
|
|
array.ArrayValue.Add(wellFormed);
|
|
|
|
ElementInfo info = WithDirectProperty(0x2Eu, array);
|
|
ElementReader.ApplyCanonicalLegacyProjection(info);
|
|
|
|
UiTabTableEntry only = Assert.Single(info.TabTable);
|
|
Assert.Equal(new UiTabTableEntry(0x10001111u, 0x10002222u, false), only);
|
|
}
|
|
|
|
[Fact]
|
|
public void ReadTemplateList_DecodesLayoutDidAndElementIdInAuthoredOrder()
|
|
{
|
|
var entry0 = new UiPropertyValue { Kind = UiPropertyKind.Struct };
|
|
entry0.StructValue[0x63u] = EnumProp(0x21000099u);
|
|
entry0.StructValue[0x62u] = EnumProp(0x10003333u);
|
|
|
|
var entry1 = new UiPropertyValue { Kind = UiPropertyKind.Struct };
|
|
entry1.StructValue[0x63u] = EnumProp(0x21000099u);
|
|
entry1.StructValue[0x62u] = EnumProp(0x10004444u);
|
|
|
|
var array = new UiPropertyValue { Kind = UiPropertyKind.Array };
|
|
array.ArrayValue.Add(entry0);
|
|
array.ArrayValue.Add(entry1);
|
|
|
|
ElementInfo info = WithDirectProperty(0x64u, array);
|
|
ElementReader.ApplyCanonicalLegacyProjection(info);
|
|
|
|
Assert.Equal(2, info.TemplateList.Count);
|
|
Assert.Equal(new UiTemplateListEntry(0x21000099u, 0x10003333u), info.TemplateList[0]);
|
|
Assert.Equal(new UiTemplateListEntry(0x21000099u, 0x10004444u), info.TemplateList[1]);
|
|
}
|
|
|
|
[Fact]
|
|
public void ReadReferencedElementId_ScrollbarLinkage_DecodesEnumProperty()
|
|
{
|
|
ElementInfo info = WithDirectProperty(0x72u, EnumProp(0x10005555u));
|
|
ElementReader.ApplyCanonicalLegacyProjection(info);
|
|
|
|
Assert.Equal(0x10005555u, info.ScrollbarElementId);
|
|
}
|
|
|
|
[Fact]
|
|
public void ReadReferencedElementId_ScrollbarLinkage_AbsentPropertyStaysZero()
|
|
{
|
|
var info = new ElementInfo();
|
|
ElementReader.ApplyCanonicalLegacyProjection(info);
|
|
|
|
Assert.Equal(0u, info.ScrollbarElementId);
|
|
}
|
|
}
|