acdream/tests/AcDream.UI.Abstractions.Tests/Panels/Settings
Erik dd2cb92b99 chore(audio): Campaign A slice A6 — delete what retail does not have
Retail EoR has no music system: the linked winmm MIDI player has zero
callers, 'music' appears zero times in the 65 MB decomp, SoundType has no
music member, InitPrefs registers no music key, and the install ships no
music files. So PlayMusic/StopMusic/MusicVolume and the AudioSettings
Music knob are deleted rather than left as an API modelling dead code —
the string-keyed signature was the tell, since every other entry point is
DID-keyed. Old settings.json files carrying a 'music' key still load; the
reader ignores unknown keys and the next save drops it.

The Ambient slider is now surfaced, because slice A5 gave it something to
drive, and its default returns to retail's 1.0 from an invented 0.8 —
InitPrefs defaults every sound preference to unity. The panel rule is
unchanged: no slider that does nothing.

r05-audio-sound.md gets a SUPERSEDED banner naming its five wrong
sections (falloff, pan, voice pool, selection, music, ambient) so a
future reader reaches the lane notes instead of the Ghidra-era reads that
this campaign spent its first two slices undoing.

TS-9 re-scoped from 'any MP3 cue' to the measured blast radius: exactly 1
MP3 among 786 shipped waves, a ~2 s mono clip. Its original framing
assumed a music system that does not exist. The ADPCM count remains
unmeasured and is named as the open question.

Deferred deliberately: #321's sound-cache decode-dedup race. It is a
pre-existing concurrency flake rather than audio-parity behaviour, and
shipping a speculative fix to a race I have not reproduced is exactly the
shortcut this project's no-workarounds rule exists to prevent.

Campaign A is code-complete; the plan carries the closeout.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-08 22:58:50 +02:00
..
AudioSettingsTests.cs chore(audio): Campaign A slice A6 — delete what retail does not have 2026-08-08 22:58:50 +02:00
CharacterSettingsTests.cs feat(ui): Character tab — per-toon settings; Phase L.0 complete 2026-04-26 18:27:07 +02:00
ChatSettingsTests.cs feat(ui): Chat tab — channel filters + display prefs + font slider 2026-04-26 18:21:14 +02:00
DisplaySettingsTests.cs fix(rendering): bound portal resource lifetime 2026-07-18 21:35:16 +02:00
GameplaySettingsTests.cs feat(selection): port retail polygon picking and vivid marker 2026-07-17 21:32:51 +02:00
QualityPresetTests.cs feat(A.5 T22.5): QualityPreset schema + tests (commit 1/2) 2026-05-10 08:37:17 +02:00
SettingsPanelTests.cs chore(audio): Campaign A slice A6 — delete what retail does not have 2026-08-08 22:58:50 +02:00
SettingsStoreTests.cs chore(audio): Campaign A slice A6 — delete what retail does not have 2026-08-08 22:58:50 +02:00
SettingsVMTests.cs chore(audio): Campaign A slice A6 — delete what retail does not have 2026-08-08 22:58:50 +02:00