acdream/tests/AcDream.App.Tests/Rendering/ClipFrameLayoutTests.cs

using System.Numerics;
using AcDream.App.Rendering;
using AcDream.App.Rendering.Gpu;
using AcDream.App.Rendering.Walk;
using Xunit;

namespace AcDream.App.Tests.Rendering;

/// <summary>
/// Phase U.3: CPU-side proof that <see cref="ClipFrame"/> packs the mesh SSBO
/// clip-region table in the EXACT std430 byte layout mesh_modern.vert reads. A
/// silent layout drift here would mis-clip at U.4 with no build error — these
/// tests are the gate that catches it.
///
/// Layout under test (mesh CellClip, std430):
///   offset  0 : uint count
///   offset  4 : uint _p0  (pad)
///   offset  8 : uint _p1  (pad)
///   offset 12 : uint _p2  (pad)
///   offset 16 : vec4 planes[0]   (16-byte vec4 stride)
///   ...
///   offset 16 + i*16 : vec4 planes[i]
///   stride 144 bytes per slot.
///
/// <see cref="ClipFrame.TerrainUboBytes"/>/<see cref="ClipFrame.TerrainClipUboBinding"/>
/// share this file only because they happen to reuse the identical std140
/// 144-byte shape for a DIFFERENT, still-live consumer — see their own doc
/// comments (S3 chunk 4 fix round 2, L3).
/// </summary>
public class ClipFrameLayoutTests
{
    private static float ReadFloat(System.ReadOnlySpan<byte> b, int offset)
        => System.BitConverter.ToSingle(b.Slice(offset, 4));

    private static uint ReadUInt(System.ReadOnlySpan<byte> b, int offset)
        => System.BitConverter.ToUInt32(b.Slice(offset, 4));

    private static int ReadInt(System.ReadOnlySpan<byte> b, int offset)
        => System.BitConverter.ToInt32(b.Slice(offset, 4));

    [Fact]
    public void LayoutConstants_MatchShaderStruct()
    {
        // CellClip: 16 (count + 3 pad uints) + 8*16 (vec4 planes) = 144.
        Assert.Equal(144, ClipFrame.CellClipStrideBytes);
        Assert.Equal(16, ClipFrame.CellClipPlanesOffset);
        Assert.Equal(8, ClipFrame.MaxPlanes);
        Assert.Equal(144, ClipFrame.TerrainUboBytes);
        // Binding contract: mesh clip regions on SSBO binding=2, PortalDepthMaskRenderer's
        // exit-seal/punch-fan clip block on UBO binding=2. The mesh side's binding
        // index moved off ClipFrame at Campaign V slice V11 — the RHI arm addresses
        // it through GpuBindingModel.StorageClipRegions instead of a raw GL binding
        // constant (see ClipFrame's BeginFrame doc comment); the portal-depth UBO
        // binding is still genuinely shared, so it stays.
        Assert.Equal(2u, GpuBindingModel.StorageClipRegions);
        Assert.Equal(2u, ClipFrame.TerrainClipUboBinding);
    }

    [Fact]
    public void NoClip_HasExactlyOneSlot_AllZeros_Count0()
    {
        var frame = ClipFrame.NoClip();
        Assert.Equal(1, frame.SlotCount);

        var bytes = frame.RegionBytesForTest;
        Assert.Equal(ClipFrame.CellClipStrideBytes, bytes.Length); // 144 — exactly one slot

        // count == 0 ⇒ shader passes every plane (no-clip).
        Assert.Equal(0u, ReadUInt(bytes, 0));
        // Every byte of the reserved no-clip slot is zero.
        foreach (var b in bytes)
            Assert.Equal(0, b);
    }

    [Fact]
    public void AppendSlot_WritesCountAndPlanes_AtStd430Offsets()
    {
        var frame = ClipFrame.NoClip();

        // Three distinct planes so each lands at a verifiable offset.
        var p0 = new Vector4(1f, 0f, 0f, 0.5f);
        var p1 = new Vector4(0f, 1f, 0f, 0.25f);
        var p2 = new Vector4(-1f, 0f, 0f, -0.75f);

        int slot = frame.AppendSlot(new[] { p0, p1, p2 });
        Assert.Equal(1, slot);              // slot 0 is the reserved no-clip; this is slot 1
        Assert.Equal(2, frame.SlotCount);

        var bytes = frame.RegionBytesForTest;
        Assert.Equal(2 * ClipFrame.CellClipStrideBytes, bytes.Length); // two slots now

        int baseOff = slot * ClipFrame.CellClipStrideBytes; // 144

        // count == 3 at offset 0 of the slot; the 3 pad uints stay zero.
        Assert.Equal(3u, ReadUInt(bytes, baseOff + 0));
        Assert.Equal(0u, ReadUInt(bytes, baseOff + 4));
        Assert.Equal(0u, ReadUInt(bytes, baseOff + 8));
        Assert.Equal(0u, ReadUInt(bytes, baseOff + 12));

        // planes[0..2] at offset 16, 32, 48 (vec4 stride 16).
        AssertPlaneAt(bytes, baseOff + 16, p0);
        AssertPlaneAt(bytes, baseOff + 32, p1);
        AssertPlaneAt(bytes, baseOff + 48, p2);

        // Slot 0 (the reserved no-clip) is untouched: still count 0.
        Assert.Equal(0u, ReadUInt(bytes, 0));
    }

    [Fact]
    public void GetSlotPlanes_BorrowsTheExactPackedClipRegion()
    {
        using ClipFrame frame = ClipFrame.NoClip();
        Vector4[] expected =
        [
            new(1f, 2f, 3f, 4f),
            new(-5f, 6f, -7f, 8f),
        ];

        int slot = frame.AppendSlot(expected);

        ReadOnlySpan<Vector4> actual = frame.GetSlotPlanes(checked((uint)slot));
        Assert.Equal(expected.Length, actual.Length);
        Assert.Equal(expected[0], actual[0]);
        Assert.Equal(expected[1], actual[1]);
        Assert.Equal(0, frame.GetSlotPlanes(0).Length);
    }

    [Fact]
    public void AppendSlot_EmptyPlaneList_PacksNoClipSlot_Count0()
    {
        var frame = ClipFrame.NoClip();
        int slot = frame.AppendSlot(System.ReadOnlySpan<Vector4>.Empty);
        Assert.Equal(1, slot);

        var bytes = frame.RegionBytesForTest;
        Assert.Equal(0u, ReadUInt(bytes, slot * ClipFrame.CellClipStrideBytes)); // count 0
    }

    [Fact]
    public void AppendSlot_ClampsToEightPlanes()
    {
        var frame = ClipFrame.NoClip();
        var planes = new Vector4[12];
        for (int i = 0; i < planes.Length; i++)
            planes[i] = new Vector4(i, 0f, 0f, 0f);

        int slot = frame.AppendSlot(planes);
        var bytes = frame.RegionBytesForTest;
        // Only MaxPlanes (8) are recorded in the count.
        Assert.Equal((uint)ClipFrame.MaxPlanes, ReadUInt(bytes, slot * ClipFrame.CellClipStrideBytes));
    }

    [Fact]
    public void AppendSlot_FromClipPlaneSet_AxisAlignedSquare_PacksFourPlanes()
    {
        // A unit square in NDC → ClipPlaneSet with 4 convex planes.
        var cv = new CellView();
        cv.Add(new ViewPolygon(new[]
        {
            new Vector2(-0.5f, -0.5f), new Vector2(0.5f, -0.5f),
            new Vector2(0.5f, 0.5f),   new Vector2(-0.5f, 0.5f),
        }));
        var cps = ClipPlaneSet.From(cv);
        Assert.Equal(4, cps.Count);

        var frame = ClipFrame.NoClip();
        int slot = frame.AppendSlot(cps);

        var bytes = frame.RegionBytesForTest;
        int baseOff = slot * ClipFrame.CellClipStrideBytes;
        Assert.Equal(4u, ReadUInt(bytes, baseOff + 0));

        // Each packed plane must match the ClipPlaneSet's plane bit-for-bit.
        for (int i = 0; i < 4; i++)
            AssertPlaneAt(bytes, baseOff + ClipFrame.CellClipPlanesOffset + i * 16, cps.Planes[i]);
    }

    // S3 chunk 4 fix round 2 (L3): the walk's screen-space clip gate and its
    // own std140 layout pin are deleted outright — no shader declares that
    // block any more, so there is nothing left to pack or pin.

    private static void AssertPlaneAt(System.ReadOnlySpan<byte> bytes, int offset, Vector4 expected)
    {
        Assert.Equal(expected.X, ReadFloat(bytes, offset + 0), 6);
        Assert.Equal(expected.Y, ReadFloat(bytes, offset + 4), 6);
        Assert.Equal(expected.Z, ReadFloat(bytes, offset + 8), 6);
        Assert.Equal(expected.W, ReadFloat(bytes, offset + 12), 6);
    }

    // ── S3 chunk 4 (§10.2 KEEP): CPU/GPU clip-plane equivalence pins ────────
    //
    // Grepped first (per the chunk 4 contract): ClipPlaneSetTests.cs pins
    // sign correctness (inside >= 0, just-outside < 0 on SOME plane) and
    // AppendSlot_FromClipPlaneSet_AxisAlignedSquare_PacksFourPlanes pins
    // bit-exact GPU packing of ClipPlaneSet's own output — neither asks
    // whether a point ON an edge has ~0 distance under the planes actually
    // read back through each KEEP item's real production accessor.
    //
    // KEEP item 1 — exit seals — moved to
    // AcDream.App.Tests.Rendering.Walk.WalkFrameDriverClipSealTests
    // (S3 review fix round 1, F2): the pin that used to live here drove
    // ClipFrame.AppendSlot(ClipPlaneSet) directly through
    // ClipFrameAssembler.Assemble's packed-byte round trip — an overload
    // and a method with ZERO production callers (production interior roots
    // never call Assemble; RetailPViewPassExecutor.DrawExitPortalMask
    // reads its planes through WalkFrameDriver.InteriorFloodViewClipPlanesAt,
    // which resolves through the driver's own CaptureViews/AppendClipSlot).
    // The rewritten pin drives THAT real producer — it needs
    // WalkFrameDriverTests' own DispatcherFixture/TestContext harness, so it
    // lives alongside them rather than duplicating that machinery here.
    //
    // KEEP item 2 — punch fans stays below (it already drove the exact pair
    // that runs: BeginWalkFrame + ReassembleOutsideViewFromWalk).

    /// <summary>
    /// KEEP item 2 — punch fans: <c>RetailPViewPassExecutor.DrawWalkPunchFan</c>
    /// reads its clip planes through <c>clipAssembly.OutsideViewSlices
    /// [activeViewIndex].Planes</c> — <see cref="ClipViewSlice"/>'s
    /// <c>Planes</c> field. S3 chunk 4 fix round 2 (L4): a prior round's pin
    /// here built the slice through <c>ClipFrameAssembler.Assemble</c> — but
    /// <c>Assemble</c> has ZERO production callers (it exists only for
    /// isolated research/replay tests, per this file's own class header);
    /// production builds an interior root's outside-view slices through
    /// <c>BeginWalkFrame</c> + <c>ReassembleOutsideViewFromWalk</c>
    /// (<c>RetailPViewPassExecutor.cs</c>'s <c>BeginWalkFrame</c> call,
    /// <c>RetailPViewRenderer.cs</c>'s <c>ReassembleOutsideViewFromWalk</c>
    /// call), so a pin through <c>Assemble</c> proves nothing about the code
    /// that actually runs. This pin now drives that EXACT pair: a synthetic
    /// <see cref="WalkPortalView"/> holding one pixel-space polygon (built
    /// the way <c>WalkCopyViewTests</c> builds views), fed through
    /// <c>BeginWalkFrame(frame, outdoorRoot: false)</c> then
    /// <c>ReassembleOutsideViewFromWalk</c> — both of which now call the
    /// SAME shared <c>ClipFrameAssembler.AppendOutsideSlice</c> helper
    /// <c>Assemble</c> would have (L4's own de-duplication), so this pin
    /// exercises the helper through the producer that actually runs.
    /// MUTATION: perturbing <c>planes[0].W</c> INSIDE that shared helper (the
    /// one place both producers pack a plane) breaks this pin — see the
    /// commit body for the recorded failing assertion text. The pin's own
    /// source contains no <c>Assemble(</c> call (grep-checked in the commit
    /// body). Same non-axis-aligned synthetic polygon as before, kept
    /// distinct from the exit-seal pin's input.
    /// </summary>
    [Fact]
    public void ClipViewSlicePlanes_PunchFanPath_EqualsCpuViewPolygonEdgePlanes_ForASyntheticView()
    {
        const float ViewportWidth = 640f, ViewportHeight = 480f;
        Vector2[] verts =
        [
            new(0f, 0.6f), new(-0.6f, -0.4f), new(0.5f, -0.5f), new(0.7f, 0.2f),
        ];

        // Pixel-space points (origin top-left, +Y down) that ReassembleOutsideViewFromWalk's
        // own inverse transform (px = (ndc+1)*W/2, py = (1-ndc)*H/2) maps back to `verts`.
        var pixelPoints = new WalkScreenPoint[verts.Length];
        for (int i = 0; i < verts.Length; i++)
        {
            float px = (verts[i].X + 1f) * ViewportWidth / 2f;
            float py = (1f - verts[i].Y) * ViewportHeight / 2f;
            pixelPoints[i] = new WalkScreenPoint(px, py, 0f, 1f);
        }

        var walkView = new WalkPortalView();
        Assert.True(WalkCopyView.Append(
            walkView, pixelPoints, new SyntheticRayCaster(), Vector3.Zero));

        // The EXACT production pair: BeginWalkFrame seeds an interior root's
        // empty outside-view assembly; ReassembleOutsideViewFromWalk (the
        // walk's real producer) fills it from the walk's own pixel-space
        // view — the same two calls RetailPViewPassExecutor.cs and
        // RetailPViewRenderer.cs make.
        ClipFrameAssembly assembly = ClipFrameAssembler.BeginWalkFrame(
            ClipFrame.NoClip(), outdoorRoot: false);
        ClipFrameAssembler.ReassembleOutsideViewFromWalk(
            assembly, walkView, ViewportWidth, ViewportHeight);

        ClipViewSlice slice = Assert.Single(assembly.OutsideViewSlices);
        Assert.True(slice.Planes.Length >= 3);

        AssertEveryEdgeMidpointLiesOnSomeGpuPlane(verts, slice.Planes);
    }

    /// <summary>Trivial ray caster: only <c>WalkPortalView</c>'s stored pixel
    /// points feed <see cref="ClipFrameAssembler.ReassembleOutsideViewFromWalk"/>
    /// (via NDC conversion); the per-vertex plane a ray caster would seed is
    /// unused by that path, so any non-degenerate direction works.</summary>
    private sealed class SyntheticRayCaster : IWalkRayCaster
    {
        public Vector3 RayThrough(float screenX, float screenY) =>
            Vector3.Normalize(new Vector3(screenX, screenY, 1000f));
    }

    /// <summary>
    /// CPU/GPU equivalence: a point on a convex polygon's edge must sit
    /// (a) non-negative under EVERY plane (still inside-or-on the region —
    /// no plane clips it away) and (b) within <paramref name="verts"/>'s
    /// own floating-point tolerance of ZERO under at least one plane (that
    /// edge's own plane). MUTATION: perturbing any one GPU plane's offset
    /// or normal after it left <see cref="ClipPlaneSet.From(CellView)"/>
    /// (a packing/binding bug) breaks either (a) for a nearby edge or (b)
    /// for its own edge, failing the corresponding assertion below.
    /// </summary>
    private static void AssertEveryEdgeMidpointLiesOnSomeGpuPlane(
        Vector2[] verts, ReadOnlySpan<Vector4> gpuPlanes)
    {
        const float eps = 1e-4f;
        for (int i = 0; i < verts.Length; i++)
        {
            Vector2 a = verts[i];
            Vector2 b = verts[(i + 1) % verts.Length];
            Vector2 mid = (a + b) / 2f;
            var clip = new Vector4(mid.X, mid.Y, 0f, 1f);

            float minAbsDistance = float.PositiveInfinity;
            foreach (Vector4 plane in gpuPlanes)
            {
                float distance = Vector4.Dot(plane, clip);
                Assert.True(
                    distance >= -eps,
                    $"edge {i} midpoint ({mid.X},{mid.Y}) must be inside-or-on every "
                    + $"GPU plane; plane {plane} gave distance {distance}");
                minAbsDistance = MathF.Min(minAbsDistance, MathF.Abs(distance));
            }
            Assert.True(
                minAbsDistance < eps,
                $"edge {i} midpoint ({mid.X},{mid.Y}) should lie ~on its OWN GPU plane; "
                + $"the closest plane was only {minAbsDistance} away");
        }
    }
}