ceec3bc440
TextRenderer, BitmapFont, DebugLineRenderer, and TextureCache's UI-texture
upload path (GetOrUploadRenderSurface/UploadRgba8) now issue every draw and
resource creation through the pinned IGpuDevice/IGpuFrame/IGpuPassEncoder
RHI contract instead of raw GL. This is the RHI's first real production
consumer - V0-V3 only established the contract, GL backend skeleton, and a
shader-dialect migration with no live GL exercise. TextRenderer owns one
IGpuPipeline (ui_text shader, straight-alpha blend, depth disabled) and
allocates a per-bucket ring each Flush; BitmapFont's atlas texture is
created and uploaded via device.CreateTexture/.Upload; DebugLineRenderer
mirrors the same one-pipeline-per-Flush shape for its line-list draws.
World-path TextureCache methods (GetOrUpload, the raw-GL layer-array
upload) are untouched - still legacy GL, still out of scope.
Frame lifecycle: GpuDeviceFrameLifetime (RenderFrameOrchestrator.cs) wraps
IGpuDevice.BeginFrame()/IGpuFrame.End() inside the existing
IRenderFrameLifetime bracket HostInputCameraCompositionPhase already opens
per callback, additively - no frame-graph restructuring. Ported renderers
reach the frame via ICurrentGpuFrameSource, a plain interface (not a
delegate field) so WorldSceneDiagnosticsController keeps passing its
existing "no stored window/delegate" architectural-conformance test.
Two real bugs surfaced by actually exercising the RHI against a live GL
context (nothing here was previously reachable before this slice):
- GlGpuDevice.BeginFrame() now resets the render-state cache every frame.
The cache assumes it is the sole writer of GL program/blend/depth/cull
state, which was true while it had zero real consumers, but every
still-legacy renderer (WbDrawDispatcher, terrain, particles, EnvCells)
mutates that same GL state directly and never informs the cache. Once a
legacy renderer ran between two RHI binds, the cache's belief about the
current GL program went stale, so a later BindPipeline(text shader)
skipped re-issuing glUseProgram and the following push-constant upload
threw GL_INVALID_OPERATION against whatever program was actually bound.
Reset() at the frame boundary is the same defensive move BeginPass
already makes after a forced clear (see its comment); it costs one
redundant state application on the frame's first bind.
- GL_MULTISAMPLE has no representation in the pinned contract. Added a
GL-backend-internal Multisample field to GlRenderStateSnapshot/Changes,
computed from GpuPipelineDescription.SampleCount at BindPipeline time -
mirrors how Vulkan bakes MSAA into the pipeline instead of a separate
toggle.
Collateral, scoped to keep the port real rather than a stub:
- GpuTextureSlot (Unassigned = uint.MaxValue, NOT 0) now flows through
every consumer of TextureCache.GetOrUploadRenderSurface/UploadRgba8 and
TextRenderer.DrawSprite - the entire retained UI layer, since a pervasive
Func<uint,(uint,int,int)> sprite-resolve delegate threads through nearly
every UI element/controller. Every prior `== 0` / `!= 0` "no texture"
check became `.IsAssigned` / `!.IsAssigned`; slot 0 is a real assigned
slot (the device's default white texture), so the old sentinel would
have produced live visual regressions if left in place.
- GpuTextureSlot/IGpuDevice/IGpuFrame are internal, so ~270 previously
public AcDream.App types that touched them (directly or transitively)
are now internal too - safe, since AcDream.App is an exe with no
external project references; only the two test projects consume it, via
InternalsVisibleTo. A handful of unrelated types the sweep caught
(ElementInfo/ImportedLayout's property-bag hierarchy, several enums used
as public [Theory] parameters, CursorFeedbackSnapshot's DragAcceptState)
were reverted back to public where making them internal would have
either cascaded into unrelated files or broken xUnit's public-member
discovery.
- ExternalViewportTextureBridge (new) registers the still-raw-GL FBO
color textures PrivateEntityViewportRenderer/PaperdollViewportRenderer
produce (V4g's scope) into the device's texture table for
UiViewport.TextureHandle, via a temporary
GlGpuDevice.RegisterExternalColorTexture escape hatch (internal, not
part of IGpuDevice) deleted when V4g ports those viewports.
- TextRenderGlStateScope.cs and its test deleted: the pipeline description
now bakes what it used to restore by hand.
- ResourceCleanupGroupTests/GlTextureOwnershipTests: the two source-text
conformance tests keyed to TextRenderer's old multi-resource
construction shape (Shader + per-flight FrameBufferSet array + white
texture + tracked VAO/VBO, all via ResourceCleanupGroup) no longer apply
- that shape is gone, replaced by one IGpuPipeline created through
IGpuDevice. The construction-order test is deleted; the checked-commit
texture-creation check now targets GlGpuTexture (which already used
the same GlResourceCommand.CreateName primitive before this slice).
Gates:
- dotnet build -c Release: 0 warnings, 0 errors (AcDream.App has
TreatWarningsAsErrors).
- dotnet test tests/AcDream.App.Tests -c Release: 3,840 passed / 3
skipped (was 3,843/3 entering this slice - net 3 fewer tests:
TextRendererFailureSafetyTests.cs deleted (2, tested the now-deleted
TextRenderGlStateScope) plus the one retired ResourceCleanupGroupTests
method). Full solution: 8,908 passed / 5 skipped across all nine test
projects.
- Offline pixel gate (tools/run-offline-pixel-gate.ps1, parent ec414d60
vs this commit): differing fraction 0.318% (1,791/563,200 compared
pixels), above the 0.001 threshold. Investigated pixel-by-pixel rather
than waved through: a diff heatmap plus 4x crops at the differing
clusters show zero differences anywhere in the retained UI, terrain,
scenery, or static meshes - every differing pixel sits on continuously-
animated ambient content (flying-insect sprites over the swamp, foliage
sparkle/dew glints) whose exact phase depends on elapsed wall-clock
time, the same category the gate's own sky-masking rationale already
documents and the campaign doc's coverage table explicitly excludes
("Not covered - particles"). Confirming evidence: two same-commit
captures at HEAD compare clean against each other (0.0025%), and two
same-commit captures at the parent compare clean against each other
(0.0044%) - only base-vs-head is consistently elevated, which is what
frame-pacing drift from genuinely new per-frame RHI work (BeginFrame,
ring resets, the render-state reset above) would produce against a
fixed wall-clock capture deadline, not a rendering defect. Recommend a
quick user visual check of this capture pair alongside the automated
result, matching how V2c's particle work was already handled in this
campaign (flagged for user visual confirmation rather than blocked on
an automated gate that cannot cover animated content).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
940 lines
34 KiB
C#
940 lines
34 KiB
C#
using AcDream.App.Rendering.Gpu;
|
|
using System.Numerics;
|
|
using AcDream.App.Spells;
|
|
using AcDream.Content;
|
|
using AcDream.App.UI;
|
|
using AcDream.App.UI.Layout;
|
|
using AcDream.Core.Combat;
|
|
using AcDream.Core.Items;
|
|
using AcDream.Core.Net.Messages;
|
|
using AcDream.Core.Selection;
|
|
using AcDream.Core.Spells;
|
|
|
|
namespace AcDream.App.Tests.UI.Layout;
|
|
|
|
public sealed class AppraisalUiControllerTests
|
|
{
|
|
private const uint ObjectId = 0x50000001u;
|
|
private static (GpuTextureSlot, int, int) NoTexture(uint _) => (GpuTextureSlot.Unassigned, 0, 0);
|
|
|
|
[Fact]
|
|
public void ItemResponse_UsesAuthoredItemSubviewTitleAndScrollbars()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Atlan Weapon",
|
|
Type = ItemType.MeleeWeapon,
|
|
Value = 1250,
|
|
Burden = 350,
|
|
ContainerId = 0x50000002u,
|
|
PublicWeenieBitfield = (uint)PublicWeenieFlags.Inscribable,
|
|
});
|
|
var sent = new List<uint>();
|
|
var inscriptions = new List<(uint ObjectId, string Text)>();
|
|
var messages = new List<string>();
|
|
using var interaction = NewInteraction(objects, sent);
|
|
var combat = new CombatState();
|
|
int shown = 0;
|
|
int closed = 0;
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
combat,
|
|
inscriptions,
|
|
messages,
|
|
() => shown++,
|
|
() => closed++)!;
|
|
|
|
Assert.True(interaction.ExamineSelectedOrEnterMode(ObjectId));
|
|
var properties = new PropertyBundle();
|
|
properties.Ints[19u] = 1_250;
|
|
properties.Ints[5u] = 350;
|
|
properties.Strings[16u] = "A finely balanced weapon.";
|
|
properties.Strings[7u] = "Remember the fallen.";
|
|
properties.Strings[8u] = "Tester";
|
|
|
|
Assert.True(controller.Apply(Parsed(properties)));
|
|
|
|
Assert.Equal(1, shown);
|
|
Assert.Equal(AppraisalView.Item, controller.ActiveView);
|
|
Assert.Equal(0, interaction.BusyCount);
|
|
UiText title = Assert.IsType<UiText>(
|
|
layout.FindElement(AppraisalUiController.TitleId));
|
|
Assert.Equal("Atlan Weapon", Assert.Single(title.LinesProvider()).Text);
|
|
UiText itemText = Assert.IsType<UiText>(
|
|
layout.FindElement(AppraisalUiController.ItemTextId));
|
|
Assert.Equal(VJustify.Top, itemText.VerticalJustify);
|
|
Assert.Equal(
|
|
[
|
|
new Vector4(1f, 1f, 1f, 1f),
|
|
new Vector4(0f, 1f, 0f, 1f),
|
|
new Vector4(1f, 0f, 0f, 1f),
|
|
],
|
|
itemText.FontColorPalette);
|
|
string report = string.Join('\n', itemText.LinesProvider().Select(line => line.Text));
|
|
Assert.Contains("Value: 1,250", report);
|
|
Assert.Contains("Burden: 350", report);
|
|
Assert.Contains("A finely balanced weapon.", report);
|
|
UiScrollbar scrollbar = Assert.IsType<UiScrollbar>(
|
|
layout.FindElement(AppraisalUiController.ItemScrollbarId));
|
|
Assert.Same(itemText.Scroll, scrollbar.Model);
|
|
UiField inscription = Assert.IsType<UiField>(
|
|
layout.FindElement(AppraisalUiController.InscriptionTextId));
|
|
Assert.Contains("Remember the fallen", inscription.Text);
|
|
Assert.True(inscription.Editable);
|
|
UiText signature = Assert.IsType<UiText>(
|
|
layout.FindElement(AppraisalUiController.SignatureTextId));
|
|
Assert.Equal("--Tester", Assert.Single(signature.LinesProvider()).Text);
|
|
Assert.Empty(inscriptions);
|
|
Assert.Empty(messages);
|
|
|
|
((UiButton)layout.FindElement(AppraisalUiController.CloseId)!).OnClick!.Invoke();
|
|
Assert.Equal(1, closed);
|
|
}
|
|
|
|
[Fact]
|
|
public void ItemResponse_TitleUsesRetailMaterialDecoratedAppropriateName()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Steel Toed Boots",
|
|
Type = ItemType.Clothing,
|
|
MaterialType = 77u,
|
|
});
|
|
using var interaction = NewInteraction(objects, []);
|
|
var names = new RetailAppraisalNameResolver(
|
|
new Dictionary<uint, string> { [77u] = "Reed Shark Hide" },
|
|
new CreatureDisplayNameResolver(new Dictionary<uint, string>()));
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
[],
|
|
[],
|
|
() => { },
|
|
() => { },
|
|
itemNames: names)!;
|
|
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
Assert.True(controller.Apply(Parsed(new PropertyBundle())));
|
|
|
|
UiText title = Assert.IsType<UiText>(
|
|
layout.FindElement(AppraisalUiController.TitleId));
|
|
Assert.Equal(
|
|
"Reed Shark Hide Steel Toed Boots",
|
|
Assert.Single(title.LinesProvider()).Text);
|
|
}
|
|
|
|
[Fact]
|
|
public void CreatureResponse_SelectsCreatureSubviewAndRefreshesInCombatWithoutBusy()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Drudge Slinker",
|
|
Type = ItemType.Creature,
|
|
});
|
|
var sent = new List<uint>();
|
|
using var interaction = NewInteraction(objects, sent);
|
|
var combat = new CombatState();
|
|
int shown = 0;
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
combat,
|
|
[],
|
|
[],
|
|
() => shown++,
|
|
() => { })!;
|
|
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
var properties = new PropertyBundle();
|
|
properties.Ints[25u] = 12;
|
|
var creature = new AppraiseInfoParser.CreatureProfile(
|
|
Flags: 0,
|
|
Health: 80,
|
|
HealthMax: 100,
|
|
Strength: null,
|
|
Endurance: null,
|
|
Quickness: null,
|
|
Coordination: null,
|
|
Focus: null,
|
|
Self: null,
|
|
Stamina: null,
|
|
Mana: null,
|
|
StaminaMax: null,
|
|
ManaMax: null,
|
|
AttributeHighlights: null,
|
|
AttributeColors: null);
|
|
|
|
Assert.True(controller.Apply(Parsed(properties, creature)));
|
|
Assert.Equal(AppraisalView.Creature, controller.ActiveView);
|
|
Assert.Equal(1, shown);
|
|
controller.OnShown();
|
|
Assert.False(layout.FindElement(AppraisalUiController.ItemPanelId)!.Visible);
|
|
Assert.True(layout.FindElement(AppraisalUiController.CreaturePanelId)!.Visible);
|
|
|
|
combat.SetCombatMode(CombatMode.Melee);
|
|
controller.Tick(0.74);
|
|
Assert.Single(sent);
|
|
controller.Tick(0.01);
|
|
Assert.Equal(new[] { ObjectId, ObjectId }, sent);
|
|
Assert.Equal(0, interaction.BusyCount);
|
|
|
|
controller.OnHidden();
|
|
controller.Tick(0.75);
|
|
Assert.Equal(new[] { ObjectId, ObjectId }, sent);
|
|
|
|
Assert.True(controller.Apply(Parsed(properties, creature)));
|
|
Assert.Equal(1, shown);
|
|
}
|
|
|
|
[Fact]
|
|
public void CreatureResponse_UsesRetailHeaderAndNineOrderedTemplateRows()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Specter",
|
|
Type = ItemType.Creature,
|
|
});
|
|
using var interaction = NewInteraction(objects, []);
|
|
UiText characterLabel = Assert.IsType<UiText>(
|
|
layout.FindElement(0x1000014Au));
|
|
UiText levelLabel = Assert.IsType<UiText>(
|
|
layout.FindElement(0x1000014Bu));
|
|
characterLabel.LinesProvider = () =>
|
|
[new UiText.Line("Character", characterLabel.DefaultColor)];
|
|
levelLabel.LinesProvider = () =>
|
|
[new UiText.Line("Level", levelLabel.DefaultColor)];
|
|
var templates = new CreatureAppraisalRowTemplateFactory(
|
|
FixtureLoader.LoadExaminationRowTemplateInfos(),
|
|
NoTexture,
|
|
defaultFont: null);
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
[],
|
|
[],
|
|
() => { },
|
|
() => { },
|
|
templates,
|
|
new CreatureDisplayNameResolver(
|
|
new Dictionary<uint, string> { [77u] = "Ghost" }))!;
|
|
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
var properties = new PropertyBundle();
|
|
properties.Ints[2u] = 77;
|
|
properties.Ints[25u] = 80;
|
|
properties.Ints[0x133u] = 35;
|
|
properties.Ints[0x13Au] = 4;
|
|
var profile = new AppraiseInfoParser.CreatureProfile(
|
|
Flags: 0x08u,
|
|
Health: 295u,
|
|
HealthMax: 295u,
|
|
Strength: 120u,
|
|
Endurance: 190u,
|
|
Quickness: 190u,
|
|
Coordination: 190u,
|
|
Focus: 330u,
|
|
Self: 350u,
|
|
Stamina: 190u,
|
|
Mana: 550u,
|
|
StaminaMax: 190u,
|
|
ManaMax: 550u,
|
|
AttributeHighlights: (ushort)0,
|
|
AttributeColors: (ushort)0);
|
|
|
|
Assert.True(controller.Apply(Parsed(properties, profile)));
|
|
|
|
Assert.Equal(
|
|
"Character",
|
|
Assert.Single(characterLabel.LinesProvider()).Text);
|
|
Assert.Equal("Level", Assert.Single(levelLabel.LinesProvider()).Text);
|
|
Assert.Equal(
|
|
"80",
|
|
Assert.Single(((UiText)layout.FindElement(
|
|
AppraisalUiController.CreatureLevelValueId)!)
|
|
.LinesProvider()).Text);
|
|
Assert.Equal(
|
|
"Ghost",
|
|
Assert.Single(((UiText)layout.FindElement(
|
|
AppraisalUiController.CreatureDisplayNameId)!)
|
|
.LinesProvider()).Text);
|
|
|
|
UiElement host = layout.FindElement(
|
|
AppraisalUiController.CreatureStatsListId)!;
|
|
UiElement creaturePanel = layout.FindElement(
|
|
AppraisalUiController.CreaturePanelId)!;
|
|
UiViewport viewport = Assert.IsType<UiViewport>(
|
|
layout.FindElement(AppraisalUiController.CreatureViewportId));
|
|
UiItemList background = Assert.Single(
|
|
host.Children.OfType<UiItemList>());
|
|
UiItemList list = Assert.Single(
|
|
creaturePanel.Children.OfType<UiItemList>(),
|
|
candidate => candidate.Top == host.Top);
|
|
Assert.Equal(0f, background.Left);
|
|
Assert.Equal(CreatureAppraisalLayeredList.TextInset, list.Left);
|
|
Assert.True(host.ZOrder < viewport.ZOrder);
|
|
Assert.True(viewport.ZOrder < list.ZOrder);
|
|
Assert.Same(background.Scroll, list.Scroll);
|
|
Assert.Equal(9, list.GetNumUIItems());
|
|
string[] labels = new string[9];
|
|
string[] values = new string[9];
|
|
for (int index = 0; index < 9; index++)
|
|
{
|
|
UiTemplateListSlot row =
|
|
Assert.IsType<UiTemplateListSlot>(list.GetItem(index));
|
|
labels[index] = Assert.Single(
|
|
((UiText)row.Content.FindElement(
|
|
CreatureAppraisalRowTemplateFactory.LabelId)!)
|
|
.LinesProvider()).Text;
|
|
values[index] = Assert.Single(
|
|
((UiText)row.Content.FindElement(
|
|
CreatureAppraisalRowTemplateFactory.ValueId)!)
|
|
.LinesProvider()).Text;
|
|
}
|
|
Assert.Equal(
|
|
[
|
|
"Strength", "Endurance", "Coordination", "Quickness",
|
|
"Focus", "Self", "Health", "Stamina", "Mana",
|
|
],
|
|
labels);
|
|
Assert.Equal(
|
|
[
|
|
"120", "190", "190", "190", "330", "350",
|
|
"295/295 (100 %)", "190/190", "550/550",
|
|
],
|
|
values);
|
|
|
|
UiElement extraHost = layout.FindElement(
|
|
AppraisalUiController.CreatureExtraListId)!;
|
|
UiItemList extra = Assert.Single(
|
|
creaturePanel.Children.OfType<UiItemList>(),
|
|
candidate => candidate.Top == extraHost.Top);
|
|
Assert.Equal(3, extra.GetNumUIItems());
|
|
UiTemplateListSlot rating =
|
|
Assert.IsType<UiTemplateListSlot>(extra.GetItem(1));
|
|
Assert.Equal(
|
|
"Dmg/CritDmg",
|
|
Assert.Single(((UiText)rating.Content.FindElement(
|
|
CreatureAppraisalRowTemplateFactory.LabelId)!)
|
|
.LinesProvider()).Text);
|
|
Assert.Equal(
|
|
"Rating: 35/4",
|
|
Assert.Single(((UiText)rating.Content.FindElement(
|
|
CreatureAppraisalRowTemplateFactory.ValueId)!)
|
|
.LinesProvider()).Text);
|
|
Assert.True(extraHost.ZOrder < viewport.ZOrder);
|
|
Assert.True(viewport.ZOrder < extra.ZOrder);
|
|
}
|
|
|
|
[Fact]
|
|
public void VisibleExaminationFollowsSelectionAcrossSubviewsAndClosesOnClear()
|
|
{
|
|
const uint otherObjectId = 0x50000003u;
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Drudge",
|
|
Type = ItemType.Creature,
|
|
});
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = otherObjectId,
|
|
Name = "Sword",
|
|
Type = ItemType.MeleeWeapon,
|
|
});
|
|
var selection = new SelectionState();
|
|
var sent = new List<uint>();
|
|
int closed = 0;
|
|
using var interaction = NewInteraction(objects, sent);
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
[],
|
|
[],
|
|
() => { },
|
|
() => closed++,
|
|
selection: selection)!;
|
|
|
|
selection.Select(ObjectId, SelectionChangeSource.World);
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
Assert.True(controller.Apply(Parsed(
|
|
new PropertyBundle(),
|
|
new AppraiseInfoParser.CreatureProfile(
|
|
Flags: 0u,
|
|
Health: 1u,
|
|
HealthMax: 1u,
|
|
Strength: null,
|
|
Endurance: null,
|
|
Quickness: null,
|
|
Coordination: null,
|
|
Focus: null,
|
|
Self: null,
|
|
Stamina: null,
|
|
Mana: null,
|
|
StaminaMax: null,
|
|
ManaMax: null,
|
|
AttributeHighlights: null,
|
|
AttributeColors: null))));
|
|
controller.OnShown();
|
|
|
|
selection.Select(otherObjectId, SelectionChangeSource.Inventory);
|
|
Assert.Equal(new[] { ObjectId, otherObjectId }, sent);
|
|
Assert.True(controller.Apply(Parsed(
|
|
new PropertyBundle(),
|
|
guid: otherObjectId)));
|
|
Assert.Equal(AppraisalView.Item, controller.ActiveView);
|
|
|
|
selection.Clear(SelectionChangeSource.World);
|
|
Assert.Equal(1, closed);
|
|
|
|
controller.OnHidden();
|
|
selection.Select(ObjectId, SelectionChangeSource.World);
|
|
Assert.Equal(new[] { ObjectId, otherObjectId }, sent);
|
|
}
|
|
|
|
[Fact]
|
|
public void ResponseForNeitherPendingNorCurrent_IsIgnored()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject { ObjectId = ObjectId, Name = "Item" });
|
|
using var interaction = NewInteraction(objects, []);
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
[],
|
|
[],
|
|
() => throw new InvalidOperationException("must not show"),
|
|
() => { })!;
|
|
|
|
Assert.False(controller.Apply(Parsed(new PropertyBundle())));
|
|
Assert.Equal(0u, controller.CurrentObjectId);
|
|
}
|
|
|
|
[Fact]
|
|
public void EmptyOwnedInscription_FocusEditAndBlur_SendsRetailTransactionOnce()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Sword",
|
|
Type = ItemType.MeleeWeapon,
|
|
ContainerId = 0x50000002u,
|
|
PublicWeenieBitfield = (uint)PublicWeenieFlags.Inscribable,
|
|
});
|
|
var inscriptions = new List<(uint ObjectId, string Text)>();
|
|
using var interaction = NewInteraction(objects, []);
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
inscriptions,
|
|
[],
|
|
() => { },
|
|
() => { })!;
|
|
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
Assert.True(controller.Apply(Parsed(new PropertyBundle())));
|
|
|
|
UiField field = Assert.IsType<UiField>(
|
|
layout.FindElement(AppraisalUiController.InscriptionTextId));
|
|
UiText signature = Assert.IsType<UiText>(
|
|
layout.FindElement(AppraisalUiController.SignatureTextId));
|
|
Assert.True(field.Editable);
|
|
Assert.Equal("<Inscribe here>", field.Text);
|
|
|
|
field.OnEvent(new UiEvent(field.EventId, field, UiEventType.FocusGained));
|
|
Assert.Equal(string.Empty, field.Text);
|
|
Assert.Equal("--Tester", Assert.Single(signature.LinesProvider()).Text);
|
|
foreach (char c in "For glory")
|
|
field.InsertChar(c);
|
|
field.OnEvent(new UiEvent(field.EventId, field, UiEventType.FocusLost));
|
|
|
|
Assert.Equal(
|
|
new[] { (ObjectId, "For glory") },
|
|
inscriptions);
|
|
Assert.Equal("--Tester", Assert.Single(signature.LinesProvider()).Text);
|
|
|
|
field.OnEvent(new UiEvent(field.EventId, field, UiEventType.FocusGained));
|
|
field.OnEvent(new UiEvent(field.EventId, field, UiEventType.FocusLost));
|
|
Assert.Single(inscriptions);
|
|
}
|
|
|
|
[Fact]
|
|
public void ExistingInscription_ClearOnBlur_SendsEmptyAndRestoresPlaceholder()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Sword",
|
|
Type = ItemType.MeleeWeapon,
|
|
ContainerId = 0x50000002u,
|
|
PublicWeenieBitfield = (uint)PublicWeenieFlags.Inscribable,
|
|
});
|
|
var inscriptions = new List<(uint ObjectId, string Text)>();
|
|
using var interaction = NewInteraction(objects, []);
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
inscriptions,
|
|
[],
|
|
() => { },
|
|
() => { })!;
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
var properties = new PropertyBundle();
|
|
properties.Strings[7u] = "Old words";
|
|
properties.Strings[8u] = "Tester";
|
|
Assert.True(controller.Apply(Parsed(properties)));
|
|
|
|
UiField field = Assert.IsType<UiField>(
|
|
layout.FindElement(AppraisalUiController.InscriptionTextId));
|
|
UiText signature = Assert.IsType<UiText>(
|
|
layout.FindElement(AppraisalUiController.SignatureTextId));
|
|
field.SetText(string.Empty);
|
|
field.OnEvent(new UiEvent(field.EventId, field, UiEventType.FocusLost));
|
|
|
|
Assert.Equal(new[] { (ObjectId, string.Empty) }, inscriptions);
|
|
Assert.Equal("<Inscribe here>", field.Text);
|
|
Assert.Equal(string.Empty, Assert.Single(signature.LinesProvider()).Text);
|
|
}
|
|
|
|
[Fact]
|
|
public void InscriptionPermissionMessages_MatchRetail()
|
|
{
|
|
ImportedLayout otherScribeLayout = FixtureLoader.LoadExamination();
|
|
var otherScribeObjects = new ClientObjectTable();
|
|
otherScribeObjects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Sword",
|
|
ContainerId = 0x50000002u,
|
|
PublicWeenieBitfield = (uint)PublicWeenieFlags.Inscribable,
|
|
});
|
|
var messages = new List<string>();
|
|
using var otherInteraction = NewInteraction(otherScribeObjects, []);
|
|
using AppraisalUiController otherController = Bind(
|
|
otherScribeLayout,
|
|
otherScribeObjects,
|
|
otherInteraction,
|
|
new CombatState(),
|
|
[],
|
|
messages,
|
|
() => { },
|
|
() => { })!;
|
|
otherInteraction.ExamineSelectedOrEnterMode(ObjectId);
|
|
var otherProperties = new PropertyBundle();
|
|
otherProperties.Strings[7u] = "Hands off";
|
|
otherProperties.Strings[8u] = "Other";
|
|
Assert.True(otherController.Apply(Parsed(otherProperties)));
|
|
UiField otherField = Assert.IsType<UiField>(
|
|
otherScribeLayout.FindElement(AppraisalUiController.InscriptionTextId));
|
|
Assert.False(otherField.Editable);
|
|
otherField.OnEvent(new UiEvent(
|
|
otherField.EventId,
|
|
otherField,
|
|
UiEventType.Click));
|
|
Assert.Equal("Only Other can change the inscription", Assert.Single(messages));
|
|
|
|
ImportedLayout unownedLayout = FixtureLoader.LoadExamination();
|
|
var unownedObjects = new ClientObjectTable();
|
|
unownedObjects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Sword",
|
|
ContainerId = 0x60000000u,
|
|
PublicWeenieBitfield = (uint)PublicWeenieFlags.Inscribable,
|
|
});
|
|
messages.Clear();
|
|
using var unownedInteraction = NewInteraction(unownedObjects, []);
|
|
using AppraisalUiController unownedController = Bind(
|
|
unownedLayout,
|
|
unownedObjects,
|
|
unownedInteraction,
|
|
new CombatState(),
|
|
[],
|
|
messages,
|
|
() => { },
|
|
() => { })!;
|
|
unownedInteraction.ExamineSelectedOrEnterMode(ObjectId);
|
|
Assert.True(unownedController.Apply(Parsed(new PropertyBundle())));
|
|
UiField unownedField = Assert.IsType<UiField>(
|
|
unownedLayout.FindElement(AppraisalUiController.InscriptionTextId));
|
|
unownedField.OnEvent(new UiEvent(
|
|
unownedField.EventId,
|
|
unownedField,
|
|
UiEventType.Click));
|
|
Assert.Equal(
|
|
"Item must be in your inventory to inscribe.",
|
|
Assert.Single(messages));
|
|
}
|
|
|
|
[Fact]
|
|
public void NonInscribableItem_HidesEditorAndBackgroundReportsRetailMessage()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Component",
|
|
ContainerId = 0x50000002u,
|
|
});
|
|
var messages = new List<string>();
|
|
using var interaction = NewInteraction(objects, []);
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
[],
|
|
messages,
|
|
() => { },
|
|
() => { })!;
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
Assert.True(controller.Apply(Parsed(new PropertyBundle())));
|
|
|
|
UiField field = Assert.IsType<UiField>(
|
|
layout.FindElement(AppraisalUiController.InscriptionTextId));
|
|
UiText signature = Assert.IsType<UiText>(
|
|
layout.FindElement(AppraisalUiController.SignatureTextId));
|
|
Assert.False(field.Visible);
|
|
Assert.False(signature.Visible);
|
|
|
|
UiDatElement background = Assert.IsType<UiDatElement>(
|
|
layout.FindElement(AppraisalUiController.InscriptionBackgroundId));
|
|
background.OnClick!.Invoke();
|
|
Assert.Equal("This item is not inscribable.", Assert.Single(messages));
|
|
}
|
|
|
|
[Fact]
|
|
public void HookProfileControlsVisibilityButPublicFlagStillControlsEditing()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Hooked Decoration",
|
|
ContainerId = 0x50000002u,
|
|
HookItemTypes = (uint)ItemType.Misc,
|
|
HookType = 1u,
|
|
});
|
|
var messages = new List<string>();
|
|
using var interaction = NewInteraction(objects, []);
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
[],
|
|
messages,
|
|
() => { },
|
|
() => { })!;
|
|
interaction.ExamineSelectedOrEnterMode(ObjectId);
|
|
|
|
AppraiseInfoParser.Parsed appraisal = Parsed(new PropertyBundle()) with
|
|
{
|
|
Flags = AppraiseInfoParser.IdentifyResponseFlags.HookProfile,
|
|
HookProfile = new AppraiseInfoParser.HookProfile(
|
|
Flags: 1u,
|
|
ValidLocations: 0u,
|
|
AmmoType: 0u),
|
|
};
|
|
Assert.True(controller.Apply(appraisal));
|
|
|
|
UiField field = Assert.IsType<UiField>(
|
|
layout.FindElement(AppraisalUiController.InscriptionTextId));
|
|
Assert.True(field.Visible);
|
|
Assert.False(field.Editable);
|
|
field.OnEvent(new UiEvent(field.EventId, field, UiEventType.Click));
|
|
Assert.Equal("This item is not inscribable.", Assert.Single(messages));
|
|
}
|
|
|
|
[Fact]
|
|
public void Examination_IsAnIndependentFloatyWindow_NotSharedMainPanelContent()
|
|
{
|
|
Assert.False(
|
|
RetailPanelCatalog.TryGetPanelId(WindowNames.Examination, out _));
|
|
Assert.DoesNotContain(
|
|
RetailPanelCatalog.MountedPanels,
|
|
mounted => mounted.WindowName == WindowNames.Examination);
|
|
}
|
|
|
|
[Fact]
|
|
public void SpellExamination_UsesAuthoredLocalSubviewWithoutSelectingOrAppraisingSpellId()
|
|
{
|
|
ImportedLayout layout = FixtureLoader.LoadExamination();
|
|
var objects = new ClientObjectTable();
|
|
objects.AddOrUpdate(new ClientObject
|
|
{
|
|
ObjectId = ObjectId,
|
|
Name = "Selected Drudge",
|
|
Type = ItemType.Creature,
|
|
});
|
|
var sent = new List<uint>();
|
|
using var interaction = NewInteraction(objects, sent);
|
|
var selection = new SelectionState();
|
|
selection.Select(ObjectId, SelectionChangeSource.World);
|
|
SpellMetadata metadata = ExaminedSpell();
|
|
var spellbook = new Spellbook(SpellTable.Create([metadata]));
|
|
var components = new[]
|
|
{
|
|
new SpellExamineComponent(
|
|
10u,
|
|
new SpellComponentDescriptor(100u, "Lead Scarab", 0u, 0x06000010u),
|
|
Owned: true),
|
|
new SpellExamineComponent(
|
|
11u,
|
|
new SpellComponentDescriptor(101u, "Malar Herb", 1u, 0x06000011u),
|
|
Owned: false),
|
|
};
|
|
var componentTemplate = new SpellExamineComponentTemplateFactory(
|
|
new ElementInfo
|
|
{
|
|
Id = SpellExamineComponentTemplateFactory.TemplateId,
|
|
Type = 3,
|
|
Width = 20,
|
|
Height = 20,
|
|
},
|
|
NoTexture,
|
|
defaultFont: null);
|
|
var resolvedComponentIcons = new List<uint>();
|
|
int shown = 0;
|
|
using AppraisalUiController controller = Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
new CombatState(),
|
|
[],
|
|
[],
|
|
() => shown++,
|
|
() => { },
|
|
selection: selection,
|
|
spellbook: spellbook,
|
|
resolveSpellIcon: id => new GpuTextureSlot(id + 1_000u),
|
|
resolveComponentIcon: did =>
|
|
{
|
|
resolvedComponentIcons.Add(did);
|
|
return new GpuTextureSlot(did + 2_000u);
|
|
},
|
|
spellComponents: _ => components,
|
|
magicSkill: _ => 200u,
|
|
spellComponentTemplates: componentTemplate)!;
|
|
|
|
Assert.True(interaction.ExamineSelectedOrEnterMode(ObjectId));
|
|
Assert.Equal(1, interaction.BusyCount);
|
|
|
|
Assert.True(controller.ExamineSpell(metadata.SpellId));
|
|
|
|
Assert.Equal(AppraisalView.Spell, controller.ActiveView);
|
|
Assert.Equal(1, shown);
|
|
Assert.Equal(ObjectId, selection.SelectedObjectId);
|
|
Assert.Equal(new uint[] { ObjectId, 0u }, sent);
|
|
Assert.Equal(0, interaction.BusyCount);
|
|
Assert.Equal(0u, controller.CurrentObjectId);
|
|
Assert.True(layout.FindElement(AppraisalUiController.SpellPanelId)!.Visible);
|
|
Assert.False(layout.FindElement(AppraisalUiController.ItemPanelId)!.Visible);
|
|
Assert.False(layout.FindElement(AppraisalUiController.CreaturePanelId)!.Visible);
|
|
|
|
AssertSpellText(
|
|
layout,
|
|
AppraisalUiController.TitleId,
|
|
"Incantation of Test");
|
|
AssertSpellText(
|
|
layout,
|
|
AppraisalUiController.SpellSchoolTextId,
|
|
"School: War Magic");
|
|
AssertSpellText(
|
|
layout,
|
|
AppraisalUiController.SpellManaTextId,
|
|
"Mana: 50 + 14 per target");
|
|
AssertSpellText(
|
|
layout,
|
|
AppraisalUiController.SpellDurationTextId,
|
|
"Duration: 1 min.");
|
|
AssertSpellText(
|
|
layout,
|
|
AppraisalUiController.SpellRangeTextId,
|
|
"Range: 82.0 yds.");
|
|
string display = string.Join(
|
|
'\n',
|
|
((UiText)layout.FindElement(
|
|
AppraisalUiController.SpellDisplayTextId)!)
|
|
.LinesProvider()
|
|
.Select(line => line.Text));
|
|
Assert.Contains("A projected retail spell.", display);
|
|
Assert.Contains("COMPONENTS:", display);
|
|
Assert.Contains("Lead Scarab", display);
|
|
Assert.Contains("Malar Herb", display);
|
|
|
|
UiElement iconHost = layout.FindElement(
|
|
AppraisalUiController.SpellIconId)!;
|
|
UiTextureElement icon = Assert.Single(
|
|
iconHost.Children.OfType<UiTextureElement>());
|
|
Assert.Equal(new GpuTextureSlot(metadata.SpellId + 1_000u), icon.Texture);
|
|
Assert.Equal(
|
|
new uint[] { 0x06000010u, 0x06000011u },
|
|
resolvedComponentIcons);
|
|
UiElement formula = layout.FindElement(
|
|
AppraisalUiController.SpellFormulaListId)!;
|
|
Assert.Equal(
|
|
new[]
|
|
{
|
|
new GpuTextureSlot(0x06000010u + 2_000u),
|
|
new GpuTextureSlot(0x06000011u + 2_000u),
|
|
},
|
|
formula.Children
|
|
.OfType<UiDatElement>()
|
|
.Select(cell => cell.RuntimeImageTexture!.Value));
|
|
}
|
|
|
|
private static AppraisalUiController? Bind(
|
|
ImportedLayout layout,
|
|
ClientObjectTable objects,
|
|
ItemInteractionController interaction,
|
|
CombatState combat,
|
|
List<(uint ObjectId, string Text)> inscriptions,
|
|
List<string> messages,
|
|
Action show,
|
|
Action close,
|
|
CreatureAppraisalRowTemplateFactory? creatureRows = null,
|
|
CreatureDisplayNameResolver? creatureNames = null,
|
|
SelectionState? selection = null,
|
|
RetailAppraisalNameResolver? itemNames = null,
|
|
Spellbook? spellbook = null,
|
|
Func<uint, GpuTextureSlot>? resolveSpellIcon = null,
|
|
Func<uint, GpuTextureSlot>? resolveComponentIcon = null,
|
|
Func<uint, IReadOnlyList<SpellExamineComponent>>? spellComponents = null,
|
|
Func<MagicSchool, uint>? magicSkill = null,
|
|
SpellExamineComponentTemplateFactory? spellComponentTemplates = null)
|
|
=> AppraisalUiController.Bind(
|
|
layout,
|
|
objects,
|
|
interaction,
|
|
selection ?? new SelectionState(),
|
|
combat,
|
|
spellbook ?? new Spellbook(),
|
|
() => "Tester",
|
|
(objectId, text) => inscriptions.Add((objectId, text)),
|
|
messages.Add,
|
|
show,
|
|
close,
|
|
creatureRows,
|
|
creatureNames,
|
|
itemNames,
|
|
resolveSpellIcon,
|
|
resolveComponentIcon,
|
|
spellComponents,
|
|
magicSkill,
|
|
spellComponentTemplates);
|
|
|
|
private static ItemInteractionController NewInteraction(
|
|
ClientObjectTable objects,
|
|
List<uint> sent)
|
|
=> new(
|
|
objects,
|
|
new AcDream.Runtime.Gameplay.RuntimeInteractionTransactionState(new InventoryTransactionState(objects)),
|
|
new InteractionState(),
|
|
playerGuid: () => 0x50000002u,
|
|
sendUse: null,
|
|
sendUseWithTarget: null,
|
|
sendWield: null,
|
|
sendDrop: null,
|
|
sendExamine: sent.Add);
|
|
|
|
private static AppraiseInfoParser.Parsed Parsed(
|
|
PropertyBundle properties,
|
|
AppraiseInfoParser.CreatureProfile? creature = null,
|
|
uint guid = ObjectId)
|
|
=> new(
|
|
Guid: guid,
|
|
Flags: creature is null
|
|
? AppraiseInfoParser.IdentifyResponseFlags.IntStatsTable
|
|
: AppraiseInfoParser.IdentifyResponseFlags.CreatureProfile,
|
|
Success: true,
|
|
Properties: properties,
|
|
SpellBook: [],
|
|
ArmorProfile: null,
|
|
CreatureProfile: creature,
|
|
WeaponProfile: null,
|
|
HookProfile: null,
|
|
ArmorLevels: null,
|
|
ArmorEnchantments: null,
|
|
WeaponEnchantments: null,
|
|
ResistEnchantments: null);
|
|
|
|
private static void AssertSpellText(
|
|
ImportedLayout layout,
|
|
uint elementId,
|
|
string expected)
|
|
{
|
|
UiText text = Assert.IsType<UiText>(layout.FindElement(elementId));
|
|
Assert.Equal(
|
|
expected,
|
|
string.Join('\n', text.LinesProvider().Select(line => line.Text)));
|
|
}
|
|
|
|
private static SpellMetadata ExaminedSpell()
|
|
=> new(
|
|
SpellId: 42u,
|
|
Name: "Incantation of Test",
|
|
School: "War Magic",
|
|
Family: 1u,
|
|
IconId: 0x06001234u,
|
|
SpellWords: "Malar Aether",
|
|
Duration: 90f,
|
|
ManaCost: 50,
|
|
IsDebuff: false,
|
|
IsFellowship: false,
|
|
Description: "A projected retail spell.",
|
|
SortKey: 0,
|
|
Difficulty: 0,
|
|
Flags: 0u,
|
|
Generation: 6,
|
|
IsFastWindup: false,
|
|
IsOffensive: true,
|
|
IsUntargeted: false,
|
|
Speed: 0f,
|
|
CasterEffect: 0u,
|
|
TargetEffect: 0u,
|
|
TargetMask: 0u,
|
|
SpellType: 0)
|
|
{
|
|
SchoolId = MagicSchool.WarMagic,
|
|
BaseRangeConstant = 40f,
|
|
BaseRangeModifier = 0.25f,
|
|
ManaModifier = 14u,
|
|
FormulaComponents = [10u, 11u],
|
|
};
|
|
}
|