acdream/tests/AcDream.Core.Tests/Items
Erik c68ad1e646
Some checks are pending
Headless portability / portable-headless (ubuntu-latest) (push) Waiting to run
Headless portability / portable-headless (windows-latest) (push) Waiting to run
Headless portability / linux-graphical (push) Waiting to run
Headless portability / linux-vulkan (push) Waiting to run
fix(vendor): 6b/6c review corrections — pre-send guards, accumulating staging, trade-note exemption, drag-over tab switch, full-stack sells
All thirteen findings, each anchored in recovered bytes or pc reads:

Buy All now runs retail's four PRE-SEND guards in order (pyreal and
alt-currency affordability, container and item slot capacity; strings
recovered from .rdata at 0x007b57b4/0x007b5750) — a rejected batch can
no longer destroy the staged list. Staged adds ACCUMULATE with the
5000 cap ("I can't possibly sell you that much!..." @0x007b59d8) and
the shop rows decrement/restore per RemoveFromShop. The max-value sell
rejection exempts trade notes — the raw bytes at 0x005d1add are `not`
(bitwise), not the pseudo-C's misleading `!`, and the early ret skips
the min check too. BF_RETAINED gates selling end to end (the bit was
already on ClientObject; AP-164's three claims were all false once
traced — RETIRED). Dragging over the vendor window auto-opens the
Selling tab per UpdateDragOver — with a correction to the review's own
citation: token 0x100000cd is the SELLING page, the guard is
"don't reopen the current tab." Sells are full-stack-only (three
retail sites; "Cannot sell part of a stack" @0x007b57ec) and Sell Item
acts on the global selection unconditionally. The confirm string gains
its byte-true trailing '?', dies with the session, staged-row
highlights repaint, dead guids unstage with retail's shopping-list
notice, and move-to-use no longer walks to targets the dispatch would
refuse.

AP-162 narrowed, AP-164 retired, AP-167/AP-168 filed honest.

Clean-room complete solution: 11,508 passed / 4 skipped / 0 failed.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-08-08 12:50:28 +02:00
..
AetheriaUnlockStateTests.cs fix(paperdoll): port quest-gated Aetheria slots 2026-07-13 09:55:20 +02:00
BurdenMathTests.cs fix(ui): match retail vitae and character info 2026-07-17 12:06:14 +02:00
ClientObjectNameTests.cs fix(ui): finish retail stack selector polish 2026-07-11 10:22:11 +02:00
ClientObjectTableBurdenTests.cs feat(core): D.2b-B — ClientObjectTable.SumCarriedBurden (carried-Burden fallback) 2026-06-21 08:55:35 +02:00
ClientObjectTableTests.cs fix(physics): #297 — keep the PWD bitfield live so PK status reaches the client 2026-08-03 20:59:01 +02:00
ClientObjectTableUpdateTests.cs feat(core): D.2b-B B-Wire — ClientObjectTable.UpdateStackSize 2026-06-21 18:48:54 +02:00
EquipMaskTests.cs fix(D.2b): correct EquipMask to canonical retail INVENTORY_LOC + numeric-pin test 2026-06-22 21:56:06 +02:00
ExternalContainerStateTests.cs refactor(net): converge live session state reset 2026-07-21 12:00:48 +02:00
InventoryTransactionStateTests.cs refactor(runtime): own inventory transaction state 2026-07-26 08:20:32 +02:00
ItemCooldownDisplayTests.cs feat(items): port retail shared cooldown overlays 2026-07-23 10:41:16 +02:00
ItemInteractionPolicyTests.cs fix(items): port retail useability and autowear rejection 2026-07-23 08:33:31 +02:00
ItemManaStateTests.cs feat(ui): port retail selected-item mana 2026-07-11 11:16:21 +02:00
ItemUseabilityTests.cs fix(items): port retail useability and autowear rejection 2026-07-23 08:33:31 +02:00
PaperdollSelectionPolicyTests.cs fix(ui): port exact paperdoll body selection 2026-07-11 11:56:26 +02:00
PlayerKillerStatusBitfieldTests.cs fix(physics): #297 — keep the PWD bitfield live so PK status reaches the client 2026-08-03 20:59:01 +02:00
ShortcutDropPlannerTests.cs feat(ui): complete retail item drop branches 2026-07-11 09:46:32 +02:00
ShortcutStoreTests.cs refactor(runtime): close canonical gameplay ownership 2026-07-26 09:48:51 +02:00
StackMergePlannerTests.cs feat(ui): complete retail item drop branches 2026-07-11 09:46:32 +02:00
StackSplitQuantityStateTests.cs fix(ui): port retail partial stack transfers 2026-07-11 10:34:13 +02:00
ToolbarAmmoPolicyTests.cs feat(ui): port retail toolbar ammo count 2026-07-11 12:29:51 +02:00
VendorPricingTests.cs fix(runtime/core): Slice 5.3 review corrections — retirement/transit close, per-unit pricing, guarded auto-close dispatch 2026-08-07 16:15:57 +02:00
VendorSellAcceptabilityTests.cs fix(vendor): 6b/6c review corrections — pre-send guards, accumulating staging, trade-note exemption, drag-over tab switch, full-stack sells 2026-08-08 12:50:28 +02:00
VendorStagingListTests.cs fix(vendor): 6b/6c review corrections — pre-send guards, accumulating staging, trade-note exemption, drag-over tab switch, full-stack sells 2026-08-08 12:50:28 +02:00
VendorStateTests.cs fix(ui): Slice 5.4 review corrections — the dropdown renders from its authored popup, retail cost semantics, auto-select, icon overlays 2026-08-07 18:26:17 +02:00