Item 2: retail's portal-space "In Portal Space..." notice is the SpewBox (ECM_UI::SendNotice_DisplayStringInfo(0x1A,...) -> AddTextToScroll(str, 0x1A, 1, 0), hardcoded to the SpewBox per the decomp), not a dedicated centered overlay. PortalWaitNoticeController and its lease are deleted; PortalTunnelPresentation's per-rotation-segment cadence now writes straight into RuntimeCommunicationState.AddText(ClientLocal) -- the SpewBox's own dedupe-at-index-0 handles the repetition exactly as retail's does. Register row AP-184 records the surface fix and the AP-178 scope extension. Items 4+5: /help text was partially fabricated -- the user caught the "/help death" meta-message. Generalized tools/pdb-extract/sweep_weenie_strings.py to decode narrow PStringBase<char> literals (the ClientCommunicationSystem::Help* family's shape) alongside its original UTF-16LE support, then swept every HelpXxxGroup function's exact byte extent against the PDB-paired acclient.exe. 4 of 7 group topics (death/status/text/allegiances) are now complete verbatim listings; the other 3 (channels/chatting/commands) keep an honest UNVERIFIED note citing HelpStupidChannelHack @0x0056f290 (a genuinely undecodable BN-mislabeled-fragment mechanism) instead of the old fabricated sentinel. 7 of ~35 channel one-liners are also now verbatim. ISSUES.md #364 tracks the remainder; RetailCommandHelpTableTests.cs pins every result byte-exact. Item 1: jump-in-air refusal still silent live is NOT reproduced and NOT speculatively fixed. Exhaustive static re-audit found the mechanism correct by construction (single-writer OnWalkable, exactly-once-per-frame Update()/Capture(), no interfering edge-history resets). A live headless repro (new jump-probe bot policy, real ACE connect) was blocked -- probeaccount2 has no character, and the graphical client already owned testaccount this session so the task's own fallback rule forbade using it. Two temporary probes are left behind ACDREAM_PROBE_JUMP=1 (blocked entirely in Headless by the existing multi-session static-state guard -- graphical-only for the next round). Item 3 confirmed fixed, no regression. Item 6 (resize: no diagonal cursors, cannot grow Y from bottom-right) folded into CH6a's existing scope. Full Release suite: 12,267 passed / 4 skipped / 0 failed (up from 12,221/4/0). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
263 lines
14 KiB
C#
263 lines
14 KiB
C#
using System.Numerics;
|
||
using AcDream.App.UI.Layout;
|
||
using AcDream.UI.Abstractions.Panels.SpewBox;
|
||
|
||
namespace AcDream.App.UI;
|
||
|
||
/// <summary>
|
||
/// Retained presentation of retail's <c>gmSpewBoxUI</c> (research doc
|
||
/// §1.1/§7.3/§7.4) — the transient top-of-viewport interface-text queue.
|
||
/// A single <c>ClickThrough</c> <see cref="UiText"/> block at a high
|
||
/// <see cref="UiElement.ZOrder"/>. Campaign CH user-gate round 2, item 2:
|
||
/// this is now the ONLY on-screen interface-text presentation surface —
|
||
/// the former <c>PortalWaitNoticeController</c> (a dedicated centered
|
||
/// overlay with a single overwrite-only slot) is deleted; the portal-space
|
||
/// wait notice routes here too, through the same
|
||
/// <c>RuntimeCommunicationState.AddText</c> chokepoint every other
|
||
/// <c>ClientLocal</c> refusal uses. This reads <see cref="SpewBoxVM"/>'s
|
||
/// bounded, newest-on-top, per-entry-expiring queue every frame.
|
||
/// </summary>
|
||
/// <remarks>
|
||
/// <b>CH2 REJECT-review rework, BLOCKER 1
|
||
/// (<c>docs/research/2026-08-09-ch2-review-findings.md</c>):</b> the
|
||
/// original landing drove the queue drain from
|
||
/// <see cref="UiText.LinesProvider"/>, which <c>UiText.OnDraw</c> only
|
||
/// calls when the element is ALREADY <c>Visible</c> — and the element
|
||
/// starts invisible, so the provider was never invoked, no line ever drew,
|
||
/// and <see cref="SpewBoxState"/>'s pending queue never drained (an
|
||
/// unbounded per-session leak). Retail's own <c>gmSpewBoxUI::Update</c>
|
||
/// drains off the UI tick (global message 3,
|
||
/// <c>UIElementManager::UseTime @0x0045CFD0</c>), not off drawing —
|
||
/// <see cref="GlobalTimeSink"/> reproduces that: it is a zero-size child
|
||
/// mounted alongside <see cref="_text"/> purely so <see cref="UiRoot"/>'s
|
||
/// per-frame <c>BroadcastGlobalUiTime</c> walk reaches it (the same
|
||
/// pattern <c>VendorUiController.DragOverGlobalTimeSink</c> uses for
|
||
/// <c>gmVendorUI::ListenToGlobalMessage</c>). <see cref="Tick"/> pulls
|
||
/// <see cref="SpewBoxVM.Lines"/>, caches the resulting lines, and sets
|
||
/// <see cref="_text"/>'s <c>Visible</c> flag; <see cref="UiText.LinesProvider"/>
|
||
/// now only ever returns the cache — it is polled by drawing, but no
|
||
/// longer double-duties as the tick source, so lines become visible and
|
||
/// the queue drains even across a frame where nothing gets drawn (headless,
|
||
/// a hidden window, or simply before the first render pass).
|
||
/// </remarks>
|
||
/// <remarks>
|
||
/// <b>Position / font / colour are still PLACEHOLDERS; extent and
|
||
/// max-items are now AUTHORED.</b> CH2 REJECT-review rework, NIT 3
|
||
/// (<c>docs/research/2026-08-09-ch2-review-findings.md</c>): the task C.7
|
||
/// LayoutDesc dump (<c>SpewBoxLayoutDumpDiagnostic</c>) originally searched
|
||
/// only <c>dats.Portal</c> — EXHAUSTIVELY, against the entire installed
|
||
/// LayoutDesc id range (<c>0x21000000</c>-<c>0x21000075</c>, 101 of 118
|
||
/// possible ids populated, sanity-checked against 3 independently-known
|
||
/// ids) — and found ZERO elements of class <c>0x10000016</c> there.
|
||
/// Extending the identical sweep to <c>dats.Local</c>
|
||
/// (<c>client_local_English.dat</c>) found it: LayoutDesc
|
||
/// <c>0x21000011</c>, element <c>0x10000048</c> (<c>gmSpewBoxUI</c>),
|
||
/// position <c>(0,0)</c> RELATIVE TO ITS PARENT (edge codes
|
||
/// <c>leftEdge=3/rightEdge=3</c> — <c>ElementReader.ToAnchors</c>'s own doc
|
||
/// comment names 3 as "centered", a mode that projection cannot represent;
|
||
/// <c>topEdge=1</c> — top-anchored per that same helper), size
|
||
/// <c>450×72</c>, one child (ListBox <c>0x10000049</c>, matching
|
||
/// <c>gmSpewBoxUI::PostInit</c>'s <c>GetChildRecursive(0x10000049)</c>
|
||
/// verbatim) carrying <c>MaxConcurrentItems</c> (property
|
||
/// <c>0x10000028</c>) = <c>4</c>, not retail's code-default <c>1</c>. The
|
||
/// PARENT this element mounts under (and therefore the ABSOLUTE screen
|
||
/// position) is still unresolved — <c>(0,0)</c> is parent-relative, and the
|
||
/// parent is presumably assigned by the same C++ code the research doc's
|
||
/// §1.1 describes, not by another LayoutDesc this sweep can walk to. See
|
||
/// the divergence register rows this class cites for each remaining
|
||
/// placeholder.
|
||
/// </remarks>
|
||
internal sealed class SpewBoxController : IDisposable
|
||
{
|
||
/// <summary>
|
||
/// Register row AP-178 (screen position): retail's authored ABSOLUTE
|
||
/// screen position is still unknown — the LayoutDesc dump (see class
|
||
/// remarks) recovered the element's position as <c>(0,0)</c> relative
|
||
/// to a PARENT this sweep could not identify, so this centered-top
|
||
/// placement remains acdream's own choice, not a resolved retail value.
|
||
/// (The SIBLING row AP-177 — the invented line-lifetime timeout — lives
|
||
/// in <see cref="SpewBoxState.DefaultLifetime"/>'s own doc comment, not
|
||
/// here; this controller does not own that concern.)
|
||
/// </summary>
|
||
private const float TopOffset = 60f;
|
||
|
||
/// <summary>
|
||
/// Register row AP-178 (extent): AUTHORED, not a placeholder — the
|
||
/// LayoutDesc dump (see class remarks) found the SpewBox element sized
|
||
/// <c>450×72</c> in <c>dats.Local</c>. Retail's own edge codes
|
||
/// (<c>leftEdge=3</c>/<c>rightEdge=3</c>, "centered" per
|
||
/// <c>ElementReader.ToAnchors</c>'s doc comment) mean the box is a
|
||
/// FIXED-width block horizontally centered in its parent, not a
|
||
/// full-viewport stretch. <see cref="AnchorEdges"/> has no "centered,
|
||
/// fixed-width" flag combination to express retail's mode 3 directly, so
|
||
/// <see cref="Tick"/> recomputes a centered <see cref="UiText.Left"/>
|
||
/// against the CURRENT <see cref="UiRoot.Width"/> every frame instead of
|
||
/// anchoring.
|
||
/// <para>
|
||
/// CH2 re-review nit 1
|
||
/// (<c>docs/plans/2026-08-09-chat-parity-campaign.md</c>): the original
|
||
/// rework anchored with <see cref="AnchorEdges.Top"/> only, meaning
|
||
/// <see cref="UiElement.ApplyAnchor"/> captured the constructor's
|
||
/// one-time centered <c>Left</c> as a fixed left MARGIN
|
||
/// (<c>ComputeAnchoredRect</c>'s Left/Right-both-false branch) and
|
||
/// replayed that absolute pixel position forever — a window resize left
|
||
/// the box off-center. <see cref="Anchors"/> is now
|
||
/// <see cref="AnchorEdges.None"/> (so <c>ApplyAnchor</c> is a no-op) and
|
||
/// centering is owned entirely by the per-frame recompute below.
|
||
/// </para>
|
||
/// </summary>
|
||
private const float SpewBoxWidth = 450f;
|
||
private const float SpewBoxHeight = 72f;
|
||
|
||
/// <summary>
|
||
/// Register row AP-178 (colour): CH user-gate round 1 (2026-08-09)
|
||
/// PINNED this — the user confirmed live, side-by-side against retail,
|
||
/// that the on-screen SpewBox text is the same bright yellow as an
|
||
/// incoming Tell (<c>0x81C4C8</c>, <c>RetailChatColorTable.Yellow</c> =
|
||
/// <c>(1, 1, 0.247, 1)</c>). The chat colour table's <c>0x1A</c> entry
|
||
/// (<c>colorBrightRed</c>) is still explicitly NOT this — retail's own
|
||
/// <c>BuildChatColorLookupTable</c> writes to <c>ChatInterface::m_chatLog</c>,
|
||
/// a completely different element tree the SpewBox never touches
|
||
/// (research doc §3.2.3); the LayoutDesc dump (see class remarks) also
|
||
/// never surfaced a colour property for this element. The exact retail
|
||
/// value simply happens to coincide with the Tell colour, per the user's
|
||
/// live observation. SIZE/POSITION/FONT remain OPEN — the user reports
|
||
/// all three still differ from retail; user gate round 1: differs,
|
||
/// iterating.
|
||
/// </summary>
|
||
private static readonly Vector4 SpewBoxColor = new(1f, 1f, 0.247f, 1f);
|
||
|
||
private readonly UiRoot _root;
|
||
private readonly UiText _text;
|
||
private readonly SpewBoxVM _vm;
|
||
private readonly GlobalTimeSink _timeSink;
|
||
private UiText.Line[] _lines = Array.Empty<UiText.Line>();
|
||
private bool _disposed;
|
||
|
||
public SpewBoxController(UiRoot root, SpewBoxVM vm)
|
||
{
|
||
_root = root ?? throw new ArgumentNullException(nameof(root));
|
||
_vm = vm ?? throw new ArgumentNullException(nameof(vm));
|
||
_text = new UiText
|
||
{
|
||
Name = "SpewBox",
|
||
// Centered fixed-width block (retail's "mode 3" edge code on
|
||
// both left and right) — see the AP-178 extent comment above.
|
||
// This is only the FIRST frame's value; Tick recomputes it
|
||
// every frame against the current root width (CH2 re-review
|
||
// nit 1 — see the extent comment's nit-1 paragraph).
|
||
Left = (root.Width - SpewBoxWidth) / 2f,
|
||
Top = TopOffset,
|
||
Width = SpewBoxWidth,
|
||
Height = SpewBoxHeight,
|
||
Anchors = AnchorEdges.None,
|
||
Centered = true,
|
||
// AUTHORED MaxConcurrentItems is 4, not retail's code-default 1
|
||
// (see SpewBoxState.MaxConcurrentItems) — OneLine=true would
|
||
// silently collapse the box back down to showing only the
|
||
// newest of up to 4 concurrent lines.
|
||
OneLine = false,
|
||
// CH2 re-review nit 2 (docs/plans/2026-08-09-chat-parity-campaign.md):
|
||
// retail's own authored vertical justification for THIS element
|
||
// is unknown (register row AP-178 covers presentation
|
||
// unknowns) — top-aligned flow is acdream's own choice, made
|
||
// because it is the only placement consistent with "lines flow
|
||
// from the top, newest on top" (see Tick's ordering comment).
|
||
// HonorVerticalJustification opts the scrollable multi-line
|
||
// path into VerticalJustify without a full ConfigureDatState
|
||
// LayoutDesc binding, which this synthesized element does not
|
||
// have.
|
||
VerticalJustify = VJustify.Top,
|
||
HonorVerticalJustification = true,
|
||
ClickThrough = true,
|
||
ZOrder = int.MaxValue,
|
||
DefaultColor = SpewBoxColor,
|
||
Visible = false,
|
||
};
|
||
_text.LinesProvider = () => _lines;
|
||
_root.AddChild(_text);
|
||
|
||
_timeSink = new GlobalTimeSink(Tick);
|
||
_root.AddChild(_timeSink);
|
||
}
|
||
|
||
/// <summary>
|
||
/// The SpewBox's per-frame tick, driven by <see cref="UiRoot"/>'s
|
||
/// global-message-3 broadcast via <see cref="GlobalTimeSink"/> — the
|
||
/// direct analogue of <c>gmSpewBoxUI::Update</c>. Drains
|
||
/// <see cref="SpewBoxState"/>'s pending queue and prunes expired
|
||
/// entries (see <see cref="SpewBoxVM.Lines"/>), caches the resulting
|
||
/// display lines, and sets <see cref="_text"/>'s visibility. Runs
|
||
/// whether or not a draw pass follows.
|
||
/// </summary>
|
||
/// <param name="nowSeconds">
|
||
/// <see cref="UiRoot"/>'s own per-frame clock — <b>not</b>
|
||
/// <c>Environment.TickCount64</c> — matching every other
|
||
/// <see cref="IUiGlobalTimeListener"/> consumer's time source.
|
||
/// </param>
|
||
private void Tick(double nowSeconds)
|
||
{
|
||
// CH2 re-review nit 1 (docs/plans/2026-08-09-chat-parity-campaign.md):
|
||
// Anchors is AnchorEdges.None (see the AP-178 extent comment on
|
||
// SpewBoxWidth), so nothing else recenters this element on a
|
||
// window resize — recompute every frame against the CURRENT root
|
||
// width rather than the width captured once at construction.
|
||
_text.Left = (_root.Width - SpewBoxWidth) / 2f;
|
||
|
||
// CH2 re-review nit 3 (docs/plans/2026-08-09-chat-parity-campaign.md):
|
||
// deliberate inversion of UiText.LinesProvider's documented
|
||
// contract ("Provider of the lines to show, oldest-first" —
|
||
// UiText.cs). SpewBoxVM.Lines returns newest-first, matching
|
||
// retail's InsertItem(item, 0), and this controller feeds that
|
||
// order straight through WITHOUT reversing it. That is correct
|
||
// here specifically because the box is top-aligned
|
||
// (VerticalJustify.Top + HonorVerticalJustification above): index 0
|
||
// of the lines array draws at the TOP of the box, so feeding
|
||
// newest-first into a slot documented as oldest-first is exactly
|
||
// what makes "newest line on top" true. Reversing the feed to
|
||
// satisfy the doc comment literally would flip the visible order to
|
||
// oldest-on-top, which is wrong for this element — see
|
||
// SpewBoxControllerTests' rendered-order test. With OneLine now
|
||
// false and the AUTHORED MaxConcurrentItems == 4 (see
|
||
// SpewBoxState.MaxConcurrentItems), up to 4 lines render.
|
||
IReadOnlyList<SpewBoxLine> lines = _vm.Lines(nowSeconds);
|
||
_text.Visible = lines.Count > 0;
|
||
if (lines.Count == 0)
|
||
{
|
||
_lines = Array.Empty<UiText.Line>();
|
||
return;
|
||
}
|
||
|
||
var result = new UiText.Line[lines.Count];
|
||
for (int i = 0; i < lines.Count; i++)
|
||
result[i] = new UiText.Line(lines[i].Text, SpewBoxColor);
|
||
_lines = result;
|
||
}
|
||
|
||
public void Dispose()
|
||
{
|
||
if (_disposed)
|
||
return;
|
||
|
||
_root.RemoveChild(_text);
|
||
_root.RemoveChild(_timeSink);
|
||
_disposed = true;
|
||
}
|
||
|
||
/// <summary>
|
||
/// A runtime-only, zero-size, always-invisible-to-hit-testing helper
|
||
/// that opts this controller into retail's global UI message 3 — see
|
||
/// the class remarks and <c>VendorUiController.DragOverGlobalTimeSink</c>
|
||
/// for the identical pattern. <see cref="SpewBoxController"/> is not
|
||
/// itself a <see cref="UiElement"/> (it wraps one), so it cannot
|
||
/// directly implement <see cref="IUiGlobalTimeListener"/> the way
|
||
/// <see cref="UiButton"/> does — <see cref="UiRoot.Tick"/>'s broadcast
|
||
/// walks the ELEMENT tree, not arbitrary controllers.
|
||
/// </summary>
|
||
private sealed class GlobalTimeSink : UiElement, IUiGlobalTimeListener
|
||
{
|
||
private readonly Action<double> _onGlobalUiTime;
|
||
public GlobalTimeSink(Action<double> onGlobalUiTime) => _onGlobalUiTime = onGlobalUiTime;
|
||
public void OnGlobalUiTime(double nowSeconds) => _onGlobalUiTime(nowSeconds);
|
||
}
|
||
}
|