Both OP4 reviews converged on one headline bug (Character-tab rows never re-read live server truth after their pre-login constructor-word seed) plus overlapping MUST-FIXes. All ten converged/consolidated findings land here: MUST-FIX: - BoolOptionRow.SaveCurrentValue now re-reads its live binding (retail's GetValue()-into-SaveCurrentValue) on every OnShown — panel open, tab switch in, initial activation — instead of trusting the pre-login constructor word it was built with. Reset/tab-switch can now only restore values that were actually live at the last show. LockUI's host.Root.UiLocked one-shot mount seed now also converges on every PlayerDescription via the existing OnCharacterOptionsChanged hook. - Apply/Reset are wired to OptionPage.OnOptionChanged in production (Ghosted when nothing changed, Normal when dirty, run once at bind so both start disabled per retail's PostInit); Defaults stays ungated. - The Combat panel's three LEDs (Repeat Attacks/Auto Target/Keep in View) now read/write the same RuntimeCharacterOptionsState seam the Character tab uses instead of a disconnected client-local GameplaySettings copy — closes the "two writable copies" divergence. The three now-orphaned GameplaySettings fields and RuntimeSettingsController's mirror properties/SetCombatGameplay are deleted outright; the headless host's hardcoded AutoRepeatAttack/AutoTarget now read the live option bit. - RuntimeSettingsController.SetUiLocked's convergence guard now compares against the last value actually applied to the runtime target instead of the persisted GameplaySettings.LockUI snapshot, which could already match a server-derived request without ever having been pushed. SHOULD-FIX: - DisplayTimeStamps now prefixes every chat producer (ChatLog.Append is the one seam all of them funnel through), not just AddText's own callers — heard speech, emotes, Turbine channels, and combat text were previously missed. The prefix format escapes its colons and forces InvariantCulture instead of the culture-dependent TimeSeparator placeholder. - sky.frag now honors uFogParams.w (fog mode) like the mesh/terrain shaders, so Disable Distance Fog stops the sky dome's horizon band from blending toward fog color too. - Corrected the "byte-verified" overclaim on the timestamp format string doc comment (BN-sourced, wire doc U6) and the AP-194 anchor-column class-name typo; the RunAsDefaultMovement doc comments now cite retail's actual acclient.h enumerator name. - Added: DispatcherMovementInputSource's option x modifier truth table (incl. || AutoRunActive with the option off), the per-page Apply/Reset enable-gate tests, a real checkbox.OnClick/ToggleBehavior-driven click test, and hash-pins for the six header string keys. - Gate script step 8 corrected for the logout-flush false-failure (closing the panel before relogging is load-bearing); a new step documents the enable-gate sequence and the Combat-panel/Character-tab cross-check. Register: AP-196 (the Group-C default-source change + GameplaySettings retirement) and AP-197 (the ignored per-character timestamp format override) filed in this commit. Full Release suite: 13,044 passed / 4 skipped / 0 failed (was 13,008/4/0; net +36 tests from new coverage and legitimate assertion updates from the GameplaySettings retirement). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
149 lines
3.9 KiB
JSON
149 lines
3.9 KiB
JSON
{
|
|
"note": "Campaign V slice V6c. Regenerate with tools/compile-shaders.ps1.",
|
|
"shaders": [
|
|
{
|
|
"name": "debug_line",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "069ef7c89eea80c68e28f44b9e065c5cd3cc9220e8ba63261d345377025c2ea1",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "5db0714b88329f2465f4b8b949116e4295e37bf17360d81c108eacccb102a336",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "mesh_modern",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "2c37aa0fd1ee4af5ee1f6541b00e6a7226d4173988e748b1fb1c271b0a9b91b2",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "12f2ceec9a8420bd273650e95251ca56c3bf3c3691fce1a539e4c5aea7abaabf",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "particle",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "921c32617708b3931a6304b4697ee96d728077d96f489d6c09eea4c5fe225b63",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "6f2a5769670087bf58b0c1a7a007c1853952354dfd9106973656311bcbb855cd",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "particle_mesh",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "19db8757c1a61a2fbec8e56ce89d56b6dd6d66a123cedcdae40915af07d58c0e",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "73c8db72aeb44e88054dd79fd722c7f683b27a8bc03368b5201f05adffd92728",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "portal_depth",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "6214fc04936d92320594acb722e63f1cd1f7106dd4d0af60ed985abc2a50c4a9",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "711ba97649f27f890f0cad5f355552fd8f707cbe801af4ac14afbee1b8f800c9",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "sky",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "a89580f54c8d36b33d50b84b9fb61024861c737bb0b5bd7a4df0704bf010c3c3",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "2ddf210d69b0c4a3c0870eecfb0ccba2097d93b365729739402bfe91e3b120d0",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "terrain_modern",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "a3f8592d482793622f7a69c08f8ba828a4e071f2fb5e1763f865be84797bceb7",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "a9f0ad2e679b68ee2de6c4877202f6f5e5089d0f7368fcedd6048891c6848915",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "ui_text",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "4ddc52f18ea953b33e9263dc2703397f63f4b104bc45d67edc06531145bd9d53",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "43cb53aa8c933f7800142b72ea81bafc923fd7039fd460022d55543081d0aee5",
|
|
"compiled": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"name": "vk_probe",
|
|
"vulkanReady": true,
|
|
"stages": [
|
|
{
|
|
"stage": "vert",
|
|
"sourceSha256": "1f3f73aa4e9448c36f3b577e63b2142815736a4195bbc4395e1d674a9be92f43",
|
|
"compiled": true
|
|
},
|
|
{
|
|
"stage": "frag",
|
|
"sourceSha256": "8093adcacb925258ea79371a3ac3415de4f270f95eb12a621c759912992a5614",
|
|
"compiled": true
|
|
}
|
|
]
|
|
}
|
|
]
|
|
}
|