cd1cdee0e5
The paperdoll was visible only in portal space. Root cause: the classic WbDrawDispatcher.Draw path appended its transforms into the SHARED world transform frame (WorldTransformFrameArena.Append) with a non-zero base instance, but the default mesh shaders index every parallel per-instance array - clip slots, light sets, indoor, OPACITY, selection lighting, detail category - zero-based; only the packed world submission's shader convention subtracts the shared-arena prefix. With a world frame active the doll drew all instances at per-instance opacity 0 into a cleared target: counted draws, blank pixels, deterministic. Portal space worked because no world transform frame is active there, so the same code took the ring path with base 0. The private viewports are the only production consumers of the classic path, hiding the defect everywhere else. Fix: WbDrawDispatcher.NextClassicDrawIsPrivatePass - the private viewport renderer marks its draw and WriteWorldTransformSection routes private passes onto the plain ring path unconditionally (self-contained render state: the private pass owns its own camera, lighting, and target, and must not depend on the world frame's pose address space). Also landed, each independently justified: - Per-GPU-flight-slot private targets (PrivateViewportFlightTargets), restoring the pre-f6fe0f2a design: that revert's claim that frame submission order protects the single target's write->sample transition is not guaranteed across Vulkan command buffers. Per-slot completed scenes fix the cleared-sibling-after-reveal wart the old attempt had. - Paperdoll resource preparation moved to the frame resource phase (IPrivateEntityViewportResourcePreparation) before world draws consume the bounded composite-upload budget. - The presenter redresses on every dirty edge (an appearance-equal clone can pin retired readiness across generations; the renderer's two-phase promote keeps the last completed image visible during replacement), publishes only non-zero handles, and clears the viewport exactly once at the explicit character-session boundary. Verified live on the clean build: doll visible in the NORMAL world, visible through portal space, and still visible after arrival - the exact reported repro cycle. 26 paperdoll/private-viewport/preparation tests plus 60 renderer-suite tests pass; owner visual gate pending. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
58 lines
2.3 KiB
C#
58 lines
2.3 KiB
C#
namespace AcDream.App.Rendering;
|
|
|
|
internal interface IRenderWeatherFramePhase
|
|
{
|
|
void Tick(double deltaSeconds);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Optional per-frame developer-presentation hook. Its one production
|
|
/// implementation (the ImGui developer-tools frontend) was removed at
|
|
/// Campaign V slice V11; the interface survives as the seam a follow-up
|
|
/// re-homing Settings/Debug onto the retained UI will implement, and every
|
|
/// current caller already treats it as optional (<c>null</c>-conditional).
|
|
/// </summary>
|
|
internal interface IDevToolsFrameLifecycle : IRenderFrameFailureRecovery
|
|
{
|
|
void BeginFrame(float deltaSeconds);
|
|
|
|
void Render(double deltaSeconds, int viewportWidth, int viewportHeight);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Preserves the accepted pre-world order after the GPU/resource transaction:
|
|
/// begin optional developer UI, advance render-time weather, then hand the
|
|
/// completed preparation to the world phase.
|
|
/// </summary>
|
|
internal sealed class RenderFramePreparationController : IRenderFrameResourcePhase
|
|
{
|
|
private readonly IRenderFrameResourcePhase _resources;
|
|
private readonly IDevToolsFrameLifecycle? _devTools;
|
|
private readonly IRenderWeatherFramePhase _weather;
|
|
private readonly IPrivateEntityViewportResourcePreparation? _privateViewports;
|
|
|
|
public RenderFramePreparationController(
|
|
IRenderFrameResourcePhase resources,
|
|
IDevToolsFrameLifecycle? devTools,
|
|
IRenderWeatherFramePhase weather,
|
|
IPrivateEntityViewportResourcePreparation? privateViewports = null)
|
|
{
|
|
_resources = resources ?? throw new ArgumentNullException(nameof(resources));
|
|
_devTools = devTools;
|
|
_weather = weather ?? throw new ArgumentNullException(nameof(weather));
|
|
_privateViewports = privateViewports;
|
|
}
|
|
|
|
public void Prepare(RenderFrameInput input)
|
|
{
|
|
_resources.Prepare(input);
|
|
// The composite upload budget opens with the resource phase. Give the
|
|
// paperdoll's private object its prewarm slot before the world can
|
|
// consume the complete per-frame budget (#443 — the doll rendered
|
|
// only while portal space quiesced the world); presentation samples
|
|
// the result later, after the world pass has closed.
|
|
_privateViewports?.PrepareResources();
|
|
_devTools?.BeginFrame((float)input.DeltaSeconds);
|
|
_weather.Tick(input.DeltaSeconds);
|
|
}
|
|
}
|