614a1e055f
Ports retail's SendTurbineChat (@0x0057db10) local pre-send membership gate so Roleplay/Society/Olthoi stop silently swallowing outbound chat: a new TurbineChatMembershipGate checks Turbine availability and the player's own Hear*Chat option before sending, raising "Turbine chat is not available." or the 0x0551 YouAreNotListeningTo_Channel refusal through the CH2 AddText chokepoint instead. Wired into both the graphical (LiveSessionCommandRouter) and headless (DirectGameRuntimeCommandAdapter) send paths so they can't diverge. Retracts the 26-day-old false "ACE doesn't run a TurbineChat server" claim from ISSUES.md, the roadmap, and project_chat_pipeline.md — ACE's TurbineChat implementation is complete and on by default; the real bug was treating Hear*Chat as a display filter instead of room membership. Also: implements SetSingleCharacterOption (0x0005), the only wire message that actually joins/leaves a Turbine room, and wires the five Settings Chat toggles to it (publish on Save, changed bits only) plus seeds ChatSettings from the server's own CharacterOptions2 on every PlayerDescription. Fixes the legacy-channel double-print (Fellow/Vassals/Patron/Monarch/CoVassals skip the local echo now that ChatChannelInfo.IsSelfEchoChannel is finally consulted). Routes /a to Turbine unconditionally (retail's @a never falls back to the legacy bitflag) and adds /ab for the legacy AllegianceBroadcast verb retail actually has. Surfaces a nonzero TurbineChat ack HResult instead of discarding it silently. Deletes the malformed, callerless SetCharacterOptions (0x01A1) and AddChannel/RemoveChannel (0x0145/0x0146) builders. Files every AC-specific algorithm change cites the named retail decomp (SendTurbineChat 0x0057db10, StartupTurbineChatSystem 0x0057EFB0, GameActionSetSingleCharacterOption) plus ACE/holtburger cross-checks. Register rows AP-181 (no client-side spam throttle) and UN-9 (an incidentally-discovered CharacterOptions1.Default literal mismatch, not investigated further) filed per the divergence-register rule. 11,957 passed / 4 skipped / 0 failed (full Release suite, up from the 11,916/4/0 baseline). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
59 lines
2.2 KiB
C#
59 lines
2.2 KiB
C#
namespace AcDream.UI.Abstractions;
|
|
|
|
/// <summary>
|
|
/// Outbound chat channel selector. Mirrors holtburger's <c>ChatChannelKind</c>
|
|
/// (<c>references/holtburger/crates/holtburger-core/src/client/types.rs</c>
|
|
/// lines 35-49) plus a synthetic <see cref="Say"/> + <see cref="Tell"/> for
|
|
/// the two non-channel cases — local speech and whispers — so a single
|
|
/// <see cref="SendChatCmd"/> can carry every outbound flavour the chat
|
|
/// panel emits.
|
|
///
|
|
/// <para>
|
|
/// Channels split into:
|
|
/// <list type="bullet">
|
|
/// <item><b>Legacy</b> (Fellowship, Vassals, Patron, Monarch, CoVassals,
|
|
/// AllegianceBroadcast): map to a fixed <c>ChatChannel</c> bitflag id
|
|
/// via <see cref="ChannelResolver"/> and ride 0x0147 ChatChannel.</item>
|
|
/// <item><b>Turbine</b> (Allegiance, General, Trade, Lfg, Roleplay, Society,
|
|
/// Olthoi): resolve to a server-assigned Turbine room id at runtime via
|
|
/// <c>TurbineChatMembershipGate</c> and ride 0xF7DE TurbineChat.
|
|
/// Campaign CH slice CH3 (2026-08-09) moved <see cref="Allegiance"/>
|
|
/// here unconditionally — retail's <c>@a</c> binds to
|
|
/// <c>DoTurbineChat_Allegiance</c>, never the legacy bitflag; see
|
|
/// <see cref="AllegianceBroadcast"/> for the legacy sibling
|
|
/// (retail's <c>@ab</c>).</item>
|
|
/// <item><b>Say</b> / <b>Tell</b>: route to the dedicated 0x0015 / 0x005D
|
|
/// opcodes — no channel id needed.</item>
|
|
/// </list>
|
|
/// </para>
|
|
/// </summary>
|
|
public enum ChatChannelKind
|
|
{
|
|
Say,
|
|
Tell,
|
|
Fellowship,
|
|
Allegiance,
|
|
Vassals,
|
|
Patron,
|
|
Monarch,
|
|
CoVassals,
|
|
General,
|
|
Trade,
|
|
Lfg,
|
|
Roleplay,
|
|
Society,
|
|
Olthoi,
|
|
|
|
/// <summary>
|
|
/// Campaign CH slice CH3 (2026-08-09): the legacy
|
|
/// <c>ChatChannel.AllegianceBroadcast (0x02000000)</c> bound to retail's
|
|
/// <c>@ab</c> verb — a monarch/speaker-permission broadcast over the
|
|
/// legacy 0x0147 pipe. Distinct from <see cref="Allegiance"/>, which is
|
|
/// ALWAYS the Turbine room now: retail's <c>@a</c> binds unconditionally
|
|
/// to <c>DoTurbineChat_Allegiance</c> once Turbine chat starts (research
|
|
/// doc §4.3), so it never falls back to this bitflag.
|
|
/// </summary>
|
|
AllegianceBroadcast,
|
|
|
|
Unknown,
|
|
}
|