acdream/tests/AcDream.Runtime.Tests/Gameplay
Erik 609a2dfda0
Some checks are pending
Headless portability / portable-headless (ubuntu-latest) (push) Waiting to run
Headless portability / portable-headless (windows-latest) (push) Waiting to run
Headless portability / linux-graphical (push) Waiting to run
Headless portability / linux-vulkan (push) Waiting to run
fix(runtime/core): Slice 5.3 review corrections — retirement/transit close, per-unit pricing, guarded auto-close dispatch
The adversarial review's three blocking findings, each fixed at root:

1. A vendor session now CLOSES when its entity retires (despawn,
   death, ObjectDelete) and at teleport BEGIN
   (HasPendingTeleportStart || IsTeleportActive at the existing
   per-frame seam — both hosts funnel through
   RuntimeWorldTransitState.TryQueueTeleportStart, which flips the
   pending flag strictly before activation). The previous permissive
   early-return stranded the session forever: panel pinned to a stale
   guid, ActiveVendorId swallowing Use for the rest of the session.
2. VendorShopItem carries the desc's stack size, and
   VendorPricing.PerUnitValue ports retail's stack-total division
   (VendorProfile::VendorSellPrice 0x005D1B00: <= 0 guard, integer
   division) — a stack of 50 arrows now prices per arrow, not at 50x.
3. VendorState.Close() guards its observer fanout with the
   dispatcher's catch-and-log semantics — a throwing panel listener
   can no longer propagate into the unprotected per-frame path.

Register honesty rides along: the 0.6 m UseRadius fallback was
acdream's invention (ACE's CheckClose has no fallback; retail passes
the raw authored radius) — removed, the watcher now uses the raw
radius and AP-160's citations are corrected and extended with the
accepted-position-snapshot cadence; AD-72 files VendorPricing's
double-vs-x87-extended narrowing (AD-33's class, bounded by the
±0.1 margin).

Nine tests added. Clean-room complete solution: 11,311 passed /
4 skipped / 0 failed.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2026-08-07 16:15:57 +02:00
..
InteractionStateTests.cs refactor(runtime): own canonical action state 2026-07-26 10:44:09 +02:00
LocalPlayerImmediatePositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
LocalPlayerOutboundCombatStyleTests.cs refactor(runtime): own local movement and outbound cadence 2026-07-26 12:33:53 +02:00
PlayerMouseLookMovementTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerMovementControllerTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerOutboundPositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerPhysicsQuantumCaptureTests.cs fix(physics): port retail slope landing stop 2026-07-31 09:10:53 +02:00
RuntimeActionStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeActionTestFactory.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCharacterStateTests.cs feat(runtime): bridge executor completion to the placement stream 2026-08-02 05:22:37 +02:00
RuntimeCombatAttackStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatModeStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatTargetStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCommunicationStateTests.cs refactor(runtime): expose canonical gameplay state 2026-07-26 09:12:30 +02:00
RuntimeGameplayOwnershipTests.cs refactor(runtime): close simulation ownership 2026-07-26 15:53:31 +02:00
RuntimeHostileTargetQueryTests.cs feat(headless): complete deterministic bot command parity 2026-07-27 08:23:36 +02:00
RuntimeInteractionTransactionStateTests.cs refactor(runtime): own interaction transactions 2026-07-26 11:13:09 +02:00
RuntimeInventoryStateTests.cs refactor(runtime): close canonical gameplay ownership 2026-07-26 09:48:51 +02:00
RuntimeLocalPlayerFirstEntryStateTests.cs feat(physics): C4 route 4b-3 — remote teleport + cell-less through the canonical placement 2026-08-04 16:00:10 +02:00
RuntimeLocalPlayerMovementStateTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
RuntimeLocalPlayerPhysicsPublicationStateTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
RuntimeSpellCastStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeVendorLifecycleTests.cs feat(runtime): Slice 5.3 — RuntimeInventoryState owns the vendor browse session 2026-08-07 15:37:12 +02:00
RuntimeVendorRangeQueryTests.cs fix(runtime/core): Slice 5.3 review corrections — retirement/transit close, per-unit pricing, guarded auto-close dispatch 2026-08-07 16:15:57 +02:00