8b8afeefa3
Move camera pointer, framebuffer resize, and retained/devtools input edges behind focused reversible owners. Preserve input priority while making shutdown deactivate callbacks before live-session retirement and retry physical detach without stranding transport teardown.
354 lines
15 KiB
C#
354 lines
15 KiB
C#
namespace AcDream.App.Tests.Rendering;
|
|
|
|
/// <summary>
|
|
/// Temporary source-shape freeze for the Slice 8 cutover. Each later checkpoint
|
|
/// replaces the corresponding assertion with functional tests on the extracted
|
|
/// owner; this file prevents a mechanical move from silently reordering host
|
|
/// behavior before that owner exists.
|
|
/// </summary>
|
|
public sealed class GameWindowSlice8BoundaryTests
|
|
{
|
|
[Fact]
|
|
public void Run_PreservesNativeAttributeAndCallbackOrder()
|
|
{
|
|
string body = MethodBody("public void Run()", "private void OnLoad()");
|
|
|
|
AssertAppearsInOrder(
|
|
body,
|
|
"startupStore.LoadDisplay()",
|
|
"QualitySettings.WithEnvOverrides(startupBase)",
|
|
"_displayFramePacing.InitializeStartup(startupDisplay.VSync)",
|
|
"VSync = startupPacing.UseVSync",
|
|
"Samples = startupQuality.MsaaSamples",
|
|
"Window.Create(options)",
|
|
"_displayFramePacing.BindSurface(",
|
|
"_windowCallbacks = SilkWindowCallbackBinding.Create(",
|
|
"new WindowCallbackTargets(",
|
|
"OnLoad,",
|
|
"OnUpdate,",
|
|
"OnRender,",
|
|
"OnClosing,",
|
|
"OnFocusChanged,",
|
|
"OnFramebufferResize),",
|
|
"_displayFramePacing,",
|
|
"_hostQuiescence);",
|
|
"_windowCallbacks.Attach();",
|
|
"_window.Run();");
|
|
|
|
Assert.Equal(1, CountOccurrences(body, "SilkWindowCallbackBinding.Create("));
|
|
Assert.Equal(1, CountOccurrences(body, "_windowCallbacks.Attach();"));
|
|
Assert.DoesNotContain("_window.Load +=", body, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("_window.Update +=", body, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("_window.Render +=", body, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("_window.Closing +=", body, StringComparison.Ordinal);
|
|
}
|
|
|
|
[Fact]
|
|
public void SessionStart_FollowsFrameGraphPublication()
|
|
{
|
|
string body = MethodBody(
|
|
"private void OnLoad()",
|
|
"private AcDream.App.Net.LiveSessionHost");
|
|
|
|
AssertAppearsInOrder(
|
|
body,
|
|
"_gl = GL.GetApi(_window!);",
|
|
"_input = _window!.CreateInput();",
|
|
"_kbSource = AcDream.App.Input.SilkKeyboardSource.CreateDetached(",
|
|
"_kbSource.Attach();",
|
|
"_mouseSource = AcDream.App.Input.SilkMouseSource.CreateDetached(",
|
|
"_mouseSource.Attach();",
|
|
"_inputDispatcher = AcDream.UI.Abstractions.Input.InputDispatcher.CreateDetached(",
|
|
"_inputDispatcher.Attach();",
|
|
"_movementInput.Bind(_inputDispatcher);",
|
|
"_cameraInput.Bind(_inputDispatcher);",
|
|
"_inputDispatcher.Fired += OnInputAction;",
|
|
"_cameraController = new CameraController(orbit, fly);",
|
|
"_cameraPointerInput = AcDream.App.Input.CameraPointerInputController.Create(",
|
|
"_cameraPointerInput.AttachRaw();",
|
|
"_dats = RuntimeDatCollectionFactory.OpenReadOnly(_datDir);",
|
|
"LoadAndApplyPersistedSettings();",
|
|
"_uiHost = new AcDream.App.UI.UiHost(",
|
|
"_uiHost.WireMouse(m)",
|
|
"_uiHost.WireKeyboard(kb)",
|
|
"_retailUiRuntime = AcDream.App.UI.RetailUiRuntime.Mount(",
|
|
"_liveEntities = new AcDream.App.World.LiveEntityRuntime(",
|
|
"_renderFrameOrchestrator =",
|
|
"_updateFrameOrchestrator = new AcDream.App.Update.UpdateFrameOrchestrator(",
|
|
"_liveSessionHost = CreateLiveSessionHost();",
|
|
"_liveSessionHost.Start(_options)");
|
|
Assert.Equal(1, CountOccurrences(body, "_liveSessionHost.Start(_options)"));
|
|
Assert.Contains("if (firstKb is not null)", body, StringComparison.Ordinal);
|
|
Assert.Contains("if (firstMouse is not null)", body, StringComparison.Ordinal);
|
|
Assert.Contains(
|
|
"if (_kbSource is not null && _mouseSource is not null)",
|
|
body,
|
|
StringComparison.Ordinal);
|
|
Assert.DoesNotContain(
|
|
"if (firstKb is not null && firstMouse is not null)",
|
|
body,
|
|
StringComparison.Ordinal);
|
|
int start = body.IndexOf("_liveSessionHost.Start(_options)", StringComparison.Ordinal);
|
|
string postStart = body[start..];
|
|
Assert.Contains("switch (liveStart.Status)", postStart, StringComparison.Ordinal);
|
|
Assert.Empty(System.Text.RegularExpressions.Regex.Matches(
|
|
postStart,
|
|
@"(?m)^\s+_[A-Za-z]\w*\s*(?:\?\?=|=)"));
|
|
Assert.DoesNotContain("new ", postStart, StringComparison.Ordinal);
|
|
Assert.DoesNotContain(".Mount(", postStart, StringComparison.Ordinal);
|
|
Assert.DoesNotContain(".Bind(", postStart, StringComparison.Ordinal);
|
|
Assert.DoesNotContain(".Attach(", postStart, StringComparison.Ordinal);
|
|
Assert.DoesNotContain(".Compose(", postStart, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("PrepareResources(", postStart, StringComparison.Ordinal);
|
|
}
|
|
|
|
[Fact]
|
|
public void WorldEnvironment_IsOwnedAndGameWindowOnlyComposesItsTypedEdges()
|
|
{
|
|
string source = GameWindowSource();
|
|
string load = MethodBody(
|
|
"private void OnLoad()",
|
|
"private AcDream.App.Net.LiveSessionHost");
|
|
string sessionFactory = MethodBody(
|
|
"private AcDream.App.Net.LiveSessionEventRouter CreateLiveSessionEventRouter(",
|
|
"private AcDream.App.Net.LiveInventorySessionBindings");
|
|
|
|
Assert.Contains(
|
|
"private readonly AcDream.App.World.WorldEnvironmentController _worldEnvironment =",
|
|
source,
|
|
StringComparison.Ordinal);
|
|
Assert.Contains("_worldEnvironment.Initialize(region!);", load, StringComparison.Ordinal);
|
|
AssertAppearsInOrder(
|
|
sessionFactory,
|
|
"new AcDream.App.Net.LiveEnvironmentSessionSink(",
|
|
"_worldEnvironment.ApplyAdminEnvirons,",
|
|
"_worldEnvironment.SynchronizeFromServer)");
|
|
Assert.DoesNotContain("_loadedSkyDesc", source, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("_loadedSkyDayIndex", source, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("private void RefreshSkyForCurrentDay()", source, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("private void OnEnvironChanged(", source, StringComparison.Ordinal);
|
|
|
|
string cycleTime = MethodBody(
|
|
"private void CycleTimeOfDay()",
|
|
"private void CycleWeather()");
|
|
AssertAppearsInOrder(
|
|
cycleTime,
|
|
"_worldEnvironment.CycleTimeOfDay();",
|
|
"_debugVm?.AddToast(message);");
|
|
}
|
|
|
|
[Fact]
|
|
public void InputAction_PreservesRetailAcceptedPriority()
|
|
{
|
|
string body = MethodBody(
|
|
"private void OnInputAction(",
|
|
"private void ToggleLiveCombatMode()");
|
|
|
|
AssertAppearsInOrder(
|
|
body,
|
|
"HandlePointerAction(action, activation)",
|
|
"action == AcDream.UI.Abstractions.Input.InputAction.ScrollUp",
|
|
"HandleScrollAction(action);",
|
|
"HandleCombatAction(action, activation)",
|
|
"activation != AcDream.UI.Abstractions.Input.ActivationType.Press",
|
|
"_retailUiRuntime?.HandleInputAction(action)",
|
|
"_selectionInteractions?.HandleInputAction(action)",
|
|
"HandlePressedMovementAction(action)",
|
|
"switch (action)");
|
|
}
|
|
|
|
[Fact]
|
|
public void FramebufferResize_IsOneTypedOwnerHandoff()
|
|
{
|
|
string load = MethodBody(
|
|
"private void OnLoad()",
|
|
"private AcDream.App.Net.LiveSessionHost");
|
|
string body = MethodBody(
|
|
"private void OnFramebufferResize(",
|
|
"private void ApplyDisplayWindowState(");
|
|
|
|
Assert.Contains("=> _framebufferResize.Resize(newSize);", body, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("Viewport(", body, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("SetAspect(", body, StringComparison.Ordinal);
|
|
Assert.DoesNotContain("ResetLayout(", body, StringComparison.Ordinal);
|
|
AssertAppearsInOrder(
|
|
load,
|
|
"_framebufferResize.BindViewport(",
|
|
"_framebufferResize.BindCamera(",
|
|
"_framebufferResize.Resize(_window!.FramebufferSize);");
|
|
Assert.DoesNotContain(
|
|
"_viewportAspect.Update(_window",
|
|
load,
|
|
StringComparison.Ordinal);
|
|
}
|
|
|
|
[Fact]
|
|
public void UpdateRenderFocusAndCloseRemainNarrowHostEdges()
|
|
{
|
|
string source = GameWindowSource();
|
|
string update = Slice(
|
|
source,
|
|
"private void OnUpdate(double dt)",
|
|
"private void OnRender(double deltaSeconds)");
|
|
string render = Slice(
|
|
source,
|
|
"private void OnRender(double deltaSeconds)",
|
|
"private AcDream.App.Diagnostics.WorldLifecycleResourceSnapshot");
|
|
string focus = Slice(
|
|
source,
|
|
"private void OnFocusChanged(bool focused)",
|
|
"public void Dispose()");
|
|
string close = Slice(
|
|
source,
|
|
"private void OnClosing()",
|
|
"private ResourceShutdownTransaction CreateShutdownTransaction()");
|
|
|
|
Assert.Equal(1, CountOccurrences(update, "_updateFrameOrchestrator.Tick("));
|
|
Assert.Equal(1, CountOccurrences(render, "_renderFrameOrchestrator!.Render("));
|
|
AssertAppearsInOrder(
|
|
render,
|
|
"Vector2D<int> size = _window!.Size;",
|
|
"_renderFrameOrchestrator!.Render(",
|
|
"new AcDream.App.Rendering.RenderFrameInput(");
|
|
Assert.DoesNotContain("FramebufferSize", render, StringComparison.Ordinal);
|
|
Assert.Contains(
|
|
"=> _cameraPointerInput?.HandleFocusChanged(focused);",
|
|
focus,
|
|
StringComparison.Ordinal);
|
|
AssertAppearsInOrder(
|
|
close,
|
|
"_hostQuiescence.StopAccepting();",
|
|
"CompleteShutdown();",
|
|
"_shutdown.CompleteOrThrow();");
|
|
}
|
|
|
|
[Fact]
|
|
public void Shutdown_PreservesDependencyStagesAndNativeWindowLast()
|
|
{
|
|
string source = GameWindowSource();
|
|
string manifest = Slice(
|
|
source,
|
|
"private ResourceShutdownTransaction CreateShutdownTransaction()",
|
|
"private void OnFocusChanged(bool focused)");
|
|
string dispose = Slice(
|
|
source,
|
|
"public void Dispose()",
|
|
"private sealed class NullAnimLoader");
|
|
|
|
string[] stages =
|
|
[
|
|
"new ResourceShutdownStage(\"input callback deactivation\"",
|
|
"new ResourceShutdownStage(\"session lifetime\"",
|
|
"new ResourceShutdownStage(\"input callback detach\"",
|
|
"new ResourceShutdownStage(\"frame borrowers\"",
|
|
"new ResourceShutdownStage(\"session dependents\"",
|
|
"new ResourceShutdownStage(\"live entities\"",
|
|
"new ResourceShutdownStage(\"live entity dependents\"",
|
|
"new ResourceShutdownStage(\"submitted GPU work\"",
|
|
"new ResourceShutdownStage(\"render frontends\"",
|
|
"new ResourceShutdownStage(\"shared texture owners\"",
|
|
"new ResourceShutdownStage(\"mesh adapter\"",
|
|
"new ResourceShutdownStage(\"remaining render owners\"",
|
|
"new ResourceShutdownStage(\"frame flight owner\"",
|
|
"new ResourceShutdownStage(\"content mappings\"",
|
|
"new ResourceShutdownStage(\"input\"",
|
|
"new ResourceShutdownStage(\"OpenGL context\"",
|
|
];
|
|
AssertAppearsInOrder(manifest, stages);
|
|
Assert.Equal(stages.Length, CountOccurrences(manifest, "new ResourceShutdownStage("));
|
|
foreach (string stage in stages)
|
|
Assert.Equal(1, CountOccurrences(manifest, stage));
|
|
AssertAppearsInOrder(
|
|
manifest,
|
|
"binding.Dispose();",
|
|
"if (!binding.IsDisposalComplete)",
|
|
"_windowCallbacks = null;");
|
|
AssertAppearsInOrder(
|
|
manifest,
|
|
"new(\"camera pointer\", () => _cameraPointerInput?.Deactivate())",
|
|
"new ResourceShutdownStage(\"session lifetime\"",
|
|
"controller.Dispose();",
|
|
"new ResourceShutdownStage(\"input callback detach\"",
|
|
"pointer.Dispose();",
|
|
"new ResourceShutdownStage(\"session dependents\"",
|
|
"pointer.ReleaseMouseLookAfterSessionRetirement();",
|
|
"pointer.UnbindGameplayFrame(gameplayFrame);",
|
|
"_cameraPointerInput = null;");
|
|
AssertAppearsInOrder(
|
|
dispose,
|
|
"CompleteShutdown();",
|
|
"_window?.Dispose();",
|
|
"_window = null;");
|
|
Assert.Equal(1, CountOccurrences(dispose, "CompleteShutdown();"));
|
|
Assert.Equal(1, CountOccurrences(dispose, "_window?.Dispose();"));
|
|
Assert.Equal(1, CountOccurrences(dispose, "_window = null;"));
|
|
int nativeReleased = dispose.IndexOf("_window = null;", StringComparison.Ordinal)
|
|
+ "_window = null;".Length;
|
|
string afterNativeRelease = dispose[nativeReleased..];
|
|
int fallbackDocumentation = afterNativeRelease.IndexOf(
|
|
"/// <summary>",
|
|
StringComparison.Ordinal);
|
|
if (fallbackDocumentation >= 0)
|
|
afterNativeRelease = afterNativeRelease[..fallbackDocumentation];
|
|
Assert.All(
|
|
afterNativeRelease,
|
|
character => Assert.True(char.IsWhiteSpace(character) || character == '}'));
|
|
}
|
|
|
|
private static string MethodBody(string start, string end) =>
|
|
Slice(GameWindowSource(), start, end);
|
|
|
|
private static string Slice(string source, string start, string end)
|
|
{
|
|
int first = source.IndexOf(start, StringComparison.Ordinal);
|
|
int last = source.IndexOf(end, first + 1, StringComparison.Ordinal);
|
|
Assert.True(first >= 0, $"Missing source boundary: {start}");
|
|
Assert.True(last > first, $"Missing source boundary: {end}");
|
|
return source[first..last];
|
|
}
|
|
|
|
private static int CountOccurrences(string source, string value)
|
|
{
|
|
int count = 0;
|
|
int cursor = 0;
|
|
while ((cursor = source.IndexOf(value, cursor, StringComparison.Ordinal)) >= 0)
|
|
{
|
|
count++;
|
|
cursor += value.Length;
|
|
}
|
|
|
|
return count;
|
|
}
|
|
|
|
private static void AssertAppearsInOrder(string source, params string[] fragments)
|
|
{
|
|
int cursor = -1;
|
|
foreach (string fragment in fragments)
|
|
{
|
|
int next = source.IndexOf(fragment, cursor + 1, StringComparison.Ordinal);
|
|
Assert.True(next >= 0, $"Missing expected source fragment: {fragment}");
|
|
Assert.True(next > cursor, $"Out-of-order source fragment: {fragment}");
|
|
cursor = next;
|
|
}
|
|
}
|
|
|
|
private static string GameWindowSource() => File.ReadAllText(Path.Combine(
|
|
FindRepoRoot(),
|
|
"src",
|
|
"AcDream.App",
|
|
"Rendering",
|
|
"GameWindow.cs"));
|
|
|
|
private static string FindRepoRoot()
|
|
{
|
|
DirectoryInfo? directory = new(AppContext.BaseDirectory);
|
|
while (directory is not null)
|
|
{
|
|
if (File.Exists(Path.Combine(directory.FullName, "AcDream.slnx")))
|
|
return directory.FullName;
|
|
directory = directory.Parent;
|
|
}
|
|
|
|
throw new DirectoryNotFoundException("Could not find AcDream.slnx.");
|
|
}
|
|
}
|