acdream/tests/AcDream.Core.Tests/CharGen
Erik f3ef7baae2 docs+fix(chargen): CC1/CC2 review closeout — R2/R3 residuals closed, ledger final
Both narrow re-reviews returned CLOSED. This closeout takes the two cheap
re-review residuals before CC3 takes references to the shared model:

R2: every array handed into the typed chargen model is now wrapped in
Array.AsReadOnly at the projection seam — a T[] behind IReadOnlyList<T>
was still downcast-mutable, and ChargenOptions is a process-shared
singleton graph.

R3: the no-Chorizite-leak guard now also walks public fields; every
current type uses properties, but a public field would have slipped
through the property-only walk.

Ledger: CC1 fix-round sha corrected to cb4703e8 (the cell previously
cited the pre-amend 459a87f2), CC1/CC2 rows flipped to REVIEW-CLOSED
with the re-review outcomes, R1 (retail refunds +1 credit on a
both-tier cost miss; port charges 0 — unreachable via retail's own
listbox, noted for CC3) and the Olthoi-locked-to-template-0 decomp fact
recorded for CC3/CC4.

Core.Tests 4736/1 skip, Content.Tests 145/0, Release.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-08-15 13:41:37 +02:00
..
ChargenAttributeMathTests.cs feat(content): Campaign CC CC1 — chargen table reader and typed options model 2026-08-15 12:53:50 +02:00
ChargenNoChoriziteLeakTests.cs docs+fix(chargen): CC1/CC2 review closeout — R2/R3 residuals closed, ledger final 2026-08-15 13:41:37 +02:00
ChargenOptionsTests.cs fix(chargen): CC1 review fix round — Custom is template 0, SkillTable cost fallback, frozen model 2026-08-15 13:33:37 +02:00
ChargenSkillAdvancementSetTests.cs feat(content): Campaign CC CC1 — chargen table reader and typed options model 2026-08-15 12:53:50 +02:00
ChargenSkillCreditMathTests.cs fix(chargen): CC1 review fix round — Custom is template 0, SkillTable cost fallback, frozen model 2026-08-15 13:33:37 +02:00