acdream/tests/AcDream.Content.Tests/PreparedAssetSourceTests.cs
Erik acf172469e feat(content): S1 exact CellStruct surface-index construction, recipe 8
Campaign OVERHAUL S1 chunk A. Retail's D3DPolyRender::ConstructMesh
@0x0059DFA0 is ported as one pure Core descriptor plus the Content
extraction that consumes it:

- side candidates come only from sides_type (0/1/2); NoPos/NoNeg mean
  UV-array absence only and never suppress a side (CPolygon::UnPack
  @0x00538650);
- ST_DOUBLE's second copy is reversed with a negative normal; ST_BOTH's
  negative side has a negative normal and forward fan order (reverse is on
  the copy ordinal, not the side ordinal);
- an absent UV-index array is UV index 0 (ConstructMesh @0x0059E691
  xor ebx,ebx, arbitrated on the PDB-paired binary); copyVert @0x0059C080
  zeroes coordinates only for a negative or out-of-range index or a vertex
  without UVs, never by clamping to slot 0;
- the subset owner is the source surface-array index, emitted in ascending
  slot order with retail's per-slot mask (2 > 8 > 4 precedence, positive
  surface OR on signed stippling > 0);
- built-EnvCell admission is (Surface.Type & (BASE1_IMAGE|BASE1_CLIPMAP))
  != 0 after surface resolution (DrawEnvCell @0x0059F170 -> DrawMesh
  @0x0059D4A0 arg4=1); untextured slots are constructed but not emitted;
- cell batches carry SourceSurfaceIndex, RetailSurfaceMask, RawSurfaceType,
  IsCellShell, and fixed clockwise raster cull (RenderMeshSubset
  @0x0059CA10); authored sides_type is no longer stored as GPU cull.

Prepared-mesh serializer gains the four fields; bake recipe 7 -> 8 with a
FullRebuild migration; pak format stays 2 (pinned). Ordinary GfxObj
extraction is unchanged. AP-234's register row and CellMesh unification
land in chunk B.

Core: 32 descriptor tests. Content: 170/170. Bake: 18/18. Launcher.Core:
365/365 (Lane!=Linux). Solution Release build 0 warnings / 0 errors.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 18:40:33 +02:00

280 lines
9.6 KiB
C#

using System.Numerics;
using AcDream.Content.Pak;
namespace AcDream.Content.Tests;
public sealed class PreparedAssetSourceTests : IDisposable
{
private static readonly PreparedAssetCatalogIdentity Identity =
new(10, 20, 30, 40, PakFormat.CurrentBakeToolVersion);
private readonly List<string> _paths = [];
[Fact]
public void Probe_IsTypedAndDoesNotFaultPayloadBytes()
{
string path = WritePak(
(PakAssetType.GfxObjMesh, 0x0100_0001u, Mesh(0x0100_0001u)));
using var source = new PakPreparedAssetSource(path, Identity);
Assert.Equal(
PreparedAssetPresence.Available,
source.Probe(PakAssetType.GfxObjMesh, 0x0100_0001u));
Assert.Equal(
PreparedAssetPresence.Missing,
source.Probe(PakAssetType.SetupMesh, 0x0100_0001u));
Assert.Equal(2, source.Stats.Probes);
Assert.Equal(0, source.Stats.Reads);
}
[Fact]
public void Read_PreservesMissingLoadedAndCorruptStates()
{
const uint fileId = 0x0100_0001u;
string path = WritePak(
(PakAssetType.GfxObjMesh, fileId, Mesh(fileId)));
using (var source = new PakPreparedAssetSource(path, Identity))
{
PreparedAssetReadResult loaded =
source.Read(PreparedAssetRequest.GfxObj(fileId));
Assert.Equal(PreparedAssetReadStatus.Loaded, loaded.Status);
Assert.NotNull(loaded.Data);
PreparedAssetReadResult missing =
source.Read(PreparedAssetRequest.GfxObj(0x0100_FFFFu));
Assert.Equal(PreparedAssetReadStatus.Missing, missing.Status);
Assert.Null(missing.Data);
}
FlipFirstBlobByte(path);
using var corruptSource = new PakPreparedAssetSource(path, Identity);
Assert.Equal(
PreparedAssetPresence.Available,
corruptSource.Probe(PakAssetType.GfxObjMesh, fileId));
PreparedAssetReadResult corrupt =
corruptSource.Read(PreparedAssetRequest.GfxObj(fileId));
Assert.Equal(PreparedAssetReadStatus.Corrupt, corrupt.Status);
Assert.Null(corrupt.Data);
Assert.Equal(
PreparedAssetPresence.Corrupt,
corruptSource.Probe(PakAssetType.GfxObjMesh, fileId));
}
[Fact]
public void Read_EnvCellAliasUsesSourceKeyAndRuntimeGeometryIdentity()
{
const uint primaryCell = 0x1234_0101u;
const uint aliasCell = 0x1234_0102u;
const ulong geometryId = 0x2_0000_1234UL;
string path = NewPath();
using (var writer = new PakWriter(path, Header()))
{
writer.AddBlob(
PakKey.Compose(PakAssetType.EnvCellMesh, primaryCell),
Mesh(geometryId));
writer.AddAlias(
PakKey.Compose(PakAssetType.EnvCellMesh, aliasCell),
PakKey.Compose(PakAssetType.EnvCellMesh, primaryCell));
writer.Finish();
}
using var source = new PakPreparedAssetSource(path, Identity);
var request = PreparedAssetRequest.EnvCellGeometry(
aliasCell,
geometryId,
environmentId: 7,
cellStructure: 3,
surfaces: [1, 2, 3]);
PreparedAssetReadResult result = source.Read(request);
Assert.Equal(PreparedAssetReadStatus.Loaded, result.Status);
Assert.Equal(geometryId, result.Data!.ObjectId);
}
[Fact]
public void Read_RejectsPayloadIdentityOrTypeMismatchAsCorruption()
{
const uint setupId = 0x0200_0001u;
string path = WritePak(
(PakAssetType.SetupMesh, setupId, Mesh(setupId)));
var diagnostics = new List<string>();
using var source = new PakPreparedAssetSource(
path,
Identity,
diagnostics.Add);
PreparedAssetReadResult result =
source.Read(PreparedAssetRequest.Setup(setupId));
Assert.Equal(PreparedAssetReadStatus.Corrupt, result.Status);
Assert.Single(diagnostics);
Assert.Contains("identity mismatch", diagnostics[0]);
}
[Fact]
public void Constructor_RejectsEveryCatalogIdentityMismatch()
{
string path = WritePak(
(PakAssetType.GfxObjMesh, 1u, Mesh(1u)));
var mismatches = new[]
{
Identity with { PortalIteration = 11 },
Identity with { CellIteration = 21 },
Identity with { HighResIteration = 31 },
Identity with { LanguageIteration = 41 },
Identity with { BakeToolVersion = Identity.BakeToolVersion + 1 },
};
foreach (PreparedAssetCatalogIdentity expected in mismatches)
{
InvalidDataException error = Assert.Throws<InvalidDataException>(
() => new PakPreparedAssetSource(path, expected));
Assert.Contains("does not match the installed DAT set", error.Message);
Assert.Contains("Re-bake", error.Message);
}
}
/// <summary>
/// OH2/S1 contract §10.5: an OLDER-recipe (7) package must be rejected
/// by a CURRENT-recipe (8) consumer through the catalog-identity check
/// alone, BEFORE any TextureBatchData payload field is ever
/// deserialized -- so an older pak can never be silently misread as
/// carrying the new SourceSurfaceIndex/RetailSurfaceMask/RawSurfaceType/
/// IsCellShell fields.
/// </summary>
[Fact]
public void Constructor_RejectsOlderRecipePackageBeforePayloadDecode()
{
// PakWriter stamps BakeToolVersion to PakFormat.CurrentBakeToolVersion
// unconditionally (the header-template default-0 footgun guard), so
// an "older recipe" file has to be produced by patching the on-disk
// header dword directly -- the same technique
// PakRoundTripTests.Reader_RejectsWrongFormatVersion uses for the
// sibling FormatVersion field. BakeToolVersion is offset 36 per
// PakHeader's normative layout.
string path = WritePak(
(PakAssetType.EnvCellMesh, 1u, Mesh(1u)));
using (var fs = new FileStream(path, FileMode.Open, FileAccess.ReadWrite))
{
fs.Position = 36;
Span<byte> buf = stackalloc byte[4];
System.Buffers.Binary.BinaryPrimitives.WriteUInt32LittleEndian(
buf, PakFormat.CurrentBakeToolVersion - 1);
fs.Write(buf);
}
InvalidDataException error = Assert.Throws<InvalidDataException>(
() => new PakPreparedAssetSource(path, Identity));
Assert.Contains("does not match the installed DAT set", error.Message);
Assert.Contains("Re-bake", error.Message);
}
[Fact]
public void Read_PreCanceledTokenPropagatesWithoutStartingRead()
{
const uint fileId = 0x0100_0001u;
string path = WritePak(
(PakAssetType.GfxObjMesh, fileId, Mesh(fileId)));
using var source = new PakPreparedAssetSource(path, Identity);
using var cancellation = new CancellationTokenSource();
cancellation.Cancel();
Assert.Throws<OperationCanceledException>(
() => source.Read(
PreparedAssetRequest.GfxObj(fileId),
cancellation.Token));
Assert.Equal(0, source.Stats.Reads);
}
[Fact]
public void Dispose_ReleasesMappedPackage()
{
string path = WritePak(
(PakAssetType.GfxObjMesh, 1u, Mesh(1u)));
var source = new PakPreparedAssetSource(path, Identity);
source.Dispose();
using var exclusive = new FileStream(
path,
FileMode.Open,
FileAccess.ReadWrite,
FileShare.None);
Assert.True(exclusive.CanWrite);
}
private string WritePak(
params (PakAssetType Type, uint FileId, ObjectMeshData Data)[] entries)
{
string path = NewPath();
using var writer = new PakWriter(path, Header());
foreach ((PakAssetType type, uint fileId, ObjectMeshData data) in entries)
{
writer.AddBlob(PakKey.Compose(type, fileId), data);
}
writer.Finish();
return path;
}
private string NewPath()
{
string path = Path.Combine(
Path.GetTempPath(),
$"acdream-prepared-{Guid.NewGuid():N}.pak");
_paths.Add(path);
return path;
}
private static PakHeader Header() =>
new()
{
PortalIteration = Identity.PortalIteration,
CellIteration = Identity.CellIteration,
HighResIteration = Identity.HighResIteration,
LanguageIteration = Identity.LanguageIteration,
BakeToolVersion = Identity.BakeToolVersion,
};
private static ObjectMeshData Mesh(ulong objectId) =>
new()
{
ObjectId = objectId,
Vertices =
[
new(
new Vector3(1, 2, 3),
Vector3.UnitZ,
new Vector2(0.25f, 0.75f)),
],
};
private static void FlipFirstBlobByte(string path)
{
using var stream = new FileStream(
path,
FileMode.Open,
FileAccess.ReadWrite,
FileShare.None);
stream.Position = PakHeader.Size + 4;
int value = stream.ReadByte();
Assert.NotEqual(-1, value);
stream.Position = PakHeader.Size + 4;
stream.WriteByte((byte)(value ^ 0xFF));
}
public void Dispose()
{
foreach (string path in _paths)
{
try
{
File.Delete(path);
}
catch
{
// Best-effort test cleanup.
}
}
}
}