acdream/tests/AcDream.Runtime.Tests/Gameplay
Erik 78b981cca0 fix(runtime): transient collision-seal failure no longer terminal for login (#357)
Login could hang forever at reveal ready=True with the world never
revealed: UI and sky drawn, geometry absent, client healthy. The player's
first-entry conductor was being terminally dropped by a TRANSIENT
condition.

Mechanism, pinned by probes: the C3c-F2 rearm guard validates the exact
destination cell's prefix admissibility before moving the dormant lease
out of AwaitingCell, but the placement transaction's ring search touches
NEIGHBOUR landblocks and TrySealCollisionEvaluationAuthority covers every
touched prefix. A hard login recenter admits nine landblocks at once, so
a rearm taken while a neighbour's admission was still registered passed
the guard and failed the seal. The operation was left in
AwaitingPreparation, IsDormantLocalActivationAwaitingCell went false, and
EvaluateActivation had no way to say 'retry' - it fell through to
RejectedAuthority, which RuntimeFirstEntryDriveController treats as
terminal. The local player left the pump (pending=0), the movement
controller never published, auto-entry never fired, the reveal never
completed. Timing-flipped: the same binary worked when the rearm landed
outside a neighbour's admission window, then lost that race consistently.

Fix is classification, not state: EvaluateActivation reports DeferredCell
when the abort happens while the dormant lease is still current
(IsDormantLocalActivationLeaseCurrent), so the conductor keeps retrying.
The operation deliberately stays in AwaitingPreparation - the retry
re-runs the full evaluation against fresh state, which is the recovery
contract the publication-state tests already pin (the SAME token
evaluates Evaluated once the authority settles). Genuine discards still
report RejectedAuthority. A first attempt that re-parked the lease to
AwaitingCell was rejected by the test matrix: recovery would then need
the rearm gate, which is stricter than the seal, and the
reentrant-restriction-mutation recoveries hung in DeferredCell.

Seven publication-state tests move their transient-abort assertion from
RejectedAuthority to DeferredCell; the two genuinely-terminal tests
(lease retired) are unchanged. The [wake]/[rearm]/[pump] probes that
pinned the mechanism stay behind ACDREAM_PROBE_PARK=1 with the rest of
the C4 family.

Exonerated by experiment before the fix: ACE (wire capture shows
PlayerCreate sent; retail logs in fine) and the portal-cue commit
2914e43a (full revert stalled identically).

Verified: 2/2 live logins reach auto-entered player mode and reveal
event=complete, with the probe showing seal-refused -> retry -> recovery
in flight; full Release suite 11,740 passed / 4 skipped / 0 failed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-09 12:32:53 +02:00
..
InteractionStateTests.cs refactor(runtime): own canonical action state 2026-07-26 10:44:09 +02:00
LocalPlayerImmediatePositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
LocalPlayerOutboundCombatStyleTests.cs refactor(runtime): own local movement and outbound cadence 2026-07-26 12:33:53 +02:00
PlayerMouseLookMovementTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerMovementControllerTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerOutboundPositionTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
PlayerPhysicsQuantumCaptureTests.cs fix(physics): port retail slope landing stop 2026-07-31 09:10:53 +02:00
RuntimeActionStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeActionTestFactory.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCharacterStateTests.cs feat(runtime): bridge executor completion to the placement stream 2026-08-02 05:22:37 +02:00
RuntimeCombatAttackStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatModeStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCombatTargetStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeCommunicationStateTests.cs refactor(runtime): expose canonical gameplay state 2026-07-26 09:12:30 +02:00
RuntimeGameplayOwnershipTests.cs refactor(runtime): close simulation ownership 2026-07-26 15:53:31 +02:00
RuntimeHostileTargetQueryTests.cs feat(headless): complete deterministic bot command parity 2026-07-27 08:23:36 +02:00
RuntimeInteractionTransactionStateTests.cs fix(vendor): grand-gate findings — wire-truth container counts, the live split bar, arrival-gated use, prepend-order race 2026-08-08 14:03:57 +02:00
RuntimeInventoryStateTests.cs refactor(runtime): close canonical gameplay ownership 2026-07-26 09:48:51 +02:00
RuntimeLocalPlayerFirstEntryStateTests.cs feat(physics): C4 route 4b-3 — remote teleport + cell-less through the canonical placement 2026-08-04 16:00:10 +02:00
RuntimeLocalPlayerMovementStateTests.cs refactor(physics): delete legacy PhysicsEngine.Resolve/ResolvePlacement/HasCellSurface (C5a, AP-1/AD-1) 2026-08-05 14:11:31 +02:00
RuntimeLocalPlayerPhysicsPublicationStateTests.cs fix(runtime): transient collision-seal failure no longer terminal for login (#357) 2026-08-09 12:32:53 +02:00
RuntimeSpellCastStateTests.cs refactor(runtime): own combat and magic intent 2026-07-26 11:56:40 +02:00
RuntimeVendorLifecycleTests.cs fix(vendor): gate-findings pass — the X button HIDES like retail, clicks return, the dropdown scrolls, pyreal suffix, staged-tab slots 2026-08-08 10:29:39 +02:00
RuntimeVendorRangeQueryTests.cs fix(runtime/core): Slice 5.3 review corrections — retirement/transit close, per-unit pricing, guarded auto-close dispatch 2026-08-07 16:15:57 +02:00
VendorShopItemMaterializerTests.cs fix(vendor): evidence-based pass — max-first stack ceiling; the local player resolves never-animated MoveTo targets 2026-08-08 17:17:04 +02:00