Lands the working A8 indoor-rendering and streaming fixes accumulated this session. User has verified these visually to some degree (e.g. lifestone / translucent meshes confirmed fine under the FrontFace flip; bridge / wall / collision regressions confirmed fixed after travel); not every path has been exhaustively gated. The cellar-flap defect remains OPEN and will be solved the retail-faithful way via a dedicated brainstorm (see handoff docs). Rendering core (reviewed, high confidence): - EnvCellRenderer SSBO stride fix: upload packed Matrix4x4[] (64B) instead of the 80B CPU InstanceData struct the shader never expected — fixes the transform/texture "explosion" for any draw with >1 instance (cells that dedupe to a shared cellGeomId). Real root cause. - WB-style global FrontFace(CW) + per-batch CullMode carried through the MDI layout (GroupKey + BuildIndirectArrays + DrawIndirectRange split into same-cull runs with absolute uDrawIDOffset per run). - EntitySet partitioning (IndoorPass / OutdoorScenery / LiveDynamic) + WorldEntity.BuildingShellAnchorCellId so building shells scope to their dat-derived building cell instead of rendering everywhere. - RenderOutsideInAcdream (look into buildings from outside) + CollectVisiblePortalBuildings frustum cull of portal bounds. - Sky-when-inside-building + per-cell audit probe + GL-state probe. Streaming / perf (test-covered; not independently code-reviewed this session): - Near/far priority queues so near work wins over far; PromoteToNear carries full landblock + mesh data; LandblockEntriesWithoutAnimatedIndex avoids rebuilding the animated-lookup dict in the hot draw path. Fixes the bridge-not-appearing / missing-walls / broken-collision-after-travel regressions and improves post-transition FPS. Tooling + docs: - tools/A8CellAudit: offline dat cell/portal/building dumper (portals + buildings modes) — reproduces the cellar-flap investigation with no launch. - docs/research cellar-flap root-cause + option-2 handoff (the didInsideStencil double-duty finding + the WB-recursive design decision + brainstorm prompt), entity-taxonomy, replan, issue-78 visibility investigation. Diagnostics retained on purpose: ACDREAM_A8_DIAG_* gates, portal_stencil.vert provisional pos.w clamp, and the probe families are kept (env-var gated, zero cost when off) because the pending option-2 cellar-flap brainstorm needs them. Strip in the option-2 ship commit. Indoor branch stays behind ACDREAM_A8_INDOOR_BRANCH=1 (default off = pre-A8 visual). Build green; App tests + Core (streaming/dispatcher/loader) tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
117 lines
4.4 KiB
C#
117 lines
4.4 KiB
C#
using DatReaderWriter;
|
|
using DatReaderWriter.DBObjs;
|
|
using DatReaderWriter.Types;
|
|
|
|
namespace AcDream.Core.World;
|
|
|
|
public static class LandblockLoader
|
|
{
|
|
private const uint GfxObjMask = 0x01000000u;
|
|
private const uint SetupMask = 0x02000000u;
|
|
private const uint TypeMask = 0xFF000000u;
|
|
|
|
/// <summary>
|
|
/// Load a single landblock (heightmap + static objects) from the dats.
|
|
/// </summary>
|
|
/// <returns>Null if the landblock is missing from the cell dat.</returns>
|
|
public static LoadedLandblock? Load(DatCollection dats, uint landblockId)
|
|
{
|
|
var block = dats.Get<LandBlock>(landblockId);
|
|
if (block is null)
|
|
return null;
|
|
|
|
var info = dats.Get<LandBlockInfo>((landblockId & 0xFFFF0000u) | 0xFFFEu);
|
|
var entities = info is null
|
|
? Array.Empty<WorldEntity>()
|
|
: BuildEntitiesFromInfo(info, landblockId);
|
|
|
|
return new LoadedLandblock(landblockId, block, entities);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Pure mapping from a parsed LandBlockInfo to a list of WorldEntity.
|
|
/// Each Stab and BuildingInfo becomes one entity. Unsupported id types
|
|
/// (neither GfxObj 0x01xxxxxx nor Setup 0x02xxxxxx) are silently skipped.
|
|
/// MeshRefs is left empty at this stage — Task 5 populates it.
|
|
/// </summary>
|
|
public static IReadOnlyList<WorldEntity> BuildEntitiesFromInfo(LandBlockInfo info, uint landblockId = 0)
|
|
{
|
|
var result = new List<WorldEntity>(info.Objects.Count + info.Buildings.Count);
|
|
|
|
// When landblockId is non-zero, namespace stab Ids globally:
|
|
// 0xC0XXYY00 + n, where XX = lbX byte, YY = lbY byte
|
|
// matching the scenery (0x80XXYY00) and interior (0x40XXYY00) patterns
|
|
// in GameWindow.cs. The 0xC0 top byte distinguishes stabs from those.
|
|
//
|
|
// Pre-Tier-1 callers (existing tests) pass landblockId=0 and get the
|
|
// legacy starting-from-1 monotonic Ids — compatible with their assertions
|
|
// which check uniqueness within a single landblock.
|
|
//
|
|
// Latent: if a landblock has >256 stabs (rare), nextId overflows the
|
|
// low byte and bleeds into the lbY byte → cross-LB collision. Same
|
|
// pattern + same limitation as scenery/interior. Document but don't
|
|
// fix in this commit — out of scope for the Tier 1 cache bug fix.
|
|
uint stabIdBase = landblockId == 0
|
|
? 0u
|
|
: 0xC0000000u | ((landblockId >> 24) & 0xFFu) << 16 | ((landblockId >> 16) & 0xFFu) << 8;
|
|
uint nextId = stabIdBase == 0 ? 1u : stabIdBase + 1u;
|
|
|
|
foreach (var stab in info.Objects)
|
|
{
|
|
if (!IsSupported(stab.Id))
|
|
continue;
|
|
var stabEntity = new WorldEntity
|
|
{
|
|
Id = nextId++,
|
|
SourceGfxObjOrSetupId = stab.Id,
|
|
Position = stab.Frame.Origin,
|
|
Rotation = stab.Frame.Orientation,
|
|
MeshRefs = Array.Empty<MeshRef>(),
|
|
};
|
|
stabEntity.RefreshAabb(); // A.5 T18: populate cached AABB at construction
|
|
result.Add(stabEntity);
|
|
}
|
|
|
|
foreach (var building in info.Buildings)
|
|
{
|
|
if (!IsSupported(building.ModelId))
|
|
continue;
|
|
var buildingEntity = new WorldEntity
|
|
{
|
|
Id = nextId++,
|
|
SourceGfxObjOrSetupId = building.ModelId,
|
|
Position = building.Frame.Origin,
|
|
Rotation = building.Frame.Orientation,
|
|
MeshRefs = Array.Empty<MeshRef>(),
|
|
IsBuildingShell = true, // Phase A8: tag at source array boundary
|
|
BuildingShellAnchorCellId = FirstBuildingAnchorCellId(building, landblockId),
|
|
};
|
|
buildingEntity.RefreshAabb(); // A.5 T18: populate cached AABB at construction
|
|
result.Add(buildingEntity);
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
private static bool IsSupported(uint id)
|
|
{
|
|
var type = id & TypeMask;
|
|
return type == GfxObjMask || type == SetupMask;
|
|
}
|
|
|
|
private static uint? FirstBuildingAnchorCellId(BuildingInfo building, uint landblockId)
|
|
{
|
|
if (landblockId == 0)
|
|
return null;
|
|
|
|
uint lbPrefix = landblockId & 0xFFFF0000u;
|
|
foreach (var portal in building.Portals)
|
|
{
|
|
if (portal.OtherCellId == 0xFFFF)
|
|
continue;
|
|
return lbPrefix | (uint)portal.OtherCellId;
|
|
}
|
|
|
|
return null;
|
|
}
|
|
}
|