7013651a90
0x00A0 InventoryServerSaveFailed carries (itemGuid, weenieError) per ACE GameEventInventoryServerSaveFailed.cs and holtburger events.rs:147. The old parser returned only the itemGuid as uint?, silently dropping the error code. Replaced with a typed InventoryServerSaveFailed record that reads both u32s (8-byte guard). Parser was unwired (no callers in GameEvents.cs or GameEventWiring.cs) so the signature change is safe. 1 new test in GameEventsInventoryTests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
75 lines
3 KiB
C#
75 lines
3 KiB
C#
using System.Buffers.Binary;
|
||
using AcDream.Core.Net.Messages;
|
||
using Xunit;
|
||
|
||
namespace AcDream.Core.Net.Tests.Messages;
|
||
|
||
public sealed class GameEventsInventoryTests
|
||
{
|
||
[Fact]
|
||
public void ParseViewContents_twoEntries_returnsContainerAndItems()
|
||
{
|
||
// containerGuid + count(2) + 2×{guid, containerType}
|
||
var b = new byte[4 + 4 + 2 * 8];
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(0), 0x500000C9u); // containerGuid
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(4), 2u); // count
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(8), 0x50000A01u); // guid 1
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(12), 0u); // type 1 (item)
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(16), 0x50000A02u);// guid 2
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(20), 1u); // type 2 (container)
|
||
|
||
var p = GameEvents.ParseViewContents(b);
|
||
Assert.NotNull(p);
|
||
Assert.Equal(0x500000C9u, p!.Value.ContainerGuid);
|
||
Assert.Equal(2, p.Value.Items.Count);
|
||
Assert.Equal(0x50000A01u, p.Value.Items[0].Guid);
|
||
Assert.Equal(0u, p.Value.Items[0].ContainerType);
|
||
Assert.Equal(0x50000A02u, p.Value.Items[1].Guid);
|
||
Assert.Equal(1u, p.Value.Items[1].ContainerType);
|
||
}
|
||
|
||
[Fact]
|
||
public void ParseViewContents_zeroCount_returnsEmptyList()
|
||
{
|
||
var b = new byte[8];
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(0), 0x500000C9u);
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(4), 0u);
|
||
var p = GameEvents.ParseViewContents(b);
|
||
Assert.NotNull(p);
|
||
Assert.Empty(p!.Value.Items);
|
||
}
|
||
|
||
[Fact]
|
||
public void ParseViewContents_truncated_returnsNull()
|
||
=> Assert.Null(GameEvents.ParseViewContents(new byte[4]));
|
||
|
||
[Fact]
|
||
public void ParsePutObjInContainer_readsAllFourFields()
|
||
{
|
||
var b = new byte[16];
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(0), 0x50000A01u); // itemGuid
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(4), 0x500000C9u); // containerGuid
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(8), 3u); // placement
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(12), 1u); // containerType
|
||
|
||
var p = GameEvents.ParsePutObjInContainer(b);
|
||
Assert.NotNull(p);
|
||
Assert.Equal(0x50000A01u, p!.Value.ItemGuid);
|
||
Assert.Equal(0x500000C9u, p.Value.ContainerGuid);
|
||
Assert.Equal(3u, p.Value.Placement);
|
||
Assert.Equal(1u, p.Value.ContainerType);
|
||
}
|
||
|
||
[Fact]
|
||
public void ParseInventoryServerSaveFailed_readsGuidAndError()
|
||
{
|
||
var b = new byte[8];
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(0), 0x50000A01u); // itemGuid
|
||
BinaryPrimitives.WriteUInt32LittleEndian(b.AsSpan(4), 0x0Au); // weenieError
|
||
|
||
var p = GameEvents.ParseInventoryServerSaveFailed(b);
|
||
Assert.NotNull(p);
|
||
Assert.Equal(0x50000A01u, p!.Value.ItemGuid);
|
||
Assert.Equal(0x0Au, p.Value.WeenieError);
|
||
}
|
||
}
|